From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0073.outbound.protection.outlook.com [104.47.42.73]) by dpdk.org (Postfix) with ESMTP id AA8821BABD for ; Sat, 23 Jun 2018 14:41:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BtN2lRkSHglid27AN1yiInwFwI9TM2FC1peJpeOLkQQ=; b=HHVQepuXGaqtSpB8b4TJKsw7Ro87j+B4y6SxP7V/XQhw9rt9Nm0dN1S0BX5ofgaBfFLWk8qfERlzRgJPmgilXVPNUA6UvsGQxY8N0cXiVJfgZfClsFcVI5TnmXptSJIFZgh/0k72HRnaFBnO0OlztCJz1DIFQ2L3hZ0djqZ6MQk= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3763.namprd07.prod.outlook.com (52.132.102.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Sat, 23 Jun 2018 12:41:49 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.021; Sat, 23 Jun 2018 12:41:48 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHUBj6irvnKsPODDEKF52aG05BtfaRkkSqwgABH5ACAAKR6kIAIUqIQ Date: Sat, 23 Jun 2018 12:41:48 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [117.98.211.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3763; 7:+2s7ZWOJ82Y5Y7ebpP+Rl6HZ1f5aN9GKpS3wSXWXk62NBYR6VQxFejZDYUcLDoMpumUFt9z9wP1ohW7e5z0++wRnybpZnGV5Qz4P+zGJW5Y2dMqJrl+IENIJfo3MHbtnkWUMvYWtliDAo8WS6SF784Y8/isHU70fhq1/qi7MJtDQIEkZk5gaAcN+MM4CNOJfpguAr/U7iofVhGIdsOf8OZPy5JR9NnFeEB58l1P4vmHK6sT0n/NxXs7H3jNgWLX1 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(396003)(39850400004)(376002)(346002)(39380400002)(51444003)(199004)(189003)(13464003)(66066001)(486006)(186003)(4326008)(25786009)(26005)(97736004)(9686003)(476003)(446003)(6246003)(99286004)(14454004)(54906003)(2900100001)(11346002)(53936002)(478600001)(86362001)(72206003)(5660300001)(55016002)(107886003)(316002)(76176011)(3846002)(93886005)(6436002)(106356001)(105586002)(2906002)(6116002)(33656002)(305945005)(3280700002)(6916009)(3660700001)(68736007)(5250100002)(8676002)(8936002)(229853002)(6506007)(7736002)(7696005)(74316002)(102836004)(81166006)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3763; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 2341bb17-1d08-447c-d0e9-08d5d906afa2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3763; x-ms-traffictypediagnostic: CY4PR0701MB3763: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3763; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3763; x-forefront-prvs: 07126E493C received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qNKQum2KBSY1Gat2M46na4n29kGUejpWbsQwuNCRhTOLJDVlrQRgKeuttyI5zeuQ5UafYN37OfaDW4x4bZjqe6W0ZfOuL8RVOVw0LTL1hm0k4neRR4jWiGBjKJgbqug3XH0dAxkDP6qLvVIhPz4k1tNPo6U9Jcj6xndrFcJlA3SSBxgTqBqv7WMDCJfYQJyff+6op3U1VACSFaOaelYjg3gCYHcIH9q1lEYC09meFOhLD018HDfL0xoXoewdqCyDKA8Q/wr5kxjB9efRKL3+4kVDSgegq13Q7cqpi566QVhNwUApku8xY5jDl1KEmW9s5l01ZRbBnAkC/U9zH+C1GQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2341bb17-1d08-447c-d0e9-08d5d906afa2 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2018 12:41:48.1882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3763 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 12:41:52 -0000 Hi Pablo >-----Original Message----- >From: Verma, Shally >Sent: 18 June 2018 11:00 >To: 'De Lara Guarch, Pablo' >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; dev@dpdk.or= g; Athreya, Narayana Prasad >; Sahu, Sunila = ; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > //snip >>> >> >>> >> .session_get_size =3D openssl_pmd_session_get_si= ze, >>> >> + .asym_session_get_size =3D >>> >> openssl_pmd_asym_session_get_size, >>> >> .session_configure =3D openssl_pmd_session_config= ure, >>> >> - .session_clear =3D openssl_pmd_session_clear >>> >> + .asym_session_configure =3D >>> >> openssl_pmd_asym_session_configure, >>> >> + .session_clear =3D openssl_pmd_session_clear, >>> >> + .asym_session_clear =3D openssl_pmd_asym_session_c= lear >>> >> }; >>> > >>> >I think session_get_size, session_configure and session_clear should b= e >>> >renamed to sym_session_*, to avoid confusion. Could you add another pa= tch >>> renaming these? >>> > >>> [Shally] I see in latest cryptodev these typedefs are already named to >>> cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and >>> _sym_free_.. so these changes would come while rebase. >>> or you are referring to change openssl_pmd_session_configure to >>> openssl_pmd_sym_session_configure and so others? >> >>Yes, but the name is still session_configure/clear, not sym_session_confi= gure/clear, right? >>And also, I think we should rename the OpenSSL functions, openssl_pmd_ses= sion_*, >>to openssl_pmd_sym_session_*. >> >[Shally] Ok. I will look into this. > [Shally] if I change these names in struct rte_cryptodev_ops, then we will = need to change all drivers. I think that should be done in a separate patch= series specific to rename these. For now, I will rename only openssl pmd A= PIs to use _sym version for this patch series. >Thanks >Shally > >>Pablo >> >>> >>> Thanks for review. >>> >>> >Thanks, >>> >Pablo >>> >