From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680074.outbound.protection.outlook.com [40.107.68.74]) by dpdk.org (Postfix) with ESMTP id B3A581B06D for ; Tue, 10 Jul 2018 07:22:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YMffclavGDM2+nFhlg+1VPYivaO2Sk2eZlTmikg24rQ=; b=Bml5Q22AoatkB5UBmSF95Nfn72WPEuQqs5Mr2L6D++I9VduQi7xe4HHbey7omtkrVONymo0nmRjC8DKfdPCWMl5r01EYB/qDfARXaOMJ3sfQimoiwkEzJ1ey8l8nGtuR9KyNchIqbp/3Qq+RTZm3fzB5r1Z2oF3GYdWIbksKia0= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3730.namprd07.prod.outlook.com (52.132.102.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Tue, 10 Jul 2018 05:22:31 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0930.022; Tue, 10 Jul 2018 05:22:28 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Murthy, Nidadavolu" , "Sahu, Sunila" , "Gupta, Ashish" , "Kartha, Umesh" Thread-Topic: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev Thread-Index: AQHUF9OAxovObU6P4Eab6CgGP7WEgqSH7IjA Date: Tue, 10 Jul 2018 05:22:28 +0000 Message-ID: References: <1530631466-26427-1-git-send-email-shally.verma@caviumnetworks.com> <1530631466-26427-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3730; 7:lUEhsYMCGDXevE7VSieCrIF9JGqJhJ+zHMmzYq8JVPnq5qXcXh8Q9/q+jVczJv5UXgYYCD/mA12DlBv4nNPszgYNoqTaQJsPidRZ0xZkuCFBYZWsimqcKHIARGr2W4BIIkzxEmOgLkgbjuSN53ZpHY9znnjY5lOC2Z2qKkVwUY9KsVwPJ+LwGMdfH+TiC/eRw9VVFjgk+jGQxcZQ3c9GpxlpEa4AEkA2zKAXK8HlPwPtHDbVAfyQEXePaZE23bS9 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(136003)(39850400004)(366004)(346002)(376002)(396003)(189003)(199004)(13464003)(2906002)(74316002)(53936002)(4326008)(99286004)(6116002)(316002)(26005)(2900100001)(3846002)(14444005)(7736002)(66066001)(86362001)(305945005)(446003)(11346002)(476003)(6246003)(486006)(256004)(107886003)(68736007)(5660300001)(81166006)(81156014)(33656002)(478600001)(9686003)(5250100002)(6916009)(7696005)(106356001)(25786009)(105586002)(6436002)(186003)(229853002)(54906003)(55016002)(76176011)(102836004)(97736004)(72206003)(14454004)(8936002)(6506007)(53546011)(55236004)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3730; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: fdd05587-bffd-4adb-210a-08d5e6252103 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3730; x-ms-traffictypediagnostic: CY4PR0701MB3730: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3730; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3730; x-forefront-prvs: 0729050452 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /dF94rie612EEhvP+f1YP/CTL43UpwABOnSfX91717sipT4OUeTxlnnXAUKlgBUqt8S6R+1gsuAMwVKYrLEMKlUUWmNIA0iHJJ0MpdotC3etllNTzyOehJdBavw59pfjPbGYm08T6BziqZAJdPePA+UuCfWszsT58Rsin1ZRJb2EGOVeynEN82Qd2il0qwu4IXGQaHFBRv4dHYZAqC7UPWCQ0WZzlBt2zKOLxnPR+DRoDpFflTYILrqBteagdZhJ8rRGkzdfvDQH99K8QzLnToqTeZr9cLUhliWqlY2lA+E50ozV5r3X9bp+SsHVy5A5Aw5fpPO2+wnjTdhwGsmnW65tgZgTqKlZsfWwVKCPvOY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdd05587-bffd-4adb-210a-08d5e6252103 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2018 05:22:28.3262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3730 Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 05:22:33 -0000 Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 10 July 2018 03:54 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Murthy, Nidadavolu >; Sahu, Sunila ; Gup= ta, Ashish ; Kartha, >Umesh >Subject: RE: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptod= ev > >External Email > >Hi Shally, > >A few minor comments: > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Tuesday, July 3, 2018 4:24 PM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; >> nmurthy@caviumnetworks.com; Sunila Sahu >> ; Ashish Gupta >> ; Umesh Kartha >> >> Subject: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev >> > >Change title to: "cryptodev: add basic asymmetric structures"? >At least, don't use lib, and cryptodev twice. So what's convention for all patches? Just cryptodev: ? Thanks Shally > >> Add rte_crypto_asym.h with supported xfrms and associated op structures = and >> APIs >> >> API currently supports: >> - RSA Encrypt, Decrypt, Sign and Verify >> - Modular Exponentiation and Inversion >> - DSA Sign and Verify >> - Deffie-hellman private key exchange > >Diffie-Hellman > >> - Deffie-hellman public key exchange >> - Deffie-hellman shared secret compute >> - Deffie-hellman public/private key pair generation using xform chain >> >> Signed-off-by: Shally Verma >> Signed-off-by: Sunila Sahu >> Signed-off-by: Ashish Gupta >> Signed-off-by: Umesh Kartha >