From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0072.outbound.protection.outlook.com [104.47.40.72]) by dpdk.org (Postfix) with ESMTP id 267AE2951 for ; Fri, 6 Jul 2018 14:33:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SN5aUgaP/S7brhC1l5X9aZZ5IJUlHDioCZGFLIZmsoA=; b=CQMcd685Wo1NC91uPmJ8640y9JOkCIB7CyTg7XlwXMZaeLj/ll1Tg+VbUsLgds6aomnQge3WrDGx9c+QuhCT6eThrou8zJPQd63PY5iIOUEP72QHURO8CpL/Adt5a5BlemLHBiORj30J5prjxb4W9J6wjn/GnHdkoEbZcqzfQ8I= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3666.namprd07.prod.outlook.com (52.132.102.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Fri, 6 Jul 2018 12:33:14 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0930.016; Fri, 6 Jul 2018 12:33:14 +0000 From: "Verma, Shally" To: Pablo de Lara , "Gupta, Ashish" , "fiona.trahe@intel.com" , "lee.daly@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUFRiQQzarjuEX80ush0UnsgPL8KSCHzBw Date: Fri, 6 Jul 2018 12:33:14 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180706025430.21342-1-pablo.de.lara.guarch@intel.com> <20180706025430.21342-3-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180706025430.21342-3-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3666; 7:XLTJXXjP2vubUgJWFuqWdELeZkZqvELKBPCYfZyXicmb9FNyROIjdUFuNqo+fCeyewgQZr1ncEsCoE6oTjR+tL3hBn6hNLE8RAXSKoPXP70ZC3kKHcKfjQxclWdTn/WfYgY90Hcuzh/xqG0f/QPmjFe0daZhdqsI7LrARRm7lYdyt0Sdusd1BaZFKAClwXlRkAIwQFZc0iNtPopi5S+D99abJb/IHArP/fwmx7smF04Hs82wboYwqCHv8VxAg6Uk x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(39850400004)(366004)(346002)(396003)(136003)(376002)(13464003)(199004)(189003)(72206003)(74316002)(229853002)(9686003)(33656002)(5660300001)(478600001)(68736007)(81156014)(6436002)(575784001)(2201001)(486006)(7736002)(8676002)(305945005)(81166006)(2906002)(476003)(446003)(256004)(2900100001)(8936002)(11346002)(86362001)(186003)(102836004)(26005)(6506007)(97736004)(316002)(55236004)(66066001)(76176011)(7696005)(6246003)(99286004)(4326008)(14454004)(55016002)(110136005)(105586002)(53936002)(25786009)(2501003)(106356001)(5250100002)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3666; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 432aac39-f15a-47ec-dc33-08d5e33ca4a2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3666; x-ms-traffictypediagnostic: CY4PR0701MB3666: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3666; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3666; x-forefront-prvs: 0725D9E8D0 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: CjCiqXn+Hz1bMbgyoietbRsEvgOrXjxSZ7odGM7gB9e5BfErNoEnYa+U4nbMEc27mQ11g4sY89LlmJ5sqyi4ZGY9Z2v6joDSDuEzmKYe00EdgH5MF/bbT2ts8HsnTbSb5ZDeSTtmCid1QVDEAVzzZIyZUdzuLBw0njzywKuNLK5pB7xGAreMpOEXKj89x4aTvnCcCMb0MOCavIMVVaU1Jln1MMdQGQw0sDd+PjHrwBaTH3AM+JlFga1aTOzd4WH79NZI/YTZsftdDVUVGzTwShQAJq6xJLVZGVip+f1DDjEE2ba43eWZlfF3odNP/f1dx6w1R0AzlZDQZbIN8BWbFeDO1vC2wJ6AQQQ0JORUGx4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 432aac39-f15a-47ec-dc33-08d5e33ca4a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2018 12:33:14.1222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3666 Subject: Re: [dpdk-dev] [PATCH v4 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 12:33:18 -0000 Hi Pablo Looks fine. Just minor comments: >-----Original Message----- >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] >Sent: 06 July 2018 08:24 >To: Verma, Shally ; Gupta, Ashish ; fiona.trahe@intel.com; >lee.daly@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v4 3/4] compressdev: replace mbuf scatter gather flag > ... >@@ -6,19 +6,21 @@ >diff --git a/doc/guides/compressdevs/overview.rst b/doc/guides/compressdev= s/overview.rst >index d01c1a966..6d12c3bd6 100644 >--- a/doc/guides/compressdevs/overview.rst >+++ b/doc/guides/compressdevs/overview.rst >@@ -16,3 +16,17 @@ Supported Feature Flags > - "Pass-through" feature flag refers to the ability of the PMD > to let input buffers pass-through it, copying the input to the outpu= t, > without making any modifications to it (no compression done). >+ >+ - "OOP SGL In SGL Out" feature flag stands for >+ "Out-of-place Scatter-gather list Input, Scatter-gater list Output", >+ which means that the input and output buffers can consist of multipl= e segments. >+ May be its simpler to rephrase it and following somewhat this way: Which means " PMD support different scatter-gather styled input and output = buffers i.e. both can consists of multiple segments" >+ - "OOP SGL In LB Out" feature flag stands for >+ "Out-of-place Scatter-gather list Input, Flat Buffers Output", >+ which means that the input buffer can consist of multiple segments c= ombined >+ with a single segment buffer in the output. Which means "PMD support input from scatter-gathered styled buffers , but c= an output to linear buffers. And better to replace "flat" by "linear" to be consistent with name. >+ >+ - "OOP LB In SGL Out" feature flag stands for >+ "Out-of-place Flat Buffers Input, Scatter-gather list Output", >+ which means that the output buffer can consist of multiple segments = combined >+ with a single segment buffer in the input. Thanks Shally >diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes= /release_18_08.rst >index bc0124295..3487e3fb9 100644 >--- a/doc/guides/rel_notes/release_18_08.rst >+++ b/doc/guides/rel_notes/release_18_08.rst >@@ -60,6 +60,12 @@ API Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > >+* compressdev: Feature flag ``RTE_COMP_FF_MBUF_SCATTER_GATHER`` is >+ replaced with the following more explicit flags: >+ - ``RTE_COMP_FF_OOP_SGL_IN_SGL_OUT`` >+ - ``RTE_COMP_FF_OOP_SGL_IN_LB_OUT`` >+ - ``RTE_COMP_FF_OOP_LB_IN_SGL_OUT`` >+ > > ABI Changes > ----------- >diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rt= e_comp.c >index d596ba872..97ea0d922 100644 >--- a/lib/librte_compressdev/rte_comp.c >+++ b/lib/librte_compressdev/rte_comp.c >@@ -14,8 +14,12 @@ rte_comp_get_feature_name(uint64_t flag) > return "STATEFUL_COMPRESSION"; > case RTE_COMP_FF_STATEFUL_DECOMPRESSION: > return "STATEFUL_DECOMPRESSION"; >- case RTE_COMP_FF_MBUF_SCATTER_GATHER: >- return "MBUF_SCATTER_GATHER"; >+ case RTE_COMP_FF_OOP_SGL_IN_SGL_OUT: >+ return "OOP_SGL_IN_SGL_OUT"; >+ case RTE_COMP_FF_OOP_SGL_IN_LB_OUT: >+ return "OOP_SGL_IN_LB_OUT"; >+ case RTE_COMP_FF_OOP_LB_IN_SGL_OUT: >+ return "OOP_LB_IN_SGL_OUT"; > case RTE_COMP_FF_MULTI_PKT_CHECKSUM: > return "MULTI_PKT_CHECKSUM"; > case RTE_COMP_FF_ADLER32_CHECKSUM: >diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rt= e_comp.h >index 5b513c77e..274b5eadf 100644 >--- a/lib/librte_compressdev/rte_comp.h >+++ b/lib/librte_compressdev/rte_comp.h >@@ -30,23 +30,34 @@ extern "C" { > /**< Stateful compression is supported */ > #define RTE_COMP_FF_STATEFUL_DECOMPRESSION (1ULL << 1) > /**< Stateful decompression is supported */ >-#define RTE_COMP_FF_MBUF_SCATTER_GATHER (1ULL << 2) >-/**< Scatter-gather mbufs are supported */ >-#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 3) >+#define RTE_COMP_FF_OOP_SGL_IN_SGL_OUT (1ULL << 2) >+/**< Out-of-place Scatter-gather (SGL) buffers, >+ * with multiple segments, are supported in input and output >+ */ >+#define RTE_COMP_FF_OOP_SGL_IN_LB_OUT (1ULL << 3) >+/**< Out-of-place Scatter-gather (SGL) buffers are supported >+ * in input, combined with linear buffers (LB), with a >+ * single segment, in output >+ */ >+#define RTE_COMP_FF_OOP_LB_IN_SGL_OUT (1ULL << 4) >+/**< Out-of-place Scatter-gather (SGL) mbufs are supported >+ * in output, combined with linear buffers (LB) in input >+ */ >+#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 5) > /**< Adler-32 Checksum is supported */ >-#define RTE_COMP_FF_CRC32_CHECKSUM (1ULL << 4) >+#define RTE_COMP_FF_CRC32_CHECKSUM (1ULL << 6) > /**< CRC32 Checksum is supported */ >-#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM (1ULL << 5) >+#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM (1ULL << 7) > /**< Adler-32/CRC32 Checksum is supported */ >-#define RTE_COMP_FF_MULTI_PKT_CHECKSUM (1ULL << 6) >+#define RTE_COMP_FF_MULTI_PKT_CHECKSUM (1ULL << 8) > /**< Generation of checksum across multiple stateless packets is supporte= d */ >-#define RTE_COMP_FF_SHA1_HASH (1ULL << 7) >+#define RTE_COMP_FF_SHA1_HASH (1ULL << 9) > /**< SHA1 Hash is supported */ >-#define RTE_COMP_FF_SHA2_SHA256_HASH (1ULL << 8) >+#define RTE_COMP_FF_SHA2_SHA256_HASH (1ULL << 10) > /**< SHA256 Hash of SHA2 family is supported */ >-#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS (1ULL << 9) >+#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS (1ULL << 11) > /**< Creation of non-compressed blocks using RTE_COMP_LEVEL_NONE is suppo= rted */ >-#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM (1ULL << 10) >+#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM (1ULL << 12) > /**< Private xforms created by the PMD can be shared > * across multiple stateless operations. If not set, then app needs > * to create as many priv_xforms as it expects to have stateless >-- >2.14.4