From: "Verma, Shally" <Shally.Verma@cavium.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
"Sahu, Sunila" <Sunila.Sahu@cavium.com>,
"Gupta, Ashish" <Ashish.Gupta@cavium.com>
Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support
Date: Tue, 26 Jun 2018 11:22:17 +0000 [thread overview]
Message-ID: <CY4PR0701MB3634A9E884D0BC074B89394AF0490@CY4PR0701MB3634.namprd07.prod.outlook.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8DC234@IRSMSX108.ger.corp.intel.com>
>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 26 June 2018 14:53
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
>Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support
//snip
>> - retval = process_op(qp, ops[i], sess);
>> + if (ops[i]->type == RTE_CRYPTO_OP_TYPE_SYMMETRIC)
>> + retval = process_op(qp, ops[i],
>> + (struct openssl_session *) sess);
>
>Could you rename process_op to process_sym_op?
>
[Shally] Will do.
>Also, I think we need this check for the other PMDs.
>I will send a patch to check if op type is equal to symmetric.
>
>Pablo
next prev parent reply other threads:[~2018-06-26 11:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 6:05 [dpdk-dev] [PATCH v3 0/6] crypto: " Shally Verma
2018-05-16 6:05 ` [dpdk-dev] [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev Shally Verma
2018-06-15 8:40 ` De Lara Guarch, Pablo
2018-06-22 15:38 ` Verma, Shally
2018-06-25 21:34 ` De Lara Guarch, Pablo
2018-06-26 11:54 ` Verma, Shally
2018-05-16 6:05 ` [dpdk-dev] [PATCH v3 2/6] lib/cryptodev: add asym op support " Shally Verma
2018-06-15 9:05 ` De Lara Guarch, Pablo
2018-06-26 9:20 ` De Lara Guarch, Pablo
2018-06-26 11:21 ` Verma, Shally
2018-05-16 6:05 ` [dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability " Shally Verma
2018-06-17 12:11 ` De Lara Guarch, Pablo
2018-07-03 14:12 ` Trahe, Fiona
2018-07-03 14:47 ` Verma, Shally
2018-05-16 6:05 ` [dpdk-dev] [PATCH v3 4/6] test/crypto: add unit testcase for asym crypto Shally Verma
2018-06-17 12:52 ` De Lara Guarch, Pablo
2018-06-17 15:01 ` Verma, Shally
2018-06-17 19:31 ` De Lara Guarch, Pablo
2018-06-18 5:40 ` Verma, Shally
2018-06-18 6:39 ` Akhil Goyal
2018-06-18 6:48 ` Verma, Shally
2018-06-18 7:34 ` Akhil Goyal
2018-06-18 8:38 ` De Lara Guarch, Pablo
2018-06-18 16:22 ` Verma, Shally
2018-05-16 6:05 ` [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support Shally Verma
2018-06-17 13:25 ` De Lara Guarch, Pablo
2018-06-17 15:48 ` Verma, Shally
2018-06-17 19:38 ` De Lara Guarch, Pablo
2018-06-18 5:30 ` Verma, Shally
2018-06-23 12:41 ` Verma, Shally
2018-06-23 18:16 ` De Lara Guarch, Pablo
2018-06-23 18:26 ` Verma, Shally
2018-06-25 16:35 ` De Lara Guarch, Pablo
2018-06-26 9:23 ` De Lara Guarch, Pablo
2018-06-26 11:22 ` Verma, Shally [this message]
2018-07-03 14:50 ` Trahe, Fiona
2018-07-03 14:59 ` Verma, Shally
2018-07-03 15:11 ` Trahe, Fiona
2018-07-03 15:14 ` Verma, Shally
2018-05-16 6:05 ` [dpdk-dev] [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide Shally Verma
2018-06-14 10:43 ` Kovacevic, Marko
2018-06-15 8:06 ` Verma, Shally
2018-06-17 13:33 ` De Lara Guarch, Pablo
2018-06-17 16:59 ` Verma, Shally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR0701MB3634A9E884D0BC074B89394AF0490@CY4PR0701MB3634.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=Ashish.Gupta@cavium.com \
--cc=NarayanaPrasad.Athreya@cavium.com \
--cc=Sunila.Sahu@cavium.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).