From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0086.outbound.protection.outlook.com [104.47.32.86]) by dpdk.org (Postfix) with ESMTP id 7A12B2965 for ; Tue, 17 Jul 2018 14:50:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJQuDQav0wPr2NiZorPoAyyFn3fVc/RCC3jkAhL8vWs=; b=gmPzvWSV5YTrycUPM86lrDrLWYD/OUUqIHiOwMClE//tJ84xVzgXbJEDdrHY7XF56PfTOtoKVJolzU4wK+NwzlNwvXtF0/NnI6a9K6mVp6wghIkPSptgYsNomfmpAk1fl8j+yedcAWCHE81tPd1Hz2Tsj9z+JdmMzzXxUp3slx4= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3713.namprd07.prod.outlook.com (52.132.102.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Tue, 17 Jul 2018 12:50:15 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0952.021; Tue, 17 Jul 2018 12:50:14 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v2 3/6] compress/octeontx: add xform and stream create support Thread-Index: AQHUGvhW+/kN8tf0l0mOAGh3j0NBKKSTWrWg Date: Tue, 17 Jul 2018 12:50:14 +0000 Message-ID: References: <1530550477-22444-1-git-send-email-shally.verma@caviumnetworks.com> <1530550477-22444-4-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3713; 7:fcQlos8um16JZcC+nk/6GYno4JC+Wr1Jfnih3c1wVyX9BeR12TozJED+da9lAKlNyKSWRXHhhUeIkXzZC++IUm7orqCTL0jn1VGw8yonBVl5Igtom3VbpugDEulFiPgRnGPf7f5KKjC2v2UhUrpJyzr6EZ7ZGiq1WDC8JPxcAvlAJCr5YihPrIF/U0UWRJ2GPSLX6viWUxBdysuS4J0j/4Zuc61CIuUJatPq9UzYPB2waifsHgGh9zwMII2xg1yI x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(376002)(39860400002)(136003)(13464003)(189003)(199004)(53936002)(256004)(72206003)(97736004)(33656002)(316002)(6916009)(5660300001)(105586002)(106356001)(74316002)(5250100002)(478600001)(54906003)(305945005)(4326008)(25786009)(3846002)(2906002)(6116002)(66066001)(81156014)(81166006)(55016002)(8676002)(68736007)(6246003)(8936002)(76176011)(55236004)(7696005)(26005)(6506007)(9686003)(102836004)(53546011)(229853002)(2900100001)(6436002)(14454004)(107886003)(7736002)(186003)(486006)(476003)(86362001)(11346002)(99286004)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3713; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: ae857750-539b-47d9-aeea-08d5ebe3d72b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3713; x-ms-traffictypediagnostic: CY4PR0701MB3713: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3713; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3713; x-forefront-prvs: 073631BD3D received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: r0NcQvSxMxNUdxGwSfPY16f3955bSLGhr/Unlts1QHSsVaov0HUAhC3Ij/ZSDmcjhed6/gooo3lc+Vfp3BuBgeuMmkBmWitNJDLliexQBhI/JoLrwErsD4BzZ4y5QsZL5jgnc7Y850smw8L0DT6HTdQMoKwlOwbvsnTbdMLbv7Nv341WRiS267I2Xkua9CImFsu5S721msl5bXZSQTHj6zgT+9nZguVp2yNhLgnzkezG1nUiPXPi1zmqj+W/HRCmG7zyfXlBjNGUYPCxvY+QHJKVLXfqxVNG1UT3B1see+s6QhzCRgj1NxmP0uHybSYy6/+0yTWWHJ/ohWiY+I3K17KZx1eEOsnwIxff5oWL1aE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae857750-539b-47d9-aeea-08d5ebe3d72b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2018 12:50:14.2010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3713 Subject: Re: [dpdk-dev] [PATCH v2 3/6] compress/octeontx: add xform and stream create support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 12:50:17 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 14 July 2018 03:55 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Challa, Mahipal >; Gupta, Ashish ; Gupt= a, Ashish ; Sahu, >Sunila >Subject: RE: [PATCH v2 3/6] compress/octeontx: add xform and stream create= support > >External Email > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Monday, July 2, 2018 5:55 PM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; >> mchalla@caviumnetworks.com; Ashish Gupta >> ; Ashish Gupta >> ; Sunila Sahu >> >> Subject: [PATCH v2 3/6] compress/octeontx: add xform and stream create >> support >> >> From: Ashish Gupta >> >> implement private xform and stream create ops >> >> Signed-off-by: Ashish Gupta >> Signed-off-by: Shally Verma >> Signed-off-by: Sunila Sahu >> --- > >... > >> >> +static int >> +zip_pmd_stream_create(struct rte_compressdev *dev, >> + const struct rte_comp_xform *xform, void **stream) { > >Do you support stateful ops? If you don't, this should not be implemented,= I think (or should return -ENOTSUP). For us non-shareable priv_xform are equivalent to stream, so priv_xform_cre= ate falls back to stream_create . However, I see your point so to reflect = stateful not supported, we will set stream_create function pointer =3D NULL= in pmd_ops. Thanks Shally