From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0072.outbound.protection.outlook.com [104.47.41.72]) by dpdk.org (Postfix) with ESMTP id 597CB1BB3A for ; Sat, 23 Jun 2018 20:26:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9hjmsdn1yKk1g6pO0wway8nuLMpPzZCgpm9G3xUk8LY=; b=QOBhyYN35x3n2Nlm5M++z9d6egb2JxfwzJz0rRUkmL4rpkhi4bJvNjsLddwrP7+hJeHa7jynWiuecyZDnKmm+cyks6+44+ZvfzBegggRZxtAslBWTfjeKwsw3piJtYsHzYvurYb413t850Qu1VWVjvWpyziKUcNhUZRikBHp2mU= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3649.namprd07.prod.outlook.com (52.132.102.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Sat, 23 Jun 2018 18:26:27 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.023; Sat, 23 Jun 2018 18:26:26 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHUBj6irvnKsPODDEKF52aG05BtfaRkkSqwgABH5ACAAKR6kIAIUqIQgABgBwCAAAGQwA== Date: Sat, 23 Jun 2018 18:26:26 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [117.98.211.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3649; 7:kiWn+fKJNu35nlqgn2cvR3PO0yF1fVdPFkZCepCDmvhIVsxc4ulUllpdvGgltP6Mi46ErVrDO56bkxTvgaeO8I1EiseLgw60VM+nbrYyUvy37RqmC0eddio7HN44R/swOA2MurJEJYIW29dC5eFkMO/xYGaNF09BU+lfYBFMq+93XBXwvv92L1NmaXW+XOO1q0FoFuBURqNXt7j3x6D0bIGSyAzLfkP9n7rhUYlrqvP/4FKRSOmK1Au1mGALk5hr x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(39850400004)(39380400002)(346002)(376002)(396003)(189003)(199004)(51444003)(13464003)(33656002)(72206003)(86362001)(3846002)(478600001)(107886003)(25786009)(53936002)(106356001)(6246003)(105586002)(66066001)(81166006)(4326008)(6116002)(81156014)(9686003)(8936002)(2900100001)(68736007)(8676002)(3280700002)(26005)(2906002)(11346002)(54906003)(5250100002)(3660700001)(305945005)(6436002)(446003)(476003)(99286004)(486006)(7736002)(229853002)(76176011)(5660300001)(74316002)(93886005)(102836004)(7696005)(316002)(6916009)(55016002)(97736004)(14454004)(6506007)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3649; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 7f1e434a-8ba6-4edf-5bed-08d5d936d4d4 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3649; x-ms-traffictypediagnostic: CY4PR0701MB3649: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3649; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3649; x-forefront-prvs: 07126E493C received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /G2P3uPgs+Y3XaPn48CxmrqKuEBOG0DjLmAGZ+VFhRVgdCR/MVY0F1Dx3CzyFhj6IWbzJ38W9p9WF7+CePRaVG3H1E7Xz5gsGn25KOC4F6IPRPiAQDj+HLoVkboH1jJDBl5V/illkH2aWtXVOK2e7AJ3ubxHSxxz3CHT+ZS0ctjzQNk9VMtpTmlCMrs5PvncYgKm96AJZm8owIdyQ/02W8BoldtF1WAk5XYFVpMCZcKiXW7HgBw53BJUj9If/Ai72ErkcFcTJMvBvTVd3MHA65b+R9ZCghRUxgsVXUZuWO0MvCLg74H+ps4IJMgQhXDmkl5HxowlsqbTdOsKdhbC5A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f1e434a-8ba6-4edf-5bed-08d5d936d4d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2018 18:26:26.3535 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3649 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 18:26:29 -0000 >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 23 June 2018 23:47 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; dev@dpdk.or= g; Athreya, Narayana Prasad >; Sahu, Sunila = ; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > >External Email // snip >> >>Yes, but the name is still session_configure/clear, not >> sym_session_configure/clear, right? >> >>And also, I think we should rename the OpenSSL functions, >> >>openssl_pmd_session_*, to openssl_pmd_sym_session_*. >> >> >> >[Shally] Ok. I will look into this. >> > >> [Shally] if I change these names in struct rte_cryptodev_ops, then we wi= ll need >> to change all drivers. I think that should be done in a separate patch s= eries >> specific to rename these. For now, I will rename only openssl pmd APIs t= o use >> _sym version for this patch series. > >Right. I think a separate patch is a good idea, but it has to be done in o= ne patch, >to avoid breaking the compilation. Could you send this patch soon? > I can send openssl asym related patch soon. Can't commit on right now for s= ym_ session name in pmd ops changes. Sorry about that. Thanks Shally >Thanks, >Pablo > >> >> >Thanks >> >Shally >> > >> >>Pablo >> >> >> >>> >> >>> Thanks for review. >> >>> >> >>> >Thanks, >> >>> >Pablo >> >>> >