From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0059.outbound.protection.outlook.com [104.47.37.59]) by dpdk.org (Postfix) with ESMTP id 273481BE0F for ; Sat, 7 Jul 2018 08:34:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E28wuXAm6RlkiRNwr6FOJRXqNXRjK0x8s9nqg3HCJBU=; b=Xg7n6NkXQMt26eFo9ih1XwEGqkSfVakRAIwn0ym2lHuTRrZ69Y4lgoi7noMrVgBqGaAbAEK4qq9A1szqwCYjhfOfpmAQeNTsu4s6u0gd6g3YSauB1ZKLdLCsCQGfpKh/OJqSKSxxR3f7wJmJpHoRTSbmPflbwYTyK4cPK5RaPEk= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3731.namprd07.prod.outlook.com (52.132.102.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.19; Sat, 7 Jul 2018 06:34:14 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0930.016; Sat, 7 Jul 2018 06:34:13 +0000 From: "Verma, Shally" To: Pablo de Lara , "Gupta, Ashish" , "fiona.trahe@intel.com" , "lee.daly@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUFS31Vd3S/Oc+Y0ydLXyWhb4aHKSDTcoA Date: Sat, 7 Jul 2018 06:34:13 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180706052801.12901-1-pablo.de.lara.guarch@intel.com> <20180706052801.12901-3-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180706052801.12901-3-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [171.49.225.192] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3731; 7:lwXNhI7SolrU+voQsar43opmO2c2bdVJqttOe6M+1n5IWDCq3xvQvpae+6xC3+HcEMZ3PIA6GQnlQvJRDvKy4EPJRl3Sy1ufnJRXFfGfwq0qaTYSFhCyQ1YNw+UUJfJotARCzy6DDvEeW0G1rfRTGoq5BX0vl8Ukmf4o9THgFy5YWv0XO/UqnghB6KMm1YsTlSltomzi29GOkABAbprM6zIRHWQ24VJZJnrw69EwcrwweQj+PBsjKHylUKrneSdY x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(396003)(376002)(136003)(39860400002)(346002)(199004)(189003)(13464003)(55016002)(8936002)(14454004)(229853002)(2201001)(86362001)(72206003)(478600001)(9686003)(4326008)(33656002)(316002)(97736004)(25786009)(106356001)(110136005)(26005)(81166006)(3846002)(7696005)(6116002)(105586002)(53936002)(6436002)(186003)(256004)(81156014)(2501003)(68736007)(8676002)(76176011)(5250100002)(5660300001)(55236004)(305945005)(6506007)(486006)(11346002)(2906002)(102836004)(6246003)(74316002)(476003)(99286004)(446003)(2900100001)(66066001)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3731; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: e1e6dba4-06f9-4c70-e52c-08d5e3d3a7db x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3731; x-ms-traffictypediagnostic: CY4PR0701MB3731: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3731; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3731; x-forefront-prvs: 0726B2D7A6 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: L5qR1j8fdbSBTZXKe4DJDA0HGNWmgP9EOF7eJPoluCkn4NtPR3xchnHHHMuZSajfAvd99ESEra7hB1x2PnFRy6NvitionBDZhhgmj/rf5fM5gnbMeNm7pVsyqZKUKpxefx8TXpH/df0+4Ednb2Pnqh2danJqVLJxrERvop85yF4EMKxwkcFfdl/T6/pBb/jocWwWEu93zKyMXxuwNAJGoKLxIPXdRZPAeg+EbXYuDNRT1kmOwCbezxqZTQ0libz3Ss6rpvesWcb+UY+mj5lFbLDZZLRvUJQhw69U2sq3FYPQLBGAVKhYhKCmYqO/MC/DWT92i2x3gtNFXUyhEKFT5eqNU6C6tdrHfV1uL0d0BjI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1e6dba4-06f9-4c70-e52c-08d5e3d3a7db X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2018 06:34:13.5822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3731 Subject: Re: [dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2018 06:34:16 -0000 >-----Original Message----- >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] >Sent: 06 July 2018 10:58 >To: Verma, Shally ; Gupta, Ashish ; fiona.trahe@intel.com; >lee.daly@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag > >External Email > >The current mbuf scatter gather feature flag is >too ambiguous, as it is not clear if input and/or output >buffers can be scatter gather mbufs or not. > >Therefore, three new flags will replace this flag: >- RTE_COMP_FF_OOP_SGL_IN_SGL_OUT >- RTE_COMP_FF_OOP_SGL_IN_FB_OUT >- RTE_COMP_FF_OOP_LB_IN_SGL_OUT > >Note that out-of-place flat buffers is supported by default >and in-place is not supported by the library. > >Signed-off-by: Pablo de Lara >Acked-by: Fiona Trahe >--- > >v5: >- Replaced left "Flat Buffer" with "Linear Buffer" (Shally) >- Rephrased comment about new feature flags (Shally) > >v4: >- Replaced FB (Flat Buffers) with LB (Linear Buffers) (Shally) >- Add extra explanation on comments about Linear Buffers vs > Scatter-gather lists > >v3: >- Replaced Out-of-place with OOP >- Added new feature flags in default.ini > >v2: >- Fixed typos >- Rephrased comments > > doc/guides/compressdevs/features/default.ini | 34 +++++++++++++++--------= ----- > doc/guides/compressdevs/overview.rst | 14 ++++++++++++ > doc/guides/rel_notes/release_18_08.rst | 6 +++++ > lib/librte_compressdev/rte_comp.c | 8 +++++-- > lib/librte_compressdev/rte_comp.h | 31 +++++++++++++++++------= -- > 5 files changed, 65 insertions(+), 28 deletions(-) > ... >diff --git a/doc/guides/compressdevs/overview.rst b/doc/guides/compressdev= s/overview.rst >index d01c1a966..70bbe82b7 100644 >--- a/doc/guides/compressdevs/overview.rst >+++ b/doc/guides/compressdevs/overview.rst >@@ -16,3 +16,17 @@ Supported Feature Flags > - "Pass-through" feature flag refers to the ability of the PMD > to let input buffers pass-through it, copying the input to the outpu= t, > without making any modifications to it (no compression done). >+ >+ - "OOP SGL In SGL Out" feature flag stands for >+ "Out-of-place Scatter-gather list Input, Scatter-gater list Output", >+ which means PMD supports different scatter-gather styled input and o= utput buffers >+ (i.e. both can consists of multiple segments). >+ >+ - "OOP SGL In LB Out" feature flag stands for >+ "Out-of-place Scatter-gather list Input, Linear Buffers Output", >+ which means PMD supports input from scatter-gathered styled buffers,= outputting linear buffers >+ (i.e. single segment). >+ >+ - "OOP LB In SGL Out" feature flag stands for >+ "Out-of-place Linear Buffers Input, Scatter-gather list Output", >+ which means PMD supports input from linear buffer, outputting scatte= r-gathered styled buffers. .... >diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rt= e_comp.h >index 5b513c77e..274b5eadf 100644 >--- a/lib/librte_compressdev/rte_comp.h >+++ b/lib/librte_compressdev/rte_comp.h >@@ -30,23 +30,34 @@ extern "C" { > /**< Stateful compression is supported */ > #define RTE_COMP_FF_STATEFUL_DECOMPRESSION (1ULL << 1) > /**< Stateful decompression is supported */ >-#define RTE_COMP_FF_MBUF_SCATTER_GATHER (1ULL << 2) >-/**< Scatter-gather mbufs are supported */ >-#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 3) >+#define RTE_COMP_FF_OOP_SGL_IN_SGL_OUT (1ULL << 2) >+/**< Out-of-place Scatter-gather (SGL) buffers, >+ * with multiple segments, are supported in input and output >+ */ >+#define RTE_COMP_FF_OOP_SGL_IN_LB_OUT (1ULL << 3) >+/**< Out-of-place Scatter-gather (SGL) buffers are supported >+ * in input, combined with linear buffers (LB), with a >+ * single segment, in output >+ */ >+#define RTE_COMP_FF_OOP_LB_IN_SGL_OUT (1ULL << 4) >+/**< Out-of-place Scatter-gather (SGL) mbufs are supported >+ * in output, combined with linear buffers (LB) in input >+ */ [Shally] Similar rephrase here please. Rest, Acked-by: Shally Verma Thanks Shally >+#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 5) > /**< Adler-32 Checksum is supported */ >-#define RTE_COMP_FF_CRC32_CHECKSUM (1ULL << 4) >+#define RTE_COMP_FF_CRC32_CHECKSUM (1ULL << 6) > /**< CRC32 Checksum is supported */ >-#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM (1ULL << 5) >+#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM (1ULL << 7) > /**< Adler-32/CRC32 Checksum is supported */ >-#define RTE_COMP_FF_MULTI_PKT_CHECKSUM (1ULL << 6) >+#define RTE_COMP_FF_MULTI_PKT_CHECKSUM (1ULL << 8) > /**< Generation of checksum across multiple stateless packets is supporte= d */ >-#define RTE_COMP_FF_SHA1_HASH (1ULL << 7) >+#define RTE_COMP_FF_SHA1_HASH (1ULL << 9) > /**< SHA1 Hash is supported */ >-#define RTE_COMP_FF_SHA2_SHA256_HASH (1ULL << 8) >+#define RTE_COMP_FF_SHA2_SHA256_HASH (1ULL << 10) > /**< SHA256 Hash of SHA2 family is supported */ >-#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS (1ULL << 9) >+#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS (1ULL << 11) > /**< Creation of non-compressed blocks using RTE_COMP_LEVEL_NONE is suppo= rted */ >-#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM (1ULL << 10) >+#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM (1ULL << 12) > /**< Private xforms created by the PMD can be shared > * across multiple stateless operations. If not set, then app needs > * to create as many priv_xforms as it expects to have stateless >-- >2.14.4