From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0065.outbound.protection.outlook.com [104.47.42.65]) by dpdk.org (Postfix) with ESMTP id 22EB51B5A5 for ; Wed, 11 Jul 2018 14:41:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SpuWwxS4Ah4NUqt3DWp1WNBYD34Qfh8kbSItg3Wl2UA=; b=lp+UloQ9CSwzLT1KcVoPoOb1Gve4qtyS3OZ88atKsJTXchOdqcFNIn00c5Z5UGkKSvD2UiYXqtO0X2m336IFhbkdMqp8t+Jh2BM/J0fcogwBWdFTw2yuf7uPYyaiFQ41qg9rj2n+RDZZEs7hAnUlMkvF4W+n8KMzSjvJglplRG8= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3827.namprd07.prod.outlook.com (52.132.102.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Wed, 11 Jul 2018 12:40:59 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0930.022; Wed, 11 Jul 2018 12:40:58 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support Thread-Index: AQHUGRC5U6CkVEHs40ent1ZF/yzEyaSJ9how Date: Wed, 11 Jul 2018 12:40:58 +0000 Message-ID: References: <1530550631-22841-1-git-send-email-shally.verma@caviumnetworks.com> <1530550631-22841-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3827; 7:XeSighFeInE47uqJKYTX6pDLpwyqyq9Pfl6Bllez1gyYQse0oNKU635d5OHXtUBaAJpDKlnkuzIHShHaudx+OQGPMNFkWk4DUTB4Wi2DMVyz+v4hMzqXVH0kEQ9V0B+Bos5C5loXV+NKbFwOcKOZ5H9NlCO5KLWSYXKLzIR7G6XYe9Kg3UZQYkqqsvbWkHvbr+88DkXW4uELICQy8PXsi/xtKX5eVzuapZUdo38R38f7rfsgqVcfPGHXCBDO8uzH x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(366004)(39860400002)(136003)(13464003)(199004)(189003)(14444005)(7696005)(105586002)(53546011)(2900100001)(76176011)(6506007)(25786009)(106356001)(72206003)(81166006)(81156014)(478600001)(8676002)(14454004)(8936002)(476003)(6916009)(55236004)(446003)(33656002)(99286004)(11346002)(66066001)(256004)(2906002)(5250100002)(229853002)(102836004)(7736002)(55016002)(9686003)(54906003)(5660300001)(6436002)(3846002)(26005)(186003)(316002)(86362001)(305945005)(6116002)(6246003)(4326008)(107886003)(74316002)(97736004)(486006)(53936002)(68736007)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3827; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: c69a1852-b21e-439b-1583-08d5e72b8d93 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3827; x-ms-traffictypediagnostic: CY4PR0701MB3827: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3827; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3827; x-forefront-prvs: 0730093765 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ATXreJL9YImfsLmD8ZDCWVol/lIFQLN1qk1gsW2PDJ7G9a2R3UQV0pBkVkqcqQ+cp3KFsQ1rTs1wX9SnfgoFE8nuKUhg+ihVmQzkqkOMihZZxY05WOR5+XdG/8786bHYhrIfB5Y54nPqrpKMPx8JbqvDP32w2vTJ+THKeXEIFDmYNZNLC8s2luaVaHhL1JK8c7Vl445BC5joUjKEa+t3AWEbyTPWa2xRd9GeURVUP5/qawzvbQYFm4d3gpzpzn4S8gIq8wo1VmUM24sfGmqRrqDgS8VW/HKFOz2UGcfuDSlg52/CtYsqGhZdtODlC0TTx5OX7XO3AqOpE1pAjmrrnBmi86mSq5b82PkULUklkMM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: c69a1852-b21e-439b-1583-08d5e72b8d93 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2018 12:40:58.7004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3827 Subject: Re: [dpdk-dev] [PATCH v2 1/5] compress/zlib: add ZLIB PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 12:41:01 -0000 Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 11 July 2018 17:44 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Challa, Mahipal >; Gupta, Ashish ; Sahu= , Sunila >Subject: RE: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support > >External Email > >And the last comments, sorry for the multiple replies. No issues. > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Monday, July 2, 2018 5:57 PM >> To: De Lara Guarch, Pablo >> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; >> mchalla@caviumnetworks.com; Ashish Gupta >> ; Sunila Sahu >> >> Subject: [PATCH v2 1/5] compress/zlib: add ZLIB PMD support >> >> From: Ashish Gupta >> >> Add sw zlib pmd support in compressdev driver. >> Add device probe and remove support. >> Add ZLIB build file support. >> >> Signed-off-by: Sunila Sahu >> Signed-off-by: Shally Verma >> Signed-off-by: Ashish Gupta > >... > >> +++ b/drivers/compress/zlib/zlib_pmd.c > >... > >> +static void >> +zlib_init_log(void) >> +{ >> + zlib_logtype_driver =3D rte_log_register("compress_zlib"); > >The standard for the name of the logtype for PMDs is "pmd.driverType.drive= rName", >so in this case it would be "pmd.compress.zlib". > > >> + if (zlib_logtype_driver >=3D 0) >> + rte_log_set_level(zlib_logtype_driver, RTE_LOG_INFO); } >> diff --git a/drivers/compress/zlib/zlib_pmd_private.h >> b/drivers/compress/zlib/zlib_pmd_private.h >> new file mode 100644 >> index 0000000..d4c80b1 >> --- /dev/null >> +++ b/drivers/compress/zlib/zlib_pmd_private.h > >... > >> +#define ZLIB_PMD_INFO(fmt, args...) \ >> + ZLIB_PMD_LOG(INFO, fmt, ## args) >> +#define ZLIB_PMD_ERR(fmt, args...) \ >> + ZLIB_PMD_LOG(ERR, fmt, ## args) >> +#define ZLIB_PMD_WARN(fmt, args...) \ >> + ZLIB_PMD_LOG(WARNING, fmt, ## args) > >What do you think of having a single macro ZLIB_LOG(level, fmt, args...)? > I find it simpler to use ZLIB_PMD_INFO/ERR?DEBUG version . So would prefer = to stick to them. Thanks for review. Shally