From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0072.outbound.protection.outlook.com [104.47.40.72]) by dpdk.org (Postfix) with ESMTP id DD9D1235 for ; Mon, 23 Jul 2018 19:18:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dOKyKSf1RHh0FCIfZNRakh42bOUjbgNFCK3pxQSAzKQ=; b=HysljEiyxG02wLLhm1XMvRk4T16Vdtaz0YsDEEBnWDjyRSaHrDYoPTkfTXkQIpeAQIK+B8j4Nm9cHIl/ZXxKS4U+BIr4EjwYrcRgiD3Wp8BA9nTLbfxBiudFFESWOHpPztKMd4IhHY2+2iae9OestBZc6el+OW64lDusu7wMC38= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3681.namprd07.prod.outlook.com (52.132.102.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Mon, 23 Jul 2018 17:14:28 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f0d4:1828:37f5:5927%2]) with mapi id 15.20.0973.022; Mon, 23 Jul 2018 17:14:26 +0000 From: "Verma, Shally" To: Stephen Hemminger CC: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" , "Sahu, Sunila" Thread-Topic: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue Thread-Index: AQHUIqXDXy3kcu5YSU66+Pg9gMH2NqSdCvdg Date: Mon, 23 Jul 2018 17:14:26 +0000 Message-ID: References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com> <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com> <20180723095357.5a85b206@xeon-e3> In-Reply-To: <20180723095357.5a85b206@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [114.143.185.87] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3681; 6:BIrH4HvjtnGtpcJYxRKb2ByTcl4t/hhWnLLrsufzGGx9fb4IGZGLD9BM/PYQJ8Bz4BuVay1kgUjauwlxTtDeCvocsT68ui+eotNI+Pt1oNWEidtiaXvsX6x0n9KCqiOO3/v/Yo3KQb01kjWlUtKWqo5x3oxY+4iw4AZN8JsgCAoZfUzSvzG0SRDTx8QR2EzLcgX8LlQkuFLS7rFxC/5zT2FcrKoSoNcK6MwSufZpLYqn5veRDu/NGf7Dm6DolaZc31G8cT9npv8IvSPQhQGqTpwPyx1YqhVMMNNYmWszFzOld64PP1tM2vOpAM0Ysc1x3b+xtSLe01BAqWn4j6DhDX9x129mWY82f5VpmJGy664+zaT0jW+By4FxGF6Ym+I2mCcjXaLHclkxXD9KoggiENt0mM5qv0OJVB8pY/2agcSHq63bJKdRAhrX20FQJBypWMIe1cWqfA//NPSHHcHhaA==; 5:ZSqe+piE6fjSEI8YjZRMSpVryBrk0vMZkJ6rr3U/J/1GZ5Prr1Yawwolel0pjWPJuza1XdFkmw3pd9kj1IlgPAfedDlJKCsKr5S1Ji3CQZIy3swkQqqXzU6obtep2VZXrXF+1M2KfdDxyyNo7Unf4hw6ione4rvQl0SVrFmL7Eg=; 7:eZUz08Yi3TeqW65qczOW4YWYt+V/gRnpPnmNeaFGwmi8W9Twluzx7UEwEIkS/+1sHPBdaRyEkxqKiDOy2roTYkMGpQjCkm5izaMvMUWagdIqW/yKhlVSbz52E/UYnrLsFC17skG+xRaNvpB9roiQzDiDOfbOwnKnZoNZNVUIYILIfAWpJsA/C5uOg+BKCuSSDx3s4YKEHIcdZQIGbmfqkv+JzcA6Vw+dFklILmVCSj1eojTODCZwAuMnAIbeyH38 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(346002)(136003)(366004)(39860400002)(376002)(199004)(189003)(13464003)(5250100002)(2906002)(74316002)(7736002)(68736007)(2900100001)(53936002)(305945005)(6916009)(81156014)(81166006)(8676002)(478600001)(229853002)(8936002)(72206003)(54906003)(6436002)(97736004)(66066001)(55016002)(256004)(33656002)(9686003)(446003)(26005)(106356001)(14454004)(105586002)(316002)(99286004)(25786009)(5660300001)(3846002)(6116002)(107886003)(7696005)(11346002)(76176011)(86362001)(186003)(102836004)(6506007)(4326008)(476003)(6246003)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3681; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 0c2c67d2-be82-4a9f-e4f3-08d5f0bfbe57 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3681; x-ms-traffictypediagnostic: CY4PR0701MB3681: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3681; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3681; x-forefront-prvs: 0742443479 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KPT3+C2Rg8i8ydbodL1gHNxCCam4J9r9dqGx48gt+4WjyiWoOwZj/o9cYkMR8DyCH4S/OoLwH1rY2Ouyo1dpUYWVLoJCukXMhVMHr1KMRLHHIuArZ8U3YkWRAs6KEhvfyGhp0q2rx+4MgWxCaGtTz6tbvd2oI0jFrNiL/nL3J++XM+z6THUFQBEKAQ5dMna9IWXJlzQZesgBOJb0qDCZ91wL5iXaphJyGZgmzU7Cbimn9pzCZwfTHrcxB6TOM7d3snsMj8e4mk2SHXWUkL4+x0K0TavuRIiUuy21jx31Dbm3xVoSOXVAEiQ9zDPRP8JT30K54XcwZtORb3nBME3/cE2fsJCM9vaMjnC2Y/qTXjU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c2c67d2-be82-4a9f-e4f3-08d5f0bfbe57 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2018 17:14:26.4383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3681 Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 17:18:22 -0000 >-----Original Message----- >From: Stephen Hemminger >Sent: 23 July 2018 22:24 >To: Verma, Shally >Cc: pablo.de.lara.guarch@intel.com; dev@dpdk.org; Athreya, Narayana Prasad= ; Challa, >Mahipal ; Gupta, Ashish ; Sahu, Sunila ; >Sahu, Sunila >Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueu= e/dequeue > >External Email > >On Sat, 21 Jul 2018 23:47:48 +0530 >Shally Verma wrote: > >> -/** Parse comp xform and set private xform/stream parameters */ >> +/** Compute next mbuf in the list, assign data buffer and length, >> + * returns 0 if mbuf is NULL >> + */ >> +#define COMPUTE_BUF(mbuf, data, len) \ >> + ((mbuf =3D mbuf->next) ? \ >> + (data =3D rte_pktmbuf_mtod(mbuf, uint8_t *)), \ >> + (len =3D rte_pktmbuf_data_len(mbuf)) : 0) >> + > >Could this be an inline not a macro? [Shally] Again what goes in favour of inline here? Just curious to know if = DPDK has any preferred guidelines regarding this? Thanks Shally=20