From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0058.outbound.protection.outlook.com [104.47.34.58]) by dpdk.org (Postfix) with ESMTP id CEBE925B3 for ; Sun, 17 Jun 2018 17:48:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uWgUvGx5hYZcC8JXP8Ahme/ha3hHZTUjeoFtglEw+dY=; b=Y5F2X8867/GsscKt66p7MWozvBG2CQjd5vF05/urrP+Uo5UB2Plv5E9+md15uzdRGmnyzk01+l00nBhbqaeu0IAHYtoguC0YpUjm75fOiECm2qyJFs5v0aVV40FuNXWpBW3ZuW/TyxKdzZpIE6lvIQjOXzHkdfyIJ5JdGw38koE= Received: from CY4PR0701MB3634.namprd07.prod.outlook.com (52.132.101.164) by CY4PR0701MB3700.namprd07.prod.outlook.com (52.132.102.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Sun, 17 Jun 2018 15:48:22 +0000 Received: from CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b]) by CY4PR0701MB3634.namprd07.prod.outlook.com ([fe80::f55a:7354:8d2f:cf0b%2]) with mapi id 15.20.0863.016; Sun, 17 Jun 2018 15:48:21 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHUBj6irvnKsPODDEKF52aG05BtfaRkkSqw Date: Sun, 17 Jun 2018 15:48:21 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [117.98.211.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR0701MB3700; 7:XEYGT24RKx/ZBs2WI+nT9H1DtDlv15OhNxxoTsif4KeqxgkC8z5KzjgEiTcc0Knu7mssi3k2e6u1PMYLFZ2PrQHY0GJ+/th2NDvMHmF+jfww15T0XvRjrKC9G1dpwGy/3/UwiC1v83jXQsa6tssHMBOzPdgoYuUtIfNLtYgbZ7SBVvu1MDugWHx4ksfxpDtRExalRwR41pJJObf6iFNhUAEhvfs7fFz2sQdja8SX4hQutrwbS6VKGkTmHDgQgJT8 x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(376002)(346002)(39380400002)(396003)(366004)(39850400004)(13464003)(189003)(199004)(102836004)(316002)(105586002)(575784001)(86362001)(7736002)(186003)(26005)(476003)(59450400001)(6506007)(72206003)(229853002)(53546011)(6436002)(6916009)(11346002)(446003)(305945005)(8676002)(54906003)(478600001)(5250100002)(76176011)(7696005)(74316002)(14454004)(486006)(4326008)(55016002)(3846002)(6116002)(81156014)(8936002)(25786009)(81166006)(5660300001)(3280700002)(3660700001)(106356001)(2906002)(6246003)(33656002)(68736007)(107886003)(8656006)(53936002)(2900100001)(66066001)(9686003)(6306002)(97736004)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3700; H:CY4PR0701MB3634.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 88a7eba3-7c64-4c4e-468b-08d5d469c0aa x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3700; x-ms-traffictypediagnostic: CY4PR0701MB3700: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:CY4PR0701MB3700; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3700; x-forefront-prvs: 07063A0A30 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: CO/Iy0J2RrtfyFQH4f8CvJNId0hRJfxVCdScOv9JobJMaCFSCALWcWJgaryR67/DeAHHhxPDRXaH0Yt4A3A1sfZFADTySEAxiViSFT5Li7YKBzAfhq8rSyzKas1t2R/xx8XONtzXjTLUNtD7sRXsAUzCpJ3h+VEjb8bMvjJ05+GPBd1WjQmZwjLSJ7JKSVkA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88a7eba3-7c64-4c4e-468b-08d5d469c0aa X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2018 15:48:21.0269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3700 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 15:48:24 -0000 Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] >Sent: 17 June 2018 18:55 >To: Verma, Shally >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; dev@dpdk.or= g; Athreya, Narayana Prasad >; Sahu, Sunila = ; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > >External Email > >> -----Original Message----- >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] >> Sent: Wednesday, May 16, 2018 7:05 AM >> To: De Lara Guarch, Pablo >> Cc: Trahe, Fiona ; akhil.goyal@nxp.com; >> dev@dpdk.org; pathreya@caviumnetworks.com; Sunila Sahu >> ; Ashish Gupta >> >> Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support >> >> Add asymmetric crypto operation support in openssl PMD. >> Current list of supported asym xforms: >> * RSA >> * DSA >> * Deffie-hellman >> * Modular Operations >> >> changes from v2: >> - Update the pmd capability as per new capability structure >> >> changes from v1: >> - resolve new line error in dod/guides/cryptodevs/openssl.rst >> >> Signed-off-by: Shally Verma >> Signed-off-by: Sunila Sahu >> Signed-off-by: Ashish Gupta >> --- .. [snip] .. >> +; >> +; Supported Asymmetric algorithms of the 'openssl' crypto driver. >> +; >> +[Asymmetric] >> +RSA =3D Y >> +DSA =3D Y >> +Modular Exponentiation =3D Y >> +Modular Inversion =3D Y >> +Deffie-hellman =3D Y > >You need to add these parameters in default.ini file, >otherwise they are not shown when building the documentation. > [Shally] Ok ..[snip].. >> >> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c >> b/drivers/crypto/openssl/rte_openssl_pmd.c >> index f584d0d6f..527e42773 100644 >> --- a/drivers/crypto/openssl/rte_openssl_pmd.c >> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > >... > >> + } >> + dh_key->priv_key =3D BN_bin2bn(op->priv_key.data, >> + op->priv_key.length, >> + dh_key->priv_key); > >As on the previous patch, I am getting a compilation issue: > >drivers/crypto/openssl/rte_openssl_pmd.c:1711:9: error: >dereferencing pointer to incomplete type 'DH {aka struct dh_st}' > dh_key->priv_key =3D BN_bin2bn(op->priv_key.data, > [Shally] as I mentioned before Openssl PMD support 1.0.2 version series(ht= tp://doc.dpdk.org/guides/cryptodevs/openssl.html) and thus the error=20 >... > >> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c >> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c >> index 1cb87d59a..76f7410cb 100644 >> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c >> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > >... > >> struct rte_cryptodev_ops openssl_pmd_ops =3D { >> .dev_configure =3D openssl_pmd_config, >> .dev_start =3D openssl_pmd_start, >> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops =3D { >> .queue_pair_count =3D openssl_pmd_qp_count, >> >> .session_get_size =3D openssl_pmd_session_get_size, >> + .asym_session_get_size =3D >> openssl_pmd_asym_session_get_size, >> .session_configure =3D openssl_pmd_session_configure, >> - .session_clear =3D openssl_pmd_session_clear >> + .asym_session_configure =3D >> openssl_pmd_asym_session_configure, >> + .session_clear =3D openssl_pmd_session_clear, >> + .asym_session_clear =3D openssl_pmd_asym_session_clear >> }; > >I think session_get_size, session_configure and session_clear should be re= named >to sym_session_*, to avoid confusion. Could you add another patch renaming= these? > [Shally] I see in latest cryptodev these typedefs are already named to=20 cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and _sym= _free_.. so these changes would come while rebase. or you are referring to change openssl_pmd_session_configure to openssl_pmd= _sym_session_configure and so others? Thanks for review. >Thanks, >Pablo >