From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6696A034F; Tue, 30 Mar 2021 05:25:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F12A140F70; Tue, 30 Mar 2021 05:25:34 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 1B2A2140F6F for ; Tue, 30 Mar 2021 05:25:32 +0200 (CEST) IronPort-SDR: LWmJ/eGY2BR0agR0V4MwqyAtEmA036l66HEnXfKudZYmxThl7idpGEFqxg8d0BHDuhMbv2cLpk 8vYbS6OEOkEg== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="191708288" X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="191708288" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 20:25:31 -0700 IronPort-SDR: 4CzavNODPY1Nj513+VhwXZ7xCseo/KYKMs7F9/COM4VQHCcb3DetTdQAR85kKSIpZHjPsi1VW+ CEtQLtNE7FPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,289,1610438400"; d="scan'208";a="527170648" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 29 Mar 2021 20:25:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 29 Mar 2021 20:25:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 29 Mar 2021 20:25:30 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 29 Mar 2021 20:25:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vixm+UMEEzgBFOvD5fCuFArZzoXgIBoP8/UwSHUj2Ww5SSn390ieO6Cylnqq7QFwJ+wl7Gr3y1e+VnyjQnuwexMPGqKsfCwaAS9z9cHQeLGlladRpTRBkRnIiWWJMAkHo8Lf93PurPsMJumYLNUykWozqt/bxB84nLAq9TL4aeMFCLd4mnbDMF5k1P0aS8CnL3tcJG56h4ylRQH5Lc0v5evZzXOA21brWd2qhy+S1Kny85jedwPCbUp6SSg9HkFjbut5nBxx5zbZMRT6XfRo4PVIzu6xcmpCey+feUWiu+wOenEAgiOpLrcz7tLiZNIZsYuWDNlWCfSbttCjrvL3kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6AtBTlAGc44mtu02+FW6GbFZ0/vuP4s0ErI9aihpeyU=; b=UyR8iLiQmKZIUJpx9olUIG2RnwBM7qP2B63zT3GUiNVvCWFdPyGZIqvP7mbn23PmXH1VPW/yOarUWqQb+uAOOLePI+vRBamJ4o0b8IjxvA6uD3nhzAwbjfmMUBSxZLNTD/hdjYbwWSe6SVUrJwNlWlqCTAvNAsJtS8cElmsiHd6YZKyIUWr9i4ZfJR+gvV4izh3oft7vW/6IgDX5Yj42H6b4nS6J37aRCfTeD5xwlgzPg9q87ZKr4ltf38tqQbkpVpMUETv9rbsNLMGMKxWefuuqz0kw6+AfbgxiCB60snhZPzZd6aAzmsXyKKIkoscOCjHlyBAW1txPHQtHoTfxUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6AtBTlAGc44mtu02+FW6GbFZ0/vuP4s0ErI9aihpeyU=; b=ai7Wrqu3Ra4f9ll4IjeYDdVITOkEnYbSkcYwxIqaBHDE4+dTwR/+8HWszZs9lb2hEZ4YCsCZ2fe+JuBa6AecayYZWrYoxIFofBH77+elFs2sKxIHEm6RNmnNuvOVCIp8Nddq9VvEgSr/EAm6fCdQkj4kKBitAfjk78qUMIG5W3k= Received: from CY4PR1101MB2069.namprd11.prod.outlook.com (2603:10b6:910:17::7) by CY4PR1101MB2247.namprd11.prod.outlook.com (2603:10b6:910:19::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.30; Tue, 30 Mar 2021 03:25:24 +0000 Received: from CY4PR1101MB2069.namprd11.prod.outlook.com ([fe80::54f9:e389:a014:91ca]) by CY4PR1101MB2069.namprd11.prod.outlook.com ([fe80::54f9:e389:a014:91ca%2]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 03:25:24 +0000 From: "Xu, Ting" To: "Guo, Jia" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet Thread-Index: AQHXILXMCSoEtQGAlkOWcAnDpiZ8Uqqb48Wg Date: Tue, 30 Mar 2021 03:25:24 +0000 Message-ID: References: <20210317034335.31974-1-jia.guo@intel.com> <20210324135407.60637-1-jia.guo@intel.com> <20210324135407.60637-4-jia.guo@intel.com> In-Reply-To: <20210324135407.60637-4-jia.guo@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.55] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3862bf18-f51e-4555-d3dd-08d8f32b7518 x-ms-traffictypediagnostic: CY4PR1101MB2247: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oxSEiOFV5MM4o0PqKdPc1XRwoZxL+dkmJYS+yYCDxu8xGayMKmY9dju4j++g8Dbw3k8vQcsgXvhxLIh48sO6WoaK7zuUYA5pa0ltlpg5UBWNzK+4wLjSjp1mevcTFyD0Gc2uyHSrVNBbS6OrPixO10q/tj1p7LpYwD7talJAZSBoX4gVCMWH06k0YHziI1C0M8GbTiU8TgLaw68uHyUqhTB9IJKegvTf7a9NQYuiM9i9fKxwIj15QJnzMH/oyYDn81kYo7TAU1YvT9rDGxs7GwZc/a5daGg2K39nmktoFraxSGwL0tjA8jlQ4jx8GibzTH38Yli6OsMMhhbEw3Nj/WLFnXo04SgOUgNJglSakCYNF8DQEHgKSU/iuX9JFNlv5uR+1xmy+GjjG5PollRERd+TrNVGbbN0v26tSz4qtzT1FsR2iEY/T+ZvgC4c9OlRUR3GawKly1Q5ViXyCgILK548UjVu8qDLX4Hx5/wDVBIaCgqHkd0S4i/uVr1vG9Vnf7SPtKiDNSzXhxzC65fnyaLofRfEVGgDj1TTjE08CWdrUsoEVPDpFdNvuPIkswntUIuatBqkfKQoPOaSqC5DVU7Mf9ZSAjPwOQARyb9O2R/pNyV/GMZaeA64Ikna42s3FiQ1K3AmXEeiZoXLaEvKKdGQfYDb+Jy3WKyo5sRypbY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2069.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(376002)(396003)(136003)(39860400002)(186003)(66476007)(55016002)(8676002)(9686003)(7696005)(86362001)(71200400001)(66556008)(64756008)(66446008)(76116006)(38100700001)(52536014)(53546011)(66946007)(8936002)(26005)(6636002)(6506007)(83380400001)(4326008)(110136005)(5660300002)(2906002)(478600001)(33656002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2nvErwruvhmwJ4TfEUPopZf9zfIOoP7X19YGMgOtHHQ6216tJsROkU5QwVcr?= =?us-ascii?Q?G36rIObj+7AVENgX0Y+lvByzgloy5eZAdT0+3p1ECiuC0bBSZ7z+GC3KYyYd?= =?us-ascii?Q?jmP0MW/WoEFLxDjiYZCCiL/e6OPRSdYSrDG5gxfJX0wDtqXBZ0qnjJLAXWLz?= =?us-ascii?Q?EyLoshgU9R6pbfEmb3+C2xtWEa5HVNXdG4F8/8CD7/IvNmsuMMePtF9xE2Aq?= =?us-ascii?Q?Ct6l3p6CAMCgApGaK9hGnhERfjGQw4L63eb3g+ZAEjR0AlqcxvFRwwnh8YXw?= =?us-ascii?Q?glxSGI8xCnbQ/i6Qr2ltkycPNVQQ/vRC4e3yjXy9JHILS8d0nC92FSz/0rpB?= =?us-ascii?Q?/mOQcXnhswVZ8ZCFG8zQ51jQto5RpqwFN2JOtfE8l2o5LXcNZyPjD9GpnKsS?= =?us-ascii?Q?ZgABorHvpR2Bo8PZJnyadU+HDBQdGSbvRkpdrVoIt2rfEHTpVbloZYLe1l4L?= =?us-ascii?Q?Gj9fZRZy3PDzv50I3O9q1agMboNrEcrFpArRnucKAgc4J+3sJHO0SqH+SURX?= =?us-ascii?Q?/es4+R9m0bcBJNNeD/uir/fgLniPcjvGHjdiHN6+ODMJ2e/jKr6+nyrCyapD?= =?us-ascii?Q?XwABfke29Hu6LZ1pwL3/5bvS7v0t44OOvJ4AUiNzcd4nXotENmKg8xfskpm/?= =?us-ascii?Q?pVAt+dR12JZ9ru2hDIsRnLuA3h7pIpFoKw4y7a+UzMndaEN3ZfN3VFjpjdBi?= =?us-ascii?Q?VKoWQXMwmkYwC4gKDN1JRoAk0dC+Jntg+KURgxAchgP/d1mZKHo5be8x8yP+?= =?us-ascii?Q?E/r+SRqu05SmjuW0b+TGwPEftkOdPtFiAL2ViFGP2It/9YShm/uozXSN8mRo?= =?us-ascii?Q?xcDF4FqURltMHzfcYpBXcGG5Watpdd1cWrxtwaG+6jCDkPWKligUOq//Puh0?= =?us-ascii?Q?er5RnLERZ2tI7y+smG0j4HObbtTjlPHvx8QJUyF5WJsUSrfrZjcytbvESMfw?= =?us-ascii?Q?tcjIE5zwQbgz07oaW2cFI5vipXfToO1uFHfZkxvpZ9hk9gl8jvOgKKuOjPsZ?= =?us-ascii?Q?dZBrGoVMrWBWkpXlWGecRE7V8Qqul+dOYs2FiVtMpzwJ//IWHXv7jOVdJWEX?= =?us-ascii?Q?gKf2j+Xu4beZMQBmtflzgUCRMPihJRfyihPgJucE21zp4yBuFRuwlD749NPW?= =?us-ascii?Q?y5ksWVr+Isfs/iXJNQJD3459ojtC3tbAJ1r2JQcN3Fw0+4w/6s87JvVDJReF?= =?us-ascii?Q?/O4HEWWFtMTvxm1pCUYS4zmfe223th2AcVpAK+OSPGTHpgD9llH9/1tbookU?= =?us-ascii?Q?AocBWgfvzygjDNgPTdFB8mdCwSeQgvt5eDYmk4FqF92tUwRZsCy0NbMOFLN1?= =?us-ascii?Q?5DtFeUl9K1SFjteZtwadhVa+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2069.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3862bf18-f51e-4555-d3dd-08d8f32b7518 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 03:25:24.1372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9p/18VYi+jD4aTxPdHqxigE9lidL3a8x5JYV6RnxxtsrFGzJEVtZVxmHH2RtRkd1hkNiXCifp5d3j9UXqaKtXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2247 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Jeff > -----Original Message----- > From: Guo, Jia > Sent: Wednesday, March 24, 2021 9:54 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: Xu, Ting ; dev@dpdk.org; Guo, Jia > Subject: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet >=20 > New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. >=20 > Signed-off-by: Jeff Guo > --- > drivers/net/ice/ice_fdir_filter.c | 96 +++++++++++++++++++++++++++---- > 1 file changed, 85 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index 3af5812660..3504d3c6c2 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -24,7 +24,7 @@ > #define ICE_FDIR_INSET_ETH_IPV4 (\ > ICE_FDIR_INSET_ETH | \ > ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | ICE_INSET_IPV4_TOS | \ > - ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_PROTO) > + ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_PROTO | ICE_INSET_IPV4_PKID) >=20 > #define ICE_FDIR_INSET_ETH_IPV4_UDP (\ > ICE_FDIR_INSET_ETH_IPV4 | \ > @@ -41,7 +41,8 @@ > #define ICE_FDIR_INSET_ETH_IPV6 (\ > ICE_INSET_DMAC | \ > ICE_INSET_IPV6_SRC | ICE_INSET_IPV6_DST | ICE_INSET_IPV6_TC | \ > - ICE_INSET_IPV6_HOP_LIMIT | ICE_INSET_IPV6_NEXT_HDR) > + ICE_INSET_IPV6_HOP_LIMIT | ICE_INSET_IPV6_NEXT_HDR | \ > + ICE_INSET_IPV6_PKID) >=20 > #define ICE_FDIR_INSET_ETH_IPV6_UDP (\ > ICE_FDIR_INSET_ETH_IPV6 | \ > @@ -56,7 +57,8 @@ > ICE_INSET_SCTP_SRC_PORT | ICE_INSET_SCTP_DST_PORT) >=20 > #define ICE_FDIR_INSET_IPV4 (\ > - ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST) > + ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | \ > + ICE_INSET_IPV4_PKID) >=20 > #define ICE_FDIR_INSET_IPV4_TCP (\ > ICE_FDIR_INSET_IPV4 | \ > @@ -72,7 +74,8 @@ >=20 > #define ICE_FDIR_INSET_ETH_IPV4_VXLAN (\ > ICE_FDIR_INSET_ETH | \ > - ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST) > + ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | \ > + ICE_INSET_IPV4_PKID) >=20 > #define ICE_FDIR_INSET_IPV4_GTPU (\ > ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | ICE_INSET_GTPU_TEID) > @@ -95,6 +98,7 @@ static struct ice_pattern_match_item > ice_fdir_pattern_list[] =3D { > {pattern_eth_ipv4_tcp, > ICE_FDIR_INSET_ETH_IPV4_TCP, ICE_INSET_NONE, > ICE_INSET_NONE}, > {pattern_eth_ipv4_sctp, > ICE_FDIR_INSET_ETH_IPV4_SCTP, ICE_INSET_NONE, > ICE_INSET_NONE}, > {pattern_eth_ipv6, > ICE_FDIR_INSET_ETH_IPV6, ICE_INSET_NONE, > ICE_INSET_NONE}, > + {pattern_eth_ipv6_frag_ext, > ICE_FDIR_INSET_ETH_IPV6, ICE_INSET_NONE, > ICE_INSET_NONE}, > {pattern_eth_ipv6_udp, > ICE_FDIR_INSET_ETH_IPV6_UDP, ICE_INSET_NONE, > ICE_INSET_NONE}, > {pattern_eth_ipv6_tcp, > ICE_FDIR_INSET_ETH_IPV6_TCP, ICE_INSET_NONE, > ICE_INSET_NONE}, > {pattern_eth_ipv6_sctp, > ICE_FDIR_INSET_ETH_IPV6_SCTP, ICE_INSET_NONE, > ICE_INSET_NONE}, > @@ -882,11 +886,13 @@ ice_fdir_input_set_parse(uint64_t inset, enum > ice_flow_field *field) > {ICE_INSET_IPV4_TOS, ICE_FLOW_FIELD_IDX_IPV4_DSCP}, > {ICE_INSET_IPV4_TTL, ICE_FLOW_FIELD_IDX_IPV4_TTL}, > {ICE_INSET_IPV4_PROTO, ICE_FLOW_FIELD_IDX_IPV4_PROT}, > + {ICE_INSET_IPV4_PKID, ICE_FLOW_FIELD_IDX_IPV4_ID}, > {ICE_INSET_IPV6_SRC, ICE_FLOW_FIELD_IDX_IPV6_SA}, > {ICE_INSET_IPV6_DST, ICE_FLOW_FIELD_IDX_IPV6_DA}, > {ICE_INSET_IPV6_TC, ICE_FLOW_FIELD_IDX_IPV6_DSCP}, > {ICE_INSET_IPV6_NEXT_HDR, > ICE_FLOW_FIELD_IDX_IPV6_PROT}, > {ICE_INSET_IPV6_HOP_LIMIT, ICE_FLOW_FIELD_IDX_IPV6_TTL}, > + {ICE_INSET_IPV6_PKID, ICE_FLOW_FIELD_IDX_IPV6_ID}, > {ICE_INSET_TCP_SRC_PORT, > ICE_FLOW_FIELD_IDX_TCP_SRC_PORT}, > {ICE_INSET_TCP_DST_PORT, > ICE_FLOW_FIELD_IDX_TCP_DST_PORT}, > {ICE_INSET_UDP_SRC_PORT, > ICE_FLOW_FIELD_IDX_UDP_SRC_PORT}, @@ -935,6 +941,10 @@ > ice_fdir_input_set_hdrs(enum ice_fltr_ptype flow, struct ice_flow_seg_inf= o > *seg) > ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 | > ICE_FLOW_SEG_HDR_IPV_OTHER); > break; > + case ICE_FLTR_PTYPE_FRAG_IPV4: > + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 | > + ICE_FLOW_SEG_HDR_IPV_FRAG); > + break; > case ICE_FLTR_PTYPE_NONF_IPV6_UDP: > ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP | > ICE_FLOW_SEG_HDR_IPV6 | > @@ -951,6 +961,10 @@ ice_fdir_input_set_hdrs(enum ice_fltr_ptype flow, > struct ice_flow_seg_info *seg) > ICE_FLOW_SEG_HDR_IPV_OTHER); > break; > case ICE_FLTR_PTYPE_NONF_IPV6_OTHER: > + ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 | > + ICE_FLOW_SEG_HDR_IPV_FRAG); > + break; > + case ICE_FLTR_PTYPE_FRAG_IPV6: Are the frag and non-frag cases inverted? > ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 | > ICE_FLOW_SEG_HDR_IPV_OTHER); > break; > @@ -1592,8 +1606,10 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > enum rte_flow_item_type l3 =3D RTE_FLOW_ITEM_TYPE_END; > enum ice_fdir_tunnel_type tunnel_type =3D > ICE_FDIR_TUNNEL_TYPE_NONE; > const struct rte_flow_item_eth *eth_spec, *eth_mask; > - const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_mask; > + const struct rte_flow_item_ipv4 *ipv4_spec, *ipv4_last, *ipv4_mask; > const struct rte_flow_item_ipv6 *ipv6_spec, *ipv6_mask; > + const struct rte_flow_item_ipv6_frag_ext *ipv6_frag_spec, > + *ipv6_frag_last, *ipv6_frag_mask; > const struct rte_flow_item_tcp *tcp_spec, *tcp_mask; > const struct rte_flow_item_udp *udp_spec, *udp_mask; > const struct rte_flow_item_sctp *sctp_spec, *sctp_mask; @@ -1615,6 > +1631,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, > struct ice_fdir_extra *p_ext_data; > struct ice_fdir_v4 *p_v4 =3D NULL; > struct ice_fdir_v6 *p_v6 =3D NULL; > + bool spec_all_pid =3D false; >=20 > for (item =3D pattern; item->type !=3D RTE_FLOW_ITEM_TYPE_END; item++) > { > if (item->type =3D=3D RTE_FLOW_ITEM_TYPE_VXLAN) @@ -1632,13 > +1649,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, > * flow. input_set_i is used for inner part. > */ > for (item =3D pattern; item->type !=3D RTE_FLOW_ITEM_TYPE_END; item++) > { > - if (item->last) { > + if (item->last && (item_type !=3D RTE_FLOW_ITEM_TYPE_IPV4 || > + item_type !=3D > + RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT)) { > rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ITEM, > - item, > + RTE_FLOW_ERROR_TYPE_ITEM, item, > "Not support range"); > - return -rte_errno; > } > + > item_type =3D item->type; >=20 > input_set =3D (tunnel_type && !is_outer) ? > @@ -1689,6 +1707,7 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > flow_type =3D ICE_FLTR_PTYPE_NONF_IPV4_OTHER; > l3 =3D RTE_FLOW_ITEM_TYPE_IPV4; > ipv4_spec =3D item->spec; > + ipv4_last =3D item->last; > ipv4_mask =3D item->mask; > p_v4 =3D (tunnel_type && is_outer) ? > &filter->input.ip_outer.v4 : > @@ -1700,8 +1719,6 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > /* Check IPv4 mask and update input set */ > if (ipv4_mask->hdr.version_ihl || > ipv4_mask->hdr.total_length || > - ipv4_mask->hdr.packet_id || > - ipv4_mask->hdr.fragment_offset || > ipv4_mask->hdr.hdr_checksum) { > rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > @@ -1710,6 +1727,20 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > return -rte_errno; > } >=20 > + if (ipv4_last->hdr.version_ihl || > + ipv4_last->hdr.type_of_service || > + ipv4_last->hdr.time_to_live || > + ipv4_last->hdr.total_length | > + ipv4_last->hdr.next_proto_id || > + ipv4_last->hdr.hdr_checksum || > + ipv4_last->hdr.src_addr || > + ipv4_last->hdr.dst_addr) { > + rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ITEM, > + item, "Invalid IPv4 last."); > + return -rte_errno; > + } > + > if (ipv4_mask->hdr.dst_addr =3D=3D UINT32_MAX) > *input_set |=3D ICE_INSET_IPV4_DST; > if (ipv4_mask->hdr.src_addr =3D=3D UINT32_MAX) @@ - > 1726,6 +1757,24 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter > *ad, > p_v4->ttl =3D ipv4_spec->hdr.time_to_live; > p_v4->proto =3D ipv4_spec->hdr.next_proto_id; > p_v4->tos =3D ipv4_spec->hdr.type_of_service; > + > + if (ipv4_mask->hdr.packet_id =3D=3D UINT16_MAX) { > + if (ipv4_last && > + ipv4_spec->hdr.packet_id =3D=3D 0 && > + ipv4_last->hdr.packet_id =3D=3D 0xffff) > + spec_all_pid =3D true; > + > + /* All IPv4 fragment packet has the same > + * ethertype, if the spec is for all invalid > + * packet id, set ethertype into input set. > + */ > + *input_set |=3D spec_all_pid ? > + ICE_INSET_ETHERTYPE : > + ICE_INSET_IPV4_PKID; > + } > + > + if (ipv4_mask->hdr.fragment_offset =3D=3D UINT16_MAX) > + flow_type =3D ICE_FLTR_PTYPE_FRAG_IPV4; > break; > case RTE_FLOW_ITEM_TYPE_IPV6: > flow_type =3D ICE_FLTR_PTYPE_NONF_IPV6_OTHER; @@ > -1771,6 +1820,31 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > p_v6->proto =3D ipv6_spec->hdr.proto; > p_v6->hlim =3D ipv6_spec->hdr.hop_limits; > break; > + case RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT: > + l3 =3D RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT; > + flow_type =3D ICE_FLTR_PTYPE_FRAG_IPV6; > + ipv6_frag_spec =3D item->spec; > + ipv6_frag_last =3D item->last; > + ipv6_frag_mask =3D item->mask; > + > + if (!(ipv6_frag_spec && ipv6_frag_mask)) > + break; > + > + if (ipv6_frag_last && > + ipv6_frag_spec->hdr.id =3D=3D 0 && > + ipv6_frag_last->hdr.id =3D=3D > + 0xffffffff) > + spec_all_pid =3D true; > + > + /* All IPv6 fragment packet has the same ethertype, if > + * the spec is for all invalid packet id, set ethertype > + * into input set. > + */ > + *input_set |=3D spec_all_pid ? > + ICE_INSET_ETHERTYPE : > + ICE_INSET_IPV6_PKID; > + break; > + > case RTE_FLOW_ITEM_TYPE_TCP: > if (l3 =3D=3D RTE_FLOW_ITEM_TYPE_IPV4) > flow_type =3D ICE_FLTR_PTYPE_NONF_IPV4_TCP; > -- > 2.20.1