From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACE3EA053A; Mon, 3 Aug 2020 18:45:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7EE52BD8; Mon, 3 Aug 2020 18:45:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 396422952 for ; Mon, 3 Aug 2020 18:45:57 +0200 (CEST) IronPort-SDR: LPzh1LGar34Dj8JsshiAuyqxg4jSBkXl9RtvWLhS45qq99jsyM1hwpvkS5kbmvkxq71UHNXVno 074kBQzqQgQg== X-IronPort-AV: E=McAfee;i="6000,8403,9702"; a="237008814" X-IronPort-AV: E=Sophos;i="5.75,430,1589266800"; d="scan'208";a="237008814" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2020 09:45:55 -0700 IronPort-SDR: Jvhw+gRfr0VYAkZNjHGwbt3Akp8PUq64fT4z5wyhrBODgETdEU+PYSLU+5uNPwM194ctSE7CAM OkvTdTEnPq/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,430,1589266800"; d="scan'208";a="288099161" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga003.jf.intel.com with ESMTP; 03 Aug 2020 09:45:55 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Aug 2020 09:45:55 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 3 Aug 2020 09:45:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Aug 2020 09:45:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPH3G2vgwf7GVcdhHEVyXFkj236WQ9FU69wpqS5vj9kceTZ8QEyFJl8qGZ6tdjk3yZB6hDzN+qnASaI+udkbAOXpM58uAJaBOD4OOPpozJA9WmWAFjy9dvlEeDFp7ar5uG2n5KEwWTLdZvO1kvB8qCxbn3GDj2rno9tQlkyFUAQzjwxFKOhQBzsK7KhfDZbCeXKWnUbFH5FsY4uchOtPLgLvIP3T1JIDwq/KjkgGyIl0u7Zy9fnL8nShevgR1gWTeZ74bRpMSKWZ6qEgdmDDF3X8vM86ClbRNtAv7aseKIdRyvDyN/UZtskac/VX0bH5vZw2v1VXyZTxH/vvjpmqZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMLd1J6VR1U/0xBfAZXFxQFBg6AviBeKzsNMko2gxos=; b=K/BM24F6YMd+om1W5/OmVK4HWjv4i3KhzUU5g1iehIbCHNmPL3M7SViPVZGKM9TXl637Pnb7unnQWspqx9gBBSRV7F/EuTNqVUqVc8cWSUB2JVHEJgx7zWHRnQApEiPAOLyxD4D7IOx0tDEuxaTRZ6IO3DubWNLCK8dMMHMfdBwBXltDixN4RmwTPDDcpzAVRfsoyqwQeIHBKlrjMT6LWCe3thguDPKSbNnnBsVmpxBdB5fagd5jWeZBRwpBJTaE9UhM3EcUuR3OAxfGPj3vNJ80gtAd9j73cJ3cJnxjzXSLNm51ZDIqx5e+mGJaP1g40HoiiOJR9Pm2gyEMveke5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OMLd1J6VR1U/0xBfAZXFxQFBg6AviBeKzsNMko2gxos=; b=y00IB4AlZAoeJRakvL7apvaTIN7Gy8iT6aRP9+9wjHIIS+MknoPQcRICcH7bK3FqI6uU7b1FwkCXvyaUFehIDqnX4glSaKEqrmFEiHBaNmFraJBAGz3BU3BFclBoijihY6tDSTZ9ntrch2lbNRn3jLDVaZIYr7ZIAc23RivEhBI= Received: from CY4PR1101MB2118.namprd11.prod.outlook.com (2603:10b6:910:1f::10) by CY4PR11MB0007.namprd11.prod.outlook.com (2603:10b6:910:79::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Mon, 3 Aug 2020 16:45:52 +0000 Received: from CY4PR1101MB2118.namprd11.prod.outlook.com ([fe80::94c8:157:491:71be]) by CY4PR1101MB2118.namprd11.prod.outlook.com ([fe80::94c8:157:491:71be%7]) with mapi id 15.20.3239.021; Mon, 3 Aug 2020 16:45:52 +0000 From: "Carrillo, Erik G" To: Sarosh Arif , "rsanford@akamai.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] doc: announce API change in timer Thread-Index: AQHWaYhb6deoeK+O+UueFUhH+TIFEakmlwng Date: Mon, 3 Aug 2020 16:45:52 +0000 Message-ID: References: <20200803112059.23328-1-sarosh.arif@emumba.com> In-Reply-To: <20200803112059.23328-1-sarosh.arif@emumba.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: emumba.com; dkim=none (message not signed) header.d=none;emumba.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [136.49.135.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e1b573d-b00b-407f-34cb-08d837ccaf25 x-ms-traffictypediagnostic: CY4PR11MB0007: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r8Th/HnqS8JbQ1JqUu0UkwgOSOATclBZ5d5wfN/Gc6sF6/I2ipoU4h71P0F5ZDbwMDImVQZwW/FQWK1hHsvFsi/1py04o9/vp+O0Vg1JroUVdaxYlqbfQviQh1iMV2dBewJ2s0PyqkO2HGMQqx2w9Y+wAckO3WSd4JuzARFhG8SUObLJGIwcS4Ko0OgIRGSHLM314wnaWu2DD0Y2UxtisLR89dz6/3o0y747/Yu7mcGW4ywE66RPRwRoWm313yaQAkx3BiEzr/Kf490JzifUJxoRdKLrcr4l0DWM0R42nszKBykqKoO3pXgX2XCYf9vQrSmH/eAST8uIsnsR1sFcWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2118.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(33656002)(5660300002)(83380400001)(478600001)(26005)(52536014)(9686003)(86362001)(66446008)(71200400001)(64756008)(55016002)(2906002)(4326008)(186003)(66556008)(66946007)(66476007)(6506007)(110136005)(53546011)(7696005)(76116006)(8936002)(8676002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: s6YmSYIarGq3faWQCxoGEW6z8cPbVFG/CJVZpQmOVAyS9hs2M0r1685TDHkaANTROvrvj9LzwgAoX93TRUC/06Nij3mOwGK/8rSuo+MzKCH0kLhXeTbxiNL41ecjD7ZQ0oVL1/by7HdMOl1HOcsC9+XCK0vQe1m0F0TZaiaLdVVW48LEbwjU9Tmh5YvHOz9+S3jWwq4R6Db1azg/Mhk0CMmnwppm6EPM250dpbe48romJikfBI39GRAt3SxrcPc89zpQGHp95opwcddbTsb1jIkvntb0J0eS5NjJtkqu4dJ6c0kagsmucXej8OJf6DbBsDNBJ7G76JOQplhquc2NOl/bKFQVj8U//AIfAe23KZY639LeoHPCi+8RVRDfRrH6QxcxcwDuhr2aONFhYnPqb9lBS1cYkfyFHwbOM9unjWZmNUE75iC966D/zRBWOjxqKecHi4BHMwFgB8vyaOaQP7Brnuk1X1Yq4J0nMGt+1yXiQbQf3417/hr2y6W1ja+7uPsLH8mDZDLUIEfBNVRh8X1kJxjCezJh8cq9M4GUNFbW02uuAh399Wppkdb0bsH7kKHOubD6uW5mEW1d9kJgaJ4d6wu6fCQ0tan0HxrBNbikFXzAuDo5+aMF42kzPg7iupDzHXHk7qdJ+yyW44EMtQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2118.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1b573d-b00b-407f-34cb-08d837ccaf25 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2020 16:45:52.3472 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xSldHSAWa6mgfEG5N/DmTj3REz+rX1s8vOtng6b2Dqjuq29AacA6+nBoAeb3gMLWyUheJaJ4CrV7lBTX8KwXYXbGfNA1DX+XH0E9hBgKJM4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0007 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in timer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sarosh Arif > Sent: Monday, August 3, 2020 6:21 AM > To: Carrillo, Erik G ; rsanford@akamai.com > Cc: dev@dpdk.org; Sarosh Arif > Subject: [PATCH] doc: announce API change in timer >=20 > If the user tries to reset/stop some other timer in it's callback functio= n, which > is also about to expire, using rte_timer_reset_sync/rte_timer_stop_sync t= he > application goes into an infinite loop. This happens because > rte_timer_reset_sync/rte_timer_stop_sync loop until the timer resets/stop= s > and there is check inside timer_set_config_state which prevents a running > timer from being reset/stopped by not it's own timer_cb. Therefore > timer_set_config_state returns -1 due to which rte_timer_reset returns -1 > and rte_timer_reset_sync goes into an infinite loop >=20 > To to prevent this rte_timer_reset_sync and rte_timer_stop_sync should > have int return types, so that -1 can be returned if the above condition > occurs >=20 > Signed-off-by: Sarosh Arif > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index ea4cfa7a4..ed93a707d 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -151,3 +151,9 @@ Deprecation Notices > Python 2 support will be completely removed in 20.11. > In 20.08, explicit deprecation warnings will be displayed when running > scripts with Python 2. > + > +* timer: Since timer can get stuck in an infinite loop if the > +application tries to > + reset/stop some other timer in it's callback function, which is also > +about to > + expire. The function ``rte_timer_stop_sync`` and It looks like this should be rte_timer_reset_sync. Maybe something like: timer: Timers can get stuck in an infinite loop if their callback tries to= synchronously reset/stop some other timer that is also about to expire. T= he functions ``rte_timer_reset_sync`` and ``rte_timer_stop_sync`` will upda= ted with an int return type so that an error code can be returned when this= condition occurs. Thanks, Erik > +``rte_timer_stop_sync`` will > + have a int return type in order to return with -1 in when this > +condition > + occures. > -- > 2.17.1