From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87D0AA04BA; Wed, 7 Oct 2020 12:13:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67B261E34; Wed, 7 Oct 2020 12:13:47 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 701AAA3; Wed, 7 Oct 2020 12:13:44 +0200 (CEST) IronPort-SDR: 4Txx9LInww8Kkf4UudF5JCW4Dm1+ennSYgXR/HyWSMOVQlxUSN7S4Zk0DXk27a8bVZGto7GvhQ UyFLvHkv8wSw== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="162267159" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="162267159" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 03:13:41 -0700 IronPort-SDR: hCGy3ExmXMAVDsZnhzR9cKNQcb1U0THnO2PRgx3wV20mbVrvWZ0ZH1WjRuABDi/Xx0RC+yn++J KBh5HP9Ic0Gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="527882390" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 07 Oct 2020 03:13:40 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 03:13:40 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 03:13:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 7 Oct 2020 03:13:40 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 7 Oct 2020 03:13:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EOgztzM/0VNzmeiY4AK6VG6yxVl6K8n83Fr2Z5obrlVqh1W8GXwBexrO1cgu9Ws7q+GC5A1ugIPYnnnyTgAGZbjXBecxLHjQJcRvN7Db4m8mWTudjgTlaBE//WI01J08A9gTMUUxUa+S8RRDgndCkes4XPx9Eld7VqMi7nlyxOv+57np+qTslqTyfjgt837+btJIe5i/6QbvGzUeK9kh4t4unZiUB0ItY7ZbVtKCmFJJSu4AHCAFbkiG62b9rDLYFp7h9m9BF3y60SVdF/0Nh3p18/jskyNPyI+VUpXQkR4/dNmQDo/pDemLJuA/h3B8/1yYhT6YTw1BC0rFYqzwMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PQK898Pl35JIUxlzyf7MC9TphrlOLwtKaowb82xCsgU=; b=nd5x2EfAhgKhqwLJT4CSplJRihkj4chZbCOhXKAEapRarYsC4kY9W9pOaDcDPkbXTi5tFyI0iI3gW6JMZQv6z/tu7hXqxEkcd6YWIgX8rxmpoP5tk6LlCYzHQ7fVVQGH3v4QI3p/LR9i1yKL1/2/CNRsh7RId8y8nENx2O/QAKPv9Si4qJcgKRa6EIsAJOIv9JJalYsM5Q9lCw7x9Q+pvKwa82kqt8ClmRKugT2w5V5jXKhiwEzX1tHQaCndPZI6NE6wA6Ey8QoP6jwtqVAMXPDXG4u9KAeHH4x3ZtWyolMVecx/mGXjUYgvfolhzt+8Jn5Kg1JWzRkXZZX+NXbGgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PQK898Pl35JIUxlzyf7MC9TphrlOLwtKaowb82xCsgU=; b=LIKWZgU2+NlZ/3KPoSVfCMPNFjHGAcunnqIfJGQazUYlTLQV4LwGkuOmq1Bu6857izEpyz2hEa6L4ZqIHPTPmedCnuFOAuhsXtdV2LRmc/H/ecjMW9ZVpns99/yOciefSL91Jhqx2a9v++aDDOJ9OHj5wMjRe2KInKDI+lzTJD0= Received: from CY4PR1101MB2296.namprd11.prod.outlook.com (2603:10b6:910:1a::15) by CY4PR11MB0070.namprd11.prod.outlook.com (2603:10b6:910:78::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Wed, 7 Oct 2020 10:13:38 +0000 Received: from CY4PR1101MB2296.namprd11.prod.outlook.com ([fe80::80c9:e4f1:ec68:6e64]) by CY4PR1101MB2296.namprd11.prod.outlook.com ([fe80::80c9:e4f1:ec68:6e64%5]) with mapi id 15.20.3455.023; Wed, 7 Oct 2020 10:13:38 +0000 From: "Rao, Nikhil" To: "Jayatheerthan, Jay" , "jerinj@marvell.com" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Jayatheerthan, Jay" Thread-Topic: [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest Thread-Index: AQHWmWVOqvv26u04CkCHmehcoXH/KqmL8d2g Date: Wed, 7 Oct 2020 10:13:38 +0000 Message-ID: References: <20201003090541.32449-1-jay.jayatheerthan@intel.com> In-Reply-To: <20201003090541.32449-1-jay.jayatheerthan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [106.201.40.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 33c916e1-42ca-491d-817f-08d86aa9a8ae x-ms-traffictypediagnostic: CY4PR11MB0070: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:324; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qpt3bDpkliJBeoD8gpdXysl62TCn4urkYNTMgiiJqszhOp2GN2l8RZP0UbY2mdIJu5ttlKZqTYj/b3P3L4j6fzBuNrKHiP3CU1KEbiT6V+I/G7gncaB3Uj7uM3JZO2c4/uttU4Pu8RMUOjLqBRHUiieRqxs1gJQ0laFJwywGoVIYrWYRhhIIabkyU+skSqb2yvPVWwJqImIgxFuTl4TotUdl9V4hwiohOrGcNqC94gP5Y2LN90xDT4n+fV6YohN2f0/gq+P+5vYkY0rDoc2qsIAXDkPmljaVOygwKgiATHYyVB2sDXa7AUt1Nc/jG7hPHY2kHHjwAlBO+ufwHDBoTg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2296.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(2906002)(8676002)(8936002)(33656002)(83380400001)(55016002)(66446008)(64756008)(76116006)(7696005)(66946007)(316002)(66476007)(4326008)(66556008)(186003)(107886003)(9686003)(26005)(52536014)(55236004)(5660300002)(71200400001)(53546011)(6506007)(54906003)(86362001)(110136005)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: SPEdzbvkY7HVeI+Sk8MNE7cWLtV4bxuydr4EZj/NwuJB2vhYM2+kJRLQ7ezPv3APp8mXPS95Bn6jDvGH9pdGlVFlhCcQMsy3TQnlPSW8XKglzUJYiHpKwYiQ0B3p+u1JxcxjODA0NDrKdK2MI53WzNzcF/+dNBzIaeUn3gNk3D/uGmw6xKm3ujQby4h6/jZ8pYd70bnYlhcYcfGWXQlSVM7xY3vSUcldRKPjwhkLjP488PeijQORZOXOtmmcP5PhxChfivZPdhqcZhL3FPdGXzJE0Q7ZXx2AoBVPjoNzwcdgdQ5HAwFKIMHnEAP/iMf1gLu9DGz98mk8VMRviFWhpRN4G09XxcPXbzI5dlv94t1f1F8zuvG65QehlQC6g5SmNzeynELaQ0E552K8XsgfE33gcdYFwd7bdw325Y8ftV0P8Lc6KT/RdS6hWxQZjLGsL6gE8HDPHzXnhjCOgXWpXuh19PhuYA9dfPvRsouetZ8/4isxQHdMKp+Wjycy3qG7DfbYMjcf1vd4H9CF/8koYMik7gk8NvID1/MdHeiM8yz2oYiqlv2jjeeoDoQhnFUSIiXV/jmaAeDsxEEK6fa4OZ475HP+QhFQgxsPajtW1pPuLKbR1yIjrz38mDJ8/mWd0qOGeqpM2R7ZayDkp5V7pw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2296.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33c916e1-42ca-491d-817f-08d86aa9a8ae X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 10:13:38.3241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uqzKNHbCrPEhbfY8zWQoKNNhJzfp5dTVMWKuEIAartiTGaGGGOhgOdvmRYYw7oBNswrbB1q/GwByuQeagVWezg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0070 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jayatheerthan, Jay > Sent: Saturday, October 3, 2020 2:36 PM > To: jerinj@marvell.com; thomas@monjalon.net; Rao, Nikhil > > Cc: dev@dpdk.org; stable@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autot= est >=20 > From: "Jay Jayatheerthan" >=20 > adapter_multi_eth_add_del() does vdev init but doesn't uninit them. > This causes issues when running event_eth_rx_adapter_autotest multiple > times. >=20 > The fix does vdev uninit before exiting the test. >=20 > Signed-off-by: Jay Jayatheerthan > --- > app/test/test_event_eth_rx_adapter.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_event_eth_rx_adapter.c > b/app/test/test_event_eth_rx_adapter.c > index dd3bce71b..71c946164 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -464,7 +464,7 @@ adapter_multi_eth_add_del(void) > int err; > struct rte_event ev; >=20 > - uint16_t port_index, drv_id =3D 0; > + uint16_t port_index, port_index_base, drv_id =3D 0; > char driver_name[50]; >=20 > struct rte_event_eth_rx_adapter_queue_conf queue_config; @@ - > 484,6 +484,7 @@ adapter_multi_eth_add_del(void) >=20 > /* add the max port for rx_adapter */ > port_index =3D rte_eth_dev_count_total(); > + port_index_base =3D port_index; > for (; port_index < RTE_MAX_ETHPORTS; port_index +=3D 1) { > snprintf(driver_name, sizeof(driver_name), "%s%u", > "net_null", > drv_id); > @@ -513,6 +514,17 @@ adapter_multi_eth_add_del(void) > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > } >=20 > + /* delete vdev ports */ > + for (drv_id =3D 0, port_index =3D port_index_base; > + port_index < RTE_MAX_ETHPORTS; > + drv_id +=3D 1, port_index +=3D 1) { > + snprintf(driver_name, sizeof(driver_name), "%s%u", > "net_null", > + drv_id); > + err =3D rte_vdev_uninit(driver_name); > + TEST_ASSERT(err =3D=3D 0, "Failed driver %s got %d", > + driver_name, err); > + } > + > return TEST_SUCCESS; > } >=20 > -- > 2.17.1 Reviewed-by: Nikhil Rao