From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09BF1A0526; Wed, 22 Jul 2020 10:30:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE8BF1BFD1; Wed, 22 Jul 2020 10:30:47 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8B82B2B86; Wed, 22 Jul 2020 10:30:45 +0200 (CEST) IronPort-SDR: oTFxI8yEayfk5ZZlZYBh3DC4QZLOt/Yu9AG2OJQOrpD79HH2aqb2jjF8fFpFLpAZG/cbBm8WAk /C7H49WqVdlg== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="151616755" X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="151616755" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 01:30:43 -0700 IronPort-SDR: bVOYb/Jcp7Z/TZ6vIVJZn9/PgA3e0PFUousioWXC3fqFpWHpH1Ez9myjp/T6BuQHaHCspqykfb nnedChSCAc6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="320201119" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 22 Jul 2020 01:30:43 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 01:30:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 01:30:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JMpeVCcEt2WP4zKUhgWlyhhALSH59X6Eczljlj3CFKaQpzzVJAByVs8VS7KgTS1nY3CnvHfWHOi/nV5B6qn7fBpYa8UrmcGPA4kZay7pFiz2vHo78e5atWTBEmNVu9TvVY2GwhVc55ofBnTskvgtJxLWT34fCQTLK4dAgPB/tMuJkguaIVKzhBneDFM6u+1mooEC3yepBMtkYK365qNKbdANtFnls1lXYKnQN/UaZ32gCtBgO+wcONz8z3jdppdtLSO5SdfdKF8q1madYHBvOoJtOoqxg9kYBruNwdnkpa9fBB/tOiZQZK3cXBvchKgMZZQSxOmmrx/fSdFFoLDixA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UVMyUKpnmArsa9f/M3btqXBq+LFPh1WcamS+HPpW2ak=; b=VE5Q4AKw5aPXPAh7fHQ5QDagPzrDNPDBqPBOYi7gGbe9SJijBD1xnOFTEhQwGvSVnoKQU7iLqTBHkwcwiZNPboQmOjWeVy031qX6tBBZF7JKZMFpZgy1Z/yYH5CAvBR6jo5gl+X+WqvCyhYLTubEhEpgFrRdLXAHWJjg5oIJSCBYSXp2PGqhS6vLD0jyS6umTyINy2oTtr0YaZAlBepXZuq/g8uDkmR5n8M2I9iBbtFcdbDQBYer5T/Cd9w5TtlJZrElUmtgkL0HOjLMqiPS4EeD2d6vSVP+syDMO4e7wf3uHwK7GblbapgxShkqMSPTGtjxY4403qoEIW38c3Vn+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UVMyUKpnmArsa9f/M3btqXBq+LFPh1WcamS+HPpW2ak=; b=krIqSYZZ0H7b4RuRBu1W54QyhkPZ1U46RbZyYRCYf4a3PrW7rCr5EE+/S/DYBvj0/9VTUR//Wz0rpeQ3UQ97FgzMHUu4Jo/Nu8N2M79MzPS+dWfSG3FEeOqXTbtk/pYySGaus9EKeLi698gs9kvn0iHe9WYIuDqN/TBhzLAFYCk= Received: from CY4PR1101MB2310.namprd11.prod.outlook.com (2603:10b6:910:1b::16) by CY4PR11MB2023.namprd11.prod.outlook.com (2603:10b6:903:30::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Wed, 22 Jul 2020 08:30:41 +0000 Received: from CY4PR1101MB2310.namprd11.prod.outlook.com ([fe80::2497:a5ff:5152:7782]) by CY4PR1101MB2310.namprd11.prod.outlook.com ([fe80::2497:a5ff:5152:7782%10]) with mapi id 15.20.3216.021; Wed, 22 Jul 2020 08:30:41 +0000 From: "Xu, Ting" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4] lib/table: fix cache alignment issue Thread-Index: AQHWX82iNlqzroybpk6bRvdW1k5beqkTRBMAgAAAweA= Date: Wed, 22 Jul 2020 08:30:41 +0000 Message-ID: References: <20200616162705.83575-1-ting.xu@intel.com> <20200722021628.17194-1-ting.xu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1aa4c6e6-df7b-42ee-5f74-08d82e198536 x-ms-traffictypediagnostic: CY4PR11MB2023: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /7O5zfFHGKUWYheSgYbPxtFC4uzLNMyqRw5HW1KgWFQC4ayG8c1sPP0mLwssjJeL3mmmNILdMlpXXplaj62qTNh7xM7KVyWKa+AJFIIhGKnDsTdPqacCTF/G3GtTz6+UJRcwaBzcZaZjsISJRIa1y+oneRTqkkcYLPK36PMSE4zVN8weK2NXW+aKpu+bMbuLZLIG/ZC4SK/jGpFI4v6qmhe0cImYWKBJx/Wrq+j/1S66Wsl9flS0KUz42PG3J3jvdw7zsbyxwQYCDztlFq46Lhl2/2AlpXdsmog3LnKx7JwC7dJ26+yGIwvUnmMuZ7hr x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2310.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(71200400001)(52536014)(8936002)(9686003)(5660300002)(478600001)(66946007)(66556008)(64756008)(2906002)(66446008)(110136005)(186003)(66476007)(55016002)(76116006)(83380400001)(33656002)(86362001)(316002)(26005)(53546011)(6506007)(450100002)(4326008)(7696005)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 0JihdrBcOu6t4PHjdWwC1VGGCnWnh6/tFfKhorHNLNvrzRonVCpgGH9t1IMzYenlqxAxRL2mxmd2SRnglQ95tZWffBtNlYphQ+hVr7ie0yzzkB8/DzBstTmNGX7ReguBMGydnTkgBxreJLsMJMCGyBZclcYa3eMocNRDwc2KFRWgaC6eGmCqJrXvRb4KSWePM6kGW52CBwgC6wwnrneQlEYpRhgR/Ty+TlgMZZFyFvRkBI4nPYt5t/M1jh6yqyKnyHHffCABNpSU1YjWkBZMV3CAww3wZk2bucItGqxNhSMt2p8xCfhOkkIGlCF9zNOIHDItyEaryDhKSfSOvoGf+GmhaVIG2DkTk9IDxEokfgYquKrBWZb4Ws/G8whTyI4A1GJI4YBo1tNNJkLQY8TyGVEB9MS0h/K1j1gMAhhvLSNkEQsKIPBa8+Nbw41dNSi/FUtBcw1IHlTISIE94WV4Bt1X1q3VTamvXYfUixOSVyxiKZaem/GSrTprzr+6Wefp Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2310.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aa4c6e6-df7b-42ee-5f74-08d82e198536 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 08:30:41.5658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bj1TErEfPwlOthzmH46iB4rp8JExeMYlF64kncw+Bnrmr3Ez93PRf6QGQ7kVog8UbeG+JfX8U+EzCEvEQZFGzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2023 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: Hi, Cristian, > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Wednesday, July 22, 2020 4:27 PM > To: Xu, Ting ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v4] lib/table: fix cache alignment issue >=20 >=20 >=20 > > +#ifdef RTE_ARCH_64 > > struct rte_bucket_4_32 { > > /* Cache line 0 */ > > uint64_t signature[4 + 1]; > > @@ -46,6 +47,22 @@ struct rte_bucket_4_32 { > > /* Cache line 3 */ > > uint8_t data[0]; > > }; > > +#else > > +struct rte_bucket_4_32 { > > + /* Cache line 0 */ > > + uint64_t signature[4 + 1]; > > + uint64_t lru_list; > > + struct rte_bucket_4_32 *next; > > + uint32_t pad; > > + uint64_t next_valid; > > + > > + /* Cache lines 1 and 2 */ > > + uint64_t key[4][4]; > > + > > + /* Cache line 3 */ > > + uint8_t data[0]; > > +}; > > +#endif > > >=20 > Hi Ting, >=20 > Yes, it looks good, but as mentioned previously please do the same on the > other files in the same folder and add the changes to your patch, as we n= eed > to keep all these files in sync: >=20 > rte_table_hash_key8.c, struct rte_bucket_4_8 rte_table_hash_key32.c, stru= ct > rte_bucket_4_32 >=20 I have did the changes to 8 and 32 bytes in this patch. > Thanks, > Cristian