From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E7CDA034F; Wed, 6 May 2020 12:40:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 772C01D925; Wed, 6 May 2020 12:40:25 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A9FAD1D91A for ; Wed, 6 May 2020 12:40:23 +0200 (CEST) IronPort-SDR: 1gnnqIx/o2a2OL4pq6U8BuLNSXv0FUwvkgb5SkAVcrjvU3w9fARc1ETUIg5XrHveyM0uUSjHdh FLrY2QAB8PVg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 03:40:22 -0700 IronPort-SDR: 3J91GQx/xV4Spu5nILT3Cg5307du/LuhFuZZ+N2oH3mA5sR/cIFqTG2BkaO1LLdoUjY6ck8aR8 VQKZbuVQPsyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,358,1583222400"; d="scan'208";a="304765591" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 06 May 2020 03:40:22 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 03:40:22 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 03:40:22 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 May 2020 03:40:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NZmUCIyvI+pq08/jPmmSOu60zkdF307J9AQlyxsuLf/AjLX4oqaIrEooYjEBJHEXKZhdycVjUSZaIKUfxoz+jcUrpvXj2qTY7V/cDm4zhoNy6nDhXihpmShja+JM8cn8K7xt3qdUroYOQOQ50MQrmSM7QOLOG0NpkIRol+1s+/wqPFHz/ozSVpYj66V9xxE7cDP3rvzZLhQkz8psrJBxZ/mPhj+YDSDzfCegiSBJ5pZt78Ctd+OuJfKVOiHRF8Zmfpf47xFZDIXGmC6R2HWBAGXfuvu57P2H8wEsRrATDV4l40DXHNOOaYexC7A4/6rtq3XGzOQwnGsCLZng8/dIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yMNp1Ag4rP6eTKjTbDduviXC7EaS61wzCI6KQZtylNE=; b=hyo2fUXF5bU924vpyY/8GAzHE1HlIDay8giKryRysjNAerFDwv61VgqqYx4ycpjDUdmR++8gKK+tKWpzjkGTvMnM47ZuHahftWvya1jJTRUysro0MOrGR3x+/0nB3PL7AJQwTuujaAP2ZAx1BjY9gvc0RBOlHhAPOFtDrARY265NZBHO53ocyI/JarN8pLUXTg26SC9HXmTKqZi31++rhzSAnB8MnA00nYrZ1/tmGdKcR4VO8/Bf/NvdY2JSLSQVpDsV7ir1RfBWK1FbHSDPAELdAaaSeV0Kno8/y0jbelGeETrQ69ixWzKn5PPc4E2JRqC2RRAB5cuDFmK02MfJFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yMNp1Ag4rP6eTKjTbDduviXC7EaS61wzCI6KQZtylNE=; b=ZTXR61DrMNo0LXB+QWUF2fPgPGJY2YWaUj8QkzhrP6VU1NQW5MhTfx/UT9hvY8AZ3ugV47iImZmrtwtRz1efNKvNnpMi7Hcp6apzSAjxoYkdPo3JZq2puqALFg7AHaS3iwhlOHIUvDmJqJXa3hX0GN5mhb9t6sRupVWZEzR8xto= Received: from CY4PR1101MB2326.namprd11.prod.outlook.com (2603:10b6:903:b3::23) by CY4PR1101MB2280.namprd11.prod.outlook.com (2603:10b6:910:19::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Wed, 6 May 2020 10:40:21 +0000 Received: from CY4PR1101MB2326.namprd11.prod.outlook.com ([fe80::58c7:7df:1b11:9c56]) by CY4PR1101MB2326.namprd11.prod.outlook.com ([fe80::58c7:7df:1b11:9c56%4]) with mapi id 15.20.2958.030; Wed, 6 May 2020 10:40:20 +0000 From: "Shetty, Praveen" To: Anoob Joseph , "dev@dpdk.org" , "Doherty, Declan" , "akhil.goyal@nxp.com" CC: "Iremonger, Bernard" , "Ananyev, Konstantin" Thread-Topic: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue Thread-Index: AQHWI4Uxaf3ofh14FUiw5CwUdIiGqKiaznsAgAAPlMA= Date: Wed, 6 May 2020 10:40:20 +0000 Message-ID: References: <20200506090240.19214-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGQ2YTQ0OTAtNGE3Yy00N2U0LWE4YjAtMDUwYmVmZjlkYzMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRFkzeVdUVHdsWUdvY0haWlE2S0FZTlVrMVdrUm5WUlwvcjc3aGR6czhXRVA5TDk0WlpwcnhTXC9abVZCM0NlVzFGIn0= dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.79.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ba3c0f7-f302-48b7-cc75-08d7f1a9e039 x-ms-traffictypediagnostic: CY4PR1101MB2280: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Oa9FLRTmCIZ6elRVp105HRdY+8LLrY9D1u0xc/gWSod6vSmgcyMCnejgyEzLPhKgrLXOygQXJFut0lzQQ+MaOBVMp6jNPqHAHEEjMGYv4kv4Uomzi8LaWLUbxY9B/3mlmi/S7Az4r1Asfp3lNCz5rW9BxwsWYLgmI6PIFP6AoQdOADMHUxUx6XDF1n55WgWWMkCwdbktROh2EwF1UfAYeDQd7xRB0tG8A2ukxwURi+nslksX1Y5GRs12C/NK1Wxzbv3FbKL5EDPgtzHGjtJmDKnZI4HhB51g+8U37gDXnXqlosNZDF1aU2qfDWpnNeg9XKL0GP4Sf6umddmRt3wEIc147Szv4BsgfYSGYFCLlVdwLqA/4XRO7URKchwFlMfw+Zaq3PPOWmZ/YYQyDp5X46umBHzik7V+muTL3/rNxq+ID5TmlXSGfOLDbpAmIw4tFc5eFzTHhLr1PcM87YRmjirO3s+6xkaCJrW2GnEX9hdzES52/boC+pssQ79aaD8J7fYmJpRM/g6LEM9hWcBH1A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2326.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(366004)(39860400002)(376002)(136003)(346002)(33430700001)(7696005)(66946007)(186003)(66446008)(5660300002)(33440700001)(33656002)(52536014)(26005)(2906002)(53546011)(107886003)(6506007)(86362001)(71200400001)(55016002)(316002)(478600001)(8676002)(110136005)(66476007)(64756008)(66556008)(76116006)(8936002)(9686003)(54906003)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: XXZCxEbWVWUPev+ctCwADGFx8q1p8JyWJk2AKQmTMggWJ1iSZkDeZXpsqWYGuwNq8RlnNGOCRoH5YKe9fxTKP0esuF9UW/TyCGhi+mdWiNIsa904EnXefpp+qWmC5qNpNaWOBZGreD/wQ/gawOzzcQtgyMhtXleddHu1hR7v+1/uiXWHOxOZzon0Fji4M2L+WMHbuj5qgV2KfG5/9p1rhtuNyucBs0Ezjx27xYl2JYRhNkDle6epukiGE0qeXlYvlKegmsov2qQeqTW1kjokagDTsrMSbG6mAjHStydY0DviRz9oBCUih9UEAu4+GkA733ieNSFfgygXNf2twS7BUvFARi7EJg8yBPVxo42zgkZ2vFWAc6oOCwdDluiYcYrY5bj+W0cicwwqVUnwLA895lQP7mKAPrFDnYStKC3gKrsbBx9iMPhtXNdl5cFmJkwOqqKHmfvBC4jqECOKXMFj0R8CWtmWciWUqKO/GgdVNMP6ZcP9jYDuESq0BPf3oxUb68pf1Zf/UgD7+FPA9Z9mReLncLVWhrCPUVDhFEGbtTywSJ0DOgnJR9QWFa6HXGSIJUi9YF6GdHx45c7JTdcWjgne1Ap1/bDXbvP07haCEknFIAC/ECgVG0Kc0Q5hPMSqg0gMaUalCis2D6/uvI6bu5ZiNEilw1TyNwwKU5T/4k69w+JRddAjHCseXjUv7HZina0q5UgDlH85+pLcSOQIb5EcvESwWUYa6GL38+L4FIQ+gLmDu+nIi4jsUkaF9kV5V/PDQM2GLHDUgo5RDf+lPrwd5gHYqcngAXT2Ay27CJk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5ba3c0f7-f302-48b7-cc75-08d7f1a9e039 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 10:40:20.7446 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y7rV6JUDsUhmdk9Bg0CdKrI3u8UPuQSoOStbFxVE+PmkwSl/pCRzBJhWw5mQI2AEwwEp0lKxcR0rYgb7SkRhbD2kkYoBcKU4vjLh+WJDUxM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2280 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, Thank you. I have modified the commit message and headline accordingly and sent v2. Regards, Praveen -----Original Message----- From: Anoob Joseph =20 Sent: Wednesday, May 6, 2020 3:13 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Decl= an ; akhil.goyal@nxp.com Cc: Iremonger, Bernard ; Ananyev, Konstantin <= konstantin.ananyev@intel.com> Subject: RE: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue Hi Praveen, Please see inline. Thanks, Anoob > -----Original Message----- > From: Praveen Shetty > Sent: Wednesday, May 6, 2020 2:33 PM > To: dev@dpdk.org; declan.doherty@intel.com; akhil.goyal@nxp.com; Anoob=20 > Joseph > Cc: bernard.iremonger@intel.com; konstantin.ananyev@intel.com;=20 > praveen.shetty@intel.com > Subject: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue [Anoob] I believe Thomas insists on explaining the issue that you are tryin= g to fix rather than stating "resolve coverity issue" (which is too generic= ). So I guess you can remove all such references to coverity and retain res= t of your description. =20 >=20 > External Email >=20 > ---------------------------------------------------------------------- > Function create_ipsec_esp_flow returns a negative number in case of=20 > any failure. But passing negative number to strerror is causing the cover= ity issue. > In case of failure, displaying exact error message to console is=20 > handled in create_ipsec_esp_flow function.So it is not required to=20 > print the error message again using strerror. > This patch will remove the unnecessary calling of strerror function to=20 > fix the coverity issue. >=20 > Coverity issue: 357691 > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") > Cc: praveen.shetty@intel.com >=20 > Signed-off-by: Praveen Shetty > --- > examples/ipsec-secgw/sa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c=20 > index > e3a1a5aff..632482176 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct=20 > ipsec_sa entries[], > rc =3D create_ipsec_esp_flow(sa); > if (rc !=3D 0) > RTE_LOG(ERR, IPSEC_ESP, > - "create_ipsec_esp_flow() failed %s\n", > - strerror(rc)); > + "create_ipsec_esp_flow() failed\n"); > } > print_one_sa_rule(sa, inbound); > } > -- > 2.17.1