From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] rte_sched: fix 64-bit support in rate functions
Date: Tue, 16 Jun 2020 11:52:34 +0000 [thread overview]
Message-ID: <CY4PR11MB0072DC5A07A08CB509733B68E09D0@CY4PR11MB0072.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200615171905.5377-1-hrvoje.habjanic@zg.ht.hr>
> -----Original Message-----
> From: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> Sent: Monday, June 15, 2020 6:19 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] rte_sched: fix 64-bit support in rate functions
>
> Functions rte_sched_subport_config_pipe_profile_table and
> pipe_profile_check should also have increased rate arguments.
>
> Fixes: 68c1f26d4236 (\"sched: support 64-bit values\")
> Cc: jasvinder.singh@intel.com
>
> Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> ---
> lib/librte_sched/rte_sched.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
> c0983ddda..be822057b 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -304,7 +304,7 @@ rte_sched_port_tc_queue(struct rte_sched_port
> *port, uint32_t qindex)
>
> static int
> pipe_profile_check(struct rte_sched_pipe_params *params,
> - uint32_t rate, uint16_t *qsize)
> + uint64_t rate, uint16_t *qsize)
> {
> uint32_t i;
>
> @@ -624,7 +624,7 @@ rte_sched_pipe_profile_convert(struct
> rte_sched_subport *subport,
>
> static void
> rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport
> *subport,
> - struct rte_sched_subport_params *params, uint32_t rate)
> + struct rte_sched_subport_params *params, uint64_t rate)
> {
> uint32_t i;
>
Hi Hrvoje,
Thanks for sending the patch. Few days ago, similar fix was proposed https://www.mail-archive.com/dev@dpdk.org/msg168579.html
which I acked. I think that patch is not applied on DPDK yet but will happen soon.
Regards,
Jasvinder
prev parent reply other threads:[~2020-06-16 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 17:19 Hrvoje Habjanic
2020-06-16 11:52 ` Singh, Jasvinder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB0072DC5A07A08CB509733B68E09D0@CY4PR11MB0072.namprd11.prod.outlook.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=hrvoje.habjanic@zg.ht.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).