From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A2B20A00BE;
Tue, 15 Mar 2022 18:26:01 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7F57B40395;
Tue, 15 Mar 2022 18:26:01 +0100 (CET)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by mails.dpdk.org (Postfix) with ESMTP id 31B094014F
for <dev@dpdk.org>; Tue, 15 Mar 2022 18:26:00 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1647365160; x=1678901160;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:content-transfer-encoding:mime-version;
bh=G8KCdkgEs9cNlNFPU+ixDE2byQ52cXv+1wiTfUP0Ay4=;
b=HY3TU6v7+9CmLNFxPBDAftocfKvcvGzLM1D70UYTAE+AGVSQWcNNEQOr
IGwquSW4o2VpVLOSc82JpBhELSxsnWr04UC4h2fnSlLPd1du52ewT0HRK
FfJDKamWtkhPGaBQqabsp2m64ZY1muwILp3FgKC3xGUnb2LGqu18Stgd2
TQqevQ0v2eh/2qx/cUTbIKRRvMjFaCRIx+xWF+Yj0pl8rAW+ecUMkl7Ng
IcyUj3yH/cBn3S3E0lcG48f2oOOR0dRwtzEdTSUzs2S/hLvwefWR1sUIa
hhOl4ayxPkGhSzfYksJa2TQgkVI+ISt3Myf2zzUtGm/bXzgLVEKdm5+Po g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="342797322"
X-IronPort-AV: E=Sophos;i="5.90,184,1643702400"; d="scan'208";a="342797322"
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Mar 2022 10:25:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.90,184,1643702400"; d="scan'208";a="646311467"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
by orsmga004.jf.intel.com with ESMTP; 15 Mar 2022 10:25:59 -0700
Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by
ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.21; Tue, 15 Mar 2022 10:25:58 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 10:25:58 -0700
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by
edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2308.21; Tue, 15 Mar 2022 10:25:58 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=WYgkefeVFYgqYPRpWYuRIYENKqcKpAohYitrHztLgVOwxPdp6TlOYm8E1Unwe7Z3GZjqbZA9XZjQrOEUWLgzzUY8CqpkDNLkLuhqPbKeQGCaMPQOjNexXZOqWhn5fAqU5JKAtdlgopGVootSG8eTA9CZjerzc/cWtsoJKwUP12gtdryrlXtz19kVUGP70XWRycfHZ0HbzoRbMplggMylWn94TM+CGK4WaBe3fs19ntqUTWSDvstOrWi6M0Y3uMOExmZmhgmhRV7hZ7MX2512gD2kyNjC8lLuTr+ioYhBK4ajPmwOvIRW4OS5NqOnTw+E/FmxarsnAbd6zkm8DoCg9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=G8KCdkgEs9cNlNFPU+ixDE2byQ52cXv+1wiTfUP0Ay4=;
b=C8dVt5SSe4W8LBFQN+oBDG35hGYq7jPMVbuHJHW/EiYvoPWZG/LGADRtS0higAkDtW7wzA+6f2ajLVVPTWpOPWZ5eI2lLAp6DgpIuMALE+/n/8T2RYSjSE7KQMhElu7Db3YEGt6VpzoTagQ3L0IYQZ0jv2m8WiDc21hsUG5clCJFeWgVfSWq2zrLqQX+A2+G6bZiWcBhsxEUgGkQOJXw6G3Bfz4mM/p41ajwqtdQjlTakRJGrHXOHwbowr7kdaT8P6d/ErUqOxtlXe+57qDb2HrOKYULVKXmFrsb9W8D728Pb3LmpjHL6V41T0nR/JkF6eUvGU8gN0DpIwpeEHZm8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Received: from CY4PR11MB1589.namprd11.prod.outlook.com (2603:10b6:910:e::13)
by BN8PR11MB3841.namprd11.prod.outlook.com (2603:10b6:408:85::23) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.25; Tue, 15 Mar
2022 17:25:56 +0000
Received: from CY4PR11MB1589.namprd11.prod.outlook.com
([fe80::196d:c310:6a16:2a90]) by CY4PR11MB1589.namprd11.prod.outlook.com
([fe80::196d:c310:6a16:2a90%12]) with mapi id 15.20.5061.028; Tue, 15 Mar
2022 17:25:56 +0000
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, Thomas Monjalon
<thomas@monjalon.net>, "Ajmera, Megha" <megha.ajmera@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Mcnamara, John" <john.mcnamara@intel.com>,
"Thakur, Sham Singh" <sham.singh.thakur@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [PATCH v2] Revert "sched: enable traffic class oversubscription
unconditionally"
Thread-Topic: [PATCH v2] Revert "sched: enable traffic class oversubscription
unconditionally"
Thread-Index: AQHYN57iY+EIg7is10GCP+AMgSiJPqzATs+AgABlJQCAAAA2cA==
Date: Tue, 15 Mar 2022 17:25:56 +0000
Message-ID: <CY4PR11MB15891651E01B5A9426F4F9E3E0109@CY4PR11MB1589.namprd11.prod.outlook.com>
References: <4dfde108-70ff-d916-4b42-5048d1a82042@redhat.com>
<20220314122725.106088-1-megha.ajmera@intel.com> <3492155.hdfAi7Kttb@thomas>
<DM8PR11MB5670E96DFD968FBC7D3FA717EB109@DM8PR11MB5670.namprd11.prod.outlook.com>
In-Reply-To: <DM8PR11MB5670E96DFD968FBC7D3FA717EB109@DM8PR11MB5670.namprd11.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-version: 11.6.401.20
dlp-reaction: no-action
dlp-product: dlpe-windows
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dd0de46e-4780-4def-54c4-08da06a8dd97
x-ms-traffictypediagnostic: BN8PR11MB3841:EE_
x-microsoft-antispam-prvs: <BN8PR11MB38413D5311C7E9057A6F7690E0109@BN8PR11MB3841.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: cUcHMv2iM/Flx7dJyFmBTHKh2Mk0KKIBKpQYKsLVwrvMM9kj07qLpAA7yPm7ATXmv2rZZDsQGogpfvdMrriLUSDy68HCafzqOpTwXP3Cf0eXZM1UUNnPxrQwOXS62LlL/fBfLumvR/C77KZuid3XnSTNb/WDoAxV+ZX5hqbt2SpCvpcCaE7sOaqA5jJu/WTSQzYoBzoUG2CSwD29Ch/qZ4zmvIwbj5eNiPUtF240ZvwaCz4GWBdVzz/92LKbf1vEyC9uUSABNU7M/Dy7O+i6s9m5jH0JqzdpDWdVipoKKcD8Z3yilQ4k/xmauXjdHZ4agz6mGXSeh0P3ftQl5VG+VKTfF0Aneeavji4dGV0KS26Af36o36JjTorMmFI3/VpARkyV3iqDrO3Os2LW6fcHdWwh8dOoSs/6rnyQO6MMV9duLrjKC9pD5wAQ6P8619C4CO6DH2t71QrgTWmI0npSyGNUg1dpwtfHURJBlThY3GQ2JctpCUL317gbfPZlXejAuzYsv4FVUPfIXdbeYBgkhfD/aq9pJvxEfc02+QrjjA0Li1b5zcVXwKuWQrLB+LOIUPFavUF5/Yo8uAaL3D6ofZVBgXWZ3TUOurhyXfT+1gCIuc6y4DNgl7v5XujSnzyljhqupIoP0KW+aAQZuJC+h3AsT11VvDD65yK5I5xg4qk9Mf1gtlM+AV/VyiRKSf2RWUktH44MWJNtkOPvt/14Vg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CY4PR11MB1589.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230001)(366004)(4326008)(64756008)(66446008)(66476007)(66556008)(55016003)(53546011)(76116006)(71200400001)(66946007)(8676002)(6506007)(33656002)(54906003)(316002)(110136005)(6636002)(7696005)(52536014)(508600001)(5660300002)(8936002)(186003)(26005)(83380400001)(9686003)(2906002)(86362001)(122000001)(38100700002)(82960400001)(38070700005);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bDZOpsTtPo2jMh7BdY58TBKF3pCpyoRCrjyjdMLX5ZVQzbKnJooSxESZ043Y?=
=?us-ascii?Q?Ve615fSBDcpyQJ0TzAsdftI4HJtRmQJPh4SIovpidRToZOBT49TtaLwqHX5t?=
=?us-ascii?Q?ct+uQf9OAtU68fUdzdqLgjcH7wqPEiPdYizMMcZDuaNfgucl4adjPrHd7Rdq?=
=?us-ascii?Q?5aDzuCOflUIJxcDCgEVX9XFK601iJTaUsOA0jnNyUoHK/oCkE4K+Mde6/zY1?=
=?us-ascii?Q?nxtqUXMlokl3rqQufsG+lJAqhVkt1NMXN/ouv7OqkRxIVN33vOFi+GOwzg0z?=
=?us-ascii?Q?zShA1JGA56wUEN0sjnhh22XWKGzLiO1SqXK2HFMYEGp/IoBB7wCojvUcjnXk?=
=?us-ascii?Q?Cmt/7Z/yqX6kcx/qQfIM/4KRtWvtlDVBBFz6CHmhxFDyn2/8gl0JAozdkONN?=
=?us-ascii?Q?47xF7G82qor4qVVupEk6HfSBlsn31EcLvizb4TKtYZSEHS3OQNOx6QJeQZTa?=
=?us-ascii?Q?Tvg2LnpqjY0MGgGUSc6JoPeLHOYWnfh/nGApfgll6L+o66qmsUgUAImS0WjG?=
=?us-ascii?Q?Xq0Y7SM4akXX2Xb06gqrP1QWzYd11XtUUtOdc278HevP9DcmxYeUDVhmlc1x?=
=?us-ascii?Q?A3Klv3W5Y/WZZBx30BXsF5nWeB883QVQr/CpcfytREJXyfMVJo+ih/Iee7Hv?=
=?us-ascii?Q?NzyTRx8MHRPGLBNUVYmgZbrURTOERoittIO8SeCHC0zgREWZtNy9LKN6wXxm?=
=?us-ascii?Q?llyy7qGHiMUQWz+n6FWxnuKx7Ws1ImK0xT9lMRZmMWFwidiqMlVIxopcK5L9?=
=?us-ascii?Q?Ja/sxXY9B714gQERnDunN6XUW6kedIm/X8leeANv5xaOA9ii5GzTeAigO3E0?=
=?us-ascii?Q?oIAujyml7FgZMYgUqQVcFJ9retZ8hzyE8B49nvA9PZnN5rVFo6jusPCEWjKo?=
=?us-ascii?Q?z6lB9TAuruKUIyc8H2uBy5qzxgPX/YDmltzUk/7Fj853VRN62nxZfE73/aVP?=
=?us-ascii?Q?Ruw+jQ+CwwGkv1QEMPccOaXdSN6SX9RHxXhxEfHEwlgvXjSrm4i0CcGA6hf8?=
=?us-ascii?Q?BimRTT/klghqxLOtGPBHE1rPQBCEXG4YK4fwzHTEJ0FdhNCfnbAF44TC9beg?=
=?us-ascii?Q?sZLNZmsO0Ba6VXNaOeuFfi3Z0le8G2GZzrBSn4x8eJKs6EPG4Ai3PWgmWIeP?=
=?us-ascii?Q?ty7bCEnjgWb14BTgPPLOwQJI9NI2ynPt+Km29U0ukLT3UUPr8OB3lMNBC8Xm?=
=?us-ascii?Q?JFDb80RM64dTg4ALwyo1UsuZTZIcfayrFvHrSaORLzNyNCRfIcEWFGHfELQK?=
=?us-ascii?Q?v7BcIJOAUsB5lXnnauMWT4FvRYRcrvo7Pia10jjc3YOmRmJLmVj5GtZcwSeq?=
=?us-ascii?Q?sp9iMOakCymwNKddc7rqzjcazH5bamd7bQf0ecHK6ZR8sojtgX1djDWamXIi?=
=?us-ascii?Q?vOuYVZTWWzWyhTQ8Hs8FjXGRp9DXBBGrF74iS4hVs0mncAvsOYjiptMP4Se/?=
=?us-ascii?Q?vE7yk2myLrx6BS3733hGhjCe3xuE1IVoQTu9S7mRY0qUlYHQEuwnEQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1589.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd0de46e-4780-4def-54c4-08da06a8dd97
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 17:25:56.7363 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9Ekgn8vYhknUoMrzkPxf9PyrRnXhvkPZk/0U+fzpdInRIe6tPRSFWGALUZN1W9QodL+YBFKDXc8WOOP0RaYpv94nMdsfV8U4ufI89GQMFqo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3841
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
> -----Original Message-----
> From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Sent: Tuesday, March 15, 2022 5:25 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Ajmera, Megha
> <megha.ajmera@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Singh,
> Jasvinder <jasvinder.singh@intel.com>; Thakur, Sham Singh
> <sham.singh.thakur@intel.com>; david.marchand@redhat.com
> Subject: RE: [PATCH v2] Revert "sched: enable traffic class oversubscript=
ion
> unconditionally"
>=20
> Hi Thomas,
>=20
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, March 15, 2022 11:23 AM
> > To: Ajmera, Megha <megha.ajmera@intel.com>
> > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Singh,
> > Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> > <cristian.dumitrescu@intel.com>; Thakur, Sham Singh
> > <sham.singh.thakur@intel.com>; david.marchand@redhat.com
> > Subject: Re: [PATCH v2] Revert "sched: enable traffic class
> > oversubscription unconditionally"
> >
> > 14/03/2022 13:27, Megha Ajmera:
> > > This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e.
> > >
> > > When enabling TC OV unconditionally, it is observed the performance
> > > drops by ~20% hence reverting this commit.
> > >
> > > Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription
> > > unconditionally")
> > >
> > > Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> >
> > Repeating what was suggested yesterday in a private email.
> > Sorry Megha, I don't know why you were not Cc'ed by your Intel
> colleagues.
> >
> > David and I suggested to drop the code which was enabled by the
> > compilation flag RTE_SCHED_SUBPORT_TC_OV, which was kind of dead
> code
> > before enabling it unconditionally.
> > This way you maintain the performance of the default compilation, and
> > you can re-introduce the feature, if proven useful, in the next
> > release with a runtime option.
> >
> >
>=20
> After talking with Jasvinder and a few other folks, we think the best opt=
ion at
> this point is to keep the code as it is now in the repository, so no furt=
her
> change at this point.
>=20
> There is a small performance glitch that we plan to fix shortly after the=
22.03
> release by making the Traffic Class Oversubscription feature conditionall=
y
> enabled at run-time as opposed to enabled unconditionally. Megha already
> sent a patch on this, which is under review.
>=20
> Is this OK with you?
>=20
> Thank you for your help, we don't want to delay the release in any way!
>=20
> Regards,
> Cristian
+1