config files profile.cfg in examples/qos_sched

config files profile.cfg in examples/qos_sched

[Theo MARGUERET]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hello , 
I worked on the qos_sched application and I think, there may be an error in the config file. 
It seems that the allocation of the pipe profile mapping : 
- pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 
is not in the right place. 
I think it should be in the subport configuration. For examples like this : 
---------------------------------------------------------------------------------------------- 
[subport 0] 
number of pipes per subport = 4096 
queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 

pipe 0-4095 = 0 
---------------------------------------------------------------------------------------------- 


Moreover I did not find any parsing for the line : 
- subport 0-8 = 0 

Thanks for your attention. 
Sincerely. 

Théo Margueret 

[-- Attachment #2: Type: text/html, Size: 1449 bytes --]

Re: config files profile.cfg in examples/qos_sched

[Thomas Monjalon]

+Cc maintainers of this part

Do not hesitate to submit a patch to fix the issue you found.


12/07/2022 10:22, Theo MARGUERET:
> Hello , 
> I worked on the qos_sched application and I think, there may be an error in the config file. 
> It seems that the allocation of the pipe profile mapping : 
> - pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 
> is not in the right place. 
> I think it should be in the subport configuration. For examples like this : 
> ---------------------------------------------------------------------------------------------- 
> [subport 0] 
> number of pipes per subport = 4096 
> queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 
> 
> pipe 0-4095 = 0 
> ---------------------------------------------------------------------------------------------- 
> 
> 
> Moreover I did not find any parsing for the line : 
> - subport 0-8 = 0 
> 
> Thanks for your attention. 
> Sincerely. 
> 
> Théo Margueret 
> 

Re: config files profile.cfg in examples/qos_sched

[Theo MARGUERET]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Hello,
You can find attached a patch to fix the issue.
Sincerely
Théo
----- Mail original -----
De: "Thomas Monjalon" <thomas@monjalon.net>
À: "Theo MARGUERET" <theo.margueret@etu.toulouse-inp.fr>
Cc: "dev" <dev@dpdk.org>, "Cristian Dumitrescu" <cristian.dumitrescu@intel.com>, "Jasvinder Singh" <jasvinder.singh@intel.com>
Envoyé: Vendredi 15 Juillet 2022 18:27:41
Objet: Re: config files profile.cfg in examples/qos_sched

+Cc maintainers of this part

Do not hesitate to submit a patch to fix the issue you found.


12/07/2022 10:22, Theo MARGUERET:
> Hello , 
> I worked on the qos_sched application and I think, there may be an error in the config file. 
> It seems that the allocation of the pipe profile mapping : 
> - pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 
> is not in the right place. 
> I think it should be in the subport configuration. For examples like this : 
> ---------------------------------------------------------------------------------------------- 
> [subport 0] 
> number of pipes per subport = 4096 
> queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 
> 
> pipe 0-4095 = 0 
> ---------------------------------------------------------------------------------------------- 
> 
> 
> Moreover I did not find any parsing for the line : 
> - subport 0-8 = 0 
> 
> Thanks for your attention. 
> Sincerely. 
> 
> Théo Margueret 
>

[-- Attachment #2: profile.cfg --]
[-- Type: application/octet-stream, Size: 5553 bytes --]

;   SPDX-License-Identifier: BSD-3-Clause
;   Copyright(c) 2010-2019 Intel Corporation.

; This file enables the following hierarchical scheduler configuration for each
; 10GbE output port:
;	* Single subport (subport 0):
;		- Subport rate set to 100% of port rate
;		- Each of the 13 traffic classes has rate set to 100% of port rate
;	* 4K pipes per subport 0 (pipes 0 .. 4095) with identical configuration:
;		- Pipe rate set to 1/4K of port rate
;		- Each of the 13 traffic classes has rate set to 100% of pipe rate
;		- Within lowest priority traffic class (best-effort), the byte-level
;		  WRR weights for the 4 queues of best effort traffic class are set
;		  to 1:1:1:1
;
; For more details, please refer to chapter "Quality of Service (QoS) Framework"
; of Data Plane Development Kit (DPDK) Programmer's Guide.

; Port configuration
[port]
frame overhead = 24
number of subports per port = 1

; Subport configuration
[subport 0]
number of pipes per subport = 4096
queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
;subport 0-8 = 0               ; These line doesn't seem to be parsed



[subport profile 0]
tb rate = 1250000000           ; Bytes per second
tb size = 1000000              ; Bytes

tc 0 rate = 1250000000         ; Bytes per second
tc 1 rate = 1250000000         ; Bytes per second
tc 2 rate = 1250000000         ; Bytes per second
tc 3 rate = 1250000000         ; Bytes per second
tc 4 rate = 1250000000         ; Bytes per second
tc 5 rate = 1250000000         ; Bytes per second
tc 6 rate = 1250000000         ; Bytes per second
tc 7 rate = 1250000000         ; Bytes per second
tc 8 rate = 1250000000         ; Bytes per second
tc 9 rate = 1250000000         ; Bytes per second
tc 10 rate = 1250000000        ; Bytes per second
tc 11 rate = 1250000000        ; Bytes per second
tc 12 rate = 1250000000        ; Bytes per second

tc period = 10                 ; Milliseconds



; Pipe configuration
[pipe profile 0]
tb rate = 305175               ; Bytes per second
tb size = 1000000              ; Bytes

tc 0 rate = 305175             ; Bytes per second
tc 1 rate = 305175             ; Bytes per second
tc 2 rate = 305175             ; Bytes per second
tc 3 rate = 305175             ; Bytes per second
tc 4 rate = 305175             ; Bytes per second
tc 5 rate = 305175             ; Bytes per second
tc 6 rate = 305175             ; Bytes per second
tc 7 rate = 305175             ; Bytes per second
tc 8 rate = 305175             ; Bytes per second
tc 9 rate = 305175             ; Bytes per second
tc 10 rate = 305175            ; Bytes per second
tc 11 rate = 305175            ; Bytes per second
tc 12 rate = 305175            ; Bytes per second

tc period = 40                ; Milliseconds

tc 12 oversubscription weight = 1

tc 12 wrr weights = 1 1 1 1

; RED params per traffic class and color (Green / Yellow / Red)
;[red]
;tc 0 wred min = 48 40 32
;tc 0 wred max = 64 64 64
;tc 0 wred inv prob = 10 10 10
;tc 0 wred weight = 9 9 9

;tc 1 wred min = 48 40 32
;tc 1 wred max = 64 64 64
;tc 1 wred inv prob = 10 10 10
;tc 1 wred weight = 9 9 9

;tc 2 wred min = 48 40 32
;tc 2 wred max = 64 64 64
;tc 2 wred inv prob = 10 10 10
;tc 2 wred weight = 9 9 9

;tc 3 wred min = 48 40 32
;tc 3 wred max = 64 64 64
;tc 3 wred inv prob = 10 10 10
;tc 3 wred weight = 9 9 9

;tc 4 wred min = 48 40 32
;tc 4 wred max = 64 64 64
;tc 4 wred inv prob = 10 10 10
;tc 4 wred weight = 9 9 9

;tc 5 wred min = 48 40 32
;tc 5 wred max = 64 64 64
;tc 5 wred inv prob = 10 10 10
;tc 5 wred weight = 9 9 9

;tc 6 wred min = 48 40 32
;tc 6 wred max = 64 64 64
;tc 6 wred inv prob = 10 10 10
;tc 6 wred weight = 9 9 9

;tc 7 wred min = 48 40 32
;tc 7 wred max = 64 64 64
;tc 7 wred inv prob = 10 10 10
;tc 7 wred weight = 9 9 9

;tc 8 wred min = 48 40 32
;tc 8 wred max = 64 64 64
;tc 8 wred inv prob = 10 10 10
;tc 8 wred weight = 9 9 9

;tc 9 wred min = 48 40 32
;tc 9 wred max = 64 64 64
;tc 9 wred inv prob = 10 10 10
;tc 9 wred weight = 9 9 9

;tc 10 wred min = 48 40 32
;tc 10 wred max = 64 64 64
;tc 10 wred inv prob = 10 10 10
;tc 10 wred weight = 9 9 9

;tc 11 wred min = 48 40 32
;tc 11 wred max = 64 64 64
;tc 11 wred inv prob = 10 10 10
;tc 11 wred weight = 9 9 9

;tc 12 wred min = 48 40 32
;tc 12 wred max = 64 64 64
;tc 12 wred inv prob = 10 10 10
;tc 12 wred weight = 9 9 9

[pie]
tc 0 qdelay ref = 15
tc 0 max burst = 150
tc 0 update interval = 15
tc 0 tailq th = 64

tc 1 qdelay ref = 15
tc 1 max burst = 150
tc 1 update interval = 15
tc 1 tailq th = 64

tc 2 qdelay ref = 15
tc 2 max burst = 150
tc 2 update interval = 15
tc 2 tailq th = 64

tc 3 qdelay ref = 15
tc 3 max burst = 150
tc 3 update interval = 15
tc 3 tailq th = 64

tc 4 qdelay ref = 15
tc 4 max burst = 150
tc 4 update interval = 15
tc 4 tailq th = 64

tc 5 qdelay ref = 15
tc 5 max burst = 150
tc 5 update interval = 15
tc 5 tailq th = 64

tc 6 qdelay ref = 15
tc 6 max burst = 150
tc 6 update interval = 15
tc 6 tailq th = 64

tc 7 qdelay ref = 15
tc 7 max burst = 150
tc 7 update interval = 15
tc 7 tailq th = 64

tc 8 qdelay ref = 15
tc 8 max burst = 150
tc 8 update interval = 15
tc 8 tailq th = 64

tc 9 qdelay ref = 15
tc 9 max burst = 150
tc 9 update interval = 15
tc 9 tailq th = 64

tc 10 qdelay ref = 15
tc 10 max burst = 150
tc 10 update interval = 15
tc 10 tailq th = 64

tc 11 qdelay ref = 15
tc 11 max burst = 150
tc 11 update interval = 15
tc 11 tailq th = 64

tc 12 qdelay ref = 15
tc 12 max burst = 150
tc 12 update interval = 15
tc 12 tailq th = 64

RE: config files profile.cfg in examples/qos_sched

[Singh, Jasvinder]

> -----Original Message-----
> From: Theo MARGUERET <theo.margueret@etu.toulouse-inp.fr>
> Sent: Tuesday, July 19, 2022 8:31 AM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev <dev@dpdk.org>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: Re: config files profile.cfg in examples/qos_sched
> 
> Hello,
> You can find attached a patch to fix the issue.
> Sincerely
> Théo

Hi Theo, 

can you follow guidelines at https://core.dpdk.org/contribute/submit  for patch submission. 

Thanks, 
Jasvinder
 

Re: config files profile.cfg in examples/qos_sched

[Thomas Monjalon]

19/07/2022 16:15, Singh, Jasvinder:
> From: Theo MARGUERET <theo.margueret@etu.toulouse-inp.fr>
> > 
> > Hello,
> > You can find attached a patch to fix the issue.
> > Sincerely
> > Théo
> 
> Hi Theo, 
> 
> can you follow guidelines at https://core.dpdk.org/contribute/submit  for patch submission.

I guess you mean https://core.dpdk.org/contribute/#send

Theo, if any difficulty with the process,
don't hesitate to ask in private email or Slack, I can help.
Thanks