From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCB31A0543; Tue, 14 Jul 2020 12:56:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B88C71D5CF; Tue, 14 Jul 2020 12:56:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6572A1D551 for ; Tue, 14 Jul 2020 12:56:26 +0200 (CEST) IronPort-SDR: 4KMRet4A+3OuGirtV+it78u8CoptnAFjr0t54iad/UifjWZPLGtQPkTvOfaiIg8q72SZkNJ7KE l6TvS8ZWQhsQ== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="128424659" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="128424659" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 03:56:25 -0700 IronPort-SDR: xHdwgfqIgwBIfALJ68eCqeYMId+67Kev8NJwEQWmeoDSsFwCw1uB8lmNlDCS8NycEhc7T1p9Do suhU8ZP2JNzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="268621651" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga007.fm.intel.com with ESMTP; 14 Jul 2020 03:56:25 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jul 2020 03:56:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 14 Jul 2020 03:46:23 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 14 Jul 2020 03:46:23 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.58) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jul 2020 03:45:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ST79mN8q75YWpT/moP6o1iqohMoAipeH/lvfhuohHYe59rjoLot4S2HRUpulc9i/hd46/hN573jFyFS7uwifw59oJSCWlhDuQPOxFVq5WACez/dsdgPXYHxJZ4wRf5PgnfOFvb3zBhjtwq03B/86OUbc6kxEoMqj+NLR5T2rkEYFQw/SMieC7IPZvPAq33j+EoKyvchAZUr7pJWlxZ3BuI3opgfxM8OaW2NP/qcHNrT54wEnyrtjOX6UcK8mChC5zMqRru4HZ6BGgtdubyYw3B4JXL+LbQqG5gcaVHDE36HQC9dqV7G51c5tDX79+wZzPf6TdYixpdxyh2KWjgV1JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jLEpxfosGEKf2m6J7iDzYH5vOWG3wRFw6ShiOUjssbU=; b=UuqKJbjXvg9A1t3a92E9v8YcRbyANnq6hsAK5kdKMDNdvxKZHwgO1l+fvk+KaBnRgHf5r4PuUVVGB6R4S7nI7kntPooE8t/uCQqh2/T53Zl2KKUAsHqBTSkWcFABr+fCY5AUe/4TESIpzQ7s8wu1iRfKNWZAYa/dhfsHRbXYGqp/YPdXlhcp7D70JZC/8vih4r/91HSoCw6PE1ifUni1F/FBCLt4YIbWLx+P81197YHOq9DnfQDV8ofQWXSR2iXMNCaSG6W42tAp7sFBUzjWDRREH+FIavAg46UPoIfexg4P/9WqXtAPMdiPkuwJlN56PL7e09858bwiLKIHY1+6kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jLEpxfosGEKf2m6J7iDzYH5vOWG3wRFw6ShiOUjssbU=; b=APkYGjGOESu8E8j5Cek823iUl/MXQRH97+q39QdoJfV1+xE6NT8zqx2SrxKVApaKtCwRyvzLIuKdX/lfRMPfn4RdeNhPVhpZjnUiAjM8zRvIC2qW2CNwEtKN2M0BJd+b2ijk0Lj9yYpEMByY5BXIltsx/gbMLZpnCG7BBlxVwXY= Received: from CY4PR11MB1639.namprd11.prod.outlook.com (2603:10b6:910:f::11) by CY4PR1101MB2168.namprd11.prod.outlook.com (2603:10b6:910:18::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Tue, 14 Jul 2020 10:45:40 +0000 Received: from CY4PR11MB1639.namprd11.prod.outlook.com ([fe80::b1c1:facd:8976:d8d8]) by CY4PR11MB1639.namprd11.prod.outlook.com ([fe80::b1c1:facd:8976:d8d8%11]) with mapi id 15.20.3174.025; Tue, 14 Jul 2020 10:45:40 +0000 From: "Jiang, Cheng1" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Fu, Patrick" Thread-Topic: [PATCH 20.11] raw/ioat: added a flag to control copying handle parameters Thread-Index: AQHWWOY44FmCPgImQkSS+K13LyisiakFgSYAgAFjLHA= Date: Tue, 14 Jul 2020 10:45:40 +0000 Message-ID: References: <20200713071519.110662-1-Cheng1.jiang@intel.com> <20200713132820.GI694@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200713132820.GI694@bricha3-MOBL.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c39524a3-c0fb-491f-d356-08d827e30d5d x-ms-traffictypediagnostic: CY4PR1101MB2168: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kYEnmWghysDKToK5FD0oPOzZDIymCfYoH4fXsgGH6er+d0QQx3A+XBl5oXax+6yjcThmreYuQCsmp03NHm98FX/DzTWUV21P/85OwB8MHL+x0lbGWT8DPx0xwn3rd8QVAUsRuC56zs51vTKt3auHBm6HpJUn4a2PtpSpsJfWRGPf0qHw4EPB6ktUCKQm0qAhhfNHonEG5EY+608Evp3YfGn7qKoOPkK6W16O2tbASlBXLSmzNgXAPqrodT67hMgFxsUnBwvyoJC+M1Epn8zhGxO0HsVq8QlNif3Jo8bVk/j9JRtDV1pESwDieAzOo+qCkPQmHxmskUO4UrcCEYhUtg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(55016002)(478600001)(6636002)(66946007)(66476007)(76116006)(33656002)(66556008)(64756008)(54906003)(66446008)(53546011)(71200400001)(7696005)(6506007)(2906002)(316002)(6862004)(107886003)(26005)(9686003)(5660300002)(4326008)(186003)(8936002)(8676002)(86362001)(52536014)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7+iCAHqEwRS375/cXI9asHkYOELnjgchPtqYN8kkFTtJV7coAq4IvrCx1TCASH6jNptZTgIAisvHN6thVX3p3zjn+pzAUeyAZB4OoYowBcdG2c8CFFsMTmYCt9ZGkdbMTupY8Qx0Lb2OSjFF8/On69PuZNOj+UAPGb2gwDeuEnEOsiuzmdsrqcHFME7+VjcQcdvfXyUmO14qyrwLLdY9zLiXT2DBpTsrmSfSXXtqQ8P4VanDe9VocZbMy8eXcC/0kvzOlr8xT4VBgflTNOsT6D86PV6jwQt5qiX2jngzsI6zX5ZIOAlkaXTJqaEk3va00YcQtBu0rFF3Zgm/JO+t0ExxuXPgdw4+FDjZ+wiHBkWkcLh8Y4Bew9PHsmYvFPwOcbTzVoN/K7X/jiL8zzR4WBZWy3iN3CpfndVXCfhAZm2bTRvZSiipAEIfGijeOuxP+tFNjaDslpyNYj5KGC97wBrkkylNRCg7mWppp5+9AAPr2UGXGuV2pGQBbyWI5UTF Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c39524a3-c0fb-491f-d356-08d827e30d5d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 10:45:40.7117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GDnX3bAl5j0YShpnLttSWiUqTkwTkZyjctfMp0RuI2zMBkI4+boTsIsRG6xiZ9jrKqHqBUZ4Pt0jht9lJqvtPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2168 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 20.11] raw/ioat: added a flag to control copying handle parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, Thank you very much for these comments which really make sense for me. I wi= ll correct these problems in the next version. Thanks again. Cheng > -----Original Message----- > From: Bruce Richardson > Sent: Monday, July 13, 2020 9:28 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; Fu, Patrick > Subject: Re: [PATCH 20.11] raw/ioat: added a flag to control copying hand= le > parameters >=20 > On Mon, Jul 13, 2020 at 07:15:19AM +0000, Cheng Jiang wrote: > > Added a flag which controls whether rte_ioat_enqueue_copy and > > rte_ioat_completed_copies function should process handle parameters to > > improve the performance when handle parameters are not necessary to > > use. This is targeting > > 20.11 release. > > > > Signed-off-by: Cheng Jiang > > --- > > drivers/raw/ioat/ioat_rawdev.c | 1 + > > drivers/raw/ioat/rte_ioat_rawdev.h | 14 +++++++++++--- > > 2 files changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/raw/ioat/ioat_rawdev.c > > b/drivers/raw/ioat/ioat_rawdev.c index 87fd088aa..5bf030785 100644 > > --- a/drivers/raw/ioat/ioat_rawdev.c > > +++ b/drivers/raw/ioat/ioat_rawdev.c > > @@ -57,6 +57,7 @@ ioat_dev_configure(const struct rte_rawdev *dev, > rte_rawdev_obj_t config) > > return -EINVAL; > > > > ioat->ring_size =3D params->ring_size; > > + ioat->hdls_enable =3D params->hdls_enable; > > if (ioat->desc_ring !=3D NULL) { > > rte_memzone_free(ioat->desc_mz); > > ioat->desc_ring =3D NULL; > > diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h > > b/drivers/raw/ioat/rte_ioat_rawdev.h > > index f765a6557..daca04dd3 100644 > > --- a/drivers/raw/ioat/rte_ioat_rawdev.h > > +++ b/drivers/raw/ioat/rte_ioat_rawdev.h > > @@ -35,6 +35,7 @@ > > */ > > struct rte_ioat_rawdev_config { > > unsigned short ring_size; > > + bool hdls_enable; > > }; > > > You need a doxygen comment on the new structure member (and add to > existing one). While it's fairly clear what ring_size parameter should do= , the > hdls_enable one needs a proper explanation. >=20 > I also think you might want to investigate changing it to "hdls_disable" > so that the default zero-value is the current behaviour. Requiring it to = be set > as 1 means that existing code will likely recompile but fail to work. > For example, the ioat_rawdev_autotest fails on completion checks now.