From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id DD4942C17 for ; Thu, 14 Mar 2019 16:51:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5000; q=dns/txt; s=iport; t=1552578691; x=1553788291; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Q55VSEKhe2HlweKlQzeHngQ2Dscyd7LGNxv76sqdAmg=; b=GoOoZhvkLWSjBkjo1Wd9zG1nxeCuceOFhjzdUvhp6XFPB9lWbUg/H9du bB0Us2hyUs8HUaAVZ99zF8eNXKcuA+jT7s78B64py1U3WP3DJAyahG5yd z7suTKgyeSHh3Dgn6NSz463MF+X2eGLUHTrl6O91jjas1Re5miFoVpR5i E=; IronPort-PHdr: =?us-ascii?q?9a23=3AJ58edRSzgkSSGgCaxkAAazJCLtpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOiA6Fd5eU1lN9HCgOk8TE8H7NBXf?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAABYd4pc/4UNJK1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgTxQA4FcBAsnh1IDhFKKV4JXlwKBLhS?= =?us-ascii?q?BEANUCwEBLIRAAoRQIjQJDQEBAwEBCQEDAm0cDIVKAQEBAwEnEwYBATcBCwQ?= =?us-ascii?q?CAQgRBAEBHwkHMhQJCAIEDgUIhHgDDQgBonoCihSBbTOCeAEBBYUOGIIMCIE?= =?us-ascii?q?vAYssF4FAP4ERRoJMhGkagzmCJookJogZkWAJApM2k0ydZwIEAgQFAg4BAQW?= =?us-ascii?q?BRziBVnAVgyeCCoNug2uGaHIBgSeOdgEB?= X-IronPort-AV: E=Sophos;i="5.58,478,1544486400"; d="scan'208";a="450571943" Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 14 Mar 2019 15:51:30 +0000 Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id x2EFpUfg010745 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 14 Mar 2019 15:51:30 GMT Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 10:51:29 -0500 Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 10:51:29 -0500 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 14 Mar 2019 11:51:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8pTC0fKxnkxf2h0TI8WQ7si5lOc0UXZGLSIGBmeuGe4=; b=jDbxCpN4FMICAZsSwF+isq1ve3wLGUsjmDrqxarpyEt1xtMAE6sRmByr97W/StHBkuzPMNEsnPFiobYXkSDYtRZTTX8YtNIAiADSrUf+ddt0lVMEworz0h7JJjvo4oKnaMVaupzZJAJZkHA56J9VCjoZ/SV2efiRLjwPAheCcvo= Received: from CY4PR11MB1701.namprd11.prod.outlook.com (10.169.250.142) by CY4PR11MB1560.namprd11.prod.outlook.com (10.172.66.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.13; Thu, 14 Mar 2019 15:51:27 +0000 Received: from CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5]) by CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5%3]) with mapi id 15.20.1709.011; Thu, 14 Mar 2019 15:51:27 +0000 From: "David Harton (dharton)" To: "Zhang, Qi Z" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU1e5kNXcNBWC5l06s5kFHm55hj6YLJ4ZAgAAd1YCAAACRYA== Date: Thu, 14 Mar 2019 15:51:27 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dharton@cisco.com; x-originating-ip: [2001:420:c0c4:1002::e2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c4824cd-d1c8-41fb-8d08-08d6a894eb57 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR11MB1560; x-ms-traffictypediagnostic: CY4PR11MB1560: x-microsoft-antispam-prvs: x-forefront-prvs: 09760A0505 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(376002)(39860400002)(366004)(396003)(199004)(189003)(13464003)(54906003)(76176011)(229853002)(7696005)(93886005)(2906002)(6436002)(6246003)(4326008)(316002)(186003)(102836004)(53546011)(6506007)(25786009)(55016002)(106356001)(52536014)(14454004)(9686003)(33656002)(478600001)(99286004)(105586002)(8936002)(5660300002)(53936002)(7736002)(86362001)(305945005)(46003)(6116002)(256004)(11346002)(14444005)(6916009)(97736004)(446003)(486006)(81156014)(68736007)(71190400001)(8676002)(71200400001)(81166006)(74316002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR11MB1560; H:CY4PR11MB1701.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kI5PnqnIkT0sDXIB+bAwLlYj0Kjyyl9yTrdsA44KqlwrY6rJlFVP1tIHd5UF0PuZna0L5l+cAgZXfulYPMUxNGCpc5ZVkC8l4OKM/0O7+SHpkZr1xR4f6Gud6QN4H6vGHeTH2ieROQr7jvksSoCROkPplKW/b7Md4XdlBZwzj8ZYO92MVj3gYnKblhfHcgL1OgOCAMyB1Rl206ruAixOURWT++Alja9LejuH2G/W95SRpKJAqV8tpFWWFdsTts/Ro/vs/2POWss38GCxz0APo2XGQDve6nJ9fUmTs3F2l3T3sjIMkrrQWGLfX7zdOyAi1MJWu8htX9AmnnqhSCOJx68adUNB8s61tF4xxJRAhdDolFdoHerYobYunih37X7qi4WIn7dDk4mMvEU5gb9sDfPuIOl0c8eg9ediHzf25hE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4824cd-d1c8-41fb-8d08-08d6a894eb57 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2019 15:51:27.4852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1560 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com X-Outbound-Node: alln-core-11.cisco.com Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 15:51:32 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, March 14, 2019 11:14 AM > To: David Harton (dharton) > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 >=20 >=20 > > -----Original Message----- > > From: David Harton (dharton) [mailto:dharton@cisco.com] > > Sent: Thursday, March 14, 2019 9:38 PM > > To: David Harton (dharton) ; Zhang, Qi Z > > > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; dev@dpdk.org > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > ixgbevf > > > > Hi Qi, > > > > This patch was rejected with no feedback. > > > > Can you share why? >=20 > Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config = , > ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This look= s > like VLAN_FILTER AND VLAN_EXTEND offload is not supported and I didn't se= e > you reply for that, so I assume you agree with that. >=20 >=20 > > > > Without this patch users are not able to call the > > rte_eth_dev_vlan_filter() API for ixgbevf based ports because > > VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure(). >=20 > OK, seems vlan filter is able to be configured for ixgbevf, but I don't > know how this will work because vlan filter table needs to be enabled > first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK > PF, vlan filter will not work, maybe kernel PF driver will enable it by > default? Could you share more insight? I can't answer that but ixgbevf_vlan_filter_set() has been implemented for = quite some time and it can no longer be called since the new offload flags = are being enforced now. I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works = properly with the propose change (VLAN traffic flows) where it doesn't with= out it. >=20 > And same question to VLAN_EXTEND I actually don't care about extend but simply changed it because it seems t= o be in the same situation. I'm happy to leave it out of the patch if tha= t grants acceptance. Thanks, Dave >=20 >=20 > > > > Or, am I missing something? > > > > Thanks, > > Dave > > > > > -----Original Message----- > > > From: David Harton > > > Sent: Friday, March 08, 2019 3:35 PM > > > To: dev@dpdk.org > > > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > > > qi.z.zhang@intel.com; David Harton (dharton) > > > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > > ixgbevf > > > > > > ixgbevf vlan strip and extend capabilities were removed when > > > migrating to the bit flags implementation. > > > > > > Restoring the capbility to enable these offloads at configuration > time. > > > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > > Signed-off-by: David Harton > > > --- > > > > > > v2: removed unused function ixgbe_is_vf() > > > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > > > 1 file changed, 2 insertions(+), 21 deletions(-) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644 > > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter > > > *adapter, struct ixgbe_rx_queue *rxq) #endif } > > > > > > -static int > > > -ixgbe_is_vf(struct rte_eth_dev *dev) -{ > > > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > > > >dev_private); > > > - > > > - switch (hw->mac.type) { > > > - case ixgbe_mac_82599_vf: > > > - case ixgbe_mac_X540_vf: > > > - case ixgbe_mac_X550_vf: > > > - case ixgbe_mac_X550EM_x_vf: > > > - case ixgbe_mac_X550EM_a_vf: > > > - return 1; > > > - default: > > > - return 0; > > > - } > > > -} > > > - > > > uint64_t > > > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ -2853,15 > > > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > > > DEV_RX_OFFLOAD_TCP_CKSUM | > > > DEV_RX_OFFLOAD_KEEP_CRC | > > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > > DEV_RX_OFFLOAD_SCATTER; > > > > > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) > > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > > - > > > /* > > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > > > IOV > > > * mode. > > > -- > > > 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BFF6EA0096 for ; Thu, 14 Mar 2019 16:51:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6565C324D; Thu, 14 Mar 2019 16:51:33 +0100 (CET) Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id DD4942C17 for ; Thu, 14 Mar 2019 16:51:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5000; q=dns/txt; s=iport; t=1552578691; x=1553788291; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Q55VSEKhe2HlweKlQzeHngQ2Dscyd7LGNxv76sqdAmg=; b=GoOoZhvkLWSjBkjo1Wd9zG1nxeCuceOFhjzdUvhp6XFPB9lWbUg/H9du bB0Us2hyUs8HUaAVZ99zF8eNXKcuA+jT7s78B64py1U3WP3DJAyahG5yd z7suTKgyeSHh3Dgn6NSz463MF+X2eGLUHTrl6O91jjas1Re5miFoVpR5i E=; IronPort-PHdr: =?us-ascii?q?9a23=3AJ58edRSzgkSSGgCaxkAAazJCLtpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOiA6Fd5eU1lN9HCgOk8TE8H7NBXf?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAABYd4pc/4UNJK1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgTxQA4FcBAsnh1IDhFKKV4JXlwKBLhS?= =?us-ascii?q?BEANUCwEBLIRAAoRQIjQJDQEBAwEBCQEDAm0cDIVKAQEBAwEnEwYBATcBCwQ?= =?us-ascii?q?CAQgRBAEBHwkHMhQJCAIEDgUIhHgDDQgBonoCihSBbTOCeAEBBYUOGIIMCIE?= =?us-ascii?q?vAYssF4FAP4ERRoJMhGkagzmCJookJogZkWAJApM2k0ydZwIEAgQFAg4BAQW?= =?us-ascii?q?BRziBVnAVgyeCCoNug2uGaHIBgSeOdgEB?= X-IronPort-AV: E=Sophos;i="5.58,478,1544486400"; d="scan'208";a="450571943" Received: from alln-core-11.cisco.com ([173.36.13.133]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 14 Mar 2019 15:51:30 +0000 Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id x2EFpUfg010745 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 14 Mar 2019 15:51:30 GMT Received: from xhs-rcd-003.cisco.com (173.37.227.248) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 10:51:29 -0500 Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-003.cisco.com (173.37.227.248) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 10:51:29 -0500 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 14 Mar 2019 11:51:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8pTC0fKxnkxf2h0TI8WQ7si5lOc0UXZGLSIGBmeuGe4=; b=jDbxCpN4FMICAZsSwF+isq1ve3wLGUsjmDrqxarpyEt1xtMAE6sRmByr97W/StHBkuzPMNEsnPFiobYXkSDYtRZTTX8YtNIAiADSrUf+ddt0lVMEworz0h7JJjvo4oKnaMVaupzZJAJZkHA56J9VCjoZ/SV2efiRLjwPAheCcvo= Received: from CY4PR11MB1701.namprd11.prod.outlook.com (10.169.250.142) by CY4PR11MB1560.namprd11.prod.outlook.com (10.172.66.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.13; Thu, 14 Mar 2019 15:51:27 +0000 Received: from CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5]) by CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5%3]) with mapi id 15.20.1709.011; Thu, 14 Mar 2019 15:51:27 +0000 From: "David Harton (dharton)" To: "Zhang, Qi Z" CC: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU1e5kNXcNBWC5l06s5kFHm55hj6YLJ4ZAgAAd1YCAAACRYA== Date: Thu, 14 Mar 2019 15:51:27 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115334CA1F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dharton@cisco.com; x-originating-ip: [2001:420:c0c4:1002::e2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c4824cd-d1c8-41fb-8d08-08d6a894eb57 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR11MB1560; x-ms-traffictypediagnostic: CY4PR11MB1560: x-microsoft-antispam-prvs: x-forefront-prvs: 09760A0505 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(376002)(39860400002)(366004)(396003)(199004)(189003)(13464003)(54906003)(76176011)(229853002)(7696005)(93886005)(2906002)(6436002)(6246003)(4326008)(316002)(186003)(102836004)(53546011)(6506007)(25786009)(55016002)(106356001)(52536014)(14454004)(9686003)(33656002)(478600001)(99286004)(105586002)(8936002)(5660300002)(53936002)(7736002)(86362001)(305945005)(46003)(6116002)(256004)(11346002)(14444005)(6916009)(97736004)(446003)(486006)(81156014)(68736007)(71190400001)(8676002)(71200400001)(81166006)(74316002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR11MB1560; H:CY4PR11MB1701.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kI5PnqnIkT0sDXIB+bAwLlYj0Kjyyl9yTrdsA44KqlwrY6rJlFVP1tIHd5UF0PuZna0L5l+cAgZXfulYPMUxNGCpc5ZVkC8l4OKM/0O7+SHpkZr1xR4f6Gud6QN4H6vGHeTH2ieROQr7jvksSoCROkPplKW/b7Md4XdlBZwzj8ZYO92MVj3gYnKblhfHcgL1OgOCAMyB1Rl206ruAixOURWT++Alja9LejuH2G/W95SRpKJAqV8tpFWWFdsTts/Ro/vs/2POWss38GCxz0APo2XGQDve6nJ9fUmTs3F2l3T3sjIMkrrQWGLfX7zdOyAi1MJWu8htX9AmnnqhSCOJx68adUNB8s61tF4xxJRAhdDolFdoHerYobYunih37X7qi4WIn7dDk4mMvEU5gb9sDfPuIOl0c8eg9ediHzf25hE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4824cd-d1c8-41fb-8d08-08d6a894eb57 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2019 15:51:27.4852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1560 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com X-Outbound-Node: alln-core-11.cisco.com Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190314155127.EC59UogO0ino6q4a6C0plWxWzhXJGJiJtc_5eFNXJqQ@z> Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, March 14, 2019 11:14 AM > To: David Harton (dharton) > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 >=20 >=20 > > -----Original Message----- > > From: David Harton (dharton) [mailto:dharton@cisco.com] > > Sent: Thursday, March 14, 2019 9:38 PM > > To: David Harton (dharton) ; Zhang, Qi Z > > > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; dev@dpdk.org > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > ixgbevf > > > > Hi Qi, > > > > This patch was rejected with no feedback. > > > > Can you share why? >=20 > Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config = , > ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This look= s > like VLAN_FILTER AND VLAN_EXTEND offload is not supported and I didn't se= e > you reply for that, so I assume you agree with that. >=20 >=20 > > > > Without this patch users are not able to call the > > rte_eth_dev_vlan_filter() API for ixgbevf based ports because > > VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure(). >=20 > OK, seems vlan filter is able to be configured for ixgbevf, but I don't > know how this will work because vlan filter table needs to be enabled > first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK > PF, vlan filter will not work, maybe kernel PF driver will enable it by > default? Could you share more insight? I can't answer that but ixgbevf_vlan_filter_set() has been implemented for = quite some time and it can no longer be called since the new offload flags = are being enforced now. I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works = properly with the propose change (VLAN traffic flows) where it doesn't with= out it. >=20 > And same question to VLAN_EXTEND I actually don't care about extend but simply changed it because it seems t= o be in the same situation. I'm happy to leave it out of the patch if tha= t grants acceptance. Thanks, Dave >=20 >=20 > > > > Or, am I missing something? > > > > Thanks, > > Dave > > > > > -----Original Message----- > > > From: David Harton > > > Sent: Friday, March 08, 2019 3:35 PM > > > To: dev@dpdk.org > > > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > > > qi.z.zhang@intel.com; David Harton (dharton) > > > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for > > > ixgbevf > > > > > > ixgbevf vlan strip and extend capabilities were removed when > > > migrating to the bit flags implementation. > > > > > > Restoring the capbility to enable these offloads at configuration > time. > > > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > > Signed-off-by: David Harton > > > --- > > > > > > v2: removed unused function ixgbe_is_vf() > > > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > > > 1 file changed, 2 insertions(+), 21 deletions(-) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644 > > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter > > > *adapter, struct ixgbe_rx_queue *rxq) #endif } > > > > > > -static int > > > -ixgbe_is_vf(struct rte_eth_dev *dev) -{ > > > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > > > >dev_private); > > > - > > > - switch (hw->mac.type) { > > > - case ixgbe_mac_82599_vf: > > > - case ixgbe_mac_X540_vf: > > > - case ixgbe_mac_X550_vf: > > > - case ixgbe_mac_X550EM_x_vf: > > > - case ixgbe_mac_X550EM_a_vf: > > > - return 1; > > > - default: > > > - return 0; > > > - } > > > -} > > > - > > > uint64_t > > > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ -2853,15 > > > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > > > DEV_RX_OFFLOAD_TCP_CKSUM | > > > DEV_RX_OFFLOAD_KEEP_CRC | > > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > > DEV_RX_OFFLOAD_SCATTER; > > > > > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) > > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > > - > > > /* > > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > > > IOV > > > * mode. > > > -- > > > 2.19.1