From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id CBEA02B87 for ; Fri, 8 Mar 2019 13:39:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2973; q=dns/txt; s=iport; t=1552048740; x=1553258340; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=mJVQcy2pO2+1wrULXzPXVuNIGO9YYFjaQw86fV8pQT0=; b=X6VrSegN/U5y+RE+jifYaOxW7+a6PC9eoBCuCv1CFRst1sTL1WzZxiGP PNoNEIO5C0CwNGFtXyMURUlGHM5nAYx0vYdmgOUkl3F3RFeCWOEkepy50 c18GUt6OSdlEMWdsSl74bLTw51ah9CLcfGWQxtyT914Bx7L7wk5HVGjaq w=; IronPort-PHdr: =?us-ascii?q?9a23=3AClPkAxCMzoYK5bUPS+hRUyQJPHJ1sqjoPgMT9p?= =?us-ascii?q?ssgq5PdaLm5Zn5IUjD/qs13kTRU9Dd7PRJw6rNvqbsVHZIwK7JsWtKMfkuHw?= =?us-ascii?q?QAld1QmgUhBMCfDkiuIP7jdTA9GuxJVURu+DewNk0GUMs=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AEAAAsYoJc/51dJa1kGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBUQUBAQEBCwGBPFADgVwECyeHUAOEUIpjgleYJhSBEANUCwE?= =?us-ascii?q?BLIRAAoQ1IjQJDQEBAwEBBwEDAm0cDIVKAQEBBCcTBgEBOAsEAgEIEQQBAR8?= =?us-ascii?q?JBzIUCQgCBAESCIR4AxUBnwICihSBbTOCeAEBBYUEGIILCIEvAYsrF4FAP4F?= =?us-ascii?q?XgkyEaRqDOYImpCAJApMgkziKd5JBAgQCBAUCDQEBBYFHOCiBLnAVgyeCCoN?= =?us-ascii?q?ug2uGaHKBKI5wAQE?= X-IronPort-AV: E=Sophos;i="5.58,455,1544486400"; d="scan'208";a="242593759" Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2019 12:38:46 +0000 Received: from XCH-ALN-018.cisco.com (xch-aln-018.cisco.com [173.36.7.28]) by rcdn-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id x28CcjGT011731 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 8 Mar 2019 12:38:46 GMT Received: from xhs-aln-001.cisco.com (173.37.135.118) by XCH-ALN-018.cisco.com (173.36.7.28) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 8 Mar 2019 06:38:45 -0600 Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 8 Mar 2019 06:38:44 -0600 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 8 Mar 2019 06:38:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pKhjOU9rxC4aY+W7mdAjdpd/acJ85b2GtJ44N/MZA1k=; b=OmYBYyb0unn684WRQVf28rN6L07+FmhXHdpTFVBhcopY7S3F5gWxd7PPo+QWlPkjF+xzZVTAridp7662uBgQcnIWUPryo4xmuBiY0gZiMmArtDwGE6PJOvgXB8A2s7vav9sTfZKwjQapb6sB5/MDJwV/Hz9BmV4S5+7XdjMx8qY= Received: from CY4PR11MB1701.namprd11.prod.outlook.com (10.169.250.142) by CY4PR11MB1526.namprd11.prod.outlook.com (10.172.67.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.17; Fri, 8 Mar 2019 12:38:43 +0000 Received: from CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5]) by CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5%3]) with mapi id 15.20.1686.018; Fri, 8 Mar 2019 12:38:43 +0000 From: "David Harton (dharton)" To: "Zhao1, Wei" , "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef Thread-Index: AQHU1DCqntbUNjHtWEesvaYVpO9puaYBSdCAgABkUgA= Date: Fri, 8 Mar 2019 12:38:43 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dharton@cisco.com; x-originating-ip: [2001:420:2170:1264:9e:c249:dc23:778] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 386528ac-2ad7-471b-751e-08d6a3c2fffe x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR11MB1526; x-ms-traffictypediagnostic: CY4PR11MB1526: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; CY4PR11MB1526; 23:GbN4Hn66R42NhIAHMJmyVUkQjoo6slyS3b4AQyh8P?= =?us-ascii?Q?smoHPhMD+J1qZMzjhoPU3Ev5AWgamUJmkoGTqzIt6emvhADYzpZ+uJJvoflp?= =?us-ascii?Q?Ep5a+szkclynvQ3o62OWy5xEtNnNyUat48N7lSzX6U89wSrdCrIN6gLAz0Jm?= =?us-ascii?Q?0K2/2HjSCbe5n/nI2WodYWOw888xGlEIWvLnerK5gtfPvEnAttwMAFl7H6An?= =?us-ascii?Q?LrbtukgezInjpYuM+RzOeQMOIAq/yONT3fJEBIhxVSRLuHCwdUPhxP+TOTLy?= =?us-ascii?Q?hO9QsKQISyXw8ECYu0fWWJ0jZrDBYgiFWte3XgIzDZ6ujhseWmBKjhMIG7SQ?= =?us-ascii?Q?1RLaIM9aRhYPwLZq/jaRR8ovpvLvTnTkzPXiR9XTceyM8mQczNbQ8F4TdnPa?= =?us-ascii?Q?FyNFeFgXFrVRoIYc4qoY61JX38yj6b35vCsTFoZaSkBbXvyX2VG3A5Xscntl?= =?us-ascii?Q?hWCkcXCqoM5OKfi9ldDFhCaR55G6tAtXXGQDybnLzxmPndkeRLpK/KF60bVI?= =?us-ascii?Q?lmlEa/nEnwPnDWhRznYVudQ5dUemy9d0AFSzkc8uw75dszf08urdCuQB0Ti6?= =?us-ascii?Q?iJUqBh5aTWl5gUsGQ5JVlcYKhFg/OXXS+CYYkpXGzZVVzwuRNyGQxkLiIVcO?= =?us-ascii?Q?1Nnj+g1drRjaGrkgM2jWwjWL4v6JcGxWidtw/IXQNpBBS7M4Fk5/5RWVI76P?= =?us-ascii?Q?rd73sC6XIHuTQVnmzwU+Y9/9pGhXuIvbOEmC8xbhcjtKxWKhJpEQdohUfNpc?= =?us-ascii?Q?RILdFGgR9RCB6YKarnnpc2FRBfZS4z4p4Do5H/hg584DYzmFQ1Zma6gZ40+o?= =?us-ascii?Q?TjLJ+E026qCU0b+nkIvKvHt85jnRB/Puhvkp4sUh3SOsgEU/wgeH7jK3kGdV?= =?us-ascii?Q?z34TL3HqoQWV0phhrqlLrrYEGiMx+jvV3jCR/3e2Xv766FmsQBMzSbsH9DuJ?= =?us-ascii?Q?xzrbS1zPV07rV7LiOGU+jUtvfrmzWIgsScJVTzeocOYEPCx/BXr84oP1k6I8?= =?us-ascii?Q?QVv6+1G5PcDdYrDBDrKDju2W6EJibRr2Y7u/yygyPU3EM97OUy2GqoOK+CAD?= =?us-ascii?Q?8UzuEk7TexqclbxWntuaLj2etuaJ9+cB6JhKnoOZYuYRiFjc+eUwPcrfiV+O?= =?us-ascii?Q?OTVZY0FcsDLg4O0CcLmrGeYwgC4Ay/ga8NMnzM9zoSHDLFWcv8nBriksi8cX?= =?us-ascii?Q?Etuo/I7lNxgZtlz0G7wrBULZzSSIMzU58Sk?= x-microsoft-antispam-prvs: x-forefront-prvs: 0970508454 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(376002)(396003)(346002)(39860400002)(199004)(189003)(13464003)(5660300002)(106356001)(2906002)(6246003)(105586002)(9686003)(68736007)(476003)(74316002)(71190400001)(55016002)(478600001)(229853002)(52536013)(71200400001)(33656002)(25786009)(81166006)(86362001)(8676002)(53936002)(81156014)(99286004)(53546011)(6506007)(316002)(11346002)(6436002)(446003)(2501003)(97736004)(46003)(6116002)(76176011)(8936002)(110136005)(486006)(7696005)(186003)(14454004)(305945005)(7736002)(256004)(14444005)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR11MB1526; H:CY4PR11MB1701.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: p/S8GVqojsrctyWGDAfRY5Bxzykcvw+960c1rliAklD+CTAZK9n2S9VhXZJ9ubaLXfmj98AKFklqqXqB0AtHePsTJqdgtMmVO70eFT2rmwf7zBh4xr4YlSsWuuPXxE4fegUE5zlts0ZfpYjntd1BE+415+TJYt/5uA1opACklKDuU8fzLG7u4kRtuM77/WvfFe/UYSFIaXeQ7+ULqLFrMhSFZ2fp7MOtIhFemsfZM7m0fKAyoJ04ibJfh1AIj2NwoSBGls7mxPc4u+OIK+eSouhsDLR8whycIF/AzqcCo3loVOilOo8se3YyV1EPOkXNTlYlaq3z3r8FGU/wb4e+ANJzsQYxNChcnoy04VnS3PHsP06Sl0/0aU0HvwEIigBvbXaqxlbA+mt5bvxrN3jemmUOliSeyOd0v/NzGRTtb4Y= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 386528ac-2ad7-471b-751e-08d6a3c2fffe X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2019 12:38:43.2432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1526 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.28, xch-aln-018.cisco.com X-Outbound-Node: rcdn-core-6.cisco.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 12:39:01 -0000 Hi > -----Original Message----- > From: Zhao1, Wei > Sent: Friday, March 08, 2019 1:35 AM > To: David Harton (dharton) ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef >=20 > Hi, David Harton >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > > Sent: Wednesday, March 6, 2019 11:24 PM > > To: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, > > Konstantin > > Cc: David Harton > > Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > > ixgbvef > > > > ixgevf vlan strip and extend capabilities were removed when migrating > > to the bit flags implementation. > > > > Restoring the capbility to enable these offloads at configuration time. > > > > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > > Signed-off-by: David Harton > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..95c32257c 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev > > *dev) > > DEV_RX_OFFLOAD_TCP_CKSUM | > > DEV_RX_OFFLOAD_KEEP_CRC | > > DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER | > > + DEV_RX_OFFLOAD_VLAN_EXTEND | > > DEV_RX_OFFLOAD_SCATTER; > > >=20 > Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ? > It seems Ixgbevf do not support this configuration. Only pf does. > But this ixgbe_get_rx_port_offloads () is used by both vf and pf. I'm personally happy only to move FILTER but I noticed that EXTEND used to = be 'supported' and I see references to it elsewhere in ixgbevf code: ixgbevf_dev_start() /* Set HW strip */ mask =3D ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK | ETH_VLAN_EXTEND_MASK; ixgbe_vlan_offload_config() if (mask & ETH_VLAN_EXTEND_MASK) { if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) ixgbe_vlan_hw_extend_enable(dev); else ixgbe_vlan_hw_extend_disable(dev); } These uses imply that EXTEND should be supported, correct? Thanks, Dave >=20 >=20 > > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; > > > > - if (ixgbe_is_vf(dev) =3D=3D 0) > > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > - DEV_RX_OFFLOAD_VLAN_EXTEND); > > - > > /* > > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > > IOV > > * mode. > > -- > > 2.19.1