From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) by dpdk.org (Postfix) with ESMTP id 8874E1E2F for ; Thu, 14 Mar 2019 14:37:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2611; q=dns/txt; s=iport; t=1552570654; x=1553780254; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P41uZHpxAWHEO9FUp24mYo71SJs9fssVgbdSlrDxH2w=; b=kfzfTf16Y73XnAP5DyVfLt0KTNo/DOvsqgBlac6MwCGgLk6VO1heq/m+ e7mFeio1+0kQpX1/ijuxTNK67jsUcIUK1J/fbtYtmW64ZPtenqH117CB4 EVODSNAsVd/6auPTeMPQhz0wVgwe8yYeWyBDkidLrWkJRLciNC6abxXbp c=; IronPort-PHdr: =?us-ascii?q?9a23=3Abc8XTxNOb37eotfqiDUl6mtXPHoupqn0MwgJ65?= =?us-ascii?q?Eul7NJdOG58o//OFDEu60/l0fHCIPc7f8My/HbtaztQyQh2d6AqzhDFf4ETB?= =?us-ascii?q?oZkYMTlg0kDtSCDBj3LPfwcys8NM9DT1RiuXq8NBsdFQ=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAACyWIpc/5pdJa1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgTxQA4FcBAsVEodSA4RSilWCV5cCgS4?= =?us-ascii?q?UgRADVAsBASyEQAKEUCI0CQ0BAQMBAQkBAwJtHAyFSgEBAQQnEwYBATcBCwQ?= =?us-ascii?q?CAQgRBAEBHxAyHQgCBAENBQiEeAMVAaMQAooUgW0zgngBAQWFChiCDAiBLwG?= =?us-ascii?q?LLBeBQD+BV4JMhGkagzmCJookJogZkWAJApM2k0yKf5JoAgQCBAUCDgEBBYF?= =?us-ascii?q?HOIFWcBWDJ4IKg26Da4ZocgGBJ452AQE?= X-IronPort-AV: E=Sophos;i="5.58,478,1544486400"; d="scan'208";a="245065698" Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 14 Mar 2019 13:37:33 +0000 Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by rcdn-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id x2EDbXkW012870 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 14 Mar 2019 13:37:33 GMT Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 08:37:32 -0500 Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 08:37:32 -0500 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 14 Mar 2019 08:37:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zx+zfFCwcSgUo5HH6Cj6n8SdHJhZ+s7uhz8db60MjHM=; b=LKr2h7+P2HjiRD24Okk1D8TO/K9HVmwJAevPywQ5xa9Wnbm/3Qan8jxdzMNNwkW8eh5CjAc6IKpURXj4xCOXIQfBGPVu1RoUkXmFY5bl8P0ZfAkjQdaswSNx4ClWQozUayo1NiooRRr6PVkQiV8nlOcqXX3Q+BynkfPxwGEOZng= Received: from CY4PR11MB1701.namprd11.prod.outlook.com (10.169.250.142) by CY4PR11MB1541.namprd11.prod.outlook.com (10.172.68.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Thu, 14 Mar 2019 13:37:31 +0000 Received: from CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5]) by CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5%3]) with mapi id 15.20.1709.011; Thu, 14 Mar 2019 13:37:31 +0000 From: "David Harton (dharton)" To: "David Harton (dharton)" , "qi.z.zhang@intel.com" CC: "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU1e5kNXcNBWC5l06s5kFHm55hj6YLJ4ZA Date: Thu, 14 Mar 2019 13:37:31 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> In-Reply-To: <20190308203430.31742-1-dharton@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dharton@cisco.com; x-originating-ip: [2001:420:c0c4:1002::e2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56de6e6d-b278-4118-0f51-08d6a8823534 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR11MB1541; x-ms-traffictypediagnostic: CY4PR11MB1541: x-microsoft-antispam-prvs: x-forefront-prvs: 09760A0505 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(376002)(396003)(366004)(39860400002)(346002)(189003)(199004)(13464003)(4326008)(5660300002)(11346002)(446003)(14444005)(256004)(486006)(305945005)(476003)(33656002)(7736002)(6436002)(6246003)(53936002)(74316002)(52536014)(25786009)(9686003)(55016002)(316002)(54906003)(110136005)(99286004)(6116002)(2906002)(6506007)(105586002)(53546011)(106356001)(76176011)(186003)(229853002)(97736004)(46003)(2501003)(7696005)(8936002)(71190400001)(81156014)(71200400001)(102836004)(8676002)(68736007)(86362001)(478600001)(14454004)(81166006)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR11MB1541; H:CY4PR11MB1701.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kFF/SuaSE1j37WXBGts6VuH4fwGcK0lbAtrwVt2TPekDpyk3KlISJNMX0f+Jo+dbVttvXt+dJ0LvW9u4Q8AUzPtiXTbmo8Ghihor+9YYfdbC5qdBpU6inKa2X1twhZOChl/K5vEbfjd1ULNaj0sgDJuJv8eifqzRaAh+y4afdUqHH/CdtqC9zo1q+Gm5lMcdiCTdBlKc2Hgv3edrIbQTXJ9K3YMJqgL/0x4bINib48iX72Wo73eXo/3o/E3T9DxliRxHk6fG+hC20pmbNhdb8IZinet9/HMcm8NShP3ulzA63JGwdUMHv3E/UThD2pTR0ZvosyIfZgbl/TDTrW0hAsHep1DxvHvIG9ubYpSR6T17bvhAzu9ePIBzyKNdRHG1BC3JBGVlIr7MCF05ANtf5Tqmeb+qrlHEWBu1q5IwPjc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 56de6e6d-b278-4118-0f51-08d6a8823534 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2019 13:37:31.0342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1541 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.15, xch-aln-005.cisco.com X-Outbound-Node: rcdn-core-3.cisco.com Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 13:37:35 -0000 Hi Qi, This patch was rejected with no feedback. Can you share why? Without this patch users are not able to call the rte_eth_dev_vlan_filter()= API for ixgbevf based ports because VLAN_FILTER cannot be enabled when cal= ling rte_eth_dev_configure(). Or, am I missing something? Thanks, Dave > -----Original Message----- > From: David Harton > Sent: Friday, March 08, 2019 3:35 PM > To: dev@dpdk.org > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > qi.z.zhang@intel.com; David Harton (dharton) > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 > ixgbevf vlan strip and extend capabilities were removed when migrating to > the bit flags implementation. >=20 > Restoring the capbility to enable these offloads at configuration time. >=20 > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > Signed-off-by: David Harton > --- >=20 > v2: removed unused function ixgbe_is_vf() >=20 > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > 1 file changed, 2 insertions(+), 21 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter= , > struct ixgbe_rx_queue *rxq) #endif } >=20 > -static int > -ixgbe_is_vf(struct rte_eth_dev *dev) > -{ > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > - > - switch (hw->mac.type) { > - case ixgbe_mac_82599_vf: > - case ixgbe_mac_X540_vf: > - case ixgbe_mac_X550_vf: > - case ixgbe_mac_X550EM_x_vf: > - case ixgbe_mac_X550EM_a_vf: > - return 1; > - default: > - return 0; > - } > -} > - > uint64_t > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ -2853,15 > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > DEV_RX_OFFLOAD_TCP_CKSUM | > DEV_RX_OFFLOAD_KEEP_CRC | > DEV_RX_OFFLOAD_JUMBO_FRAME | > + DEV_RX_OFFLOAD_VLAN_FILTER | > + DEV_RX_OFFLOAD_VLAN_EXTEND | > DEV_RX_OFFLOAD_SCATTER; >=20 > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; >=20 > - if (ixgbe_is_vf(dev) =3D=3D 0) > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > - DEV_RX_OFFLOAD_VLAN_EXTEND); > - > /* > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > IOV > * mode. > -- > 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2C4A0A0096 for ; Thu, 14 Mar 2019 14:37:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F9B1374E; Thu, 14 Mar 2019 14:37:37 +0100 (CET) Received: from alln-iport-8.cisco.com (alln-iport-8.cisco.com [173.37.142.95]) by dpdk.org (Postfix) with ESMTP id 8874E1E2F for ; Thu, 14 Mar 2019 14:37:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2611; q=dns/txt; s=iport; t=1552570654; x=1553780254; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=P41uZHpxAWHEO9FUp24mYo71SJs9fssVgbdSlrDxH2w=; b=kfzfTf16Y73XnAP5DyVfLt0KTNo/DOvsqgBlac6MwCGgLk6VO1heq/m+ e7mFeio1+0kQpX1/ijuxTNK67jsUcIUK1J/fbtYtmW64ZPtenqH117CB4 EVODSNAsVd/6auPTeMPQhz0wVgwe8yYeWyBDkidLrWkJRLciNC6abxXbp c=; IronPort-PHdr: =?us-ascii?q?9a23=3Abc8XTxNOb37eotfqiDUl6mtXPHoupqn0MwgJ65?= =?us-ascii?q?Eul7NJdOG58o//OFDEu60/l0fHCIPc7f8My/HbtaztQyQh2d6AqzhDFf4ETB?= =?us-ascii?q?oZkYMTlg0kDtSCDBj3LPfwcys8NM9DT1RiuXq8NBsdFQ=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAACyWIpc/5pdJa1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgTxQA4FcBAsVEodSA4RSilWCV5cCgS4?= =?us-ascii?q?UgRADVAsBASyEQAKEUCI0CQ0BAQMBAQkBAwJtHAyFSgEBAQQnEwYBATcBCwQ?= =?us-ascii?q?CAQgRBAEBHxAyHQgCBAENBQiEeAMVAaMQAooUgW0zgngBAQWFChiCDAiBLwG?= =?us-ascii?q?LLBeBQD+BV4JMhGkagzmCJookJogZkWAJApM2k0yKf5JoAgQCBAUCDgEBBYF?= =?us-ascii?q?HOIFWcBWDJ4IKg26Da4ZocgGBJ452AQE?= X-IronPort-AV: E=Sophos;i="5.58,478,1544486400"; d="scan'208";a="245065698" Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by alln-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 14 Mar 2019 13:37:33 +0000 Received: from XCH-ALN-005.cisco.com (xch-aln-005.cisco.com [173.36.7.15]) by rcdn-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id x2EDbXkW012870 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 14 Mar 2019 13:37:33 GMT Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-005.cisco.com (173.36.7.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 08:37:32 -0500 Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Mar 2019 08:37:32 -0500 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 14 Mar 2019 08:37:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zx+zfFCwcSgUo5HH6Cj6n8SdHJhZ+s7uhz8db60MjHM=; b=LKr2h7+P2HjiRD24Okk1D8TO/K9HVmwJAevPywQ5xa9Wnbm/3Qan8jxdzMNNwkW8eh5CjAc6IKpURXj4xCOXIQfBGPVu1RoUkXmFY5bl8P0ZfAkjQdaswSNx4ClWQozUayo1NiooRRr6PVkQiV8nlOcqXX3Q+BynkfPxwGEOZng= Received: from CY4PR11MB1701.namprd11.prod.outlook.com (10.169.250.142) by CY4PR11MB1541.namprd11.prod.outlook.com (10.172.68.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Thu, 14 Mar 2019 13:37:31 +0000 Received: from CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5]) by CY4PR11MB1701.namprd11.prod.outlook.com ([fe80::8c89:290d:9989:b6a5%3]) with mapi id 15.20.1709.011; Thu, 14 Mar 2019 13:37:31 +0000 From: "David Harton (dharton)" To: "David Harton (dharton)" , "qi.z.zhang@intel.com" CC: "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf Thread-Index: AQHU1e5kNXcNBWC5l06s5kFHm55hj6YLJ4ZA Date: Thu, 14 Mar 2019 13:37:31 +0000 Message-ID: References: <20190306152355.1697-1-dharton@cisco.com> <20190308203430.31742-1-dharton@cisco.com> In-Reply-To: <20190308203430.31742-1-dharton@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dharton@cisco.com; x-originating-ip: [2001:420:c0c4:1002::e2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56de6e6d-b278-4118-0f51-08d6a8823534 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CY4PR11MB1541; x-ms-traffictypediagnostic: CY4PR11MB1541: x-microsoft-antispam-prvs: x-forefront-prvs: 09760A0505 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(376002)(396003)(366004)(39860400002)(346002)(189003)(199004)(13464003)(4326008)(5660300002)(11346002)(446003)(14444005)(256004)(486006)(305945005)(476003)(33656002)(7736002)(6436002)(6246003)(53936002)(74316002)(52536014)(25786009)(9686003)(55016002)(316002)(54906003)(110136005)(99286004)(6116002)(2906002)(6506007)(105586002)(53546011)(106356001)(76176011)(186003)(229853002)(97736004)(46003)(2501003)(7696005)(8936002)(71190400001)(81156014)(71200400001)(102836004)(8676002)(68736007)(86362001)(478600001)(14454004)(81166006)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR11MB1541; H:CY4PR11MB1701.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kFF/SuaSE1j37WXBGts6VuH4fwGcK0lbAtrwVt2TPekDpyk3KlISJNMX0f+Jo+dbVttvXt+dJ0LvW9u4Q8AUzPtiXTbmo8Ghihor+9YYfdbC5qdBpU6inKa2X1twhZOChl/K5vEbfjd1ULNaj0sgDJuJv8eifqzRaAh+y4afdUqHH/CdtqC9zo1q+Gm5lMcdiCTdBlKc2Hgv3edrIbQTXJ9K3YMJqgL/0x4bINib48iX72Wo73eXo/3o/E3T9DxliRxHk6fG+hC20pmbNhdb8IZinet9/HMcm8NShP3ulzA63JGwdUMHv3E/UThD2pTR0ZvosyIfZgbl/TDTrW0hAsHep1DxvHvIG9ubYpSR6T17bvhAzu9ePIBzyKNdRHG1BC3JBGVlIr7MCF05ANtf5Tqmeb+qrlHEWBu1q5IwPjc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 56de6e6d-b278-4118-0f51-08d6a8823534 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2019 13:37:31.0342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1541 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.15, xch-aln-005.cisco.com X-Outbound-Node: rcdn-core-3.cisco.com Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190314133731.zeUI8T4UIh9Sm76qFqS9clBJREknZbq5LAT-80RciNI@z> Hi Qi, This patch was rejected with no feedback. Can you share why? Without this patch users are not able to call the rte_eth_dev_vlan_filter()= API for ixgbevf based ports because VLAN_FILTER cannot be enabled when cal= ling rte_eth_dev_configure(). Or, am I missing something? Thanks, Dave > -----Original Message----- > From: David Harton > Sent: Friday, March 08, 2019 3:35 PM > To: dev@dpdk.org > Cc: wenzhuo.lu@intel.com; konstantin.ananyev@intel.com; > qi.z.zhang@intel.com; David Harton (dharton) > Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >=20 > ixgbevf vlan strip and extend capabilities were removed when migrating to > the bit flags implementation. >=20 > Restoring the capbility to enable these offloads at configuration time. >=20 > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") > Signed-off-by: David Harton > --- >=20 > v2: removed unused function ixgbe_is_vf() >=20 > drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++--------------------- > 1 file changed, 2 insertions(+), 21 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter= , > struct ixgbe_rx_queue *rxq) #endif } >=20 > -static int > -ixgbe_is_vf(struct rte_eth_dev *dev) > -{ > - struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > - > - switch (hw->mac.type) { > - case ixgbe_mac_82599_vf: > - case ixgbe_mac_X540_vf: > - case ixgbe_mac_X550_vf: > - case ixgbe_mac_X550EM_x_vf: > - case ixgbe_mac_X550EM_a_vf: > - return 1; > - default: > - return 0; > - } > -} > - > uint64_t > ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev) { @@ -2853,15 > +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) > DEV_RX_OFFLOAD_TCP_CKSUM | > DEV_RX_OFFLOAD_KEEP_CRC | > DEV_RX_OFFLOAD_JUMBO_FRAME | > + DEV_RX_OFFLOAD_VLAN_FILTER | > + DEV_RX_OFFLOAD_VLAN_EXTEND | > DEV_RX_OFFLOAD_SCATTER; >=20 > if (hw->mac.type =3D=3D ixgbe_mac_82598EB) > offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP; >=20 > - if (ixgbe_is_vf(dev) =3D=3D 0) > - offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER | > - DEV_RX_OFFLOAD_VLAN_EXTEND); > - > /* > * RSC is only supported by 82599 and x540 PF devices in a non-SR- > IOV > * mode. > -- > 2.19.1