From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 543EBA04BA; Sun, 4 Oct 2020 20:29:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87E9F1B74B; Sun, 4 Oct 2020 20:29:29 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DA3FA1B708 for ; Sun, 4 Oct 2020 20:29:26 +0200 (CEST) IronPort-SDR: FDNokbuJ6rj4z4SE1l7Cr4rwv3Mn/vJiQ48DTbE7mep4jeM8Ia9kgOXanq10WH/IxpDkNUDYxw Jm5Sy/nRik5w== X-IronPort-AV: E=McAfee;i="6000,8403,9764"; a="248037015" X-IronPort-AV: E=Sophos;i="5.77,335,1596524400"; d="scan'208";a="248037015" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2020 11:29:19 -0700 IronPort-SDR: o0WmiTY3kD8zN1pPl0WeaXxTxhlamTKqP8N23WzwutbJefEmvg3ZsEAxm3CMMUZS8g2e5zcThk uJ2y1Tmja32w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,335,1596524400"; d="scan'208";a="521094616" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 04 Oct 2020 11:29:18 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 4 Oct 2020 11:29:18 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 4 Oct 2020 11:29:17 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 4 Oct 2020 11:29:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 4 Oct 2020 11:29:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+s3dVhRYuHIP5rJ1LhZFRJwJGmlnhdM2SNHnAkUk+C8sES6ihJ+S+jdQ24LTtHE+/YJfH7eI/1xQFCFV4eqMsvC7OsUnjKYtf9/tBwMZrvhDVG5vkGvI5yWbuF8VOqVOQdp/pHOBzUy5BMfZkOpCv9X0woJ58VWt0vewDGcxbEgtXSBJd3ZWaA2m1llkWDGP8NIuaV0gj1sr53KVBjE/2A6mq4ELTHeFrkLmD1iESA73jtz+Ae775rkfh8XIdmS5HyePAMWEcU94JVaKHSVDqQR3DKhkwHebpam4qcHx3nLATiArgvPlftvRrCTPfxUP8XbIGTcqY//gTFjHMXXpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Db2N4zjTzZsoiE1miZRXYE1l+kAcxsB+JAAfa0Z7r6g=; b=RHWgycIVsvYxC0AY7Omj9gvHcx+pL9QkEJWxRg5JjQUl/fwd7eQ/isK2nfLyeCBOi8gzKMLCJpb/lpSBW0/3Y55g7K97/B8Y7ZzDBXMPgpS9d7cAA96HjicFazdFNGVBf4mPb3nnfYRcRg2n27cGp2pjYjgmTXA7NtkCHfos9loDSkUFSqjvdcexd9J+EsJTxeU9YIQGddzD9nj1b2+7x4xkycwMOAdCpbAHXFLJEtiRkoAjhzIQKdLutNhmaeKz84buzmzaoX3z5znz3LMo9pvrjdKJbO13al3bPvo6fpokF7nITR+/7gujybK1bkX8K0JAwcpSroTfTKcVl2iiTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Db2N4zjTzZsoiE1miZRXYE1l+kAcxsB+JAAfa0Z7r6g=; b=lgsFxNwza4qQkqHgXQOVHuLhzqSoN1tmA2e/4op9nsG40pqZrifdmPRvP3CnjP8xHq6lfOWsHrYbfPmfo17JF6UwK+iZroI5yS5sVmth4WZOgDNQ85tcIhiQNehaT7Ot8Y4bd7QQWXCSqZhWi9YnRjBjR1urNt33IddXSfKRz50= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR11MB0039.namprd11.prod.outlook.com (2603:10b6:910:76::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.19; Sun, 4 Oct 2020 18:28:58 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390%4]) with mapi id 15.20.3433.043; Sun, 4 Oct 2020 18:28:58 +0000 From: "Dumitrescu, Cristian" To: Raslan Darawsheh , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v7 32/42] pipeline: add SWX pipeline specification file Thread-Index: AQHWl95KEJG4FeGBZ0KIvvZ+Q54KmamHFmyAgACwwJA= Date: Sun, 4 Oct 2020 18:28:58 +0000 Message-ID: References: <20200930063416.68428-2-cristian.dumitrescu@intel.com> <20201001102010.36861-1-cristian.dumitrescu@intel.com> <20201001102010.36861-33-cristian.dumitrescu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.102.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2742a0f7-a4ce-4bad-7375-08d868935be5 x-ms-traffictypediagnostic: CY4PR11MB0039: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:785; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Ry69qRmMx61aHiXyk0oOTjU/uZevcYkdfNatRlmm/PKRHTBclyaye/uZQav74tAUDSolSESoqYIQfAOg4s0xyd6k8+5o/uZuqUFTTxFd+mhHj73/6VxXfs8WccUl+ZnH6+EyHAjwI0mVGD3/L/sMBSzQJbGVe/K4F7vClkKaESK5LjkaytO8Ln9wHbQNe6EQdagtDYSGM8YmJy04l9Miwvs+bTJS2Rl0e5rcUiKdphFEGhCqOTzmNpuFk2OLjbRlcoA7hjzbFG3Vg2SGyBMpzFo6xxGAl/eFkyZqRJiGs4mSZB60UBR0AjS6tPDcUNphQcTeeA2vfZGchOENjLyIVpyqmnM3r21WqzT6qeWg8eg9cbU0RIDdrBMGEtRW4iIBrifQipmoAFQ0GuSfxUV/ClZnjE1pGT1QsmPnWhruQrYfpaMrgWf9aNkGiOrkuDsMeU9fbJMnPeqGuIpwtvtPQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(7696005)(66446008)(53546011)(8936002)(83380400001)(66476007)(26005)(71200400001)(478600001)(33656002)(66946007)(66556008)(64756008)(76116006)(55016002)(9686003)(186003)(316002)(2906002)(966005)(86362001)(52536014)(110136005)(5660300002)(4326008)(54906003)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: rydp8GBwZOo1qZJhs4q7l2n4oyQ9unCEY08mj/0Ww/QNoMvmUodW0zgO4FOX6dtzeNf4tUvoaUDjFjgNX6ElJe6at3a9G8ENgDRhY4QpCdVxSUQqSkiceL26FX0bLK6TMkC99J0GF4HO9Gb1YI5Pvw/eHpHPLeKmSbsYetFWwyEPJpuimNH/FPDWzOOxPe0d+2U6YXXUFJE0C3W209JMjTvr5PK0e2O7N5xJXw02MTtI4K0qxVmfeATZJNOl5o5qZhTeQxR+ktMxrjH9MFzB6h7u6gldbeEX5zU91cdxoYLZ4OE3rfMfLD1RfHxH5NNmLqFFAeFNCDdewNu2QbIS7juHDBx8iC/FsWW1lCjxiWxUvCp3ecPWCS6CKAcd6Yo/KtT2CauLJIc8MgASpU05LY6ssO5Dmy2YX6sVUI0ldRnaeXlXdAwZkH7fOlXIwJ/GbPwRui2DOSNY0lJ1VQ3oyl/05/IkvZKD12qEwNUHfgpCxZt3qhWtyJEL6Od/eoTEm244c+u+92J8cMk6Bm/V+F2BsRL8uOH54oBCljtq4KP3o30ryfvPo/BNaZvc9k/UXtCTgVNu9S58oBd/wmRscyYSNaBpRsyQQznWUFDcN/9gCPMWJrXCeB+V/fCciw4jNA/sbnEhZAG1IxFZsWWJEg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2742a0f7-a4ce-4bad-7375-08d868935be5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2020 18:28:58.1301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iYjXMSYoyY7GyE7esuEqh4ABS9qsFeg8fpq8NvS84o/3P1nr4LSJxdJTrlsWgpNv4+rF1hvUuKtjErAn0AWy3MLuSx5Qb8oiEY65ZS2iwf4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB0039 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 32/42] pipeline: add SWX pipeline specification file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Raslan Darawsheh > Sent: Sunday, October 4, 2020 8:51 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; > david.marchand@redhat.com > Subject: RE: [dpdk-dev] [PATCH v7 32/42] pipeline: add SWX pipeline > specification file >=20 > Hi, >=20 > Resending to reply on the correct version, >=20 > > -----Original Message----- > > From: dev On Behalf Of Cristian Dumitrescu > > Sent: Wednesday, September 30, 2020 9:34 AM > > To: dev@dpdk.org > > Cc: NBU-Contact-Thomas Monjalon ; > > david.marchand@redhat.com > > Subject: [dpdk-dev] [PATCH v6 32/42] pipeline: add SWX pipeline > > specification file > > > > Add support for building the SWX pipeline based on specification file > > with syntax aligned to the P4 language. The specification file may be > > generated by the P4C compiler in the future. > > > > Signed-off-by: Cristian Dumitrescu > > --- > > lib/librte_pipeline/meson.build | 1 + > > lib/librte_pipeline/rte_pipeline_version.map | 1 + > > lib/librte_pipeline/rte_swx_pipeline.h | 26 + > > lib/librte_pipeline/rte_swx_pipeline_spec.c | 1439 > ++++++++++++++++++ > > 4 files changed, 1467 insertions(+) > > create mode 100644 lib/librte_pipeline/rte_swx_pipeline_spec.c > > > > diff --git a/lib/librte_pipeline/meson.build > b/lib/librte_pipeline/meson.build > > index be1d9c3a4..65c1a8d6a 100644 > > --- a/lib/librte_pipeline/meson.build > > +++ b/lib/librte_pipeline/meson.build >=20 > Seems like this patch introduced a new failure in compilation as followin= g: >=20 > ./../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:216:15: error: > implicit declaration of function 'reallocarray'; did you mean 'realloc'? = [- > Werror=3Dimplicit-function-declaration] > new_fields =3D reallocarray(s->fields, > ^~~~~~~~~~~~ > realloc > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:216:15: error= : > nested extern declaration of 'reallocarray' [-Werror=3Dnested-externs] > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:216:13: error= : > assignment makes pointer from integer without a cast [-Werror=3Dint- > conversion] > new_fields =3D reallocarray(s->fields, > ^ > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c: In function > 'action_block_parse': > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:455:19: error= : > assignment makes pointer from integer without a cast [-Werror=3Dint- > conversion] > new_instructions =3D reallocarray(s->instructions, > ^ > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c: In function > 'table_key_block_parse': > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:623:13: error= : > assignment makes pointer from integer without a cast [-Werror=3Dint- > conversion] > new_fields =3D reallocarray(s->params.fields, > ^ > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c: In function > 'table_actions_block_parse': > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:703:19: error= : > assignment makes pointer from integer without a cast [-Werror=3Dint- > conversion] > new_action_names =3D reallocarray(s->params.action_names, > ^ > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c: In function > 'apply_block_parse': > ../../root/dpdk/lib/librte_pipeline/rte_swx_pipeline_spec.c:1022:19: erro= r: > assignment makes pointer from integer without a cast [-Werror=3Dint- > conversion] > new_instructions =3D reallocarray(s->instructions, > ^ > cc1: all warnings being treated as errors > [502/2328] Compiling C object > lib/librte_vhost.a.p/librte_vhost_vhost_crypto.c.o > ninja: build stopped: subcommand failed. >=20 > This is reproducible in the following environment: > ARCH: aarch64 > CC: gcc > OS: Fedora 32 (Container Image) > Kernel: 4.4.0-104-generic > GCC(aarch64): aarch64-linux-gnu-gcc (Linaro GCC 7.1-2017.08) 7.1.= 1 > 20170707 >=20 > Can you kindly help with providing a fix for it ? >=20 > Kindest regards > Raslan Darawsheh > [Raslan Darawsheh] Hi Raslan, This issue was already fixed by David's patch [1] which was already applied= last Fri. Please update to the latest code and let us know if any issues. This issue is taking place when glibc version is older than 2.26, i.e. olde= r than 2017. Regards, Cristian [1] http://patches.dpdk.org/patch/79525/