From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1A12A04E1; Tue, 22 Sep 2020 11:15:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B34A01D905; Tue, 22 Sep 2020 11:15:08 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7F3C41D5D0 for <dev@dpdk.org>; Tue, 22 Sep 2020 11:15:06 +0200 (CEST) IronPort-SDR: sV/xL8Jbd4gcm3K1p4JgX5NMSEsRiOvKmU7urAbtXmGsZSF67+T22a4hTQtpo/B8ZC03eTEerl PPOmCNmnqJKg== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="140570784" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="140570784" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 02:15:05 -0700 IronPort-SDR: wQkyhTPNRurG5yR2WkQHZSG2jx7XLLfOb8TRVsmFt1ntgJsfiFn9rbO1SKhDZMtatVwUuhx8XI jJoX8ZOnE8kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="341953037" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 22 Sep 2020 02:15:05 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 02:15:05 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 02:15:04 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Sep 2020 02:15:04 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.57) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Sep 2020 02:15:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEo262yuLo/xsOcmUrYIzJZxYnxo4j1UtDES+hq87FBTKqpVV602unntZ02/CXylPdhWcZkAwyvHaDqh7QbBG8P0rqC1vedRmv63zwxD0SUivMPxoQaOVlcv6Vh1i6vhG8VzfYi/8srFZSM0MbY1t0ZqQqN0kYQGQ9WVfpPyQVEnaWmXzNT1DISyeZofyUtEzYiZZXcvlqEXsERClTI480vseYHYJgzRqgYxM162amogL0Qcsf3hejn3xH331jRnBS3/sptLxf9Fi/b6TmX+wf7voXP/LxsbuB7FtBpO2tRAe6eP9olRyio0lFDQCZo13W0IKr2MbfbMLswrloUAxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bz86AvJJ15FHb0fT9v0vyp7mZr8AelZlYD7AOVFvpJ0=; b=loYCZTJSyJeQuLyxx6UtnxIxOg8VhBEAPdhzKe/EkGxlF//ltOBwfuSvWBfACC92Jo5BCTlCWQIxx2Y2LsNMzd8XC/Q9U3FKox9XoStDm59iXoCF/QULIA05S4FYPeNbu333jwA4SDLMnvOxAsOqR9/epTgjPTUoeaypPSOijvtN+a+k98l9BHdODUuYK+TEbtDmgPjkn/6Z/hgPg6blV2KOM5Vxx44XHhUuL1ZjtglhcObczHmqYAyljAQP5rm3Nx1QuKxU7hN7fSaMS0jaMm4OfCrVU/dgp8yHafrujKI7FTKyAd1uxkSAPN7XEwP8msys4wu1JDJKwt0XbDa0zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bz86AvJJ15FHb0fT9v0vyp7mZr8AelZlYD7AOVFvpJ0=; b=EJWQZvwKbJ2WS0wS0DSB/tpN/RzVkykn3dWRjicGV3r/UUORERSCa1/dVtATTKEqLskhocFGbPQMrqR4/c/VdBJL3qIoF1c1+ojWMQxn6TwG0Vt6mj+w8DVME07SHJ5crsdQOc0QIGXX92xpsVfH4+KaLbEjCRE3cNwd+LyWPow= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR11MB1701.namprd11.prod.outlook.com (2603:10b6:903:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Tue, 22 Sep 2020 09:14:57 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390%4]) with mapi id 15.20.3391.026; Tue, 22 Sep 2020 09:14:56 +0000 From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> To: "Power, Ciara" <ciara.power@intel.com>, Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> Thread-Topic: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides Thread-Index: AQHWkDJ68vvu9hn0/EqJ36iU+5V1XKlzcrfwgADkwYCAAAkbkA== Date: Tue, 22 Sep 2020 09:14:56 +0000 Message-ID: <CY4PR11MB17022A166994A7B5F7657678EB3B0@CY4PR11MB1702.namprd11.prod.outlook.com> References: <20200903152717.42095-23-ciara.power@intel.com> <C5H285QL88G1.16CHZIFPFTQ8S@xps> <DM6PR11MB2555A631A6C461CF31CF510DE63E0@DM6PR11MB2555.namprd11.prod.outlook.com> <2501902.3BE8iA8HS7@thomas> <CY4PR11MB170258A32A1242245D60FBD8EB3A0@CY4PR11MB1702.namprd11.prod.outlook.com> <DM6PR11MB2555EA1D86745BD92346B331E63B0@DM6PR11MB2555.namprd11.prod.outlook.com> In-Reply-To: <DM6PR11MB2555EA1D86745BD92346B331E63B0@DM6PR11MB2555.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.180.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96ea13f2-5f97-4474-f41b-08d85ed7f97f x-ms-traffictypediagnostic: CY4PR11MB1701: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <CY4PR11MB17018C2340915D615FB5C5E6EB3B0@CY4PR11MB1701.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5z+m1W3Dak0bUlInO1yhbvtbH3IiZu8MD6DmH/wKWXGTLOqro8g7cNkOClTv6oytnyrneg7FPYBM7LY/WV1bx/YPAyDYAqxmaxYcPCXT7oQLMdLqupHwWPVaYtXINvF4+ReS3nMuM7rqzq6GWqEyD1ey1ErWQxKVKmVTD5iQbzWmok3FtGV8Kj/JCu7WkinnTu3Ep0DYjAflSxTpdiP4HthPqRv/oce0dEkfskEyTl1RHXyKrDwokjFUl3rZIETRQFrs/NuDeEjd6riSZ9is5QJrCQhBsxYcWWwCdd+d7ghoe8tKEaplVOHuRGj7ltzuQ9LkIxAkon4ViHLxC2jo+XBMJ0YuWbOJbMUv85qmE0SVVLsYLxuoPH3Hh4BWwyqHhXovRpX94fFHH+JOfOoC7A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(52536014)(316002)(64756008)(186003)(66556008)(66476007)(66446008)(6506007)(8936002)(8676002)(478600001)(4326008)(86362001)(26005)(83380400001)(107886003)(53546011)(966005)(110136005)(2906002)(76116006)(9686003)(54906003)(71200400001)(66946007)(5660300002)(55016002)(7696005)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Y/ePsCIyYa8aUG8+lwYPmY1DQAUBk98P7VFli1zOtvuy0lEUOxW1gJQ+oEZOxGCGiHNlYVgM5twTsqNQhj1w8Jz3kYjd5w8YDqJ3aEiEk/9P0SH/ZDmVzOy6RLhvnlJozhxzGS7KxTPzi9sTe+rd6PXlGOvVKXDZzEI3NDvt53o8fpuu+mHVssdBWBrzc8NE5ymXHtzb0O/IDSAvJDtMnolkuFuic0ttQdR8SsafQQhG4ysKtjY4GLR1kDXF0BFmz0S/c4ttZRPhdrLFISgYen/ZYeAuBTf2U7vzBgZxO2gYARP6N6JJJGvPXI71tagDjolSzFxKiNEGMWJWGsHcNYZow1XHSYKPrRyVizmfWffmUbBTyQ4VHNd14KnvpxOPrqSC9jFokycas78VvqFpgMwbCVzSN+lmmGjkgq4uXYbmmFIaiF+HtmVnHjLrPE3ZjUrv/NXPaZMs51b3EYN8DnjcMweUXa9/hwQ4MmEti/8J2VNXZaXKMBo9SfV8OBopQvQCP16hCXHiYoKjiy4AB9IATaRfgUWd5SWs6zGhzOPvppaqL1oRXBr2a6xJ5YK+pthXKX6mJxGElUI3c62I6CIQ0DelcNrYzZ26djTkGfSK8b4ZzEE4E7L1iNNDMfmLQ36jCKR22VlUcuurAep8gw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96ea13f2-5f97-4474-f41b-08d85ed7f97f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 09:14:56.8657 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D5chbXE8zmcKSpuIj9qWNe0z2oNFaY7fbj9UFFmIvlbCjyUD8TFe0gab1SOCrKcTYf8FJ+Sw8JI1fJHKuBO57OR3Wo2r+zjhiCLzrTIjDZs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1701 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Power, Ciara <ciara.power@intel.com> > Sent: Tuesday, September 22, 2020 9:40 AM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thomas Monjalon > <thomas@monjalon.net> > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com> > Subject: RE: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make i= n > contributing guides >=20 > Hi Cristian, Thomas, >=20 >=20 > >-----Original Message----- > >From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > >Sent: Monday 21 September 2020 20:14 > >To: Thomas Monjalon <thomas@monjalon.net>; Power, Ciara > ><ciara.power@intel.com> > >Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; > Kovacevic, > >Marko <marko.kovacevic@intel.com>; Richardson, Bruce > ><bruce.richardson@intel.com> > >Subject: RE: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make > in > >contributing guides > > >=20 > <snip> >=20 > >> > >[...] > >> > >> -Library Statistics > >> > >> ------------------- > >> > >> - > >> > >> -Description > >> > >> -~~~~~~~~~~~ > >> > >> - > >> > >> -This document describes the guidelines for DPDK library-level > >> > >> statistics counter -support. This includes guidelines for turning > >> > >> library statistics on and off and -requirements for preventing > >> > >> ABI changes when implementing statistics. > >> > > > >> > >I think the ABI part is still relevant. > >> > > >> > Looking for some clarification on this. Which parts (if any) of the > >> > library > >> statistics section should be > >> > added back in for the ABI section below to make sense being > >> > included? Or > >> what do you suggest doing here? > >> > >> I think we can consider we still have the ability to turn stats off > >> because of the #ifdef still being there. > >> Cristian, do you think we should remove this doc? > >> Is on/off still possible in the new pipeline libs? > >> > > > >Hi Ciara and Thomas, > > > >IMO this section is still relevant and it is unrelated to the topic of t= his patch > >set, why do we want to remove it? > > > >From the make removal point of view, we only need the following change, > >and everything else is still logically valid: > >- # DPDK file config/common_linux, config/common_freebsd, etc. > >- CONFIG_RTE_<LIBRARY_NAME>_STATS_COLLECT=3Dy/n > >+ /* Library API header file. */ > >+ #define RTE_<LIBRARY_NAME>_STATS_COLLECT > > > >On the larger stats topic, I think the section is still relevant, especi= ally from > >the point of view of avoiding ABI breakage due to stats, which is applic= able > to > >several libraries, so I suggest to keep it. > > > >In the new pipeline libs (rte_swx_pipeline.h API), all the stats are ena= bled > by > >default. > > > >Regards, > >Cristian > > >=20 > I agree the Library Statistics is still relevant, having looked at it aga= in since > sending v1. > I sent a v5 of this patchset yesterday just before your feedback here, an= d > kept the full > section but modified the instructions on how to enable/disable, removing > the mention > of CONFIG options. Please have a look at those changes here: > https://patchwork.dpdk.org/patch/78208/ >=20 > Thanks, > Ciara >=20 Cool with me, thanks Ciara.