From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB2E5A04DD; Mon, 21 Sep 2020 21:14:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16E761D993; Mon, 21 Sep 2020 21:14:28 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CB7FE1D977 for ; Mon, 21 Sep 2020 21:14:26 +0200 (CEST) IronPort-SDR: zP8TCTU/87Yhm4PE/l/aKM18RWrK5FDY8p9AQwsT4zkU92yx2uL90VEYNR2kgPNhzX6lXfJ1vm CRjyjk91TSJA== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="159752966" X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="159752966" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 12:14:20 -0700 IronPort-SDR: Gjji0Eh4GN4dQP6STMrBB/JCuAobLsNWEu8332nZ5i+NhM3nXbIGf9ZkWEuhK1zxLGT8c4It31 RDGIGLUJwo0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="348214013" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 21 Sep 2020 12:14:20 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 12:14:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Sep 2020 12:14:20 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Sep 2020 12:14:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FL0zGTSkOlphU/xtCATqzxsJzoMqMHHMJMYX2yhKM5qNeSx0MYLig4MC2lHqzk2b87k7FlUR3NyRKwqMt0pbkdnzrnmmgAUSGFdU2Gvbq1QWaOTKKlYHWgFrga0CxQwsD6EhEgFWNIl+CGLuf0d/4p3dMPZy6rdJh47oaIpQcreT7ABdrV75rqs90nPsDfXNKozi0ri0kBV+3bKs+UzJfI7YRr+ISqhwYdCtTSMXf2Qcb8DoHhgldH7RfK6JOwaDN+KuwaTwGTGI58wGAX6YB9+kqdy/cpmTcmUdg3czCgXR5ky5QMjkFKzwjvgOePce8e5FyQGNGj8VPX8uGeRCUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7NIWvjglr2wpuKAQ6hGSX/1/AOfGvsN83vnpSs8BLw=; b=ZwCLr+LjTnr1wtrC0cY8a8n6Rm3hYMWTprv9JrJrCXfHY3lmsLKIquUzbBOZ6de1Qc9+QeTZ4an40x2FAcc2YNxR61AuWqTqAiEYGTYEFgsBAhrTnTuizVJKsJdwoEmK0F7vtfyh0toHt863ej8taiach+xZuPOkqC8aZt8070hevIlDw7ucA+SjmDB8axjbQu9Gj2R5YD/e+tn7fUVSzJ6y6ARqRp8MZPeyOKyPguFyfk9vd6N1VYTsb1FdB6HVAhUvkqkyIHUtuMlnb6Oigp6LLZrViLkn/HM08vPVYDgKYt+4g0ptpxbnS5mpbJmkTeR2Lcac/QkU6IVwWQMY6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7NIWvjglr2wpuKAQ6hGSX/1/AOfGvsN83vnpSs8BLw=; b=cGbRjA96tVVGk+CXGStH6XYFDWE5LKtMIk5ujf+iceBjhrwdEiuMaZvBUFUKBXxBH8QuyEMmba8DwS+AcbeavBeWhBqgs2N9pu3vYyzcW52x98XotvvrlJrgP/jJYJPPHaHNiHMvXG7l1QFS5cEqHAuefYTfLIRW1OUA3qDdqms= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR1101MB2088.namprd11.prod.outlook.com (2603:10b6:910:17::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 19:14:18 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390%4]) with mapi id 15.20.3391.026; Mon, 21 Sep 2020 19:14:17 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Power, Ciara" CC: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides Thread-Index: AQHWkDJ68vvu9hn0/EqJ36iU+5V1XKlzcrfw Date: Mon, 21 Sep 2020 19:14:17 +0000 Message-ID: References: <20200903152717.42095-23-ciara.power@intel.com> <2501902.3BE8iA8HS7@thomas> In-Reply-To: <2501902.3BE8iA8HS7@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.180.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de3b6043-e28b-4b6a-2c10-08d85e628986 x-ms-traffictypediagnostic: CY4PR1101MB2088: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x3R8VLi+GQugIgII8ILRmvJ40o8eZPxR9UF5+emS4Xu9D4kyhxgKyXg21B0kQXVjhU6k6nnXW8XKzCQLUjfpzJcpkuMAQ00/3y5OeZZMrtnDmhMkAIq6VQFmlD4zE40/KhvE231hZ65wKIrqa48CBNKHYS9NqkT82fnnqXAtq03HCBwvVuazLJEV1xxJdrCLclRkRqO1CrPQWvl06QSzN7Zl83ud37pzL/lX/7OpC3NkC1oul1+Is7pMlFkbt4+o/HxpvY159R2iNN3NMD4/aTQB668PVqcqkfsEzU5UEZ6fIp47DphnEVMgzDlLfubVQoin1Njo9gqLP7jKKHC+ZWqnpum7uBByR8olYXAQ6v1v3k1XQfoxKPRAQ2rpwg5a x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(33656002)(64756008)(76116006)(71200400001)(4326008)(2906002)(66946007)(478600001)(86362001)(107886003)(66446008)(66556008)(66476007)(83380400001)(6636002)(5660300002)(7696005)(26005)(316002)(186003)(9686003)(6506007)(110136005)(53546011)(55016002)(52536014)(54906003)(8936002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8t4wnR25Y/F4oQPvsrEl9IWQh6fBwpUs8/mmGVcCTw+eV1vjl2ked1i1RzjTOYE8tzTV1RF4zuwuuokamZ2hSEnOWgP/yxkluBvtjlLyOQGps0ZvMdrRUDM8Z5YqZb6LESa/48itWjAhfTU2J4dkQoZtwwZw8VS9DpbbdpJscsTaQnHVGvcJpxdrcQpSA5Yo3X2QZ0gqqWOgz2MlXg9yiHkq0LeWXLXE+J0BLrUIgOAIQabUUP+mUT1K2OJb1OWc7swUtcxZUOrL8J3WuZQPm85OURsoefspvODIn3tuTwtOu3MOGO/P1k3fIAuxManYvnNQcz7uGRyNEf8gvd9ighzSgDA323a79lGwUcKcj0ARcT+3WrSl/SnjdkE3ExoUQhoDDFyP01B2xuTr1c3gT8vC7xrLVL1UMmxeVj9LUvW1I9QJbsvSzuMQi9hFCoq8ESXZ7UdYcQNCgyDQ62C65qtsKeV+2A+F/I2Uy9EwN5c8VYNOqRVLEl0Nr04fMP2GNvrmfDZ06dOG1ydjgokPSAaa8k2JBCtGpzGimARCtFGNEorxAmGko8nVp0RP/LUdy4/vzGhjAVc7byPqyAGKL1mCUx88FbZKT1xIho2lcNeGD1tdePjDCNSHKJokI8a0dMOJaX5m58OmqDiCX0mjDA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de3b6043-e28b-4b6a-2c10-08d85e628986 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 19:14:17.6924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ctha6oW3oLP5lmjVUMd/lpbmBwlLCTv5e0OP9CykccpRefynsl8FMaL6GGFsmmlZvUoffCHD3liUUpX5Zryx/yfUQqe06wpCnhoa5n7i3GQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2088 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, September 21, 2020 5:15 PM > To: Power, Ciara ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mcnamara, John ; > Kovacevic, Marko ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make i= n > contributing guides >=20 > 17/09/2020 15:44, Power, Ciara: > > Hi Thomas, > > > > One comment inline. > > > > Thanks, > > Ciara > > > > > > >-----Original Message----- > > >From: Thomas Monjalon > > >Sent: Monday 7 September 2020 11:21 > > >To: Power, Ciara ; dev@dpdk.org > > >Cc: Kilheeney, Louise ; Mcnamara, John > > >; Kovacevic, Marko > > > > > >Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to > make in > > >contributing guides > > > > > > > > > > > >[...] > > >> -Library Statistics > > >> ------------------- > > >> - > > >> -Description > > >> -~~~~~~~~~~~ > > >> - > > >> -This document describes the guidelines for DPDK library-level > > >> statistics counter -support. This includes guidelines for turning > > >> library statistics on and off and -requirements for preventing ABI > > >> changes when implementing statistics. > > > > > >I think the ABI part is still relevant. > > > > Looking for some clarification on this. Which parts (if any) of the lib= rary > statistics section should be > > added back in for the ABI section below to make sense being included? O= r > what do you suggest doing here? >=20 > I think we can consider we still have the ability to turn stats off > because of the #ifdef still being there. > Cristian, do you think we should remove this doc? > Is on/off still possible in the new pipeline libs? >=20 Hi Ciara and Thomas, IMO this section is still relevant and it is unrelated to the topic of this= patch set, why do we want to remove it? >From the make removal point of view, we only need the following change, and= everything else is still logically valid: - # DPDK file config/common_linux, config/common_freebsd, etc. - CONFIG_RTE__STATS_COLLECT=3Dy/n + /* Library API header file. */ + #define RTE__STATS_COLLECT On the larger stats topic, I think the section is still relevant, especiall= y from the point of view of avoiding ABI breakage due to stats, which is ap= plicable to several libraries, so I suggest to keep it. In the new pipeline libs (rte_swx_pipeline.h API), all the stats are enable= d by default. Regards, Cristian >=20 > > >[...] > > >> -Prevention of ABI changes due to library statistics support > > >> - > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ~ > > >> - > > >> -The layout of data structures and prototype of functions that are > > >> part of the -library API should not be affected by whether the > > >> collection of statistics -counters is turned on or off for the curre= nt > > >> library. In practical terms, this -means that space should always be > > >> allocated in the API data structures for -statistics counters and th= e > > >> statistics related API functions are always built -into the code, > > >> regardless of whether the statistics counter collection is turned -o= n > > >> or off for the current library. > > >> - > > >> -When the collection of statistics counters for the current library = is > > >> turned -off, the counters retrieved through the statistics related A= PI > > >> functions should -have a default value of zero. >=20 >=20