From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D497CA04DC; Mon, 19 Oct 2020 15:16:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 695B2C92C; Mon, 19 Oct 2020 15:16:49 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 33062AC9B for ; Mon, 19 Oct 2020 15:16:48 +0200 (CEST) IronPort-SDR: Wf5BZVN/hYoGRa/TqgN8TnkuxdQ7Ii3/um5T1QmyxEyBZXDDypuVROyfwuMqP1eWwsu6FzupSL h51vCJamkGZw== X-IronPort-AV: E=McAfee;i="6000,8403,9778"; a="184637981" X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="184637981" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 06:16:45 -0700 IronPort-SDR: dCPRbaqFWfk+eWRrEe+eWEmWsuQ/nGltBSSiIvPkc4XyVmSTvyOOjH8ysKn10HHOyYsRtBU5a+ /j+mvewqKdIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="315669516" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2020 06:16:45 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 19 Oct 2020 06:16:45 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 19 Oct 2020 06:16:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 19 Oct 2020 06:16:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 19 Oct 2020 06:16:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ieZu4ja5pMPkFx0kK3qgMR0wmNP0VD3QHkAZ0pM1MOPcQc314EU1HCGDQZMFqJc9S8BD2oC1kwBSxvDSkjnGFFVX9AQaVx9nwvLYfi6C0NTWXV1EJmpRAAsyy4UwBs4vUW04MXJs5FtlHvhxgcP+p1zAzGYNkhTzsgd9ywgaGNyRHz08z5nwUwfdlzqxXR3Xd2lDFRcQlDn+YhguNVulQ99PN98XK20P+Loa7fDj92e9KXe6NoZ4RRhbCd28UIgOX/hY2uyzTUN1ulDknuM4wAmcitZ4AEnm0GBh23OeYOjeGZ+P9NQpDT2qsDGQr4Zp5JSiH5ZGtW521u5IwXX/Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m70OKM4EfRxLWfPS6bdvQsDHJttdzfBHU8w1OS2kABM=; b=bqhs+OOCFNF5r2P/YSaCJULoKAdakRdifAGVaRTZYthxhyyk4x1lZ78B+P52QwET2oSZPXjBDg3AgdqYqs0Hz7FRmlu2jMKYyWXJTm3cTEjbQnO/VHRka9qZiWK/wly4TZE5tAItKSLHfNf9hJvIux7IcLw1VzBCBHTdt+MnH2S7JtEY7x+wGVff9Cs7jBs8yEC/kT7TlTaEfkAFI+7scCR9MJcXTAXLIA8+y26n/F5fCcDZTuJKiSmaLoIZKVQfa2Sm7fsdV7LDr6aeVMvmge6BsdMfs+tPU65or/+YHdTs9FsyBWkEKM8r0C/n2DPEdlvbl0icCYb/ee98FUX9Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m70OKM4EfRxLWfPS6bdvQsDHJttdzfBHU8w1OS2kABM=; b=fNAh7Nov31ozcd/jXQP/0dtJNlZ4slKnkr82/1TdZM8wik+XR+CrhYD3pR78WU5mVog9MOJr6+LXwGQAfMqwA+smelHARwA+2+ZrgyCsSJ61y/iAMeH0wBg/aHh5KJUU/lLSUDiTae8HGBhwA2CRMGnFJOspBmgjh5ItAv15DJo= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR1101MB2261.namprd11.prod.outlook.com (2603:10b6:910:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.27; Mon, 19 Oct 2020 13:16:43 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::891f:76e1:e31e:8337]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::891f:76e1:e31e:8337%7]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 13:16:43 +0000 From: "Dumitrescu, Cristian" To: "Dharmappa, Savinay" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/softnic: fix out of bound access Thread-Index: AQHWpg5U0fBMllkJaUibzhqcyvOTpKme5+iQ Date: Mon, 19 Oct 2020 13:16:43 +0000 Message-ID: References: <20201019105004.76433-1-savinay.dharmappa@intel.com> <20201019115216.96981-1-savinay.dharmappa@intel.com> In-Reply-To: <20201019115216.96981-1-savinay.dharmappa@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.102.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e939146-653d-4ad0-6224-08d874313965 x-ms-traffictypediagnostic: CY4PR1101MB2261: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:549; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CmfeNdZ+7DKovpLC2MNgXHR2FzDQTDoZT7Q4qPjyvZwHaBYaqZ+o34+R8/muSlLLV8UPl+DLpFptRtkB9mwwtQKurJm88GfYDRFd2CXforLoYGG5gHn/bpPalv3gUWlrJ/qDqdomZ89MxUjHnHNNNZapbC18tzo/MKiU4ljw4gGCu2xP1uIib0T5xH/yBwblFFmvI3sQi/YQXb0AZnUn7RDOe+tWTcikwWhYDb4wHAOQfWhQ/zjcPmhtKUsi5Igp+XbLov4Ucpi+0eQ5+Q82+B+l/ZKpdYqQVY1sxhCHbtyNq7g5DwJ/sUL78Z8Zw9+XuxvftgqG5TarjQLhXDayFw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(8676002)(83380400001)(52536014)(86362001)(66946007)(66476007)(66556008)(64756008)(76116006)(66446008)(5660300002)(7696005)(8936002)(9686003)(478600001)(2906002)(26005)(110136005)(316002)(186003)(33656002)(71200400001)(55016002)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +DukMDud/QQRHU5ITs7/qX8hx+xtwX5BWMm3Y0S+55djCUqc7M2xo/aDlNN82nryZNdzTBvcv9k4ONYi3afXZvh8Hu3NplfrJrasVWe0Lw2A4LMsnfDkimsYPahLr4TEnd0VqPmWI9oLv09ILZBXxNgTyABgLLFrZPt1UIky0Q58D+DvzUKXXDw44noG2SmqW5+c+C0PqqJ3yDB/FQuGa48cXTr6ekdsDPTaYRCFnWSL+Zc/9psJZa/aumUtOCVjzN9PPghi5UoDe8W7c7SswA7CcOg4E9sX7VHyN0mPJwFkQeOyY9DLdK0AXIbe1zttYqToGHi55bglP7L7DeDw3vOi1IfBatllXsqtSZZDgHqxkDtZTsdYGBix5jwyJUsWFHT/2CUbHZ0Q/uoDMmH4rUSy4VLEC6XFMHc3OznEQcv8kP4gTW/g15pRP4afbPBGoqJGqD8WonqyHdm98+pECkCImQQWuT9TMGexWxgMHiwGD0NmiNOWExCyPQ993kmEVaqGzMKOzxY+k27MRlVQSZ6mYN1PMy6y9Uc/6Iwb834PniFAt7fzTuYDP3Wqq2cgHYV3mFG5j72+7ZrCfH2bb6v7Du5mHTdboIjL16j3X6idm9H1wUIg1LCXiGF6Yw0DcG1GXzwNrXbZ2eMxYTn+nQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e939146-653d-4ad0-6224-08d874313965 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 13:16:43.7330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8LxgVIVbiIrnP+Qw0bP05inj+Tjs5tL2cHHSqW54BemAl+4vQEka6YumsoC8mf/Da5f8OoWWGcadBWxgKKh5zYci6TG3UErVYS0RJyzjwwE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2261 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/softnic: fix out of bound access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dharmappa, Savinay > Sent: Monday, October 19, 2020 12:52 PM > To: Dumitrescu, Cristian ; Singh, Jasvinde= r > ; dev@dpdk.org > Cc: Dharmappa, Savinay > Subject: [PATCH v2] net/softnic: fix out of bound access >=20 > This patch fixes out of bound access of an array. >=20 > Coverity issue: 363466, 363459 > Fixes: b5dfa6703d49 ("net/softnic: update subport rate dynamically") >=20 > Signed-off-by: Savinay Dharmappa > --- > v2: addressed review comments of v1 > --- > drivers/net/softnic/rte_eth_softnic_tm.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c > b/drivers/net/softnic/rte_eth_softnic_tm.c > index 725b0231ae..90baba15ce 100644 > --- a/drivers/net/softnic/rte_eth_softnic_tm.c > +++ b/drivers/net/softnic/rte_eth_softnic_tm.c > @@ -1147,10 +1147,15 @@ update_subport_tc_rate(struct rte_eth_dev > *dev, > struct tm_node *ns =3D np->parent_node; > uint32_t subport_id =3D tm_node_subport_id(dev, ns); > struct tm_params *t =3D &p->soft.tm.params; > - uint32_t subport_profile_id =3D t->subport_to_profile[subport_id]; > + uint32_t subport_profile_id; > struct tm_shaper_profile *sp_old =3D tm_shaper_profile_search(dev, > ss->shaper_profile_id); >=20 > + if (subport_id >=3D TM_MAX_SUBPORT_PROFILE) > + return -1; > + > + subport_profile_id =3D t->subport_to_profile[subport_id]; > + > /* Derive new subport configuration. */ > memcpy(&subport_profile, > &p->soft.tm.params.subport_profile[subport_profile_id], > @@ -2370,6 +2375,9 @@ subport_profile_get(struct rte_eth_dev *dev, > struct tm_node *np) > struct tm_params *t =3D &p->soft.tm.params; > uint32_t subport_id =3D tm_node_subport_id(dev, np->parent_node); >=20 > + if (subport_id >=3D TM_MAX_SUBPORT_PROFILE) > + return NULL; > + > return &t->subport_profile[subport_id]; > } >=20 > @@ -3024,6 +3032,9 @@ update_subport_rate(struct rte_eth_dev *dev, > struct rte_sched_subport_profile_params profile1; > uint32_t subport_profile_id; >=20 > + if (profile0 =3D=3D NULL) > + return -1; > + > /* Derive new pipe profile. */ > memcpy(&profile1, profile0, sizeof(profile1)); > profile1.tb_rate =3D sp->params.peak.rate; > -- > 2.17.1 Acked-by: Cristian Dumitrescu