From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97C72A04B1; Wed, 23 Sep 2020 21:02:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5EC11DA1D; Wed, 23 Sep 2020 21:02:24 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CE5911D9FB for ; Wed, 23 Sep 2020 21:02:22 +0200 (CEST) IronPort-SDR: faUY2x4mEFO0KnBSmaTtTnPrNI839RI1pbcjGJ4YYVO/SVq6ndZkoReAsJU1/s1q+/JwV7pf6T Czsm9IeUtRHg== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="225127160" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="225127160" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 12:02:21 -0700 IronPort-SDR: Ct/TIQfpBRfnsdw1P9SrkeGql1lW43/NIBB7nXdumUvH3vDCmTGV8fbfgU4TxFmDRTI25zYrrw udAfFFFzlA3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="511762007" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 23 Sep 2020 12:02:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 12:02:20 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 12:02:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Sep 2020 12:02:20 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.51) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 23 Sep 2020 12:02:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKY6RBQ4CB6t93VgMdObikuea5C0zra7Q5qfU30+/zv/ZMGy4M8zHP1Jaikykz+LwlYpjh2QKJCi9KC2cQEP/Ik7btscNc8XI/M6ugdr3WDlGa6lFel7yuhr4yJ4GsY9BruMi/KuNkavA4oHG0exqBOGxi+n/qgBq2HXjqk44v7rcNJz97vcaP2EupW5Li57fzKzULQ9lkClrIq9aK2ITUpObZjf5aNWne9z7gBJEVqzCqZc4Ahe7OAtFhTuJjuVsPGs1M0qs6+CkQ0aVACrbPcr85OTVL1u6tWZtaEDe0BBwCqeUXW1+LEuRBzk86bj+Ee1VHRkgB3e27a1Or3cog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kujMDd52Z897dMPzDnJtMVXG4j0qCiqYCHvq/cpuH8=; b=jLV90+aHguWH6cC2R5LtRpyOgvPwhSNID4o8W4J9s908j5M6Y7UKqqs48izMW6XyFTeSPBfpUjI1jgZ/mwaYoSRuoWc1FjhTCjcBB59Qh1sM4C3OCqTzADHYmYitbKXsU/3M6sevdxKe4pZHq86hW98m1TS1MqEuRY+FOD/bVPv0SNYbxsblaipemqTTA6gCcuGikaggP3GRNLLFp6dQiP5s44doUL+eBVPt1aUaSmh1kqsz0KOxAKo8yg245lSx6Vsxhx3N9jmGdDp+c7gaXj806VTWtT0l6b24lcpyRwZIB/Awji0n0GCKBgY6pJssAXUV9lU5EcjiJPTLyzB1Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kujMDd52Z897dMPzDnJtMVXG4j0qCiqYCHvq/cpuH8=; b=B99Sey/5AzOJCT0B0rGoln89pjQ6Op8ZVHW2PFrT0Ek/KTp1kqXN2K5+UESS+ay1Nnlyx9q/nOYi75EZuVRg5BgfyLKhduLuHjz0PZuQ41WKL9071kdjnSDhKh2yI0MrKxO8pIfJMWqz1ci7ZevkE9tnwxDmiChRxjgxpKNYONU= Received: from CY4PR11MB1702.namprd11.prod.outlook.com (2603:10b6:903:2e::8) by CY4PR11MB1878.namprd11.prod.outlook.com (2603:10b6:903:11f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Wed, 23 Sep 2020 19:02:19 +0000 Received: from CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390]) by CY4PR11MB1702.namprd11.prod.outlook.com ([fe80::ddb:33e0:ba2a:e390%4]) with mapi id 15.20.3391.026; Wed, 23 Sep 2020 19:02:19 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , David Marchand CC: dev Thread-Topic: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language Thread-Index: AQHWh4bng3lOnBhS7UyGZsJXcbTFSql2LwiAgABCerCAAAy1gIAAAx0AgAACMNCAACVzUA== Date: Wed, 23 Sep 2020 19:02:18 +0000 Message-ID: References: <20200908201830.74206-2-cristian.dumitrescu@intel.com> <3393138.8c1kj3NxaF@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.78.180.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ef5cce26-b5e4-4aea-5ca8-08d85ff331d8 x-ms-traffictypediagnostic: CY4PR11MB1878: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 73eoy5VmWwCQ4haBQ8Dg17AwVY4lz9FOI1LCKePij623uT+d5VaJ82O5CZXZakJx4EZniaxPTz3GKyL16iuDc4ZH8kA7IPaC8fWHlI1vxkQNNJSnz7C+3pI7KaeS2DUemk7tk+t8HjHJ4u2xjPyGiHfzOl1RmboYRw2TghWq1hetAhPD7UGWo3ZkPVlnv2KPMv9xmEGNTXwXIBwgZtZbJin1fPMHyLHnfVjtEDNDXRoas7X2IFx7xIjNoxkr509qOhuWlNUzS4EPAU11h4BkreNU4xdQF/zRFex+p7wtHFCXU9PiiHAu6kHikPYMpGscAZ2QnMyecJgiRbKo2YtN4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1702.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(55016002)(316002)(76116006)(9686003)(66556008)(64756008)(110136005)(66446008)(2940100002)(66476007)(186003)(478600001)(26005)(52536014)(5660300002)(8936002)(4326008)(33656002)(83380400001)(7696005)(53546011)(6506007)(66946007)(8676002)(2906002)(86362001)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 21t6SwtK0TLy9WM7P1rd96O7VKmf1HO5cT1Rr/xqjIccU9oUhgwRPuCgHZVGheaX9n7Qbr4HrdiBNXjx0eougNlsK8c7tWFfJdIgb6ZKZHTo6nmM9NUELkeZil2P0yLY306RSLW8gu87VSZ6Vy83C7AH45f9E476usz84px+rQwlYTuAmEyTSksRm7zFXleYCxHKJzpf768/DkaL86M/wryz3TWVA0zHLS0FHXRsv7gFFiJ8OxOhOl05hL1rfKkxL+t9jT9OuJKoxNmYm6KTm9hzbBOvOAFwe56v1tejVhqoJ5rDic2wYgp6UOb/EyUHXS1aWhijNNOaC34yTjRBfxiOdW1AXpQtOD4YePAKdy1/4nQEFceEEYx5I2jcTKcLX010atxePVudV65Js8vKhIblj7Y5OBAozTuWRFbpuGWSG1BtDgAMJySpJK6y5eTO9GgTRZLeHb/O8dk+2E5iKA2o1vl8XBWe66Mdsellz0BmoBjnBkypc5XIWgoGFY1pmL/rMrn6ysGL5pKiThaYEd8gc8ERxJYIA/abv9yhluIiluiWe2/mAwvTUpv3HtrVshn0iPjewANNyxmUJ0tosQtnqmUUkLOGuNRNVbgulDkW4L7qowbcO1h/fue8C4+akV8kPf0j/1rJaj38aRah8Q== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1702.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef5cce26-b5e4-4aea-5ca8-08d85ff331d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 19:02:18.9220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7Bzx+1lhPq3YuvYzt/kNulW1+YVYPU5wCZT+M1l8oufgS7Brj4+99QsqaaakTAj2Y1sXo4juCXtyJhmvizT9IOx1Sk1cz3E26cgmCYqfEFg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1878 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Wednesday, September 23, 2020 5:49 PM > To: 'Thomas Monjalon' ; David Marchand > > Cc: dev > Subject: RE: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 > language >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, September 23, 2020 5:40 PM > > To: Dumitrescu, Cristian ; David Marchan= d > > > > Cc: dev > > Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 > > language > > > > 23/09/2020 18:28, David Marchand: > > > On Wed, Sep 23, 2020 at 6:08 PM Dumitrescu, Cristian > > > wrote: > > > > > - On the patch titles, check-git-log.sh reports: > > > > > Wrong headline case: > > > > > "pipeline: add SWX dma instruction": dma --> DMA > > > > > Wrong headline case: > > > > > "pipeline: add SWX rx and extract instructions": rx -= -> Rx > > > > > Wrong headline case: > > > > > "pipeline: add SWX tx and emit instructions": tx --> = Tx > > > > > Wrong headline case: > > > > > "pipeline: introduce SWX xor instruction": xor --> XO= R > > > > > > > > > > > > > I can do this change, but IMO it is not the right choice here, as i= n this > > particular case we have instructions that are called "rx", "tx", "dma",= "and", > > "or", "xor", etc. So it is the name of an instruction rather than a tex= t > > abbreviation. Hence, I think these messages are not really applicable h= ere. > > What do you think? > > > > > > For this reason I am ok with ignoring too, Thomas wdyt? > > > > The general idea of titles is to not use exact same wording as in code > > (no function or variable names for instance). > > For the instructions, I don't know. > > If you think it is better as lowercase, I can be convinced. > > >=20 > OK, let me do the change in V5, thanks! Done in V5 just sent, thanks!