DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Dharmappa, Savinay" <savinay.dharmappa@intel.com>,
	"Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 6/9] example/ip_pipeline: add dynamic config of subport
Date: Tue, 29 Sep 2020 21:23:11 +0000
Message-ID: <CY4PR11MB17027DBCC26B0A3929A8F995EB320@CY4PR11MB1702.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1600332159-26018-7-git-send-email-savinay.dharmappa@intel.com>



> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Thursday, September 17, 2020 9:43 AM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v4 6/9] example/ip_pipeline: add dynamic config of subport
> 
> Modify the ip_pipeline application to build the hierarchical scheduler
> with default subport bandwidth profile. It also allows to configure
> a subport with different subport bandwidth profile dynamically
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
>  examples/ip_pipeline/cli.c  | 14 ++++++++------
>  examples/ip_pipeline/tmgr.c | 26 ++++++++++++++++++++++++--
>  examples/ip_pipeline/tmgr.h |  3 ++-
>  3 files changed, 34 insertions(+), 9 deletions(-)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index d79699e..7eccde3 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -407,6 +407,7 @@ cmd_tmgr_subport_profile(char **tokens,
>  	size_t out_size)
>  {
>  	struct rte_sched_subport_params p;
> +	struct rte_sched_subport_profile_params pp;
>  	int status, i;
> 
>  	if (n_tokens != 35) {
> @@ -414,23 +415,23 @@ cmd_tmgr_subport_profile(char **tokens,
>  		return;
>  	}
> 
> -	if (parser_read_uint64(&p.tb_rate, tokens[3]) != 0) {
> +	if (parser_read_uint64(&pp.tb_rate, tokens[3]) != 0) {
>  		snprintf(out, out_size, MSG_ARG_INVALID, "tb_rate");
>  		return;
>  	}
> 
> -	if (parser_read_uint64(&p.tb_size, tokens[4]) != 0) {
> +	if (parser_read_uint64(&pp.tb_size, tokens[4]) != 0) {
>  		snprintf(out, out_size, MSG_ARG_INVALID, "tb_size");
>  		return;
>  	}
> 
>  	for (i = 0; i < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; i++)
> -		if (parser_read_uint64(&p.tc_rate[i], tokens[5 + i]) != 0) {
> +		if (parser_read_uint64(&pp.tc_rate[i], tokens[5 + i]) != 0) {
>  			snprintf(out, out_size, MSG_ARG_INVALID,
> "tc_rate");
>  			return;
>  		}
> 
> -	if (parser_read_uint64(&p.tc_period, tokens[18]) != 0) {
> +	if (parser_read_uint64(&pp.tc_period, tokens[18]) != 0) {
>  		snprintf(out, out_size, MSG_ARG_INVALID, "tc_period");
>  		return;
>  	}
> @@ -440,7 +441,8 @@ cmd_tmgr_subport_profile(char **tokens,
>  		return;
>  	}
> 
> -	if (parser_read_uint32(&p.n_pipes_per_subport_enabled,
> tokens[20]) != 0) {
> +	if (parser_read_uint32(&p.n_pipes_per_subport_enabled,
> +		tokens[20]) != 0) {
>  		snprintf(out, out_size, MSG_ARG_INVALID,
> "n_pipes_per_subport");
>  		return;
>  	}
> @@ -456,7 +458,7 @@ cmd_tmgr_subport_profile(char **tokens,
>  			return;
>  		}
> 
> -	status = tmgr_subport_profile_add(&p);
> +	status = tmgr_subport_profile_add(&p, &pp);
>  	if (status != 0) {
>  		snprintf(out, out_size, MSG_CMD_FAIL, tokens[0]);
>  		return;
> diff --git a/examples/ip_pipeline/tmgr.c b/examples/ip_pipeline/tmgr.c
> index 91ccbf6..5c3df92 100644
> --- a/examples/ip_pipeline/tmgr.c
> +++ b/examples/ip_pipeline/tmgr.c
> @@ -11,6 +11,9 @@
>  static struct rte_sched_subport_params
>  	subport_profile[TMGR_SUBPORT_PROFILE_MAX];
> 
> +static struct rte_sched_subport_profile_params
> +		profile_params[TMGR_SUBPORT_PROFILE_MAX];
> +

As discussed, it is probably better to merge these two tables into one.

struct subport_profile_params {
	struct rte_sched_subport_params params;
	rte_sched_subport_profile_params profile;
};

struct subport_profile_params subport_profile[TMGR_SUBPORT_PROFILE_MAX];

It avoids confusion and also minimizes the app changes.

The same should be done for the SoftNIC code.

>  static uint32_t n_subport_profiles;
> 
>  static struct rte_sched_pipe_params
> @@ -44,10 +47,11 @@ tmgr_port_find(const char *name)
>  }
> 
>  int
> -tmgr_subport_profile_add(struct rte_sched_subport_params *p)
> +tmgr_subport_profile_add(struct rte_sched_subport_params *p,
> +			 struct rte_sched_subport_profile_params *pp)
>  {
>  	/* Check input params */
> -	if (p == NULL ||
> +	if (p == NULL || pp == NULL ||
>  		p->n_pipes_per_subport_enabled == 0)
>  		return -1;
> 
> @@ -56,6 +60,10 @@ tmgr_subport_profile_add(struct
> rte_sched_subport_params *p)
>  		p,
>  		sizeof(*p));
> 
> +	memcpy(&profile_params[n_subport_profiles],
> +		pp,
> +		sizeof(*pp));
> +
>  	n_subport_profiles++;
> 
>  	return 0;
> @@ -103,6 +111,9 @@ tmgr_port_create(const char *name, struct
> tmgr_port_params *params)
>  	p.mtu = params->mtu;
>  	p.frame_overhead = params->frame_overhead;
>  	p.n_subports_per_port = params->n_subports_per_port;
> +	p.n_subport_profiles = n_subport_profiles;
> +	p.subport_profiles = profile_params;
> +	p.n_max_subport_profiles = TMGR_SUBPORT_PROFILE_MAX;
>  	p.n_pipes_per_subport = TMGR_PIPE_SUBPORT_MAX;
> 
>  	s = rte_sched_port_config(&p);
> @@ -126,6 +137,13 @@ tmgr_port_create(const char *name, struct
> tmgr_port_params *params)
>  			return NULL;
>  		}
> 
> +		status = rte_sched_subport_profile_config(s, i, 0);
> +
> +		if (status) {
> +			rte_sched_port_free(s);
> +			return NULL;
> +		}
> +
>  		for (j = 0; j <
> subport_profile[0].n_pipes_per_subport_enabled; j++) {
>  			status = rte_sched_pipe_config(
>  				s,
> @@ -182,6 +200,10 @@ tmgr_subport_config(const char *port_name,
>  		subport_id,
>  		&subport_profile[subport_profile_id]);
> 
> +	if (!status)
> +		status = rte_sched_subport_profile_config(port->s,
> subport_id,
> +							subport_profile_id);
> +
>  	return status;
>  }
> 
> diff --git a/examples/ip_pipeline/tmgr.h b/examples/ip_pipeline/tmgr.h
> index ee50cf7..8c14523 100644
> --- a/examples/ip_pipeline/tmgr.h
> +++ b/examples/ip_pipeline/tmgr.h
> @@ -48,7 +48,8 @@ struct tmgr_port_params {
>  };
> 
>  int
> -tmgr_subport_profile_add(struct rte_sched_subport_params *p);
> +tmgr_subport_profile_add(struct rte_sched_subport_params *p,
> +			 struct rte_sched_subport_profile_params *pp);
> 
>  int
>  tmgr_pipe_profile_add(struct rte_sched_pipe_params *p);
> --
> 2.7.4


  reply	other threads:[~2020-09-29 21:23 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 18:27 [dpdk-dev] [RFC PATCH 0/2] Enable dyynamic configuration of subport bandwidth profile Savinay Dharmappa
2020-07-15 18:27 ` [dpdk-dev] [RFC PATCH 1/2] sched: add dynamic config " Savinay Dharmappa
2020-07-16  8:14   ` Singh, Jasvinder
2020-07-20 11:20   ` Dumitrescu, Cristian
2020-07-20 11:21     ` Dumitrescu, Cristian
2020-09-02  8:56   ` [dpdk-dev] [PATCH v1 1/4] " Savinay Dharmappa
2020-09-02  8:56     ` [dpdk-dev] [PATCH v1 2/4] " Savinay Dharmappa
2020-09-02  8:56     ` [dpdk-dev] [PATCH v1 3/4] " Savinay Dharmappa
2020-09-02  8:56     ` [dpdk-dev] [PATCH v1 4/4] " Savinay Dharmappa
2020-09-10 18:48     ` [dpdk-dev] [PATCH v2 00/10] Enable dynamic config of subport bandwidth Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 01/10] sched: add support profile data structure Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 02/10] sched: add subport profile table Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 03/10] sched: add subport profile add and config api Savinay Dharmappa
2020-09-14 14:05         ` Singh, Jasvinder
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 04/10] sched: update the grinder credit update function Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 05/10] sched: update the pipe config api implementation Savinay Dharmappa
2020-09-14 14:26         ` Singh, Jasvinder
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 06/10] example/qos_sched: add dynamic config of subport Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 07/10] example/ip_pipeline: " Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 08/10] drivers/softnic: " Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 09/10] app/test_sched: " Savinay Dharmappa
2020-09-10 18:48       ` [dpdk-dev] [PATCH v2 10/10] sched: remove the redundant code Savinay Dharmappa
2020-09-16 16:43       ` [dpdk-dev] [PATCH v3 0/9] Enable dynamic config of subport bandwidth Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 1/9] sched: add support profile data structure Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 2/9] sched: add subport profile table Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 3/9] sched: add subport profile add and config api Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 4/9] sched: update grinder credit and pipe config function Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 5/9] example/qos_sched: add dynamic config of subport Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 6/9] example/ip_pipeline: " Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 7/9] drivers/softnic: " Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 8/9] app/test_sched: " Savinay Dharmappa
2020-09-16 16:43         ` [dpdk-dev] [PATCH v3 9/9] sched: remove the redundant code Savinay Dharmappa
2020-09-17  8:42         ` [dpdk-dev] [PATCH v4 0/9] Enable dynamic config of subport bandwidth Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 1/9] sched: add support profile data structure Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 2/9] sched: add subport profile table Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 3/9] sched: add subport profile add and config api Savinay Dharmappa
2020-09-29 21:19             ` Dumitrescu, Cristian
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 4/9] sched: update grinder credit and pipe config function Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 5/9] example/qos_sched: add dynamic config of subport Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 6/9] example/ip_pipeline: " Savinay Dharmappa
2020-09-29 21:23             ` Dumitrescu, Cristian [this message]
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 7/9] drivers/softnic: " Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 8/9] app/test_sched: " Savinay Dharmappa
2020-09-17  8:42           ` [dpdk-dev] [PATCH v4 9/9] sched: remove the redundant code Savinay Dharmappa
2020-09-30 19:24           ` [dpdk-dev] [PATCH v5 0/9] Enable dynamic config of subport bandwidth Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 1/9] sched: add support profile table Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 2/9] sched: add subport profile add api Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 3/9] sched : add dynamic config of subport bandwidth Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 4/9] sched: update grinder credit and pipe config function Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 5/9] example/qos_sched: add dynamic config of subport Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 6/9] example/ip_pipeline: " Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 7/9] drivers/softnic: " Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 8/9] app/test_sched: " Savinay Dharmappa
2020-09-30 19:24             ` [dpdk-dev] [PATCH v5 9/9] sched : remove redundant code Savinay Dharmappa
2020-10-06 15:27             ` [dpdk-dev] [PATCH v6 0/8] Enable dynamic config of subport bandwidth Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 1/8] sched: add support profile table Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 2/8] sched: introduce subport profile add function Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 3/8] sched: update subport rate dynamically Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 4/8] example/qos_sched: " Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 5/8] example/ip_pipeline: " Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 6/8] drivers/softnic: " Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 7/8] app/test_sched: " Savinay Dharmappa
2020-10-06 15:27               ` [dpdk-dev] [PATCH v6 8/8] sched: remove redundant code Savinay Dharmappa
2020-10-06 15:52               ` [dpdk-dev] [PATCH v6 0/8] Enable dynamic config of subport bandwidth Dumitrescu, Cristian
2020-10-06 18:02               ` [dpdk-dev] [PATCH v7 " Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 1/8] sched: add support profile table Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 2/8] sched: introduce subport profile add function Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 3/8] sched: update subport rate dynamically Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 4/8] example/qos_sched: " Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 5/8] example/ip_pipeline: " Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 6/8] drivers/softnic: " Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 7/8] app/test_sched: " Savinay Dharmappa
2020-10-06 18:02                 ` [dpdk-dev] [PATCH v7 8/8] sched: remove redundant code Savinay Dharmappa
2020-10-06 19:05                 ` [dpdk-dev] [PATCH v7 0/8] Enable dynamic config of subport bandwidth Dumitrescu, Cristian
2020-10-07 14:09                 ` [dpdk-dev] [PATCH v8 " Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 1/8] sched: add support profile table Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 2/8] sched: introduce subport profile add function Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 3/8] sched: update subport rate dynamically Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 4/8] example/qos_sched: " Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 5/8] example/ip_pipeline: " Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 6/8] drivers/softnic: " Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 7/8] app/test_sched: " Savinay Dharmappa
2020-10-07 14:09                   ` [dpdk-dev] [PATCH v8 8/8] sched: remove redundant code Savinay Dharmappa
2020-10-09  8:28                     ` Thomas Monjalon
2020-10-09 12:39                   ` [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 1/8] sched: add support profile table Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 2/8] sched: introduce subport profile add function Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 3/8] sched: update subport rate dynamically Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 4/8] example/qos_sched: " Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 5/8] example/ip_pipeline: " Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 6/8] drivers/softnic: " Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 7/8] app/test_sched: " Savinay Dharmappa
2020-10-09 12:39                     ` [dpdk-dev] [PATCH v9 8/8] sched: remove redundant code Savinay Dharmappa
2020-10-11 20:11                     ` [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth Thomas Monjalon
2020-10-12  5:24                       ` Dharmappa, Savinay
2020-10-12 23:08                         ` Dharmappa, Savinay
2020-10-13 13:56                           ` Dharmappa, Savinay
2020-10-13 14:06                             ` Thomas Monjalon
2020-10-15  0:17                     ` Thomas Monjalon
2020-07-15 18:27 ` [dpdk-dev] [RFC PATCH 2/2] example/qos_sched: subport bandwidth profile config Savinay Dharmappa
2020-07-16  8:14   ` Singh, Jasvinder
2020-09-02  9:07   ` [dpdk-dev] [PATCH v1 1/4] example/qos_sched: subport bandwidth dynmaic conf Savinay Dharmappa
2020-09-02  9:07     ` [dpdk-dev] [PATCH v1 2/4] example/ip_pipeline: " Savinay Dharmappa
2020-09-02  9:07     ` [dpdk-dev] [PATCH v1 3/4] drivers/softnic: subport bandwidth profile config Savinay Dharmappa
2020-09-02  9:07     ` [dpdk-dev] [PATCH v1 4/4] app/test_sched: " Savinay Dharmappa
2020-09-02 10:46     ` [dpdk-dev] [PATCH v1 1/4] example/qos_sched: subport bandwidth dynmaic conf Dharmappa, Savinay
2020-07-16  8:14 ` [dpdk-dev] [RFC PATCH 0/2] Enable dyynamic configuration of subport bandwidth profile Singh, Jasvinder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR11MB17027DBCC26B0A3929A8F995EB320@CY4PR11MB1702.namprd11.prod.outlook.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=savinay.dharmappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git