From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B7CDA0561; Fri, 5 Mar 2021 04:25:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1284E22A341; Fri, 5 Mar 2021 04:25:47 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E262C4069F for ; Fri, 5 Mar 2021 04:25:44 +0100 (CET) IronPort-SDR: JgzhJHvCeJGR3YbDeN9CbVFYTVwJSNB4EYl2W9y+VOM/8s2h/68NcBy7XETY28YmF5ySHbzBk3 V8PILnvX9pMw== X-IronPort-AV: E=McAfee;i="6000,8403,9913"; a="174673076" X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="174673076" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 19:25:43 -0800 IronPort-SDR: i67aFDcxeOQ9CmRSZwLkn+BIl+cRNKtJv4qQBHqxlMdW1bBsJtOUykTCx1G3+8L2RZZ4l53pQS C3UPNl5AKXPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="597187445" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 04 Mar 2021 19:25:43 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Mar 2021 19:25:43 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 4 Mar 2021 19:25:43 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 4 Mar 2021 19:25:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQaelT8a2quNr4UCW81cDJpxgXw+i10JT8zs6rHdAzaOBz7ZCgcDW8e1jLxu9vlHuHCEpDLELJPQ6Hnsnz6EHcMLCph7EP5iod/50h4/GLa07hVkbBEzZhMYuhBkBgFLtdV/ObmqizKeOPGrymaMDZ36i8OaPdSL3+MZgbYFeser5AuSD6RW3yr5GSBige1wW04feQtMRIcudv+DW1HR0FiqDANDdCS+8ZLs3CDjl0H2N3gBi/Dk5htMxWSCk3AkrJRxn2rrueDGsIeZZ5cH9gEEKDkTDB8raO0ivf6Y5GPARGlsBgTdcPV+4IEidrLCH9Y4jLGsk2OOzMNkcnCBzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dYtjuUO/pqwgN554gka0kUZXTLQIuFWmQOhV/fYoWU=; b=fPFAtt0xEQw/1tjGWUi/znv67sDEOPx8SaWS9llqfqx0Wx8XQ6FFz1wKABDBIOVisg0N1d5XUX/pihvBVQJjmsK8+yjbsl6uiDkQBsaQAWapjbzRK3MgJRReJtHDHyZ3QbmwMxWQPvq4wjO05noJqpXbQMAUZn8q0OIeXhMcJwJQrPC21FvhN2puVO66OvUH66K8E5D+3QFeQfvMDuh+8s9pWZGBYxqwDgmlVR96uP0wsqxHmYs3DwK4PEcGPk0MqZQvcb84q5x4PyopX9IEq1NiSBu1+JId5OfjBXC2Mgpln3uo0D8xtI7sn4R2Uo1StqRxateInPkXlLmxd1ZYpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dYtjuUO/pqwgN554gka0kUZXTLQIuFWmQOhV/fYoWU=; b=OqVrOR5222Idyqu8WuHC02DFx5swZRnagW1HS3hEBL7rJEyJ5N1laGe9A/ygve/RmzqydkPnS0LJ0dYs0VNgHcXTFonVgrQsNEb9l/tdJrf9CyowW0PFhTkyqhEyQ2LNPBYSkH9JNepOCweNYiRVgSLk/d9ALs7tWvOGyScvz8A= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR1101MB2358.namprd11.prod.outlook.com (2603:10b6:903:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.25; Fri, 5 Mar 2021 03:25:40 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae%12]) with mapi id 15.20.3912.022; Fri, 5 Mar 2021 03:25:40 +0000 From: "Li, Xiaoyun" To: Lijun Ou , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in testpmd Thread-Index: AQHXEVpMltz8XB9J/kmWj8uikAWvKqp0uq1Q Date: Fri, 5 Mar 2021 03:25:40 +0000 Message-ID: References: <1614905757-33791-1-git-send-email-oulijun@huawei.com> <1614905757-33791-4-git-send-email-oulijun@huawei.com> In-Reply-To: <1614905757-33791-4-git-send-email-oulijun@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc055d80-18ac-412b-7e9d-08d8df865a6e x-ms-traffictypediagnostic: CY4PR1101MB2358: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vshkbz+wlpbbzGHKWV4pdLyO8ABF0bwAVG+fmGtqh9lNAApDo8p8YHBP9ZBfUimQ4eg142gLP9BUbGRscWxYAUgKmNDE5cT+Bwxt9milPO582rxp4zUwXw0NxH8KxLypX71114Q5yFlfgAeHBcmFqZpaOzWikyap2ITk+qM3hUDjTFu6HxtVAe1HF/+UT66xoMozOMAcrMQA8kUxixBVRryW7EO11IaIZ/e1IU20QZHmW8SoCeFIe1l7jXY2JTcpAYxa2GVb8xko+msS57Qo9E2hs4hk2K9IBmtABEVeA6YZdkhALWSmvCcJ8t36YW+8UngOKb2d+5PsPuGJZhzUk3/DZbfvQyuBIhc1hI7ZVX7pAsePhaED9Z5M7M4X/Zg8XKB1VDdjhexEb9qXoD9Uykm8BUlHrpQjsI8nF1uxwtP2CUoYKNuJYwPk+OLvVx/QPmK544yVN4nWCJs2s2SkejbTQr7LAm1CeUnxfxi4gRwLfyinkVTWyZk3sogsAOUMjz/2wOBEhJJFmEcFuatvUQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(39860400002)(396003)(376002)(346002)(6506007)(86362001)(316002)(83380400001)(53546011)(6636002)(478600001)(54906003)(2906002)(110136005)(7696005)(66946007)(76116006)(4326008)(52536014)(8676002)(66476007)(64756008)(66446008)(186003)(8936002)(55016002)(9686003)(5660300002)(26005)(71200400001)(33656002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Pm23Y3UwM9xUZS0weaLuKQDAeqgq2sFT/il09kSpOXUK3j5v9CjqHjtWLnoa?= =?us-ascii?Q?IKgcYp38D2IpvRPT+0WgpaqYMu3dH+4CV8Q19GkcTTM8KG0R1KzGDKnNeowL?= =?us-ascii?Q?P/HYs0X2ltIOwHOyJpNyUhUTeITHtWCyza0QRUV/4rwGQTswr3QJ0wENKCCt?= =?us-ascii?Q?3UvCVkPQO2CxW9VJhTr9VveMchQCzgsZ9jLb//gagsBaO13iSUlfK+MyavOG?= =?us-ascii?Q?xXV/H0BJbAS+aImnjaxcx73fI5evhl+WcI1zaEU9BNB15ziZP4JGXd0Dy0lc?= =?us-ascii?Q?965ecFNyp1gAoZ/o7NQPeH/aE1a+3RL/4fQca0QX9ed+qgOOn1soXH+Wf5VG?= =?us-ascii?Q?NhnR3Jnpfao/AGvh2ViAbKetJbJORmJijbctwwV0AwDuj0AzHpLhCErXw/Hv?= =?us-ascii?Q?xbwP5qEmCgtdXiAmBr4vq2czCZKOnMvd435M1SozPGbe5NXA80pbVNGrog6K?= =?us-ascii?Q?1cFhYbstlGQoj26Dpmaa+awPa+2RJnQHTVyzZXtlvrzO79iHocG3OvomNjYV?= =?us-ascii?Q?omVKN/OmJ4PMZqs+8p+Xs1bD1mgmGuApFIziTEG9cmtUpS8I26DzCOiqKHqP?= =?us-ascii?Q?npR49yhH8Zg+tqdqf2/wSHUVfw/qGByr7vXEkRCcAPcqldimSOrd0mF8Clx9?= =?us-ascii?Q?Hfk89XQyNKtmc+FVb6R5oNuGhH5nvdoSJT8kLvJX5/xanDNGQhh7wcmUm6pZ?= =?us-ascii?Q?JEKT2/W10eIRS/I7XcELZdt+0PmjaRdndTb4Pd4887Sf0PjqDCrN3xEWF78g?= =?us-ascii?Q?jVB7v9SXHCDplQqljmU2sJ+DKkSAGfn//DAprVJ2eCIQyiN8BJ+TjDhUtIkY?= =?us-ascii?Q?EcsiH+LMknzvqR46KTX1ORssxmmSfYQc6uzOY3mHvtBk89j3dZN2RkcFKXgb?= =?us-ascii?Q?ZSXJ+OzNP0onVD1gJfx5s8A1FAyMyEHQjrKSeU/wQC6x8oVdwudt7g9n8zyN?= =?us-ascii?Q?yQaW30DBuDAb1HPlr1T10dOk01iGVOK7jQaZfaQ/nwcURpA43r5o+sEYj/ys?= =?us-ascii?Q?g+xS1n0khxhQjqhEOiI3MPgOnMAU8uh/HPaFf7Tlf8iB6hInBRrUCTeISFVO?= =?us-ascii?Q?IS4gNvuaeOaBK6axo5hGwqVO5JG4f5NVcA9f2bbkGf2zxcEQD0dERYGjnxY+?= =?us-ascii?Q?1v9WRYrKigo9k07CHhYEqlpsp5UCeAGmeXdhBm9kVu/kXb0r9Ed6kppLISZU?= =?us-ascii?Q?iSUsdnY1uOS4z8MKC9w4bQDyaYbq3smj59IhQkvVATfIRKhFRZnkENUU18KB?= =?us-ascii?Q?AXjtcbqiXH/CfrAvR6ZXHel56uaqVcuY6HvlUbfWx0KwGLDt7opOIoE8F0MT?= =?us-ascii?Q?WJO7gAtb91JFFQ2wSKrDjvqA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc055d80-18ac-412b-7e9d-08d8df865a6e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 03:25:40.7928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GM1X7kjoZZ7XgOBhy7/VfsxgCz4eHsivzud5jSigw2CnkULTILJ/3rJW7DhHmgJnqQVCNf/HN/I9DVBBhc6VIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2358 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: dev On Behalf Of Lijun Ou > Sent: Friday, March 5, 2021 08:56 > To: Yigit, Ferruh > Cc: dev@dpdk.org; linuxarm@openeuler.org > Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx= in > testpmd >=20 > From: Hongbo Zheng >=20 > In testpmd, when we input "show config rxtx", we can see like this: >=20 > 1: testpmd> show config rxtx > 2: io packet forwarding packets/burst=3D32 > 3: nb forwarding cores=3D1 - nb forwarding ports=3D1 > 4: port 0: RX queue number: 1 Tx queue number: 1 > 5: Rx offloads=3D0x0 Tx offloads=3D0x10000 > 6: RX queue: 0 > 7: RX desc=3D1024 - RX free threshold=3D32 > 8: RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > 9: RX Offloads=3D0x0 > 10: TX queue: 0 > 11: TX desc=3D1024 - TX free threshold=3D928 > 12: TX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > 13: TX offloads=3D0x10000 - TX RS bit threshold=3D32 >=20 > In line 4, RX/Tx is mixed used. Also in other lines, RX/Rx/TX/Tx is mixed= used. If you're going to unify the print to only use "Rx/Tx" in testpmd as your t= itle said. There're a lot of more places using RX/TX when printing. You should change = them too. >=20 > This patch fix the mixed use of RX/Rx/TX/Tx in testpmd command "show conf= ig > rxtx" output by change to unified use Rx/Tx. >=20 > Signed-off-by: Hongbo Zheng > Signed-off-by: Lijun Ou > --- > app/test-pmd/config.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 576d5ac..2435c26 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2505,7 +2505,7 @@ rxtx_config_display(void) > int32_t rc; >=20 > /* per port config */ > - printf(" port %d: RX queue number: %d Tx queue > number: %d\n", > + printf(" port %d: Rx queue number: %d Tx queue number: %d\n", > (unsigned int)pid, nb_rxq, nb_txq); >=20 > printf(" Rx offloads=3D0x%"PRIx64" Tx offloads=3D0x%"PRIx64"\n", > @@ -2533,13 +2533,13 @@ rxtx_config_display(void) > offloads_tmp =3D rx_qinfo.conf.offloads; > } >=20 > - printf(" RX queue: %d\n", qid); > - printf(" RX desc=3D%d - RX free threshold=3D%d\n", > + printf(" Rx queue: %d\n", qid); > + printf(" Rx desc=3D%d - Rx free threshold=3D%d\n", > nb_rx_desc_tmp, rx_free_thresh_tmp); > - printf(" RX threshold registers: pthresh=3D%d > hthresh=3D%d " > + printf(" Rx threshold registers: pthresh=3D%d > hthresh=3D%d " > " wthresh=3D%d\n", > pthresh_tmp, hthresh_tmp, wthresh_tmp); > - printf(" RX Offloads=3D0x%"PRIx64"\n", offloads_tmp); > + printf(" Rx Offloads=3D0x%"PRIx64"\n", offloads_tmp); > } >=20 > /* per tx queue config only for first queue to be less verbose */ > @@ -2565,13 +2565,13 @@ rxtx_config_display(void) > tx_rs_thresh_tmp =3D tx_qinfo.conf.tx_rs_thresh; > } >=20 > - printf(" TX queue: %d\n", qid); > - printf(" TX desc=3D%d - TX free threshold=3D%d\n", > + printf(" Tx queue: %d\n", qid); > + printf(" Tx desc=3D%d - Tx free threshold=3D%d\n", > nb_tx_desc_tmp, tx_free_thresh_tmp); > - printf(" TX threshold registers: pthresh=3D%d > hthresh=3D%d " > + printf(" Tx threshold registers: pthresh=3D%d > hthresh=3D%d " > " wthresh=3D%d\n", > pthresh_tmp, hthresh_tmp, wthresh_tmp); > - printf(" TX offloads=3D0x%"PRIx64" - TX RS bit > threshold=3D%d\n", > + printf(" Tx offloads=3D0x%"PRIx64" - Tx RS bit > threshold=3D%d\n", > offloads_tmp, tx_rs_thresh_tmp); > } > } > -- > 2.7.4