Re: [dpdk-dev] [PATCH] app/testpmd: log reason of port start failure

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Thursday, March 11, 2021 18:49
> To: Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] app/testpmd: log reason of port start failure
> 
> Provide a bit more diagnostics information when port start fails.
> 
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
>  app/test-pmd/testpmd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 98c3248c01..96d2e0fcec 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2626,8 +2626,10 @@ start_port(portid_t pid)
>  		cnt_pi++;
> 
>  		/* start port */
> -		if (rte_eth_dev_start(pi) < 0) {
> -			printf("Fail to start port %d\n", pi);
> +		diag = rte_eth_dev_start(pi);
> +		if (diag < 0) {
> +			printf("Fail to start port %d: %s\n", pi,
> +			       rte_strerror(-diag));
> 
>  			/* Fail to setup rx queue, return */
>  			if (rte_atomic16_cmpset(&(port->port_status),
> --
> 2.30.1

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>