From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E64D6A052A; Wed, 23 Dec 2020 07:03:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ACFCCA4A; Wed, 23 Dec 2020 07:03:03 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 856BECA49 for ; Wed, 23 Dec 2020 07:03:00 +0100 (CET) IronPort-SDR: gf4BicsbMwlaYTjG7QSLb3EYU30S3Hw6DQxoWB6oEhWjvrtkMelSQm7vvQhT3jxOAQfKnwNDZt b9YNFBaVdOLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="194414543" X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="194414543" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 22:02:58 -0800 IronPort-SDR: jZIayv4yEuJnFj9IC2j/dFbtXw+qm6buuVUis7HRv0WoCby1awZwObiber876W6hj6VeyK75D+ lpE8rsuje9eQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="383092195" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 22 Dec 2020 22:02:58 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:02:57 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 22:02:57 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Dec 2020 22:02:57 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Dec 2020 22:02:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MT6kFzabAmznPOoWEcE7btNM/2A5ZZUcoKYuLDi9aHcd2iNJFZwznH9N9eMjpx44PjnSNMkFo7uJNxqa8o+V4D56otUdmtboTgU+ZuZLI1pKuBcQgbFC999MN0vE+t7qtZd7+janyDCpfg4NF+d5O2iVm0OCFhVlvwdMNW30ai949vbx5Q2RiPsWB/SpnVOICvIblj2n7JPLZYjoOT5/QVkl78g2RaIGfvHOR3k0QFcWSmG0+N+Bpqt8RYlKTbBBmMSWkP4PScBTjGWV8Z5du2Vc4fZ+vOVa98FCoiXcjJlNN08rIABelNL7gvutO6H1kRqbjyWcibIeUoDR8uG00A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CqjaC5Qw/jNFr2KGhGEcSPnuPkC+zVcpe+cekfDl7MI=; b=IcepP2xWhILpV47J4M+zT7w7AGYo85v2T6835T4EH1OQJOItWj1d1D3znmnkFC3FzPAg4luBVPyTllGcnQuxYKwbtGMyZ0ofX2PXDunvGv3DYERImcrwd/CqmLbIcvzFj+fZtxnZcr72TF/lcKgymCdb2W220M6rzsm3ydNNOrNlJyGyzPEuBYOYTh8m6B/9DJjzQGvSBr1cSDD2oh2bOG7Xl5JZzsVI+4B500MTdC7nZrGLCPcXTty2ERQy/KbcK0vZPj59y0kuh/QlqkCGE4D4zdtSvUvuuNhdGTNc2CM2qOEWr2RH6lRFYlFkW1NqKJT0J28nUam+CYxkLMk+dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CqjaC5Qw/jNFr2KGhGEcSPnuPkC+zVcpe+cekfDl7MI=; b=CaBvvdwOQrBMMh5qqUS9epoLAnuGoNdjnbe3ImT/7xc7JyoDfI+pRH4QdnFPmLyOcONyN/rxJgiKIJ2aDSIx5f7bWZ9xsN8vjg05r6gT2pcxaB/R/ls7kuGRudd6h2K52yhii4et1kHMxKqF7KfOXLZ/p6+dN4/Ga2QAJGt47ac= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR11MB1333.namprd11.prod.outlook.com (2603:10b6:903:24::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.30; Wed, 23 Dec 2020 06:02:56 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::4dd8:2689:73d4:43d3]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::4dd8:2689:73d4:43d3%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 06:02:55 +0000 From: "Li, Xiaoyun" To: Rahul Lakkireddy , "dev@dpdk.org" CC: "kaara.satwik@chelsio.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps Thread-Index: AQHW1yR2VOOQs4oMlECeZAO+XxUo8qoEMTbQ Date: Wed, 23 Dec 2020 06:02:55 +0000 Message-ID: References: <1608504422-29220-1-git-send-email-rahul.lakkireddy@chelsio.com> <1608504422-29220-2-git-send-email-rahul.lakkireddy@chelsio.com> In-Reply-To: <1608504422-29220-2-git-send-email-rahul.lakkireddy@chelsio.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: chelsio.com; dkim=none (message not signed) header.d=none;chelsio.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21ad4891-d27e-479d-cfd4-08d8a708645a x-ms-traffictypediagnostic: CY4PR11MB1333: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:989; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gsUYV8EOOmZfNZoPtYa2tWy7o3yI/irOKOXswG6VfpHOtD/gK5j0IION3DzdHPHfAfKt0eRi7EyN7sn2tH62goa7XvmrNJeamXpapFB8eNp9ojYij/AbYc+m5LiHDpIqtvqiYiL4vRFuw9elKlP5xKnmrvWz+CoQmlrHE86KS0XOCuxJmj69ug5R/KblkJSh5DGHMRB8JZXS/jdFpakONPAg/poWtFQr4SBW9NS++uzrvcVt5NGIZpjmVKCqICWtI7taV4s8qnlTyuB10nfnA06418RJTA1CsnNqFZ9XzlnlH1qsRy9NWmigwhCfImhCzSt9ts0k1UPUcAnIiepC0147Cnq5MHJLi27yQJTvtwHtqUqKTxNizqd98zW62GKA0fz3h4sCF9WMOn1sSpdDHxeJXAgjC2xhm110OqrjkCaJr7IStEeITMTQMuYZ/BLzpHGcFYzhRiBK8+bLLhKsjw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(8936002)(55016002)(33656002)(7696005)(9686003)(26005)(4326008)(86362001)(2906002)(66946007)(478600001)(71200400001)(66476007)(186003)(66446008)(64756008)(966005)(110136005)(316002)(52536014)(66556008)(83380400001)(53546011)(5660300002)(76116006)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?t39mM+gUsEzCGaQXyZcPaJQKu5DzXnHaHqVvf1JAg8GBnXhOr1e1arns0oSX?= =?us-ascii?Q?ZyIAi1NcSEc41QyHmq+i1AvEHCWB4Xm41iv+N6QpOeDs0+VuRMIZGsonRaLB?= =?us-ascii?Q?AySxkL8h0zH27sLjBiOSus85lBDzKqNMawiAIBAaYQWuwpy7nQZpyNbBUkzI?= =?us-ascii?Q?b24I1Rl8IcSdg0TAscQEWIjrEE4hyPunCCgVMb7jutezzRAeZUS93MZKy+ak?= =?us-ascii?Q?g+RyuB/1LMV7La5jI4ENdVIqdyuRqPPjfmplrP9XtQ4L7SBsPXogmvylzSRO?= =?us-ascii?Q?8PzqqHRXQjqeF42zKwB4TtB8xGrFLIHW3exEKC8D274Zu8vViffRnsRqz1vh?= =?us-ascii?Q?1ldEkmI91nSRQqilSagONBZ0kz+S7Vq2Zmb2Xc7YHO/iasjbjg76A44Fld/f?= =?us-ascii?Q?pmG0f+0Kly5xpgi7DZ4gEWhhKp5z4gtRTcWqLDmjst8wlU7b/iiphKemIt1c?= =?us-ascii?Q?/YTK5oXSDYlDqNIgEQSp+n3QUnoNztzad5wGfDaGhcy/7RuFgaagEWbZP1Od?= =?us-ascii?Q?5l7raWw4OwsVQ36x3ZhlbLXBPiUMi0oyV3Hz+h+ZZEG+eDI2sDi0HkzHHogm?= =?us-ascii?Q?2DXr1A+dmCXwfIaCr5hLzJt0fDj8cKmsAelKWRAKUeOPS8348M03sCRbHB06?= =?us-ascii?Q?J+SYUnJcvDKBcYGuPgX36HGfczSIvL606TmwtQW2z8G5TGHQapTCXUn8u9jX?= =?us-ascii?Q?GQQ1AipoNqMjdz98fendF21m49IXvEDWkv6Xh5E3ADrYKuk28NFWPFn3B9/j?= =?us-ascii?Q?8lxIl4fiI/cvViJ3IYLZZH9d/2YHWbHuPgwPdQJVT0g/14HpQxVlCmFN1AHV?= =?us-ascii?Q?O5bI8Q3itKvO5Iu+au9r+HyFxDxw4yxFEWIERobTaWz0vcEJ3eEk0HGQxoYy?= =?us-ascii?Q?qi8/GfVg7O3LRENGFeQH6F2o5u7yX6NPYb2R3KSJOM1xhlnVSgcdQ1ZDGGwb?= =?us-ascii?Q?tSChz1h1KYcv9Ff55+bFKx5C238tsSMEnX3QqHrsHNY=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21ad4891-d27e-479d-cfd4-08d8a708645a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 06:02:55.5476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gL8J1SgqBr7TO9pWM3e4D1dWLVvUfs6QHKr3VZg1dqcNKze6FWWB+WlyllmbB4NpgCvkzRSuMm32TrHipVSHbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1333 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: dev On Behalf Of Rahul Lakkireddy > Sent: Monday, December 21, 2020 06:47 > To: dev@dpdk.org > Cc: kaara.satwik@chelsio.com > Subject: [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supp= orted > FEC caps >=20 > From: Karra Satwik >=20 > Request the driver for number of entries in the FEC caps array and then > dynamically allocate the array. >=20 > Signed-off-by: Karra Satwik > Signed-off-by: Rahul Lakkireddy > --- > app/test-pmd/cmdline.c | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 2ccbaa039..d7a90d55e 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16263,29 +16263,40 @@ cmd_show_fec_capability_parsed(void > *parsed_result, > __rte_unused struct cmdline *cl, > __rte_unused void *data) > { > -#define FEC_CAP_NUM 2 > struct cmd_show_fec_capability_result *res =3D parsed_result; > - struct rte_eth_fec_capa speed_fec_capa[FEC_CAP_NUM]; > - unsigned int num =3D FEC_CAP_NUM; > - unsigned int ret_num; > - int ret; > + struct rte_eth_fec_capa *speed_fec_capa; > + int num, ret; >=20 > if (!rte_eth_dev_is_valid_port(res->cmd_pid)) { > printf("Invalid port id %u\n", res->cmd_pid); > return; > } >=20 > - ret =3D rte_eth_fec_get_capability(res->cmd_pid, speed_fec_capa, num); > + ret =3D rte_eth_fec_get_capability(res->cmd_pid, NULL, 0); > if (ret =3D=3D -ENOTSUP) { > printf("Function not implemented\n"); > return; > } else if (ret < 0) { > - printf("Get FEC capability failed\n"); > + printf("Get FEC capability failed: %d\n", ret); > + return; > + } > + > + num =3D ret; > + speed_fec_capa =3D calloc(num, sizeof(*speed_fec_capa)); > + if (!speed_fec_capa) { if (speed_fec_capa =3D=3D NULL) { You can check the DPDK coding style 1.9.1. http://doc.dpdk.org/guides/contr= ibuting/coding_style.html NULL is the preferred null pointer constant. Use NULL instead of (type *)0 = or (type *)NULL, except where the compiler does not know the destination ty= pe. Except for this minor issue, Acked-by: Xiaoyun Li > + printf("Failed to alloc FEC capability buffer\n"); > return; > } >=20 > - ret_num =3D (unsigned int)ret; > - show_fec_capability(ret_num, speed_fec_capa); > + ret =3D rte_eth_fec_get_capability(res->cmd_pid, speed_fec_capa, num); > + if (ret < 0) { > + printf("Error getting FEC capability: %d\n", ret); > + goto out; > + } > + > + show_fec_capability(num, speed_fec_capa); > +out: > + free(speed_fec_capa); > } >=20 > cmdline_parse_token_string_t cmd_show_fec_capability_show =3D > -- > 2.24.0