Re: [dpdk-dev] [PATCH v3] app/testpmd: fix meter commands help strings

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

-----Original Message-----
From: Yigit, Ferruh <ferruh.yigit@intel.com> 
Sent: Tuesday, February 9, 2021 22:15
To: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; stable@dpdk.org
Subject: [PATCH v3] app/testpmd: fix meter commands help strings

Helps strings syntax is "command : description", the 'command' part was missing, updated command help strings.

Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing")
Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing")
Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: jasvinder.singh@intel.com
Cc: cristian.dumitrescu@intel.com

- "set port meter dscp table" documented with 'port_id' & 'mtr_id', but
  command itself is not requiring it, can be better to double check the
  intention in the command.
- In command "show port meter stats <port_id> <mtr_id> yes|no", it is
  not clear what 'yes|no' is, can be better to have a 'clear' keyword
  there: "show port meter stats <port_id> <mtr_id> clear yes|no"
- 'meter' commands seems using many high level commands, that is harder
  to remember when you take all commands into account:
  "show port meter ..."
  "add port meter ..."
  "del port meter ..."
  "create port meter ..."
  "enable port meter ..."
  "disable port meter ..."
  "set port meter ..."
  And some high level commands created just for 'meter'. Instead I think
  it is better to group the commands, like:
  "port meter [add,del,create,enable,disable] ..."
  "show port meter ..."
  It is already too late but it worth to keep in mind for the possible
  future update.

v2:
* Fixed typo, actiono -> action0
* Added more info to help string, like "<variable>(possible values)"

v3:
* Fix the "set port meter dscp table" command according the original
  intention
---
 app/test-pmd/cmdline_mtr.c | 33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)