From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error
Date: Wed, 23 Dec 2020 09:00:02 +0000 [thread overview]
Message-ID: <CY4PR11MB175087339A3EFFF19F317A5F99DE0@CY4PR11MB1750.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201223085152.20866-1-stevex.yang@intel.com>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> -----Original Message-----
> From: Steve Yang <stevex.yang@intel.com>
> Sent: Wednesday, December 23, 2020 16:52
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>
> Subject: [PATCH v2] app/testpmd: fix dynamic config error
>
> The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloads of
> 'dev_conf', it would cause the configuration invalid.
>
> For example:
> Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while
> rx_conf.offloads of each queue still kept the old value.
> It would cause the failure of offloads check in 'rte_eth_rx_queue_setup'.
>
> This patch applied tx/rx offloads configuration for each queue once it changed.
>
> Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config")
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
> ---
> v2:
> * moved the update logic to 'rxtx_port_config';
> * added the 'tx_conf' part;
> * optimized the 'default' assignment;
> ---
> app/test-pmd/testpmd.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 33a060dffd..6ee28e3797 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3288,9 +3288,11 @@ rxtx_port_config(struct rte_port *port)
>
> for (qid = 0; qid < nb_rxq; qid++) {
> offloads = port->rx_conf[qid].offloads;
> - port->rx_conf[qid] = port->dev_info.default_rxconf;
> - if (offloads != 0)
> - port->rx_conf[qid].offloads = offloads;
> + if (offloads != port->dev_conf.rxmode.offloads)
> + port->rx_conf[qid].offloads =
> + port->dev_conf.rxmode.offloads;
> + if (!offloads)
> + port->rx_conf[qid] = port->dev_info.default_rxconf;
>
> /* Check if any Rx parameters have been passed */
> if (rx_pthresh != RTE_PMD_PARAM_UNSET) @@ -3313,9
> +3315,11 @@ rxtx_port_config(struct rte_port *port)
>
> for (qid = 0; qid < nb_txq; qid++) {
> offloads = port->tx_conf[qid].offloads;
> - port->tx_conf[qid] = port->dev_info.default_txconf;
> - if (offloads != 0)
> - port->tx_conf[qid].offloads = offloads;
> + if (offloads != port->dev_conf.txmode.offloads)
> + port->tx_conf[qid].offloads =
> + port->dev_conf.txmode.offloads;
> + if (!offloads)
> + port->tx_conf[qid] = port->dev_info.default_txconf;
>
> /* Check if any Tx parameters have been passed */
> if (tx_pthresh != RTE_PMD_PARAM_UNSET)
> --
> 2.17.1
next prev parent reply other threads:[~2020-12-23 9:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 8:13 [dpdk-dev] [PATCH v1] app/testpmd: fix dynamic config error for max-pkt-len Steve Yang
2020-12-23 2:27 ` Li, Xiaoyun
2020-12-23 8:51 ` [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error Steve Yang
2020-12-23 9:00 ` Li, Xiaoyun [this message]
2021-01-13 8:13 ` Chen, BoX C
2021-01-19 15:44 ` Ferruh Yigit
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 0/3] fix 'max-pkt-len' errors Steve Yang
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 1/3] ethdev: fix MTU doesn't update when jumbo frame disabled Steve Yang
2021-01-25 7:12 ` Huisong Li
[not found] ` <DM6PR11MB43628A600BAAEC75FFF1343BF9BD9@DM6PR11MB4362.namprd11.prod.outlook.com>
2021-01-25 12:38 ` Ferruh Yigit
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: fix max-pkt-len option invalid Steve Yang
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: fix dynamic config error Steve Yang
2021-01-22 17:04 ` Ferruh Yigit
2021-01-22 17:15 ` Ferruh Yigit
2021-01-25 8:32 ` [dpdk-dev] [PATCH v4 0/2] fix 'max-pkt-len' errors Steve Yang
2021-01-25 8:32 ` [dpdk-dev] [PATCH v4 1/2] ethdev: fix MTU doesn't update when jumbo frame disabled Steve Yang
2021-01-25 12:41 ` Ferruh Yigit
2021-01-25 8:32 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix max-pkt-len option invalid Steve Yang
2021-01-25 14:45 ` Ferruh Yigit
2021-01-25 15:46 ` Lance Richardson
2021-01-25 17:57 ` Ferruh Yigit
2021-01-25 18:15 ` [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length Ferruh Yigit
2021-01-25 19:41 ` Lance Richardson
2021-01-26 0:44 ` Ferruh Yigit
2021-01-26 3:22 ` Lance Richardson
2021-01-26 3:45 ` Lance Richardson
2021-01-26 7:54 ` Li, Xiaoyun
2021-01-26 11:01 ` Ferruh Yigit
2021-01-28 21:36 ` Lance Richardson
2021-01-28 22:12 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-26 9:02 ` [dpdk-dev] " Wisam Monther
2021-01-27 3:04 ` Li, Xiaoyun
2021-01-28 1:57 ` Chen, BoX C
2021-01-28 9:18 ` Wisam Monther
2021-01-28 9:26 ` Ferruh Yigit
2021-01-28 11:08 ` Wisam Monther
2021-01-28 12:07 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-01-29 9:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB175087339A3EFFF19F317A5F99DE0@CY4PR11MB1750.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).