From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA302A052A; Wed, 23 Dec 2020 10:00:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E1A5CA4D; Wed, 23 Dec 2020 10:00:14 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 016FFCA4A for ; Wed, 23 Dec 2020 10:00:12 +0100 (CET) IronPort-SDR: qDyflAcGdfHUnncpcZ1HhtuQtoK3OypZxwsxUqagOlJOBiipeq+ZwP73P4RxvKkhSV795lgRgH Tcr7GW1aqTvQ== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="175210055" X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="175210055" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2020 01:00:10 -0800 IronPort-SDR: JGqjymDnJiLJz6LoZWStZ9yY/xXoAxqjBcP+FjifAwf7OJonBjg/FWE9B7NbR4oC8A+MuaIVY3 NvO1VYUwsaPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="342196626" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 23 Dec 2020 01:00:10 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Dec 2020 01:00:09 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Dec 2020 01:00:09 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 23 Dec 2020 01:00:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7JhJxGj/ymWrL6TRZVXfoD6PfwyP6Lnc0lHsslk4A/zb8W5Mv7ZBVglThMHtuInGmg1of9E7iuLX7lKZN7zfrYcoWl7AEksJcMmLtKBTIj3KPk7cv1Xbrl6Hfq0QIFIWxivd/6y0FrJBf2vlATI2RNL9F1pszf/xeRLgZFHLDcL+geL+ZJ1H0MVrNo62h4Z2naG0D6W5OQCv22hkimrn9uL+u++7ZAflWGd0oglz9TgaOaZXskKwskxBuVa79l4ciNhM92qO6C2q6M8e0BeAkFC5NkX2SV6iGMOO3ChNdJrmSfoUm6IVvEQC0OW74F+wRiprU7DIvgnDcHpbzIpjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LTU/ZmfCQFWIIZDh+mn4CGHeKT6gnnHaLDwKKboiQA=; b=eQWuFXGHzw0199P4QxZfqYpBT3iHPcKXlbPzDoExb6dw30WPTP8rmqP8WIhNYV4soDnp5PI+TocmGt5T05B7tFFUiBpaDOzHZbDJMkgvzfSk7pTo4kRjvK7DwNYLm1K+DGpv/NQkQhjrIqxWr5RQUWqHvhHOZNiUIN2RL/DuC9rWFP/P6G7pAvdEZBq5xMramJVxk8kqsUev5KgDStKphSygTBwBLYivQxSxgriUQsrTCTgTJH8ctvJuNlTytReHFMHe20aQbwJnLihvl68bMXiZ0CgCmOL6M+4DYHtpeT7HoEvmrKAS/dJvL2T1DRJMT0j8qxsORXyBAgTu2HOfsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LTU/ZmfCQFWIIZDh+mn4CGHeKT6gnnHaLDwKKboiQA=; b=CVRXGEzIk+WXGVuhrGB2ubVJ7o42tm1wBWXU4X4cwwe204dh3czigKeMVgeUI9f4GHs2ZZCsBcWu8yRsQAcaPMA5/x9K0WfVyjSmoS38YnXT+bKEWrqkZhEkP9Z8l1NCkW4ubi84i8fbvFHoLf9MZxf0aHXy6ZPqvr+aq3jOKCQ= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR1101MB2358.namprd11.prod.outlook.com (2603:10b6:903:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:00:02 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::4dd8:2689:73d4:43d3]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::4dd8:2689:73d4:43d3%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:00:02 +0000 From: "Li, Xiaoyun" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , "Yang, Qiming" , "Yang, SteveX" Thread-Topic: [PATCH v2] app/testpmd: fix dynamic config error Thread-Index: AQHW2QlI/wpUL6VSQk6IERtxiI44bqoEYc9w Date: Wed, 23 Dec 2020 09:00:02 +0000 Message-ID: References: <20201222081335.17419-1-stevex.yang@intel.com> <20201223085152.20866-1-stevex.yang@intel.com> In-Reply-To: <20201223085152.20866-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0d41218-8184-4360-8963-08d8a7212261 x-ms-traffictypediagnostic: CY4PR1101MB2358: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R4jvfT7vmeEb61ILKqWhGjRoU1BhdmxwNjRgo0zNz3fC3XEz9i9RPP5eWyAxUQoGUz2JgWRY9JkMyb1Pj1Pn6jnUsBob4zE5ZClK7+kZY9X5+QZ5DIZnm3XtdPlTlQXWnvIlO3uPQeYVCjMYm3asrVVQ1autuTpQ894f73UGa6LDiy6e3/fGxbJhb2RgWUwDopArgDj+PY11d2bVSMAK9PToEE6AQYvjs+z/TZvudhYtmAu4WqcDZhwKHhLEuB8IOqwFwPV65QauxL2Tg3xoFy6Ys8y7NyqrG6tRnvvK3MP6ApnbkBCuBu0/ApaLOZmfURlInB+qzCp8IbcFnxiAbPyuHw7KKbAwIn2WjeyrpfO8DrFAg6u7m7A0iQxUebb3/KlzXwn8UEkLc9QDnXR0Ug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(366004)(33656002)(66446008)(66476007)(66556008)(8936002)(64756008)(478600001)(76116006)(4326008)(54906003)(55016002)(2906002)(110136005)(71200400001)(9686003)(8676002)(86362001)(7696005)(6506007)(83380400001)(316002)(107886003)(53546011)(52536014)(66946007)(5660300002)(26005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rBBcfkDdF3Cs51L2bfnjBdZdOKyLBgZCfzcQGMoZ1NC0LiWPreerK8+f8dM2?= =?us-ascii?Q?N1lKv+pApSxP06ttD9tnSRSWt4jkdNWiqxA2PGP+2SNUizoTFJBYAkxTl2wy?= =?us-ascii?Q?x8oSZ/LJdGHbDav/DBsmenJid61qcS6RyzkDdciK1SBTdEf/VdwLQ9g9kfz2?= =?us-ascii?Q?FyyNSYjpmWvpaVSJVy91GCJ1CC3Fw5+ie5Vzf2IaeY4jY59HpX3OsAC5/82a?= =?us-ascii?Q?4jbWoaC/mH9g+SUm/XP4iGCErBXolvwdh/aN+C6ol3zBXckbvZi3X+6SwulO?= =?us-ascii?Q?DjPpAdGKnVnZE6vRxxVF1HwoATZGDj9F28EtsF/+P3F0Hz/NOmhiujF/yoob?= =?us-ascii?Q?4lFY87NinNgHVeah+9j0ssrqcISJo1pzzdyDpcnQF46avoZbJs3eMR5qtJSW?= =?us-ascii?Q?6Rl1uWJnvJ7lWg/dt+/u+S+6IGel00H/2vHYr6QqixELVOCMu3+sxEAz10Va?= =?us-ascii?Q?xxWt+l+5U+ijM7nbh+ZBK2XOl6YO9V8hLV/vPsJZkPbpzuGhbVba4ffsfQAg?= =?us-ascii?Q?6aka9fTsUctCW9gN+YKrWFje8iBd5CgfM95vGTedLvnRIO5iwQV0DQkVzN/H?= =?us-ascii?Q?jqvmtl5SsyNgGDs5fpsS0J9XDnczWG1i4m+b4khcXA9DeKrbRQ7zt78Sd6kI?= =?us-ascii?Q?zEyu9RbvYZMs9iwebSyBYuRIeofrMtKxjnO4zMTu4PE5wYxBLY/FaVFtV/tN?= =?us-ascii?Q?sAIu/RpQ9k9ZGVajLeDhVjkCfRNj2BXi2U44cOcE+vvXRk9TVoDatoDFW9Uz?= =?us-ascii?Q?4Le4FpFx6tqY/bVzkbsOqupMr5oCtmAmKfrtmKWSClhSHa91D1P97nnXCFTX?= =?us-ascii?Q?MTGWmS4YXw8ys2H6x9M6M8cTqoZBfS0dy+CUAWalrxDHmXAyJyLot5aFaJZW?= =?us-ascii?Q?HQ3LT91PVp6Vpj8+ztnTtF5hNQ0IQgjNL8grrOdQ/6qYLnaUJGuQ50S7UVdL?= =?us-ascii?Q?pAb+Toqxv8Ja5XJ+6BMQOQ683ZOi/5w68Dton0I9+Nk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0d41218-8184-4360-8963-08d8a7212261 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:00:02.4382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2KWbz2lgyp89CZoKbJi4NcR+H0IINZgTjyOT6FFsFqz2FTy8sfjtQTdwM0MOaJ0jrYbA/ekO7epN/gPCQKOtsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2358 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Xiaoyun Li > -----Original Message----- > From: Steve Yang > Sent: Wednesday, December 23, 2020 16:52 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard ; Li, Xiaoyun > ; Yang, Qiming ; Yang, Steve= X > > Subject: [PATCH v2] app/testpmd: fix dynamic config error >=20 > The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloa= ds of > 'dev_conf', it would cause the configuration invalid. >=20 > For example: > Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while > rx_conf.offloads of each queue still kept the old value. > It would cause the failure of offloads check in 'rte_eth_rx_queue_setup'. >=20 > This patch applied tx/rx offloads configuration for each queue once it ch= anged. >=20 > Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config") >=20 > Signed-off-by: Steve Yang > --- > v2: > * moved the update logic to 'rxtx_port_config'; > * added the 'tx_conf' part; > * optimized the 'default' assignment; > --- > app/test-pmd/testpmd.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 33a060dffd..6ee28e3797 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3288,9 +3288,11 @@ rxtx_port_config(struct rte_port *port) >=20 > for (qid =3D 0; qid < nb_rxq; qid++) { > offloads =3D port->rx_conf[qid].offloads; > - port->rx_conf[qid] =3D port->dev_info.default_rxconf; > - if (offloads !=3D 0) > - port->rx_conf[qid].offloads =3D offloads; > + if (offloads !=3D port->dev_conf.rxmode.offloads) > + port->rx_conf[qid].offloads =3D > + port->dev_conf.rxmode.offloads; > + if (!offloads) > + port->rx_conf[qid] =3D port->dev_info.default_rxconf; >=20 > /* Check if any Rx parameters have been passed */ > if (rx_pthresh !=3D RTE_PMD_PARAM_UNSET) @@ -3313,9 > +3315,11 @@ rxtx_port_config(struct rte_port *port) >=20 > for (qid =3D 0; qid < nb_txq; qid++) { > offloads =3D port->tx_conf[qid].offloads; > - port->tx_conf[qid] =3D port->dev_info.default_txconf; > - if (offloads !=3D 0) > - port->tx_conf[qid].offloads =3D offloads; > + if (offloads !=3D port->dev_conf.txmode.offloads) > + port->tx_conf[qid].offloads =3D > + port->dev_conf.txmode.offloads; > + if (!offloads) > + port->tx_conf[qid] =3D port->dev_info.default_txconf; >=20 > /* Check if any Tx parameters have been passed */ > if (tx_pthresh !=3D RTE_PMD_PARAM_UNSET) > -- > 2.17.1