From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACD59A054F; Tue, 2 Mar 2021 08:07:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AC5D40FDF; Tue, 2 Mar 2021 08:06:57 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 385964068C; Tue, 2 Mar 2021 08:06:55 +0100 (CET) IronPort-SDR: tuWM1DqubxgD0uGhxB9l+hnlNYpeX9GfFUQC0hVic/tvZLotUhnDLUqU6QQAAHEsz9oEEqtGZq LKnpb/Z3zdnQ== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="183316112" X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="183316112" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 23:06:54 -0800 IronPort-SDR: m0vgnvRaIZgP0Rj3MW+zpGYixoiGbIxVtchXqKl8IZdPLh07d+oWc0jK+Epvy0/yHCsHRBbNnJ n+2J6LPu9GiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,216,1610438400"; d="scan'208";a="406582864" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 01 Mar 2021 23:06:53 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Mar 2021 23:06:53 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Mar 2021 23:06:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Mar 2021 23:06:53 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 1 Mar 2021 23:06:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cupo4xc7qQ0thlVg5ln9nH3oNxIqTxJzlJwFvpvTdWh65LF+pwKp3rD+s3Cc24dPSIV+tcu6l05SblzqWzVYV5r5QqxxGEEyf/7vPy3Pl9ZFJJcuL9Q92BUXKKb/GY3MEICWFLw3FdsDpRi5Yh+0BWUezbxaHhkg+MxHG4kShPFa4iUjBjRzAfZUk04wxAtidYgsRgN6B4ReP9Ub0k11etbd/s9W3Y0c6C5CY11HEfdBTfuZDUYMQLYpjgHVq3KQnyx4qpOKGMbeid2Qu2jWAZGOHJLkGJdjMyagka2FKQvgDGRgxaRFyMLuuSZG3TbyEqb4D2rXD0eA0b/dcF9hkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=up8YRVbyUtswKj/ayI0KpWj8fBt81jEcmLv9VK3rBDo=; b=l4iRbbKNiz50TxABzBx8+/vLL4gNYPR1v6lRobO1bSCsETMIJQM5dO5Dina3Ek3R4jjnEtG8Ssr5936+n4gyJhtaoZoJ2CQijWwiUHiB5jRUqUMsvnYTveGNYnAfFtP/VKtQMaM/VPm9ZkDw6JXrfvzMrr1VdBoZOOZXvNFrUCJDaLhHP0f1pUfOmOioFLHl+y8RMuujMjMZp7XrcZcXjELKoDLo1ytF4i1+KZ+dpYz/CoVGm7pOCqDFjTmEkRCl91JKFvM5dRwMF3dQCl/Hwoc0WEyRAU0Bjs4/84QUP5thdA3SnTmQQMoDGQHyXt1lH0ZIkbEf9F48m618TGU7rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=up8YRVbyUtswKj/ayI0KpWj8fBt81jEcmLv9VK3rBDo=; b=LmlOPoS99AdMWVEYuEqed1s8E6/2FBa8KpL3h6ogM1ieuJ0XyjLkO4csUEFGRwGlIIdRhkGTXNTOvf9saUfSlOGlExzI+vV6Yk9RF7HOzckxsUOclTItt9k1rTCkxMk5PhuayvJZGe2sxKkcuEJlVxbTVI2Riv7YZR5X/F5HK8Y= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR11MB1415.namprd11.prod.outlook.com (2603:10b6:903:2c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.26; Tue, 2 Mar 2021 07:06:50 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::8fd:c082:f2bc:f6ae%12]) with mapi id 15.20.3890.029; Tue, 2 Mar 2021 07:06:50 +0000 From: "Li, Xiaoyun" To: "Xing, Beilei" , "dev@dpdk.org" , "Guo, Jia" , "Finn, Emma" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix IPv4 fragment offload issue Thread-Index: AQHXDBfSL7aaqgElr0OqGMq1n6DnvqpwSVQAgAADe0A= Date: Tue, 2 Mar 2021 07:06:50 +0000 Message-ID: References: <20210226081438.1693788-1-xiaoyun.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3677847-c908-4735-6b6c-08d8dd49c074 x-ms-traffictypediagnostic: CY4PR11MB1415: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i3NqKvECXqSFNImeuM8qI5Usr+pCCm9aT/T1EYVSM8IhK8dFF/Nb3itsdl7OdseFnpLHBmUYRwEuVUQk4wfN+5apViFHmT90lxGEh71fhATzsngYfKlEOxmM12Iolb26KFUGBHLsmBC/PGjxGCj72iBQSf+IB2fSjDG5CD/u9xxJH4TCb77+8psnE2k03S5kvv5IOcKfeTShAhm3i3QkisdTQpgSWB3Qetft8xDX5sC5vttX1WuaKdlGe0sPmP3qFGulzzIMUypfIEyDubJxzxEjIKvbmTODZM3OT4murd33iSAgIDx7E8/6Zh/nt/fJ+OTfgYCFYxYw7UnY86KpbNNB+nOaMG1//xii+g8O3ooTTpvuRCmAQcFk5+OT7J+1NTT6s/Clh7U4SLj6vAsU/4Mjr2KkOIQ16sykZeoAIFx7nMwzwpIwDQhgGq1PZIPFeOkGVj60jdLua9PZ4PUjM0ObHD1jjD0xLfPLK/jI9uj2GuDXqumhoUPlN/EQaE7DA7SRSJA8MZPux0ny33mqQQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(136003)(346002)(39860400002)(396003)(8676002)(6506007)(33656002)(66446008)(110136005)(55016002)(53546011)(71200400001)(86362001)(7696005)(5660300002)(66946007)(316002)(8936002)(26005)(52536014)(478600001)(64756008)(186003)(66556008)(4326008)(66476007)(9686003)(6636002)(83380400001)(2906002)(76116006)(450100002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?q5AE32Mk+Ny1HN6XaZMuAOoN57WWvFd/Yh7bS3KosKd99JHVVS7a7S02p64i?= =?us-ascii?Q?C9tQbgHL9whiDTNlytOu8KLUt2U61b3vLDC5x81jjc4OfUhrlokBB7It06yl?= =?us-ascii?Q?69fwVjI2gNOjxh1Qlaf1jdlV6VfZzgV3FnE8OyoWOBIIxvDkw1fJMVIvrHDu?= =?us-ascii?Q?x7bFMO1ZowvSmNpnY3Hg6yw1lvf1YBfPA00spDSESo91Yr8XFXBcQgxLbopt?= =?us-ascii?Q?kLAEyrjNNzAKm07gyDb0XEcvmgqyl1I8/2uVX5MOw0s0HRyGbIy6kEPci+fR?= =?us-ascii?Q?kTZXskIb5OqOLTMXn6eYh8ejv0OvGpZeH8i8O81T905sQNxuK4HkkGS5Nona?= =?us-ascii?Q?6yhVUo/JSRMsrFbcji0B2dVJAZuyZYLEXXhC0jh5leX+NGNJbzebSB5HRILr?= =?us-ascii?Q?ja7C5V1jAX//5ZBFB91TEPykf9tf3Llw0joOEhPJ5V67fbatQjS9jQ33T2kb?= =?us-ascii?Q?MEXxYwDrxJZ6LFNYJ72LCIq0BSAAGjyWPJ9OT9wRM5W9ultzv+0QPKuKHIPF?= =?us-ascii?Q?ynwJyqCz85RgiJV+hhZqCmVNJiufY69EZrzxzZ1uNtAYr+rjSMUvUSqrrJlB?= =?us-ascii?Q?bW3L4Acrm91mhi0CsopeWS3WRMwt8b0eXcYzl0MlJTVoDTlCpR4zBmTNxAGS?= =?us-ascii?Q?2RsfBD7olAZu5rbGHZKIsj0kyzKPdkLTctg1r+6oM6ogBWroZAj3GjMokkTh?= =?us-ascii?Q?L9zu0U8632dh4Rk8mY/YGhE1WusbTsASIaXlXmnstKmWwXdCTilC843ZSGzc?= =?us-ascii?Q?KWCbgN7Iu8KzctwKEdXCaCMgW3eusZDPqdZS1fFHCZOHeJGCx4y0sh2Axdk1?= =?us-ascii?Q?ELdv8sWqlB/WM48IymlcDbwsFjZvsN/Pp9rGkf8E1IHR4e1siV6pxM69Yy77?= =?us-ascii?Q?7uaazQU6MVnhPa03MLNELS4d3Fv7ujxyOOIbQo3U0hBd4sgmeM6hoGlDHQe6?= =?us-ascii?Q?2Dr+xKuIHZUPcPXbW/z+wv2uV6S/b3vj2gCLOKVxVoItIJW/J5QEmQB2JWs0?= =?us-ascii?Q?5yBK8VlPI6yW23lE4kWDSFwJcvZ/GdO0X8wdqR7fYqILVGEVdvVP82Nwg9h7?= =?us-ascii?Q?lsdUNzFjnvN6gJoUuKgy4XQS/Tpe9Du8O1yMv1wkEoWc0QaWqr70X8Uq+lN+?= =?us-ascii?Q?ZT/Cx3rEN0HXtyB25brMJjGRr2uwKEOTLQbOvckVdWmY39wMQnDytZUSTnWy?= =?us-ascii?Q?DcDBqp68XsPUuGKRipRYbDNuFJONmahMWrMwxfLPKCHtifzObHdkFDOwn4IE?= =?us-ascii?Q?ywAaaFBSnjDUnEM2s47/HAMzgG8Xi/sBtnyV/3u1Y90GymnV2s9NgqRXuEJG?= =?us-ascii?Q?mVwtZVVCoViuw4OjFRS507rq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3677847-c908-4735-6b6c-08d8dd49c074 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2021 07:06:50.3411 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MmupTS+mwO3lYfKOQhgAJk6RWUr62yWxYLZUTfjPL/YTKq+dNnrd7pTLFKr8z+gr/DaXfBwXj5LCbjBjtDMf2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1415 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix IPv4 fragment offload issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, March 2, 2021 14:54 > To: Li, Xiaoyun ; dev@dpdk.org; Guo, Jia > ; Finn, Emma > Cc: stable@dpdk.org > Subject: RE: [PATCH] net/i40e: fix IPv4 fragment offload issue >=20 >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Friday, February 26, 2021 4:15 PM > > To: dev@dpdk.org; Xing, Beilei ; Guo, Jia > > ; Finn, Emma > > Cc: Li, Xiaoyun ; stable@dpdk.org > > Subject: [PATCH] net/i40e: fix IPv4 fragment offload issue > > > > IPv4 fragment_offset mask was required to be 0 no matter what the spec > > value was. But zero mask means not caring about fragment_offset field > > then both non-frag and frag packets should hit the rule. > > > > But the actual fragment rules should be like the following: > > Only non-fragment packets can hit Rule 1: > > Rule 1: mask=3D0x3fff, spec=3D0 > > Only fragment packets can hit rule 2: > > Rule 2: mask=3D0x3fff, spec=3D0x8, last=3D0x2000 > > > > This patch allows the above rules. > > > > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyun Li > > --- > > drivers/net/i40e/i40e_flow.c | 89 > > ++++++++++++++++++++++++++++++++---- > > 1 file changed, 80 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index > > 4d44282312..86d96d9a11 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c >=20 >=20 > > + "Invalid IPv4 " > > + "fragment_offset mask"); >=20 > Needn't split the comments line. >=20 > > + return -rte_errno; > > + } > > + /* > > + * non-frag rule: > > + * mask=3D0x3fff,sepc=3D0 >=20 > Typo: sepc->spec >=20 > > + * frag rule: > > + * mask=3D0x3fff,spec=3D0x8,last=3D0x2000 > > + */ > > + if (frag_spec =3D=3D > > + (1 << RTE_IPV4_HDR_FO_SHIFT) && > > + frag_last =3D=3D > > RTE_IPV4_HDR_MF_FLAG) { > > + pctype =3D > > + > > I40E_FILTER_PCTYPE_FRAG_IPV4; > > + } else if (frag_spec || frag_last) { > > + rte_flow_error_set(error, > > + EINVAL, > > + > > RTE_FLOW_ERROR_TYPE_ITEM, > > + item, > > + "Invalid IPv4 " > > + "fragment_offset rule"); >=20 > Same as above. >=20 > > + return -rte_errno; > > + } > > + } else if (frag_spec || frag_last) { > > + rte_flow_error_set(error, > > + EINVAL, > > + > > RTE_FLOW_ERROR_TYPE_ITEM, > > + item, > > + "Invalid fragment_offset"); > > + return -rte_errno; > > + } > > > > if (input_set & (I40E_INSET_DMAC | > > I40E_INSET_SMAC)) { > > if (input_set & (I40E_INSET_IPV4_SRC > > | > > -- > > 2.25.1 Thanks for the review. Will update them in v2. BRs Xiaoyun