From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate
Date: Tue, 15 Dec 2020 08:34:43 +0000 [thread overview]
Message-ID: <CY4PR11MB1750AF0050CEEE3B4C59FEDA99C60@CY4PR11MB1750.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201215061234.36276-1-stevex.yang@intel.com>
Hi
I don't think this is right.
One question: What if users want to disable rss? What you're doing right now will just make testpmd ignore "--disable-rss".
BRs
Xiaoyun
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Steve Yang
> Sent: Tuesday, December 15, 2020 14:13
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>
> Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate
>
> When testpmd launched, the default RSS hash function will only activate
> 'ETH_RSS_IP', it isn't consistent with the command result of 'port config all rss
> default'.
>
> Removed the default 'rss_hf' limited in 'init_port_config', that will use the
> default supported RSS hash function for NIC.
>
> Fixes: 9089296206ce ("app/testpmd: fix config due to RSS offload check")
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
> ---
> app/test-pmd/testpmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 33fc0fddf5..ed6b438950 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3505,7 +3505,7 @@ init_port_config(void)
> if (nb_rxq > 1) {
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
> - rss_hf & port-
> >dev_info.flow_type_rss_offloads;
> + port->dev_info.flow_type_rss_offloads;
> } else {
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
> --
> 2.17.1
prev parent reply other threads:[~2020-12-15 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 6:12 Steve Yang
2020-12-15 8:34 ` Li, Xiaoyun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1750AF0050CEEE3B4C59FEDA99C60@CY4PR11MB1750.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stevex.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).