DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate
@ 2020-12-15  6:12 Steve Yang
  2020-12-15  8:34 ` Li, Xiaoyun
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Yang @ 2020-12-15  6:12 UTC (permalink / raw)
  To: dev
  Cc: wenzhuo.lu, beilei.xing, bernard.iremonger, ferruh.yigit,
	qi.z.zhang, Steve Yang

When testpmd launched, the default RSS hash function will only activate
'ETH_RSS_IP', it isn't consistent with the command result of
'port config all rss default'.

Removed the default 'rss_hf' limited in 'init_port_config', that will
use the default supported RSS hash function for NIC.

Fixes: 9089296206ce ("app/testpmd: fix config due to RSS offload check")

Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
 app/test-pmd/testpmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 33fc0fddf5..ed6b438950 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3505,7 +3505,7 @@ init_port_config(void)
 		if (nb_rxq > 1) {
 			port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
 			port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
-				rss_hf & port->dev_info.flow_type_rss_offloads;
+				port->dev_info.flow_type_rss_offloads;
 		} else {
 			port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
 			port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate
  2020-12-15  6:12 [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate Steve Yang
@ 2020-12-15  8:34 ` Li, Xiaoyun
  0 siblings, 0 replies; 2+ messages in thread
From: Li, Xiaoyun @ 2020-12-15  8:34 UTC (permalink / raw)
  To: Yang, SteveX, dev
  Cc: Lu, Wenzhuo, Xing, Beilei, Iremonger, Bernard, Yigit, Ferruh,
	Zhang, Qi Z, Yang, SteveX

Hi
I don't think this is right.
One question: What if users want to disable rss? What you're doing right now will just make testpmd ignore "--disable-rss".

BRs
Xiaoyun

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Steve Yang
> Sent: Tuesday, December 15, 2020 14:13
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>
> Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate
> 
> When testpmd launched, the default RSS hash function will only activate
> 'ETH_RSS_IP', it isn't consistent with the command result of 'port config all rss
> default'.
> 
> Removed the default 'rss_hf' limited in 'init_port_config', that will use the
> default supported RSS hash function for NIC.
> 
> Fixes: 9089296206ce ("app/testpmd: fix config due to RSS offload check")
> 
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
> ---
>  app/test-pmd/testpmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 33fc0fddf5..ed6b438950 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3505,7 +3505,7 @@ init_port_config(void)
>  		if (nb_rxq > 1) {
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
> -				rss_hf & port-
> >dev_info.flow_type_rss_offloads;
> +				port->dev_info.flow_type_rss_offloads;
>  		} else {
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-15  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15  6:12 [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate Steve Yang
2020-12-15  8:34 ` Li, Xiaoyun

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git