From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D050A09EE; Tue, 15 Dec 2020 09:34:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D3D9EC9D4; Tue, 15 Dec 2020 09:34:53 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BED75C9D3 for ; Tue, 15 Dec 2020 09:34:51 +0100 (CET) IronPort-SDR: yoVBMLXzqmJF7HzVExgwP4PmeJLnN2y8DxSyiIhD4Ptt0NwwlWugCKaomi8yuE/LFeZsvB0bjD 3Q3xZogBd6Kg== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="174989533" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="174989533" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 00:34:49 -0800 IronPort-SDR: tMV//RY/yKHP2XdCTHgGzvUh7w9Q13cbHHj1osvruwmqb6v3pt4utw6BoO69wT1tOefWcxLiup AG/CiGtG4Pxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="378482967" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 15 Dec 2020 00:34:49 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Dec 2020 00:34:49 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 15 Dec 2020 00:34:49 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 15 Dec 2020 00:34:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qc6AMisBDNpUT2PcWUcnzQfnKMZolSYjfEgn7ZnNrrVhmFlcJa/Rnimj+/Za1xEst58ZtWNZXm1Kf9bwOffvpG7WuPDl67KvMNd4wUbaWJZzJJ+ZgmnRA+8mm3G3OwJ/zN7nqP3osEu+rJI2T5hci74W/fg2usi38EU0lFdS9blSAP+BcGR8XWvzVuWfY922vnWLB7nhBChx5TCFIQMzFQBvL1Xrq3zUuUPHQzD+onERkAyF62Ck8u+1WVZ1gRzFttmOOyJhhtB5qrI9vOiCum7IuvKYMSgBDvTqR3vadz/linLTWJcWwOvqkm3liQHC+w1PXgQ4SDk9JDvGlNFVOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUxUeqrXfYp19sZYlNp6Q6wW2xaAzpwJWvJpzyhIC3Q=; b=hraBIecRukDodod7n27Q6WPrXoW7E2CNK/xl6VZdWtM+WWGkSd4OtRvYMlz8f0VPKWl5lGiYmNjQM9KmegpoHP0dkZQrmhsexNztuylHNp1nxyHEH+QLIZw57ssHp+37HiGbOf6MI+p8qZX+Z4Je1j+K0LoyO4uDCoJJ+NX3QkJv4ZcmhUCqSBc+R80MSvlja0BeWU52RwCOlUC1jcSTDhDi3+t0jamNmL/ToeoTIo5hPXxX3dM7lgBC32Um45TZK6nMdNoH2OGvklpMC3D2rAOTajtDHzZHUJpHic0IHZQv3NtBd0OZE9+U7T4xw3/Ahchg7lYO9TrMskcV1uF4lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUxUeqrXfYp19sZYlNp6Q6wW2xaAzpwJWvJpzyhIC3Q=; b=eKYK4S3VcL+16UV8FvaaFitOkiQs9k87/evOqHsxNT+2TP/Wzn2700KztIJrRs9pEPnFYk3y9RtNF3nhdXlKn7urUXuwKx3fHVecpYcofxSPBqR5JdVKSKzE432a/MLkgFY6Lb5apMVhtutq8lK5HYmimFzs2Z2ksJUYdHi8vTI= Received: from CY4PR11MB1750.namprd11.prod.outlook.com (2603:10b6:903:126::8) by CY4PR11MB1847.namprd11.prod.outlook.com (2603:10b6:903:127::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.19; Tue, 15 Dec 2020 08:34:44 +0000 Received: from CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::5999:7f2b:fc1d:5352]) by CY4PR11MB1750.namprd11.prod.outlook.com ([fe80::5999:7f2b:fc1d:5352%9]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 08:34:44 +0000 From: "Li, Xiaoyun" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , "Yigit, Ferruh" , "Zhang, Qi Z" , "Yang, SteveX" Thread-Topic: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate Thread-Index: AQHW0qm6aQBlWQ/a0U6b3oyGKtyUWan31EQQ Date: Tue, 15 Dec 2020 08:34:43 +0000 Message-ID: References: <20201215061234.36276-1-stevex.yang@intel.com> In-Reply-To: <20201215061234.36276-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ae4012f6-4e91-4f84-12a3-08d8a0d44602 x-ms-traffictypediagnostic: CY4PR11MB1847: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gYWEtCJvBbA0hh7bn8dOvueMWbi6qj6+sQVqKlL5WuZBAJX0BIkQkOaKlJR+y5mctoDPYclJNfjr7BkFFIOpjEaILCKaR7iGoWw5M/89/2i5AmxyBOB7HZZbUe5qCuQkTMZDWOIeYZJgAV60KjzG2RyynL5Nf67pFDEU1rsHV1Pe13vKq7lbUfvFJ4en+xbg/MmepDlqXtH1v51eqUFy8//nJnW03UykMbYXvlkL2OpCW2R0jp7gQJbSEI437aq5jnuwzCtgc97amVU986t0BJNchh6+/cjOeXzgIqK0zPkmsmfVTwcLRJY0L4tLm22BGPPvGn6qF9At4UZgfuT29Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1750.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(346002)(9686003)(64756008)(55016002)(6506007)(54906003)(66556008)(66446008)(7696005)(83380400001)(33656002)(8936002)(508600001)(86362001)(66476007)(26005)(107886003)(4326008)(53546011)(71200400001)(52536014)(186003)(110136005)(5660300002)(2906002)(8676002)(76116006)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kGAATqPkS7DXFPiUdSJCce368CJAhmiEs7N+xwKm30sZKJnOK2c13QIgyh6i?= =?us-ascii?Q?0eoQfo/H9BPGPr1bgbsnArq0vf2v3X2gPPQ/3jKvPssXpDLUR7re4hV/y5wt?= =?us-ascii?Q?NxmsY0N8iBaNfgEUK/dKg4aesPiJ9JXgIzCC1JovfpUU3HGHOg5PabQDBscn?= =?us-ascii?Q?QDOET+jW9GBGDQngfCP+yRfhcrgTuwbzaPktY3l7ZdX9tK8rvW372JIDeyBP?= =?us-ascii?Q?3H0KEwTELgttR/ypJnWF+z34q/q7KzUVTWnrIhrZA+EKOBr1ARj9IMYIYP+a?= =?us-ascii?Q?7W8clwjCyJCrvSksQ2CgCtunGGDQTk2EHaSxUgD0wkk31hJox1WIyhStQTb2?= =?us-ascii?Q?F1iGpypLVCaDK9k+OaSi+Yqz/CxxIThP2nitvW1MU8Xbq62CPDAk7xXVAIkg?= =?us-ascii?Q?NpljUAK1wbh9p2a9Ua405OJQ/hsu599iJYKUs7VhWxJXwURkObtSGhf17vVG?= =?us-ascii?Q?+L96ylJP3ayYvqSijxPybqUwpGJB1Ziy1y0jOPTfjAROJTjr7GLHHsEpLP/t?= =?us-ascii?Q?ejfh8C6QD3ffVLELFoOntz3hWli30qC0i9azgAb5CIYIdYWB11xTy0Fl4RPw?= =?us-ascii?Q?+MsJslzCcFKeQCu16FcGsyf/mZt5c3A9TLbTYJNLeYUNarHJD2SHfvJiYbP9?= =?us-ascii?Q?35ZGLAKUeH62EUgZvTzteWXArCIvN5GvyFOGJW59fAELsgIxJpn142RBlE1D?= =?us-ascii?Q?B/D/kIR5kVAVw/mF2wv+JrvTSYHeRIOHIRPasFXoqOs3gCsGN2VlRkBeF63X?= =?us-ascii?Q?izpapN/6HB7mJK5j2stHKVgJJOjeCHXp15seYANGcFyIqUP8Fh4XO1Iw8vYF?= =?us-ascii?Q?H9OAwlGA1DT7LORcaseXyIpqH/EyehpjCcC0GxIdr4Yjo69PurVeJMZJclVS?= =?us-ascii?Q?f2QLwv58/HMmn2YLsGcXvsinJvklICjg1nPL3pGGobCvFlNJo73g6u3ZBnAJ?= =?us-ascii?Q?4JTqu3cP/cnWL5shrxSAgwl2xt9piX9sHoViK0eHmnU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1750.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae4012f6-4e91-4f84-12a3-08d8a0d44602 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2020 08:34:43.9917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gfrEhAxB/mOD4/QUZj759S4WX6rnTZWuYKwMhlhBGYmirxICPtC+fUum3mxrPuNy+JEnCNHPXdAPQqHe3Yk96A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1847 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi I don't think this is right. One question: What if users want to disable rss? What you're doing right no= w will just make testpmd ignore "--disable-rss". BRs Xiaoyun > -----Original Message----- > From: dev On Behalf Of Steve Yang > Sent: Tuesday, December 15, 2020 14:13 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard ; Yigit, Ferruh > ; Zhang, Qi Z ; Yang, Steve= X > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accu= rate >=20 > When testpmd launched, the default RSS hash function will only activate > 'ETH_RSS_IP', it isn't consistent with the command result of 'port config= all rss > default'. >=20 > Removed the default 'rss_hf' limited in 'init_port_config', that will use= the > default supported RSS hash function for NIC. >=20 > Fixes: 9089296206ce ("app/testpmd: fix config due to RSS offload check") >=20 > Signed-off-by: Steve Yang > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 33fc0fddf5..ed6b438950 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3505,7 +3505,7 @@ init_port_config(void) > if (nb_rxq > 1) { > port->dev_conf.rx_adv_conf.rss_conf.rss_key =3D NULL; > port->dev_conf.rx_adv_conf.rss_conf.rss_hf =3D > - rss_hf & port- > >dev_info.flow_type_rss_offloads; > + port->dev_info.flow_type_rss_offloads; > } else { > port->dev_conf.rx_adv_conf.rss_conf.rss_key =3D NULL; > port->dev_conf.rx_adv_conf.rss_conf.rss_hf =3D 0; > -- > 2.17.1