DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules
Date: Fri, 15 Jan 2021 03:18:50 +0000	[thread overview]
Message-ID: <CY4PR11MB1750B10E47DF65B1E8AE5F8299A70@CY4PR11MB1750.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1610623187-3631-1-git-send-email-bernard.iremonger@intel.com>

There are two other mistakes in this section "Sample QinQ flow rules". Can you help to correct those too?
1.	testpmd> vlan set qinq_strip on 0
Creating QinQ rule(s) command line should be "vlan set extend on 0". Qinq_strip is not relevant to qinq flow rules.
2.  The sentence "The above command sets the inner and outer TPID's to 0x8100."
Should be "The following command sets the inner TPID to 0x8100 and sets the outer TPID to 0x88A8".

Best Regards
Xiaoyun Li

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Bernard Iremonger
> Sent: Thursday, January 14, 2021 19:20
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] doc: fix testpmd sample qinq flow rules
> In the Testpmd Flow rules management section, correct the TPID values in the
> Sample QinQ flow rules sub section.
> Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands")
> Cc: stable@dpdk.org
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 9be4500..e0020d6 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4432,8 +4432,8 @@ The above command sets the inner and outer TPID's
> to 0x8100.
>  To change the TPID's the following commands should be used::
> -   testpmd> vlan set outer tpid 0xa100 0
> -   testpmd> vlan set inner tpid 0x9100 0
> +   testpmd> vlan set outer tpid 0x88A8 0
> +   testpmd> vlan set inner tpid 0x8100 0
>     testpmd> port start 0
>  Validate and create a QinQ rule on port 0 to steer traffic to a VF queue in a VM.
> --
> 2.7.4

  reply	other threads:[~2021-01-15  3:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 11:19 [dpdk-dev] " Bernard Iremonger
2021-01-15  3:18 ` Li, Xiaoyun [this message]
2021-01-19  9:22   ` [dpdk-dev] [dpdk-stable] " Iremonger, Bernard
2021-01-19 12:23     ` Iremonger, Bernard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR11MB1750B10E47DF65B1E8AE5F8299A70@CY4PR11MB1750.namprd11.prod.outlook.com \
    --to=xiaoyun.li@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).