From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BA2BA04AC; Tue, 1 Sep 2020 12:59:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4443B1C0AD; Tue, 1 Sep 2020 12:59:17 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BA4081C07D for ; Tue, 1 Sep 2020 12:59:15 +0200 (CEST) IronPort-SDR: xD6mRNgyv+tWusuJ+4FUVakBhQxxaX0ZWRhkqLhD5fPAJd5COIACfuS88LWldgAknRCmEAkder zyWidLCgxB8A== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="218696831" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="218696831" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 03:59:14 -0700 IronPort-SDR: zoENhYaP/a0tEXtUAQw1mJ3mgs/cZ32A3VUV4a7A3URrp7ov7RYs0KcWv6ilPGOgvEFL0aBlQ6 cWY7UHw/djOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="331030779" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 01 Sep 2020 03:59:14 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 03:57:12 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 03:57:12 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Sep 2020 03:57:12 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 1 Sep 2020 03:57:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hq8d+UYB0SVEo2173/uBwVbp9r75jchF4dPkc4336mTKj7b+q+GoXwLjhxVXteD8ibaemu64CW3emu4k/BXldUotAhdXv4OsxN5UqzW3X3Pbn778F/bEaCyziVvNb0VE1XgzEAJ5+UZDyEnREsdkHck4qTJTbuBBsOUmXVoyBz4r28aZalszeLxhfnlwv2kV61uDiIUh0OPvPTRfKckL9TnDKpDMmCzoRTuta/CJEwEK3fmU5sW6Nvpxzb3ly/nA4k7ewPzL7PNja2E0FeYz7EDjvx3YRYFAXWEWxKYDqtnxK9fvu4wEuXKzsTpOGVSHd9y6MScCe3cPTbHUkeq1tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+F4t45MZsFMOR68BksiCRhNP47BPjwJo2W5zqjGjem0=; b=Ek6Qv4k1QO0vpG0K/un9ITKkMbeToIQ+RZYKzZEp+pfmIj3Y3fCuSGKbSs4MlZMN1VBujM6Ch1L1lDLp/tpyH51PeM/wV0q+1JnHLcXfANHx6ZshW88a/BAHVIjMUSkHFwTw5XAKisItfV7uh1v6qyWD5QD8c0p3P8oWifGD3TaF7BfKRXQmgZ2meD1wNv//h1bRe7+gRgoweT232dz5P+381qIkg3emjnFBHVmmL4+FBfRQVJNzI016jgUxkCLifmPb27BxjbO/5Gue6im6BAxSx8ivF6gScJxEmWBC0pXQpFLL91/wzuXqPxlxdtTOsMTEO0hERpj8PCD1aKx4dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+F4t45MZsFMOR68BksiCRhNP47BPjwJo2W5zqjGjem0=; b=LpLfestQ1nnz1+XtyFC1iR9i0+6H1CBx/qXhwDsDSVjIcABo/E9zO7WcybcNRpTUGkfJlKsicmVpmNvdFuuFFlvl0xdL7+uqP8gINj3jmyzPWNO7BIUBiApiC8J76OL3NrjGlSTjxK/5GlqYJ8m1w89Yy/6yB8gcT0wVoP7RNA8= Received: from CY4PR11MB1830.namprd11.prod.outlook.com (2603:10b6:903:125::21) by CY4PR11MB1766.namprd11.prod.outlook.com (2603:10b6:903:11a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19; Tue, 1 Sep 2020 10:57:08 +0000 Received: from CY4PR11MB1830.namprd11.prod.outlook.com ([fe80::20a7:37c7:9ba7:94d]) by CY4PR11MB1830.namprd11.prod.outlook.com ([fe80::20a7:37c7:9ba7:94d%12]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 10:57:08 +0000 From: "Kusztal, ArkadiuszX" To: Thomas Monjalon CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "anoobj@marvell.com" , "Doherty, Declan" , "Trahe, Fiona" , "asomalap@amd.com" , "rnagadheeraj@marvell.com" , "hemant.agrawal@nxp.com" , "De Lara Guarch, Pablo" , "Zhang, Roy Fan" Thread-Topic: [dpdk-dev] [PATCH v2] doc: announce move of aes gmac algorithm to aead Thread-Index: AQHWazt8s1Hr6KjCuUCe/fOj+02eNqktMsMAgCS1pTCAAbIvgIAAGAZw Date: Tue, 1 Sep 2020 10:57:08 +0000 Message-ID: References: <20200805151514.1180-1-arkadiuszx.kusztal@intel.com> <4171449.91m3rO6bWt@thomas> <10057334.se6I27zTtR@thomas> In-Reply-To: <10057334.se6I27zTtR@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzU2ZGU5ZTgtZDAxMy00NGQyLThjY2MtYWIzOWNjZmE0MzE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZVp3SzNZUkhEaElFYzI1dFpFY1ZZY2U3THc4bVhLdHZIZ2ozM3NqeFg4d0ZZRUZzTk52dm5waW1jaWRCTXdSdyJ9 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db29586b-57fe-45c2-4765-08d84e65c5a2 x-ms-traffictypediagnostic: CY4PR11MB1766: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B6zsmPlYlflbJmTy1zQV7xsHX+xEUHG6EvWnQDF99XKe35j3WtDBQuSkGTh2YqxnQrCp1N2GcrSJm53wYJdcx4tcwzIFWEyFvmRtHXDB/zi+vqFTwsN/2BxKozBS9o1+fRpFkXOcOV7BNEQQiV69PBOhAl7bA02Z87zCjxrXGykCI/9XJLPuo95MowC8cDnGCWPzcHoH/yjjM76Ikveq4Kfv8MThqQ0BRxP+Rb/rSazCWcgtMY5aHP4aMsZm/OZ5iBbjfbsMhiPHZWoH6akydLwgex0JyWourDWRUFYBFvniHOciEzLJE9NrE7Rt3zSBwnD2FsHk7KKCci6zrYCx4g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1830.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(76116006)(2906002)(86362001)(316002)(7696005)(6506007)(8936002)(26005)(66446008)(53546011)(9686003)(66556008)(64756008)(4326008)(66946007)(83380400001)(66476007)(478600001)(54906003)(107886003)(5660300002)(71200400001)(6916009)(33656002)(55016002)(8676002)(52536014)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: XmQOAS0S5qwp+llMwvsCmnBn3bpegyks32qtiXbm+Zcp8jCtNfKhZKaXj9eINmi2wneLDuWMrKMScTck1MIn+MxwPTKud1Wht4/vraNMCfd2VBoAJCazWs+JziMMdYtzjPStI3rmSswq1NJzWUK+NSAvIObcCPuaY6cJsOTg1anYhawK53P155+V89nOXFA+KzDaTz2yP6Jgs0aOZOhDA82Eh9fzpHC+sVXbEQgUq43Wbq41PPipubewHm5QtnXdTalBJ2zPwIpJw5KC2VWbgOGbjJQAb31fAtMVJOYoaXRnYMPbxY0BomsKAiHyVLOXxjrpJ8GRp+rNTYIaCOsJi5cvT6ZIp1dLtFEXJunzt43OyM1Kyb8p2JpuBiftAZdnuHma3Lzm9gZuhP0rVUHFMcxVOV+0FubuH2zBwaHZX+7HgmLK1fhW7JMhVGTfigC+has9wN9/mYduBYx4aJRrS9lk7wbsF7cBdOdpBgoZYc7UWVooLr32s6KdyswEbQdhe6LYPNLZicZz7KpAejg28/SxjAP14YbWacpfE4fIk7bktz/+525KDy4qL0q67l5AIgVaoEkW88WOpsH/4JrIJ46lsP+IqvzBM3S+OgeGrOPyK91nqRDLWe186aY9e8TVckiuu2FzJHmm1Sq8JNliZQ== Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1830.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db29586b-57fe-45c2-4765-08d84e65c5a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 10:57:08.5880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 19AwIh8QCyukKptm2hRT6pCa7OH2XSvpwSa/ErDSaf4NvfWzMySnctoAOKSD1xSt2YtPSlrgeKwZwzI+DDoZvLC7mMTeJJ6c9fCrsX/9XnY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1766 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] doc: announce move of aes gmac algorithm to aead X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: wtorek, 1 wrze=B6nia 2020 10:19 > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; akhil.goyal@nxp.com; anoobj@marvell.com; Doherty, > Declan ; Trahe, Fiona ; > asomalap@amd.com; rnagadheeraj@marvell.com; hemant.agrawal@nxp.com; > De Lara Guarch, Pablo ; Zhang, Roy Fan > > Subject: Re: [dpdk-dev] [PATCH v2] doc: announce move of aes gmac algorit= hm > to aead >=20 > 31/08/2020 08:34, Kusztal, ArkadiuszX: > > From: Thomas Monjalon > > > 05/08/2020 17:15, Arek Kusztal: > > > > This patch announces removal of RTE_CRYPTO_AUTH_AES_GMAC from > > > > rte_crypto_auth_algorithm and addition of > RTE_CRYPTO_AEAD_AES_GMAC > > > > to rte_crypto_aead_algorithm. > > > > AES-GMAC is variation of AES-GCM algorithm with the difference > > > > that it does not perform encryption. As a matter of fact > > > > internally there is no difference between GMAC and GCM except for > > > > the way how data is passed. > > > > Moving GMAC to AEAD can simplify way of implementing this > > > > alogrithm for example in IPsec (RFC4543). > > > > > > > > Signed-off-by: Arek Kusztal > > > > --- > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > +* cryptodev: ``RTE_CRYPTO_AUTH_AES_GMAC`` will no longer be > > > > +included in > > > > + ``enum rte_crypto_auth_algorithm``. It will be included in > > > > + ``enum rte_crypto_aead_algorithm`` as > ``RTE_CRYPTO_AEAD_AES_GMAC``. > > > > > > I wonder whether this move shows a problem in classification of the > > > crypto algorithms. > > > > [Arek] - it is not particularly bad that GMAC is auth algorithm, it rea= lly depends > on lib (openssl PMD internally uses conformant approach I have suggested = in > other mail). > > But from what I currently see GMAC as AEAD is preferred way, I think th= is > subject may be back in future. >=20 > The strange thing is that AEAD is a kind of authentication, isn't it? > I would see it as a subset of auth algos. [Arek] - AEAD is indeed kind of authentication but only combined with encry= ption hence it is distinct category. GMAC though is this peculiar case where there is no encryption even if algo= rithm is perfectly capable of it. So GMAC potentially can be both. >=20 > > Anyway this proposal didn't meet its audience. > > Because of the lack of ack (3 required), it cannot be accepted. >=20 > Indeed. Why others did not approve? > What is the consequence? [Arek] - rfc4543 is the one I see most of a confusion comes from (not all c= rypto protocols standardizes GMAC). It specifies ENCR_NULL_AUTH_GMAC as "companion to AES GCM ESP" (1) and "com= bined mode algorithm" (3) -> so implementation may be facilitated when GMAC and GCM would be in the same category as both share same features= -> both "combined-algorithm" not "combined" ESP-GCM and integrity ESP-GMAC= . On the other hand aforementioned rfc does not explicitly specify transport= mode (AH) GMAC as "combined" but it seems that people probably care less a= s AH comes with its own set of problems (like natural dislike of NAT), so probably using AEAD for it would not be a main issue. >=20