From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5C9DA04B6; Mon, 12 Oct 2020 07:15:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF2581D55D; Mon, 12 Oct 2020 07:15:45 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9C2FB1D53E for ; Mon, 12 Oct 2020 07:15:44 +0200 (CEST) IronPort-SDR: B5jv2vPoidXUNp16e6QVV1rlrrkgMcUP9GauRZzFSXoKGH8K/ikY+9+Vsbfk+XSEUhyAE+/Cc4 CTbunIV+Wd2g== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="162224951" X-IronPort-AV: E=Sophos;i="5.77,365,1596524400"; d="scan'208";a="162224951" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2020 22:15:42 -0700 IronPort-SDR: sNGDYAWOg27rCYi7Y8WB7Co5f6IDB/DFBeN8bvEqmEzV+aJzqiPFHTQsNtAX/6mXDyj+QvDX4A jsAamftTIscA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,365,1596524400"; d="scan'208";a="519486656" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 11 Oct 2020 22:15:41 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 11 Oct 2020 22:15:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 11 Oct 2020 22:15:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 11 Oct 2020 22:15:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=igrR6Oa0/xdN4eUGKWUdZo7lq7nwCzgTtzNovUxvngAiZ0AoPd7Eh4qu59boSc8Rdmrg/MQlHBK8AGupaTtd/qFVRlOim53tKD4lTsVfGAV0w5s/HWVVQ+eAuRqa1OARXPD1QVE1uA8TLNLlQINYlG6DpKQYb8AXaeRNE2v1y/aK0C3862vEv71IoY6duqYBb36+F3t5Ab3AP4XKcerrJyGVvIawQmfQC10+QaVxg3iBWdOpeUKma74wM63Qv9bw6k5q5lSGlm2VMz51BJEG2+TSsQmReNMGIYcMovtd267LuCjGeWWotuU2WNHNRICr9KROBdTEcjykgiUBm9vrIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bz2k1D6gSZvLGK5Nl+GFuxSnAFbI4SnkeIQX921/wek=; b=LWDKY1W/p/e+CD0ZtIEm0rzjqDBZCj8jQ094oND2DM4Pheiy5hAGKYdktgngMB0EvsCa6SQEMotxn0sgQ4IXwRIpKiEiB7jnNe5nhz7ATr+QzRnpAtEzjwWrEazxtTgbJ9WTGUzOMXJBBLOhC/bPIoxlH8UPYsV391oNCyL2dpZxaIbstFnj/FGvQScfx56vXJoGDjYPJ6RJdHFJahFag1+qOccRvBhawGI3Ff9HwsrvenAUR/64NngMlXZvlkANNb4yPzzdIv/kjzx2VhGyY5te1C501EbJj+zKWPnV4l2OjJfFi1hSTvUJw8XCY3muvGo8f0xKLPZrMtSj4EhlsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bz2k1D6gSZvLGK5Nl+GFuxSnAFbI4SnkeIQX921/wek=; b=GCrYpFcRZQPyuU4I4oB3al6AoUzaj/1FXItUvFqTQLUL6IYgtlJjfIX5xd4KMZcQspHSfBTUbncP5a0nR2nH8l/URtC3KYu6uHH+TUW/COMrsEpOJK2B19Nf514mrnoSeduWt3KKptXZggt/L5MsEwLUXvJduDC850AcgxC41E8= Received: from CY4PR11MB1830.namprd11.prod.outlook.com (2603:10b6:903:125::21) by CY4PR11MB1525.namprd11.prod.outlook.com (2603:10b6:910:9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.27; Mon, 12 Oct 2020 05:15:33 +0000 Received: from CY4PR11MB1830.namprd11.prod.outlook.com ([fe80::f41f:49db:982:7141]) by CY4PR11MB1830.namprd11.prod.outlook.com ([fe80::f41f:49db:982:7141%9]) with mapi id 15.20.3455.029; Mon, 12 Oct 2020 05:15:33 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Trahe, Fiona" , "ruifeng.wang@arm.com" , "michaelsh@marvell.com" Thread-Topic: [PATCH v2 3/5] cryptodev: remove crypto list end enumerators Thread-Index: AQHWl1AA1IQmck5J9UOv54hl23DBMamOLAuAgAVRTGA= Date: Mon, 12 Oct 2020 05:15:33 +0000 Message-ID: References: <20200930173226.770-1-arkadiuszx.kusztal@intel.com> <20200930173226.770-4-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.43] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b7a6c83e-ea87-44cc-32b4-08d86e6dd899 x-ms-traffictypediagnostic: CY4PR11MB1525: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xz4qj6MnmraJ/Lql/mqL45OjUbUgM9OovvCiH9AAzl+n3dHK2nKfsPxHoQB+usAGqsxYZ7o8lTdr4Nfey/53EBxjv6VibyWCkK4hKFVVFB/HHKRLmPh4DanFCD0cvoK+7lIZjgNV/abiHxrkgteZ8nnGBjX/SUh5MeLd+BJZrcPpPdbsSmzstlq/dpiPTTzt/xRw7IdBY0u+hh7Kb/1NrVLqCTl8Cct6l50J1QQ4TWuikh9YAYoBJmSa1/Tzn50oUUnEAMUokz58TnL8SnLmKV3XbZSabpEUuPSMggSOyVIwtv7ipRQpiZt7DrEY51JDtsOh64IvqmHXtPCO1xdJ5g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1830.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(9686003)(53546011)(6506007)(55016002)(316002)(66574015)(26005)(83380400001)(7696005)(76116006)(66946007)(33656002)(4326008)(186003)(71200400001)(110136005)(8936002)(54906003)(8676002)(52536014)(5660300002)(64756008)(86362001)(66446008)(66476007)(478600001)(66556008)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ozAJLJ4w1BoYw7CUd/Dxg522rsDwPd5y6HROSqrgGpjnRDr5xK8dF5qQX0bLHcyY22W4oVgjscRJcDKhktSwt445SjOQMLbFBpCpgB1kItDUUkPnZjyDXlkVR3ilX7ibbTiXURp9vU/DlJCWHZ5ykOYQUbCz0Lfmu9zxwXl9CEUMZjyG1yfqbrx0/ulnacANNfgjGzrtjHRbkO1xR44mucx+XWsM6BprqguiS6J/Dr+aCiLLYhiNMdumWMrcTPnULdUQC3+cl6Xpx2EPuUUuNy2En0vM1rPLAIx99DVZ5nvQajV7qidB/aD+A3GFOR8GvyfoZlZ8LJfk5w/o35484wcFm6QO5/Q02cSZzmXe8Yc3KZTuroDOGW0HnSPeyR94x1x6b2T8WPNEQV2skar6WdjU8+5c59ZIoznSu4fKMn98jovkQvUKcDVXLSvAsCdV9CHnAEDYC1i+cF4zhJq//enXCWLh11/YjPdufexAJFDy9LBNkoxdELRHJitgt4cDPdQBKdVMQDl444XFBcfrAaAt0/kDHbrbE5dywldtPHgqIgGmDHMgpuvob/nQRjzfa7+2BjVwPbakp2d8DKmdvB07UqSUoAumUOxfagBaO/Jl/cabKOas7yiUvMf3m2Qlc42iSaOos8toSkfMSSKqYg== Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1830.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7a6c83e-ea87-44cc-32b4-08d86e6dd899 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 05:15:33.5895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ypMY48iJJOiD+XFaq5L89/WEtytQTFACjjyt8E2NwVuMmjf5amA/HGXP1D2wyfhjSBtT8goANqeH0QgybfjbmKrk5eG7COeihuM+SFWLtPo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1525 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: czwartek, 8 pa=BCdziernika 2020 21:58 > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; ruifeng.wang@arm.com; > michaelsh@marvell.com > Subject: RE: [PATCH v2 3/5] cryptodev: remove crypto list end enumerators >=20 > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > b/lib/librte_cryptodev/rte_crypto_sym.h > > index f29c98051..7a2556a9e 100644 > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > @@ -132,15 +132,12 @@ enum rte_crypto_cipher_algorithm { > > * for m_src and m_dst in the rte_crypto_sym_op must be NULL. > > */ > > > > - RTE_CRYPTO_CIPHER_DES_DOCSISBPI, > > + RTE_CRYPTO_CIPHER_DES_DOCSISBPI > > /**< DES algorithm using modes required by > > * DOCSIS Baseline Privacy Plus Spec. > > * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next > > * for m_src and m_dst in the rte_crypto_sym_op must be NULL. > > */ > > - > > - RTE_CRYPTO_CIPHER_LIST_END > > - > > }; >=20 > Probably we should add a comment for each of the enums that we change, th= at > the user can define its own LIST_END =3D last item in the enum +1. > LIST_END is not added to avoid ABI breakage across releases when new algo= s > are added. [Arek] - I do not now if necessary, should it be some kind of guarantee tha= t order and number of enumerators will not change across the releases? >=20 > > > > /** Cipher algorithm name strings */ > > @@ -312,10 +309,8 @@ enum rte_crypto_auth_algorithm { > > /**< HMAC using 384 bit SHA3 algorithm. */ > > RTE_CRYPTO_AUTH_SHA3_512, > > /**< 512 bit SHA3 algorithm. */ > > - RTE_CRYPTO_AUTH_SHA3_512_HMAC, > > + RTE_CRYPTO_AUTH_SHA3_512_HMAC > > /**< HMAC using 512 bit SHA3 algorithm. */ > > - > > - RTE_CRYPTO_AUTH_LIST_END > > }; > > > > /** Authentication algorithm name strings */ @@ -412,9 +407,8 @@ enum > > rte_crypto_aead_algorithm { > > /**< AES algorithm in CCM mode. */ > > RTE_CRYPTO_AEAD_AES_GCM, > > /**< AES algorithm in GCM mode. */ > > - RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > > + RTE_CRYPTO_AEAD_CHACHA20_POLY1305 > > /**< Chacha20 cipher with poly1305 authenticator */ > > - RTE_CRYPTO_AEAD_LIST_END > > }; > > > > /** AEAD algorithm name strings */ > > -- > > 2.17.1