From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"anoobj@marvell.com" <anoobj@marvell.com>,
"shallyv@marvell.com" <shallyv@marvell.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms
Date: Wed, 5 Aug 2020 04:27:36 +0000 [thread overview]
Message-ID: <CY4PR11MB18304DB9A097F042E7AE87CF9F4B0@CY4PR11MB1830.namprd11.prod.outlook.com> (raw)
In-Reply-To: <7ef3a611-8a58-db38-d476-d5965bb90837@intel.com>
Hi Akhil,
@Akhil: Is there a chance getting this change into 20.11?
Any more comments or anyone see any potential issues with this approach?
Regards,
Arek
-----Original Message-----
From: Doherty, Declan <declan.doherty@intel.com>
Sent: piątek, 31 lipca 2020 16:34
To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; anoobj@marvell.com; shallyv@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
Subject: Re: [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms
On 29/07/2020 3:22 PM, Arek Kusztal wrote:
> This is proposal to move AES-GMAC algorithm to AEAD set of algorithms.
> It is however not 100% conformant GMAC as instead of aad pointer data
> to be authenticated is passed normally and aead.data.length field is
> used to specify length of data to be authenticated.
> Reason behind this move is that GMAC is variant of GCM so it may
> simplify implementations that are using these algorithms (mainly IPsec).
> AES-GMAC therefore needs to be removed from auth algorithms.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
..
>
I think this makes sense in light of how AES-GMAC support is specified in the IPsec GMAC rfc (https://tools.ietf.org/html/rfc4543)
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2020-08-05 4:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 14:22 Arek Kusztal
2020-07-29 14:36 ` Kusztal, ArkadiuszX
2020-07-29 16:20 ` Trahe, Fiona
2020-07-31 14:33 ` Doherty, Declan
2020-08-05 4:27 ` Kusztal, ArkadiuszX [this message]
2020-09-22 19:17 ` Akhil Goyal
2020-09-28 9:32 ` Trahe, Fiona
2020-09-01 8:13 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB18304DB9A097F042E7AE87CF9F4B0@CY4PR11MB1830.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).