From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C855AA04BC; Fri, 9 Oct 2020 09:02:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3ACDC1C030; Fri, 9 Oct 2020 09:02:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 948E61C01F for ; Fri, 9 Oct 2020 09:02:21 +0200 (CEST) IronPort-SDR: cNd4z7vaAQizT/bmr8iyIE4Y+VCscMnRtR/wpMWdZflT5Pg0H60n6bUlyUsioQOVlF+i0ijHqj +eSkQYjkeO4w== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="165565596" X-IronPort-AV: E=Sophos;i="5.77,354,1596524400"; d="scan'208";a="165565596" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 00:02:18 -0700 IronPort-SDR: ygtgR4AUbWz9kAWoKeH1Uco7v2/qguAgIF+Hu5H6BtNEixE9bmD+DJrjPYJZEtzYgN7XcisqAn 0t9IXWyFv8zA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,354,1596524400"; d="scan'208";a="344983009" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 09 Oct 2020 00:02:18 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 00:02:17 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 00:02:17 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Oct 2020 00:02:17 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 9 Oct 2020 00:02:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gf2mW6ySC2F+mBmlabrYFCEns96Aj7fX/bqCegESrUVSIj+mDQND+9jUrSDemaBonqsG9p3TqKclyjHI5R5xKld5S3wpFU7Yu0ZX7GxXSrbJzzjxsZgxUiL8IQiY38CKMHkc8EwwLqLpW7aAOf6R8XGM2XcOh4nAQ+CUNA2CX32fpQ5yRLFHj86CrmaRH5VfnoU8q8CxZ0d8nZ2dgYzc8dF0q+N+AnlaVzVRvMQeXgYxWuzy/Zr5tmglyofp5ajy0Q6Z2ttUSV46kSJKVsx4Rs+q1KJBFNz3ITIIfMrnbMTRlFDhBUwtoExinlYbT/MWLdMt18e9LRHZq5OXzokGkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zF5JyQ+tz71buLxOPFeP+XWs69uUgPEEthGC7mwaat4=; b=eCncXpWSzFNnnwaac2H69ca7Vx5NZd+KT+yBfmCMoFNVd0QHxlaw/B0ky/7afVbEN+/QhEnMp71HQALexH9uIvA5fw57TKb195pk6BSadFt4iGkkPTEaiCixPY6cCWMsmSnPXI/T9pIOvC8HR+9KN+eRG4B/FHhmnXK6hvMLD+kw0lJR+/CvPPJBFazcRXroABtTmbnDICk4QCOSKDHGYk2o6yZQXgGoujbCTLBBW9Ngf9Q2WpHETswG3ajALhKtJIZFkixTjuJtbfC7i1ilXUJNR0WhQMNmoPvdLMqGnsiRURtNEfqjvtNSapBVNNQcSKCtICZfud+3tQRGKtqS6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zF5JyQ+tz71buLxOPFeP+XWs69uUgPEEthGC7mwaat4=; b=RhfD0cBllmUfn3GsbPbtJirN54QiOJC4gtm1ov5Fe5jv6kAW9G1LdeblhDE5Yg/v91nkHR30jGjbYJNmg29wE71pUyuQ1qKhYVrebGJLi+zwYpbF9UMQRD53TLBejbMWcYN5xYQAeUlPYlciv1AFQ4J4yhNCVgFqZaH4+yacKkY= Received: from CY4PR11MB1830.namprd11.prod.outlook.com (2603:10b6:903:125::21) by CY4PR11MB1461.namprd11.prod.outlook.com (2603:10b6:910:4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Fri, 9 Oct 2020 07:02:11 +0000 Received: from CY4PR11MB1830.namprd11.prod.outlook.com ([fe80::f41f:49db:982:7141]) by CY4PR11MB1830.namprd11.prod.outlook.com ([fe80::f41f:49db:982:7141%9]) with mapi id 15.20.3455.027; Fri, 9 Oct 2020 07:02:11 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Trahe, Fiona" , "ruifeng.wang@arm.com" , "michaelsh@marvell.com" , Anoob Joseph Thread-Topic: [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api Thread-Index: AQHWl0/+qklU7YUYM0KHdtnbB4/5z6mOKjGAgAC4CfA= Date: Fri, 9 Oct 2020 07:02:11 +0000 Message-ID: References: <20200930173226.770-1-arkadiuszx.kusztal@intel.com> <20200930173226.770-5-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.44] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96bca530-afaa-41c8-3ca6-08d86c213ed2 x-ms-traffictypediagnostic: CY4PR11MB1461: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +KBdUrYYil/IsyXwGcySGb7wxaW+0ZcXLA75bx3s8yXkNa/cR4PoOSuPfU+6wUWs1Ks6sKig63J9/JJi0hwHlb5GU22BtS7+mCtTX0xinnuKmEYBNSQ+id8vEL8CWAyjDN4nK+Os90L9rRJ8Kay6kC/4GhYvdY4+/9H0j5tL8pQvY7SwK1fiS3FNdqufOow8WStAoMwbY3HlC9E2pPsmT2LOT83k4zBz1kS0g/GWsM8WwJ2ty7aw+ps13VIfwjZT11+F+JHNJmSVPmG0pUi3zhb8GGXvTMeG0cg9rCR5zBwvfKLExPrCDRrDGoeRoXba x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1830.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(366004)(7696005)(186003)(71200400001)(66556008)(64756008)(66476007)(66946007)(76116006)(5660300002)(66446008)(4326008)(9686003)(316002)(26005)(86362001)(8936002)(66574015)(33656002)(2906002)(55016002)(53546011)(8676002)(83380400001)(110136005)(6506007)(54906003)(478600001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: UQa8FXi7YmJyQ4PIKl4O2I4m0mgQhLi+wXQmyFehqtqqr8KgnEUE7vE7mMkCfEhu2vh8tDH7xvZQFDs6Fg+IY+uvxavdya4ZvKSLVHBh2FqDfiRvjIqtRc36cmZnc+sqinvwOUJ/MaEmYAj7mLBNrQLZlS+hdEfkFYTTMRM2OWSb9vrt4Bup5cLyMP7wclmPVZDCflsbci2UZpNVL2Cwpd2vER9Ag8eEufVFWvbtY2OWhYqYTxn+pOQxr7ufJr+84uGw7vNoFpFyYrKP5yMF5n0tAZ0P0xzMs7odqfSfqygGBBEaevTG8UZNHrpnUwYci/80V4zHGwWNhGaoQzbtVWzQoEe45k/clm9h76p3xE6/Bs+J+MLGN9gV65Hz3WlK6RW15oUllueo7Cs9O6U2Z5JnpZrjpM72bb9IYJobO3yvgGbG4t2zwLEWFCwwRuvAPb4RGX60iRQzV94nGJjlticeOrInttqXUspE/ebkJJ89V6ECUseU6GB7wxOJmaL27ddExeO+jTx+GZ/B7eoVq/7w1cGoxtFa2iOd3UDGx1jQgY/M+l/zpDjlR81Vzhw2iTgu7A+V8HDdWvmxKbJrsQ6VT+LEqgfc4F4Hp7lRdIWM4zK/X3UezV5huEQPke/h+3BgM+EG/YBN44m8RYDO4w== Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1830.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96bca530-afaa-41c8-3ca6-08d86c213ed2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 07:02:11.5301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qF1qmDzF90PwqNe4SzYt1WCoHYVPnYarJqz9+lIhPD0n3Z4WrHuzHpNzDplrSnh9NAiv7DCKk28Vzkek+QfakVLCt1OGft01RNNuViA1xkk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1461 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: czwartek, 8 pa=BCdziernika 2020 21:51 > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; ruifeng.wang@arm.com; > michaelsh@marvell.com > Subject: RE: [PATCH v2 4/5] cryptodev: remove list ends from asymmetric c= rypto > api >=20 > Hi Arek/Fiona, >=20 > > This patch removes RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END, > > RTE_CRYPTO_ASYM_OP_LIST_END, > > RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END > > enumerators from asymmetric crypto API. When asymmetric API will no > > more be experimental adding new entries will be possible without ABI > > breakage. >=20 > I believe XFORM_TYPE, ASYM_OP, and PADDING_TYPE are not going to Change > in near future. Hence LIST_END should not be removed from these Enums. > Adding a LIST END has its own benefits and we should not remove that unti= l we > have a solid reason for it. Moreover, these are experimental. > We should revisit these when we think ASYM is stable. As for XFORM_TYPE it could be extended by ECDH, even if ECPM is present (as= we have DH op enums), I think EdDSA can have its own enum as well. As for asym_op I don't know which way it will go as RTE_CRYPTO_ASYM_OP_PRIV= ATE_KEY_GENERATE is distinct case as it is more about generation than compu= tation, this could be clarified in future. As for rsa padding, I agree it fulfills today requirements. Though yes, since it is experimental I will remove asym patch from v3 patch= set. >=20 > IMO, we should only remove list ends in algo types. >=20 > Regards, > Akhil