From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B49A3A054D; Fri, 23 Sep 2022 18:30:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A73C242BBB; Fri, 23 Sep 2022 18:30:09 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 83EBB40156 for ; Fri, 23 Sep 2022 18:30:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663950608; x=1695486608; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tK83LGaHTknBfW4q31jJoK0vYiTEi0lta6DkIGogG8o=; b=DPfNLP047oEsfvcvSIsR7a3nedy9YDsz7BY5u1qY99VyhHBKFHSGovvh xZgOV8wetSbafVvKOEwB4HqmhlKk0I0VgVvPDkBCUBtl3HF7mayjQHBQe Xjq9kbxSttL2SMAb6msFQYAbqpfO6b5UYpXyKHeMlzeWx2nC3etJ96oAe uOox72q1d4E0LzTMEQqg+I4bg+/ZXo7jjFLrqxTzcqra7VC6r/HKrEMhX wQ8YhEJjf7la2vjfXq6zIatcs034popwDSqNCUaP6OWWH/7aAuwpQYl9V FMqWImKJlTTruWmJxDO1tTCxi3kov8lHYmyVOyUTbp0VvMpjIzb4lNboy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10479"; a="299347888" X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="299347888" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 09:30:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="865348102" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 23 Sep 2022 09:30:07 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 09:30:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 23 Sep 2022 09:30:06 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 23 Sep 2022 09:30:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmsb08BN+Fh3J8twXEcEm9u7Y3GLGBXk+7GqVaLjrjnHAKPyOcQmOxUPNFP1BgXiIJVJSCxz0MErhwXMQIvIYMX1ssA4VbkSro8zl5gcCYd/uoUrmytP4tzHcgXWmGE2RkofNT3/AGt3tE4p0yFDWbgVJJ8KBQNnIOWp9638GNkoB/TekfPU8p22JIgjdOSowMgA54/iAjoJF0g0n2f9M3BENXxrCWZi3N2T0NcIgW4j87jslFguO9/5FLthdzSOwkjkEc7sgqav3D/Su4lfb1J/y8WkVyL8ypTCSxjCJd3Mfys+vTd5RvUuKjuujJae67R/lRnDh6VieMIfqOOy9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yYwK4/wf8MhXmWhSij2P7wYaZriQjvxR5HlRJinIpZE=; b=cbY4wfAIxrRtHyKtiAz4gkqTqycoZQgjen/2d/Z9mBnhnyjjp35MusY3LjUnAM8JC6meu22fiaqTATDytMOisnp7CYD+Gsr6Vkv4/ypqikmC56bGxt90PAtKCdLtG/o+7bE4+Fp+5+RHIn+6dG9tDn90YzLNZowTzLBO+xNt7LtVRJCt43EaGfIeb2x4QxPEIGTaGvXcPp4e86V2vbYq/imsvGELYJig97owTAbZlvzuxcpaz9YCsL3Om6gzoqcLkZpLDnaSr+W/1fJ2q0nc0iu1k8IMMQIEiwlRxVV/7E0XMB1Esh6bFofUNgqBIqUbDiOPXUJA0XWVGPRKVqT7dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB1848.namprd11.prod.outlook.com (2603:10b6:903:123::22) by BN9PR11MB5257.namprd11.prod.outlook.com (2603:10b6:408:132::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 16:30:05 +0000 Received: from CY4PR11MB1848.namprd11.prod.outlook.com ([fe80::917f:87a9:4204:a8d1]) by CY4PR11MB1848.namprd11.prod.outlook.com ([fe80::917f:87a9:4204:a8d1%6]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 16:30:05 +0000 From: "Dooley, Brian" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" , Akhil Goyal Subject: RE: [PATCH v2] examples/fips_validation: fix memory allocation in AES MCT test Thread-Topic: [PATCH v2] examples/fips_validation: fix memory allocation in AES MCT test Thread-Index: AQHYrkFNV0Eb42+U302fqAMxSH/KHK3tdMWw Date: Fri, 23 Sep 2022 16:30:05 +0000 Message-ID: References: <20220713064439.3990811-1-gmuthukrishn@marvell.com> <20220812114710.1032171-1-gmuthukrishn@marvell.com> In-Reply-To: <20220812114710.1032171-1-gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY4PR11MB1848:EE_|BN9PR11MB5257:EE_ x-ms-office365-filtering-correlation-id: 0ab36245-f227-4d0e-f943-08da9d80df2a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fb/zQ5jbQwZ6c6qVTOWgFFpc1BnstKYugoFlUL0ZJrI7p0S0VyWBWvBSUKt6pOl9l1+ll+NnjEG9eztT9CQOMi6jB13jsTo+aS1IZCfNunuACwJbteVGAg0EddKOpRSUPhny2feU1FsSVJTGgYEq8iIejXfdAkXYIdgL/zi5jzsc5yo9ttYtFV/8JhNl2xEMaTeOd+WSewwRLEsd5czGw2vGajRyABj9Pz0hzdnhPDSuGZuph4P2V21lpyVhaY/wXM+yhNj7RMjKjhRWphX+eRSjLIP9bOl0fBsTesrCpG8BItnj2qP0KOKebrQh8NnYSgAspABu/jUSkmZCSfog/ltmGhrp0lczvxS9zaVz1i3qbaBDmTQTcELN12HgR+ZXDVsbWXIUVBEdjFqrHjk+dgDkjSxdESWjrxGaASwNeX7cGkH6IjFzp51XOlaxng3o/ZxvAINkLT3ugmrV+KR4tWFYCVm4ZUL/A1y4DUH5kY/2p9GNxv5WmrENwP77VczFmjlfJDkhKxlln7xn0iF1Dmpbq24NK/8vPKRQSs5XwR45iAMkCiQ12D13JD6j4LTz+hxdy0XrSNToJcPd9h3oODfo8cJbZlVPzZSBdrwl8/KgZO1354qDqzDToyjNOBgvUC/OQZ28Ado/7ygFPza2/DIvAXeXCoW/F0GFKYWjC+H+da7YK9rZ1p94PfEH7DzX0Et450O8iDgIylJcttrul8Vrkgj+9wpcJaNtLPeevEmeCFB8so+b4Iw1so92T2+iBv75l5ENeAE5ahjUtbuZRA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1848.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199015)(478600001)(53546011)(2906002)(26005)(9686003)(7696005)(6506007)(38100700002)(122000001)(41300700001)(76116006)(64756008)(4326008)(66556008)(66476007)(66446008)(38070700005)(316002)(55016003)(54906003)(8676002)(52536014)(33656002)(5660300002)(66946007)(110136005)(8936002)(71200400001)(86362001)(186003)(83380400001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WZwB9zOQ7zH+GBF5Ojsz7HfagPlVmb7eXmmwBzirPkbhBWs+UFVSFAxzkVSy?= =?us-ascii?Q?FyG8Fy40J+09zy4SwgKT9lh1HL7cXRfukoYzzLacqgwxdNDb/kLAcYOuf0Pk?= =?us-ascii?Q?R3NhIowY50MM/o5AkwK6y+z+iqkUPpYu17RAiQFHMO+lRLXbUd6wAnPnKxNn?= =?us-ascii?Q?ymzNNgYZl6VLFputbfPd66wQBx77t1myPHi0Sw9EOBMNFCEw0a2CF/ixPant?= =?us-ascii?Q?3raqAVYnH6LKUIITkoFWJWOJE4eckOck9r4UHDwfDuMhmgyji4jI5YG4ieeC?= =?us-ascii?Q?0RPVcNiJp7ckBpQwC50WfK6xCmEJAmGJOWNlWbtAquhm5TjHZtsqff4F7vDC?= =?us-ascii?Q?5Z9r+F1XXWCHIs8CKdPCd9V2OSVzBdeLcAEuGqJtdZHgG8FLEI/axfEd+yn+?= =?us-ascii?Q?rORKgPf35tMpxklk4tkT5TK+mqOgyPlWUIKoFNg2e//+4+3SI3SnoWT+ZXXr?= =?us-ascii?Q?s9yM+hyp+VBhcZTQjBBP2ckI3Ifm+gOFMG/WtZ7Eu5rvLtfdfqDvFOJu81yn?= =?us-ascii?Q?GDLWGb4qoE5uIlHYhz76DQIU1bgrMFouUGdQ1xkWq8zzrRqjK+ZwjdmUopM5?= =?us-ascii?Q?vXzNLsS+do8BbURRs2pZdTapT+qUvSBlsJQG0R+DOBmpokDgkPIy6ifiXQbJ?= =?us-ascii?Q?dxeonVHkKW1vR4RoQsEmdXTadKFYjtPJmOjccSaTfaP46VG2Mz5u6XG1l1im?= =?us-ascii?Q?VievzM4ypppWeOjBIKiQ2MGyLsE8rYvEKORu58ZhhZYm8L7CDvn4pQSWzgWy?= =?us-ascii?Q?pfOJykKH09Q71M5TIppxilWVEcH1ptLiCFguJakChKjbH+8RoHqAXJ6heZEJ?= =?us-ascii?Q?9XlxgBaPn7Mi0NUqpS4qiT/X1glXyCQwRGjX7vaOO/GEVPOhXkOW89jybKN1?= =?us-ascii?Q?NRL7NfglJMoXkhuneME+L4MZdR1lgrsbiCDo+O6CNuIwi8M6kGAOcHvSQ8rY?= =?us-ascii?Q?KS+hn7kUpXKZfZHkTgCFZplCxzOl/HJB0TRZpzqqJZa/1C4ucyRP88EVcW/S?= =?us-ascii?Q?tXB66qTsddFyeoYufcNhN1qljiTYWajYoc/mCIcVUGgtg/th+ITCtViZUGVh?= =?us-ascii?Q?s2TQWSe+JXEFL7YhC0q6E5OqaXLR+gXdfywiCSmq0c30B5e6Vn77dpo53dNF?= =?us-ascii?Q?PHL+2bZ6F56vEbpBoXFLIbHQJKbD1Pfzrei11AnM3q8vtMC6cAB1lWu1xb+j?= =?us-ascii?Q?Jakzwfo/Go0LjLK82QkpG3zpQiClONfjRTixsdsc0mDggXZW4WN9A0Xrd5UQ?= =?us-ascii?Q?AjpfA8kiR+94+CPHw2cf6qEG3KFmgQudMYKBkbtrY3/kklaST+uV7vyGZAPx?= =?us-ascii?Q?rMGHyxBF7bC0w3NGmIvKv9lolfUQ/mEwCPySom/lQHyWclVJ/iPOjhyJz9Xp?= =?us-ascii?Q?HPNPQ7+HV5Yb7qU1iQj0y2530VpdM2LlqDnFnIANii5Vyld2pqE6dudGpPG+?= =?us-ascii?Q?8j5RBtsSLfefg9ppaSmzPWbSyYYNdP/m6EUE97OZE9xramBSYu+rpkkeVvF1?= =?us-ascii?Q?KxD8/PpNITVn0ojBC1HqnMTfiMzkE3GOktvkI7vIBktz7b3F/zlLV2yJDkQr?= =?us-ascii?Q?296OK/f3WhyiATuIHGVaK/4zKB+d7GBJeV/LaUq3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1848.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab36245-f227-4d0e-f943-08da9d80df2a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 16:30:05.1231 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TtSXsJpQOY5befvpiJ9r1bvwfcV6GleOABT7BjqhxlpkDD7nm4c7qyNNcE2RD08VAr0cMesLzgg75hErMuwY8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5257 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Friday, August 12, 2022 12:47 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > ; Dooley, Brian ; Akhil > Goyal ; Gowrishankar Muthukrishnan > > Subject: [PATCH v2] examples/fips_validation: fix memory allocation in AE= S > MCT test >=20 > Instead of allocating memory in every external iteration, do once in the > beginning of AES MCT tests and free at the end. >=20 > Fixes: 8b8546aaedf ("examples/fips_validation: add parsing for AES-CBC") >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > v2: > - commit message. > --- > examples/fips_validation/main.c | 26 ++++++++++---------------- > 1 file changed, 10 insertions(+), 16 deletions(-) >=20 > diff --git a/examples/fips_validation/main.c > b/examples/fips_validation/main.c index 8bd5a66889..5c3f79a91c 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -1565,9 +1565,12 @@ fips_mct_aes_test(void) > if (info.interim_info.aes_data.cipher_algo =3D=3D > RTE_CRYPTO_CIPHER_AES_ECB) > return fips_mct_aes_ecb_test(); >=20 > - memset(&pt, 0, sizeof(struct fips_val)); > - memset(&ct, 0, sizeof(struct fips_val)); > - memset(&iv, 0, sizeof(struct fips_val)); > + pt.len =3D vec.pt.len; > + pt.val =3D calloc(1, pt.len); > + ct.len =3D vec.ct.len; > + ct.val =3D calloc(1, ct.len); > + iv.len =3D vec.iv.len; > + iv.val =3D calloc(1, iv.len); > for (i =3D 0; i < AES_EXTERN_ITER; i++) { > if (info.file_type !=3D FIPS_TYPE_JSON) { > if (i !=3D 0) > @@ -1599,16 +1602,8 @@ fips_mct_aes_test(void) >=20 > if (j =3D=3D 0) { > memcpy(prev_out, val[0].val, > AES_BLOCK_SIZE); > - pt.len =3D vec.pt.len; > - pt.val =3D calloc(1, pt.len); > memcpy(pt.val, vec.pt.val, pt.len); > - > - ct.len =3D vec.ct.len; > - ct.val =3D calloc(1, ct.len); > memcpy(ct.val, vec.ct.val, ct.len); > - > - iv.len =3D vec.iv.len; > - iv.val =3D calloc(1, iv.len); > memcpy(iv.val, vec.iv.val, iv.len); >=20 > if (info.op =3D=3D FIPS_TEST_ENC_AUTH_GEN) { > @@ -1647,12 +1642,8 @@ fips_mct_aes_test(void) > if (info.file_type !=3D FIPS_TYPE_JSON) > fprintf(info.fp_wr, "\n"); >=20 > - if (i =3D=3D AES_EXTERN_ITER - 1) { > - free(pt.val); > - free(ct.val); > - free(iv.val); > + if (i =3D=3D AES_EXTERN_ITER - 1) > continue; > - } >=20 > /** update key */ > memcpy(&val_key, &vec.cipher_auth.key, sizeof(val_key)); > @@ -1683,6 +1674,9 @@ fips_mct_aes_test(void) > } >=20 > free(val[0].val); > + free(pt.val); > + free(ct.val); > + free(iv.val); >=20 > return 0; > } > -- > 2.25.1 Acked-by: Brian Dooley