From: "Dooley, Brian" <brian.dooley@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] examples/fips_validation: fix typo
Date: Mon, 7 Nov 2022 14:37:44 +0000 [thread overview]
Message-ID: <CY4PR11MB1848972970177D89D4651E6E833C9@CY4PR11MB1848.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221107100330.2672470-1-pablo.de.lara.guarch@intel.com>
Hi Pablo,
> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Monday, November 7, 2022 10:04 AM
> To: Dooley, Brian <brian.dooley@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] examples/fips_validation: fix typo
>
> Digest length is being printed out, not IV length.
>
> Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
> Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> Cc: marko.kovacevic@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> -v2: added missing "Signed-off"
> ---
>
> examples/fips_validation/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/fips_validation/main.c
> b/examples/fips_validation/main.c index 404a29d7b6..9a9babb53a 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -1210,7 +1210,7 @@ prepare_hmac_xform(struct
> rte_crypto_sym_xform *xform)
> if (rte_cryptodev_sym_capability_check_auth(cap,
> auth_xform->key.length,
> auth_xform->digest_length, 0) != 0) {
> - RTE_LOG(ERR, USER1, "PMD %s key length %u IV length
> %u\n",
> + RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length
> %u\n",
> info.device_name, auth_xform->key.length,
> auth_xform->digest_length);
> return -EPERM;
> @@ -1339,7 +1339,7 @@ prepare_cmac_xform(struct
> rte_crypto_sym_xform *xform)
> if (rte_cryptodev_sym_capability_check_auth(cap,
> auth_xform->key.length,
> auth_xform->digest_length, 0) != 0) {
> - RTE_LOG(ERR, USER1, "PMD %s key length %u IV length
> %u\n",
> + RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length
> %u\n",
> info.device_name, auth_xform->key.length,
> auth_xform->digest_length);
> return -EPERM;
> --
> 2.34.1
Reviewed-by: Brian Dooley <brian.dooley@intel.com>
next prev parent reply other threads:[~2022-11-07 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 9:58 [PATCH] " Pablo de Lara
2022-11-07 10:03 ` [PATCH v2] " Pablo de Lara
2022-11-07 14:37 ` Dooley, Brian [this message]
2022-11-08 5:20 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1848972970177D89D4651E6E833C9@CY4PR11MB1848.namprd11.prod.outlook.com \
--to=brian.dooley@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).