From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 296BBA04DB; Thu, 15 Oct 2020 13:39:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB21A1C244; Thu, 15 Oct 2020 13:39:18 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id DD7621C231 for ; Thu, 15 Oct 2020 13:39:16 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 15 Oct 2020 04:39:02 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 15 Oct 2020 11:39:10 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 15 Oct 2020 11:39:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXmlgXEhSfe7/LheRyvlxyy+HeKf+yNTLBptVUlFUcaVtk7ic5arB5wX/7HE0TpgbpLEx5dSxE6CMUNtKiooVM8M9d2vqefUQtrHPSTMmxXFdvp2+R2rwGgtjXt1sF+d8Jk5jH1UD0Csl2IrcoOyqRcYCT4d1K8yZuwnZkHfQ5cvOAzpsoAq/2nky8CgwQDJ/Uh4jV+dybz3NgCfSUPEPlM3Hv1S7boq2J25zpVxdwyitm4KdF3sAAnH0oj1R2+Y4JZuTUtLw/formbdYuzLEfR+A24lRUS17EkqNKabQGtXHFsN3DAR/HE5+u8SqSm9cdsRy1d7AsfkpHeNWtgJzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o/RsvSaKsnHS2tnq4JjATD72cvRrI9hlgRcw6FhcvfY=; b=dP5Wh0bqPTu9GVt9KMByVeaiFt1cR63RUabzTzvBXbjYo7/ylAJe7oSYTiFYgG4meHhbsB0agr7ON/jv+2h5KX6Pj4z/O9JiAnmFHNhIFDR6GJZGcF5QXNv0XaCrzASZcrUdvOVVbvqxncSlcCE027pqkcBR93JT/ZZjc8Oo7bMf6YmNrmK7b2N8x/NK3AqQbUIDi+vs+Ggvt8t6xrqMlsOLdR05U1hqXVHrieuQwncy1xpsw7e3iV30PtRpJvXPQJbGM+r4hrhOh/UgpmbA6RNKN1kwr37qVk5ss8uYMLvSn81qNstX2pawCqtb4sY8FKBS7eg7Tk95TxtNDI97zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB0072.namprd12.prod.outlook.com (2603:10b6:910:1b::19) by CY4PR1201MB0263.namprd12.prod.outlook.com (2603:10b6:910:18::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Thu, 15 Oct 2020 11:39:08 +0000 Received: from CY4PR1201MB0072.namprd12.prod.outlook.com ([fe80::ade4:b300:381d:fe5c]) by CY4PR1201MB0072.namprd12.prod.outlook.com ([fe80::ade4:b300:381d:fe5c%10]) with mapi id 15.20.3477.020; Thu, 15 Oct 2020 11:39:07 +0000 From: Bing Zhao To: NBU-Contact-Thomas Monjalon CC: Ori Kam , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "bernard.iremonger@intel.com" , "beilei.xing@intel.com" , "wenzhuo.lu@intel.com" , "dev@dpdk.org" Thread-Topic: [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs Thread-Index: AQHWot7rXKfylwT77EyJoPP9mgWii6mYhJiA Date: Thu, 15 Oct 2020 11:39:07 +0000 Message-ID: References: <1601511962-21532-1-git-send-email-bingz@nvidia.com> <1602740124-397688-1-git-send-email-bingz@nvidia.com> <1602740124-397688-2-git-send-email-bingz@nvidia.com> <2164152.BJDqhmbNaX@thomas> In-Reply-To: <2164152.BJDqhmbNaX@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [154.18.172.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b922c28a-6a07-44ce-d7f3-08d870feed45 x-ms-traffictypediagnostic: CY4PR1201MB0263: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AsbEG+J6J2EE5vCr5/FcZTeqmHSjwrkXa+fLPwgFR0Hsp45F1e/z3tUPgQsGImGrBGM3vMN+9chyOD4xxnQDID+BhPaA7sLdSdzM2CXLBwF9uL9Vte3SZpkaY4ytazmHaM1s+90ZjCAfRdf3B37drdkIRmV4u3hpYirc1q3UVuCUA9FiWbKzbh5MxEMcX/+FEMyxpCuqQf2l+pi+1NsnjQDFe8yseOoCVW6jnyNHZZHXv0+wyhYL7zpAFKhVlQxufBH0N+78cOoRq5z6VxzRzvO05SuUb5dnv8LP9VAUlfPny7UXC3NZTUvgzv2JbMGfzKcJfW6u+0u8jGkdSijXOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB0072.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(8936002)(316002)(26005)(2906002)(66946007)(64756008)(66446008)(66476007)(9686003)(66556008)(33656002)(53546011)(76116006)(6506007)(54906003)(83380400001)(7696005)(478600001)(4326008)(8676002)(186003)(55016002)(52536014)(5660300002)(86362001)(71200400001)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Q22SJisuJ5KIHEBDEyXdIvlPJ5z3KU2zshU5nDC+9GDT+wtb3k6apJg6tmGxO7oZlDsMs8a9fXfGai9v+nweT9qsT3dpLEUXjKbUPAUMXUaehlq+uA2HnCUDLhIvL9Gin1wBQEB1sh8awI7ySgKXZozPkDMkaHOk8jha8YDy+lQ0igeYkb9dDt9Q/SJiaR3bHD1ACAoren9bWwW8h11OuziYlkh32fzy6lNU5ti8LvpGpTnJMx4akWh0XN3IP4ITrFSf8YSr1ifyJWLd71+vFE+AsTsYnWMxIlj1hbVXC/+jpNlAMOXwv0FVyQjgCz0Y5Htny/8n+pZsQV+s/bYrtAnEjGb3JlmFyauSjlVlOi5G7iwiW9azt3HHUYLj5CxVQ8xZad2QTivoy7wvdA5iVnPnjq0+MzB5EdPMhgTV1ZAkPJt8X87tzE7TkgBzio0CbRRhFLtjxax4l//V+ZJZ/l32Jv07i5gYyZRWcbLknVhIq2n3Dm1OVwNdgkvWhpctXhGTJCfFnCLYDyWd5ellEQGncp62q5I4lH205PBpVJX01I4jqO+B5JXecjrA4n/k57SIi1V90j/YphZRXImqIkTsID/C3PF0oTXyMbXeYkJKNY/CZBMhrTI5Pmi1PI36hwWL7ueLKoqqWdFl1UkVUg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0072.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b922c28a-6a07-44ce-d7f3-08d870feed45 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 11:39:07.6207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WEa6PGzzI1pbKUJNkYOs9AsgCRyMAJNOGxMfETscxp2xHKF018ZiR++elX1pIh0ePbxm+Hz5eSk7mp0H3TFFDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0263 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602761942; bh=o/RsvSaKsnHS2tnq4JjATD72cvRrI9hlgRcw6FhcvfY=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Lbi9yKbIhIPD/FyUhupk82R0DXZ8B79AxnEgRNdorQlJV1sxCG0e88j4qiEVcpQ/E CP++x5+KjKBpYjDZ4f+VxFW0JzkOg8uV9liR4r+0Z19hB8NIhhwFnk8BgNB3vN/FjD BvDz4h1OqYASp4dAtcvVhFC0BPJksqIa5i430p6MD4z3KK7BJhHdmfTBL+ssYiMleh c80VQXryLgZNZkZeCM3tSW56JuXkMYSUYQy4/V9e1QUJaJZsvrSWa2tRqyq2zW8cEb Wikl8PFQ53rvjrjZ9aBKGRF66fiFjRJNOEqOvGwDcK3k1Qqb72LDmDLo6rJnFc5B7a s+6Buo8phVezQ== Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, October 15, 2020 6:34 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yigit@intel.com; > arybchenko@solarflare.com; mdr@ashroe.eu; nhorman@tuxdriver.com; > bernard.iremonger@intel.com; beilei.xing@intel.com; > wenzhuo.lu@intel.com; dev@dpdk.org > Subject: Re: [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs >=20 > External email: Use caution opening links or attachments >=20 >=20 > 15/10/2020 07:35, Bing Zhao: > > v5: > > * Change EINVAL to ENODEV > > * add newline character in the end of log line > > * descriptions update >=20 > It looks good. > More minor coding style comments below. With those, > Acked-by: Thomas Monjalon Thanks for the review and comments >=20 > > + if (ret) >=20 > Coding style recommends explicit comparison with =3D=3D or !=3D Done >=20 > > + RTE_ETHDEV_LOG(ERR, "Failed to bind hairpin TX %d " > > + "to RX %d (%d - all ports)\n", > tx_port, > > + rx_port, RTE_MAX_ETHPORTS); >=20 > It is preferred not splitting the log lines, or maybe only after a > format specifier, so it can be grepped. > Here the space after %d would be better on the next line. >=20 > In general Rx/Tx is preferred over the full capital RX/TX version. Done >=20 > Thanks >=20 BR. Bing