From: Bing Zhao <bingz@nvidia.com> To: Ori Kam <orika@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>, "beilei.xing@intel.com" <beilei.xing@intel.com>, "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 3/4] ethdev: add APIs for hairpin queue operation Date: Wed, 7 Oct 2020 11:34:44 +0000 Message-ID: <CY4PR1201MB0072D5772D58032C06AA2E89D00A0@CY4PR1201MB0072.namprd12.prod.outlook.com> (raw) In-Reply-To: <MN2PR12MB4286087077F13B2438702EFBD60F0@MN2PR12MB4286.namprd12.prod.outlook.com> Hi Ori, > -----Original Message----- > From: Ori Kam <orika@nvidia.com> > Sent: Sunday, October 4, 2020 5:35 PM > To: Bing Zhao <bingz@nvidia.com>; NBU-Contact-Thomas Monjalon > <thomas@monjalon.net>; ferruh.yigit@intel.com; > arybchenko@solarflare.com; mdr@ashroe.eu; nhorman@tuxdriver.com; > bernard.iremonger@intel.com; beilei.xing@intel.com; > wenzhuo.lu@intel.com > Cc: dev@dpdk.org > Subject: RE: [PATCH 3/4] ethdev: add APIs for hairpin queue > operation > > Hi Bing, > > PSB > Best, > Ori > > > -----Original Message----- > > From: Bing Zhao <bingz@nvidia.com> > > Sent: Thursday, October 1, 2020 3:26 AM > > Subject: [PATCH 3/4] ethdev: add APIs for hairpin queue operation > > > > Every hairpin queue pair should be configured properly and the > > connection between TX and RX queues should be established, before > > hairpin function works. In single port hairpin mode, the queues of > > each pair belong to the same device. It is easy to get the > hardware > > and software information of each queue and configure the hairpin > > connection with such information. In two ports hairpin mode, it is > not > > easy or inappropriate to access one queue's information from > another > > device. > > > > Since hairpin is configured per queue pair, three new APIs are > > introduced and they are internal for the PMD using. > > > > The peer update API helps to pass one queue's information to the > peer > > queue and get the peer's information back for the next step. > > The peer bind API configures the current queue with the peer's > > information. For each hairpin queue pair, this API may need to be > > called twice to configure the TX, RX queues separately. > > The peer unbind API resets the current queue configuraion and > state to > > disconnect it from the peer queue. Also, it may need to be called > > twice to disconnect TX, RX queues from each other. > > > > Some parameter of the above APIs might not be mandatory, and it > > depends on the PMD implementation. > > > > The structure of `rte_hairpin_peer_info` is only a declaration and > the > > actual members will be defined in each PMD when being used. > > > > Signed-off-by: Bing Zhao <bingz@nvidia.com> > > --- > > lib/librte_ethdev/rte_ethdev.c | 55 ++++++++++++++++ > > lib/librte_ethdev/rte_ethdev_driver.h | 108 > > +++++++++++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev_version.map | 3 + > > 3 files changed, 166 insertions(+) > > > > diff --git a/lib/librte_ethdev/rte_ethdev.c > > b/lib/librte_ethdev/rte_ethdev.c index 72f567b..4bfc26e 100644 > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > @@ -5515,6 +5515,61 @@ handle_port_link_status(const char *cmd > > __rte_unused, > > return 0; > > } > > > > +int > > +rte_eth_hairpin_queue_peer_update(uint16_t peer_port, uint16_t > > peer_queue, > > + struct rte_hairpin_peer_info *cur_info, > > + struct rte_hairpin_peer_info *peer_info, > > + bool direction) > > +{ > > + struct rte_eth_dev *dev; > > + > > + /* Current queue information is not mandatory. */ > > + if (peer_info == NULL) > > + return -EINVAL; > > + > > + /* No need to check the validity again. */ > > + dev = &rte_eth_devices[peer_port]; > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops- > > >hairpin_queue_peer_update, > > + -ENOTSUP); > > + > > + return (*dev->dev_ops->hairpin_queue_peer_update)(dev, > > peer_queue, > > + cur_info, peer_info, direction); } > > + > > +int > > +rte_eth_hairpin_queue_peer_bind(uint16_t cur_port, uint16_t > cur_queue, > > + struct rte_hairpin_peer_info *peer_info, > > + bool direction) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (peer_info == NULL) > > + return -EINVAL; > > + > > + /* No need to check the validity again. */ > > + dev = &rte_eth_devices[cur_port]; > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops- > > >hairpin_queue_peer_bind, > > + -ENOTSUP); > > + > > + return (*dev->dev_ops->hairpin_queue_peer_bind)(dev, cur_queue, > > + peer_info, direction); > > +} > > + > > +int > > +rte_eth_hairpin_queue_peer_unbind(uint16_t cur_port, uint16_t > cur_queue, > > + bool direction) > > +{ > > + struct rte_eth_dev *dev; > > + > > + /* No need to check the validity again. */ > > + dev = &rte_eth_devices[cur_port]; > > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops- > > >hairpin_queue_peer_bind, > > + -ENOTSUP); > > + > > + return (*dev->dev_ops->hairpin_queue_peer_unbind)(dev, > cur_queue, > > + direction); > > +} > > + > > RTE_LOG_REGISTER(rte_eth_dev_logtype, lib.ethdev, INFO); > > > > RTE_INIT(ethdev_init_telemetry) > > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h > > b/lib/librte_ethdev/rte_ethdev_driver.h > > index 910433f..d759c58 100644 > > --- a/lib/librte_ethdev/rte_ethdev_driver.h > > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > > @@ -21,6 +21,9 @@ > > extern "C" { > > #endif > > > > +/**< @internal Declaration of the hairpin peer queue information > structure. > > */ > > +struct rte_hairpin_peer_info; > > + > > /* > > * Definitions of all functions exported by an Ethernet driver > through the > > * generic structure of type *eth_dev_ops* supplied in the > > *rte_eth_dev* @@ -622,6 +625,21 @@ typedef int > > (*eth_hairpin_bind_t)(struct rte_eth_dev *dev, typedef int > > (*eth_hairpin_unbind_t)(struct rte_eth_dev *dev, > > uint16_t rx_port); > > > > +typedef int (*eth_hairpin_queue_peer_update_t) > > + (struct rte_eth_dev *dev, uint16_t peer_queue, > > + struct rte_hairpin_peer_info *current_info, > > + struct rte_hairpin_peer_info *peer_info, bool direction); > /**< > > +@internal Update and fetch peer queue information. */ > > + > > +typedef int (*eth_hairpin_queue_peer_bind_t) > > + (struct rte_eth_dev *dev, uint16_t cur_queue, > > + struct rte_hairpin_peer_info *peer_info, bool direction); > /**< > > +@internal Bind peer queue to the current queue with fetched > > information. */ > > + > > +typedef int (*eth_hairpin_queue_peer_unbind_t) > > + (struct rte_eth_dev *dev, uint16_t cur_queue, bool direction); > /**< > > +@internal Unbind peer queue from the current queue. */ > > + > > /** > > * @internal A structure containing the functions exported by an > > Ethernet driver. > > */ > > @@ -765,6 +783,9 @@ struct eth_dev_ops { > > /**< Bind all hairpin TX queues of device to the peer port RX > queues. */ > > eth_hairpin_unbind_t hairpin_unbind; > > /**< Unbind all hairpin TX queues from the peer port RX queues. > */ > > + eth_hairpin_queue_peer_update_t hairpin_queue_peer_update; > > + eth_hairpin_queue_peer_bind_t hairpin_queue_peer_bind; > > + eth_hairpin_queue_peer_unbind_t hairpin_queue_peer_unbind; > > }; > > > > /** > > @@ -1120,6 +1141,93 @@ __rte_internal > > int > > rte_eth_dev_destroy(struct rte_eth_dev *ethdev, ethdev_uninit_t > > ethdev_uninit); > > > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without > prior > > notice > > + * > > + * @internal > > + * Pass the current hairpin queue HW and/or HW information to the > > + peer > > queue > > I don't think you need experimental tag when using internal. OK, I will remove it. > > > + * and fetch back the information of the peer queue. > > + * > > + * @param peer_port > > + * Peer port identifier of the Ethernet device. > > + * @param peer_queue > > + * Peer queue index of the port. > > + * @param cur_info > > + * Pointer to the current information structure. > > + * @param peer_info > > + * Pointer to the peer information, output. > > + * @param direction > > + * Direction to pass the information. > > + * true - pass TX queue information and get peer RX queue > > +information > > + * false - pass RX queue information and get peer TX queue > > +information > > + * > > + * @return > > + * Negative errno value on error, 0 on success. > > + */ > > +__rte_internal > > +int > > +rte_eth_hairpin_queue_peer_update(uint16_t peer_port, uint16_t > > peer_queue, > > + struct rte_hairpin_peer_info *cur_info, > > + struct rte_hairpin_peer_info *peer_info, > > + bool direction); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without > prior > > notice > > + * > > + * @internal > > + * Configure current hairpin queue with the peer information > fetched > > + to > > create > > Same comment as above. I will remove it. > > > + * the connection (bind) with peer queue in the specified > direction. > > + * This function might need to be called twice to fully create > the connection. > > + * > > + * @param cur_port > > + * Current port identifier of the Ethernet device. > > + * @param cur_queue > > + * Current queue index of the port. > > + * @param peer_info > > + * Pointer to the peer information, input. > > + * @param direction > > + * Direction to create the connection. > > + * true - bind current TX queue to peer RX queue > > + * false - bind current RX queue to peer TX queue > > + * > > + * @return > > + * Negative errno value on error, 0 on success. > > + */ > > +__rte_internal > > +int > > +rte_eth_hairpin_queue_peer_bind(uint16_t cur_port, uint16_t > cur_queue, > > + struct rte_hairpin_peer_info *peer_info, > > + bool direction); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without > prior > > notice > > + * > > + * @internal > > + * Reset the current queue state and configuration to disconnect > > +(unbind) it > > + * from the peer queue. > > + * This function might need to be called twice to disconnect each > other. > > + * > > + * @param cur_port > > + * Current port identifier of the Ethernet device. > > + * @param cur_queue > > + * Current queue index of the port. > > + * @param direction > > + * Direction to create the connection. > > + * true - unbind current TX queue from peer RX queue > > + * false - unbind current RX queue from peer TX queue > > + * > > + * @return > > + * Negative errno value on error, 0 on success. > > + */ > > +__rte_internal > > +int > > +rte_eth_hairpin_queue_peer_unbind(uint16_t cur_port, uint16_t > cur_queue, > > + bool direction); > > + > > + > > #ifdef __cplusplus > > } > > #endif > > diff --git a/lib/librte_ethdev/rte_ethdev_version.map > > b/lib/librte_ethdev/rte_ethdev_version.map > > index 18efe4e..d05cd97 100644 > > --- a/lib/librte_ethdev/rte_ethdev_version.map > > +++ b/lib/librte_ethdev/rte_ethdev_version.map > > @@ -250,6 +250,9 @@ INTERNAL { > > rte_eth_devargs_parse; > > rte_eth_dma_zone_free; > > rte_eth_dma_zone_reserve; > > + rte_eth_hairpin_queue_peer_bind; > > + rte_eth_hairpin_queue_peer_unbind; > > + rte_eth_hairpin_queue_peer_update; > > rte_eth_switch_domain_alloc; > > rte_eth_switch_domain_free; > > rte_flow_expand_rss; > > -- > > 2.5.5 Thanks
next prev parent reply other threads:[~2020-10-07 11:34 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 4:51 [dpdk-dev] [RFC] introduce support for hairpin between two ports Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 0/4] " Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 1/4] ethdev: add support for flow item transmit queue Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 2/4] testpmd: add item transmit queue in flow CLI Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 3/4] ethdev: add hairpin bind APIs Bing Zhao 2020-09-13 15:49 ` [dpdk-dev] [RFC PATCH v2 4/4] ethdev: add new attributes to hairpin queues config Bing Zhao 2020-10-01 0:25 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Bing Zhao 2020-10-01 0:25 ` [dpdk-dev] [PATCH 1/4] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-04 9:20 ` Ori Kam 2020-10-07 11:21 ` Bing Zhao 2020-10-07 11:42 ` Ori Kam 2020-10-01 0:26 ` [dpdk-dev] [PATCH 2/4] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-04 9:22 ` Ori Kam 2020-10-07 11:32 ` Bing Zhao 2020-10-01 0:26 ` [dpdk-dev] [PATCH 3/4] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-04 9:34 ` Ori Kam 2020-10-07 11:34 ` Bing Zhao [this message] 2020-10-01 0:26 ` [dpdk-dev] [PATCH 4/4] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-04 9:39 ` Ori Kam 2020-10-07 11:36 ` Bing Zhao 2020-10-04 9:45 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 0/6] " Bing Zhao 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-08 9:07 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 2/6] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-08 9:23 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-08 9:40 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-08 9:44 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 5/6] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-08 9:45 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 6/6] doc: update for two ports hairpin mode Bing Zhao 2020-10-08 9:47 ` Ori Kam 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 0/6] introduce support for hairpin between two ports Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-14 14:35 ` Thomas Monjalon 2020-10-15 2:56 ` Bing Zhao 2020-10-15 7:31 ` Thomas Monjalon 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-12 21:37 ` Thomas Monjalon 2020-10-13 12:29 ` Bing Zhao 2020-10-13 12:41 ` Thomas Monjalon 2020-10-13 13:21 ` Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-08 12:31 ` Ori Kam 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 5/6] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode Bing Zhao 2020-10-12 21:30 ` Thomas Monjalon 2020-10-13 1:13 ` Bing Zhao 2020-10-13 6:37 ` Thomas Monjalon 2020-10-13 6:40 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-14 14:43 ` Thomas Monjalon 2020-10-15 2:59 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-14 15:02 ` Thomas Monjalon 2020-10-15 4:03 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-15 10:34 ` Thomas Monjalon 2020-10-15 11:39 ` Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-15 10:46 ` Thomas Monjalon 2020-10-15 13:45 ` Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 23:03 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Ferruh Yigit 2020-10-16 1:34 ` Bing Zhao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CY4PR1201MB0072D5772D58032C06AA2E89D00A0@CY4PR1201MB0072.namprd12.prod.outlook.com \ --to=bingz@nvidia.com \ --cc=arybchenko@solarflare.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=orika@nvidia.com \ --cc=thomas@monjalon.net \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git