From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B35DA09E0; Sat, 14 Nov 2020 23:12:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89AD1C88E; Sat, 14 Nov 2020 23:12:11 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 105F0C882 for ; Sat, 14 Nov 2020 23:12:07 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sat, 14 Nov 2020 14:12:10 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 14 Nov 2020 22:12:00 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sat, 14 Nov 2020 22:12:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yfimv6QFUHGSzkqM61YI65QcEl69se13+PRgAHYsYZ+ezZYS154SAAm04A1YjkNzkDpgtyKLoqszx4Z8GYWm1jLAEIu3UiuIWxua0c3i9GpIbhzCEQDLkx3/OpzF6smuUbiE+huX91MUuSe20AKV5R1Z39Lse2qViC8EK37jE002e/1kr+9Je9ppdEpFYjlJ8lhSqY5vNqVEYKsjdG0xQmm5EgtpM2fllPckll5mtpDkXlkEpqLRZzAuFFomZwQuL+QWKm2aFRDzjB7pvQXoFzDr4gkKnlOD2xY5E+uKNhVGl8GJheUv/kFUp1IdfDoUumNRStGziF2/Ik+BcdJChA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R+mHGaLe1tI8HKgILux1N6F90HqBENrMefgUv4BYa3s=; b=CmxpK8fuikgPGCf1EygEnWghmNl8mgT0Bb7bxaIssKYBFAy4rXljxx69FHskYE1nwoIuXoOI79wDZyCUmpdOkBwQ71o+esp5lp0j/flVhDqquQ2QflwJX5O5WjauzRUWk64D/T5850ies+Hb0SeAiXZkc4QeQGLO/BwldWfgOEY33uQcXz0sy0sCvtLe0/TJxy81/Y/rfVy/0NFXnJ7TrX5AOD97qkkFwq3BbaXqLoK2Pst7rwNb/G/idItjKOcbCES6u0lbhjMfReNGyBofHuTG8MpjXs2nFBAK/xmLvdnXAOKMYbOaav/2ZKghur+aa+AaVt22IlLvE3HhrXPQeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR12MB1269.namprd12.prod.outlook.com (2603:10b6:903:40::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Sat, 14 Nov 2020 22:11:58 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::bc62:8762:4cb9:52dd]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::bc62:8762:4cb9:52dd%12]) with mapi id 15.20.3541.026; Sat, 14 Nov 2020 22:11:58 +0000 From: Tal Shnaiderman To: Dmitry Kozlyuk CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "pallavi.kadam@intel.com" Thread-Topic: [PATCH] eal/windows: definition for ETOOMANYREFS errno Thread-Index: AQHWutHRm1/E+2TQNEumPy2ga0yWUKnIL2Pw Date: Sat, 14 Nov 2020 22:11:58 +0000 Message-ID: References: <20201114211156.17196-1-talshn@nvidia.com> <20201115010155.06bcd0ea@sovereign> In-Reply-To: <20201115010155.06bcd0ea@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.114.72] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0fe4459-d5bd-4566-a06d-08d888ea4e17 x-ms-traffictypediagnostic: CY4PR12MB1269: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3CCVHZpmkKRr9apOKx0SZRK4Vgg/lmW5sf140uHaPEMeH0PARccjgOaeTyvxEetGX8OSkKh7VaoYg5oQ49uDRfR9uMEnCsZUTfk7CN4EeWa8Q2fQnmgm4GXOKL8WWyETa7hz9L4MTABnCaS050NQvKjYrIw8MsP8td5utynt0WFImX0PHILh07JY12d/pJd7Qkj7HllUEuSoPspap0cgfh4zZ6cQBdtKgU8y+y9yw4LC0u0aRCIjVlh6P+/I+tEOQToq6H1YBj62OHEwL1BWkPFsZTcRmkEhG0x+ax6AB+6IJ2JN14tisKtmGiPJNXFYCty8ngCn1TiXXeqiSAFzzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(39850400004)(346002)(136003)(396003)(83380400001)(8936002)(8676002)(52536014)(6916009)(86362001)(71200400001)(2906002)(33656002)(9686003)(55016002)(6506007)(7696005)(64756008)(66946007)(76116006)(66476007)(66446008)(54906003)(66556008)(316002)(5660300002)(186003)(478600001)(4326008)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: woarcwysB7P2/03OSSYpYQkvd1FFz6iJ9ks4+ZI+IRDbgBtH8OM+MzZbgHdlsy2RE2vTFUKRkjPKuAcMpNOuxGZpMKGFluI3n3SoGYuu1L9lejL/aNFp6jUKcSRJ96QHUVMIXdBfvN4nNeY1RJN69vRJhKDDId/DV+nYcxrTuT6mxLGZAFFAAlFYq598qbrgXyOysEdg0KUJt40jXdo+TZ9z49CF3kl1lFhHh/pCoK5nJzn8cZSkdJBWDAF3jM6Tjz6ETPyJJyeMYClizhi5Rh41i+5aXyAbAhXLJMp8lzh6ZV+ZwifHwA8DcsIbx3cAnwCTttB3z53U3EBHvIsEHeIa3aZ/m6WBHYXy3SXPqP6Ln2nSrlzEe/4YX/q52K3MoibfreyTBtjy/+3QyIuBeOpcfAqOfJP4pqZ8VC28pleEnMxJyEaKeqQU68FrZ7XX3JA8bQcNwcq5aWSCVu7w23l/3rk8kTcPbGkzdw01m4GMhLsoXqy7kFlUTxtY1YzBy3GG8x7b0v1lm/Pmovn77DS6MSTlviQsmEEjvo92R1KQskK8v/QPO2YMNFzsqzPC4T+dumELUzK6TXLFaQssHthpWAEUA3pEP5A7m+nyBRUbgrzJeZHS+UeSlxA2f72Uqp3fC6w2eXYmQpthGeQCEdN4uz5xb/103uUXeTEXP8psRMK2ysOVe7+4I37sNZR8sik9KqfFz13x0tND8CahD8Pd5i7OjE8CyicolH1i+u84glAaYrx3/gOJVNc4+9TZrZ6NvXhRxXgf/qIXZjSVApFbCrcDwrpN+dghwDppNbzzyB5mOaEedp42su2i1XgdYGhxfRg3IaMTaE15nC0wzo7fEpIlBOTZm/dEqyYlhQ7YhrTammGWLz741keXLfhScFi3avsB4NnZ7A+6f5l0Tw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0fe4459-d5bd-4566-a06d-08d888ea4e17 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2020 22:11:58.6081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dNXVEk4MQciTX70N9yY6y38423g/eUfnugracO4fdZLYBbNv2DZNg7OUDg4YkTufcF8WB/Y5fDEabZZNTSPSWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1269 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605391930; bh=R+mHGaLe1tI8HKgILux1N6F90HqBENrMefgUv4BYa3s=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=H2QH++MnkEmrU4JYh+VQG2ywTkgV+x6TaDNS4xVAnU0A+KnPCwOnNFEaiBJLNQvOL BO8S7Aljbif3uW595QVXgeTlqbrEpChLE+yg8TwZhiQhUSUTq9aCkWov5zVg8SlxNW OMHMQ6U1PWXdJ78wsnyzNLhFHaeP+cxT2ldHrhsVv5uzMgR0nenp0aXb/933HXSA/u TQUhWy1aEhvxDSnEHYjzAD62CqzFScdE8Q9AA8LT8m8VVnSup83cBmg1ldvWU8XD8k 3927a2RSntEEXC21mZNzCckxYV6x4HSNQMXXYV2qSGFTwDQTxfp0jODmfL8eHnkNN3 FA4pZPTb5yH7A== Subject: Re: [dpdk-dev] [PATCH] eal/windows: definition for ETOOMANYREFS errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [PATCH] eal/windows: definition for ETOOMANYREFS errno >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote: > > The ETOOMANYREFS errno is missing from the Windows clang build is it > > used in initialization of flow error structures. >=20 > "is it" -> "it is" >=20 > > The commit will define it as it is done in the minGW Windows build. >=20 > "The commit will" is unnecessary. >=20 > "minGW" -> "MinGW" >=20 > > Signed-off-by: Tal Shnaiderman > > --- > > lib/librte_eal/windows/include/rte_os.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_eal/windows/include/rte_os.h > > b/lib/librte_eal/windows/include/rte_os.h > > index 569ed92d51..2a91ebf6a1 100644 > > --- a/lib/librte_eal/windows/include/rte_os.h > > +++ b/lib/librte_eal/windows/include/rte_os.h > > @@ -90,6 +90,7 @@ eal_strerror(int code) } > > > > #define strerror eal_strerror > > +#define ETOOMANYREFS WSAETOOMANYREFS > > > > #endif /* RTE_TOOLCHAIN_GCC */ >=20 > Should be #define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */ for all > toolchains: >=20 > 1. Users of librte_ethdev, who check for ETOOMANYREFS, may not wish to > include because of its defines that break librte_net headers= . >=20 > 2. Now that I looked closely, MinGW-w64's #define ETOOMANYREFS > WSAETOOMANYREFS is under #if 0 clause (for documentation?). Apologies > for earlier misinformation. Thank you for the comments Dmitry, will send a v2 promptly.