DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tal Shnaiderman <talshn@nvidia.com>
To: Nick Connolly <nick.connolly@mayadata.io>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Tal Shnaiderman <talshn@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix link error with MinGW
Date: Sun, 22 Nov 2020 07:27:21 +0000
Message-ID: <CY4PR1201MB2548306C42F88C4763FE8DA4A4FD0@CY4PR1201MB2548.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201121225415.25609-1-nick.connolly@mayadata.io>

> Subject: [PATCH v2] eal/windows: fix link error with MinGW
> 
> Linking with the 'pci' driver when building with MinGW on Windows fails with
> undefined symbol 'GUID_DEVCLASS_NET'.
> This occurs because devguid.h is included in rte_windows.h before INITGUID
> is defined.
> 
> Move the include of devguid.h after the definition of INITGUID.
> 
> Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
> Cc: talshn@mellanox.com

Cc: should be stable@dpdk.org so fix can be backported, see more info at:

https://doc.dpdk.org/guides-20.08/contributing/stable.html#what-changes-should-be-backported

> 
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> ---
> v2
> * Fix commit message - add blank line, use present tense
> 
>  lib/librte_eal/windows/include/rte_windows.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/windows/include/rte_windows.h
> b/lib/librte_eal/windows/include/rte_windows.h
> index 0a5e71a05..b82af34f6 100644
> --- a/lib/librte_eal/windows/include/rte_windows.h
> +++ b/lib/librte_eal/windows/include/rte_windows.h
> @@ -25,13 +25,13 @@
>  #include <psapi.h>
>  #include <setupapi.h>
>  #include <winioctl.h>
> -#include <devguid.h>
> 
>  /* Have GUIDs defined. */
>  #ifndef INITGUID
>  #define INITGUID
>  #endif
>  #include <initguid.h>
> +#include <devguid.h>
>  #include <rte_log.h>
> 
>  /**
> --
> 2.25.1


  reply	other threads:[~2020-11-22  7:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 21:12 [dpdk-dev] [PATCH] " Nick Connolly
2020-11-20 22:41 ` Tal Shnaiderman
2020-11-20 23:43   ` Nick Connolly
2020-11-20 23:44     ` Nick Connolly
2020-11-21 20:47     ` Dmitry Kozlyuk
2020-11-21 21:50       ` Nick Connolly
2020-11-21 22:02 ` Dmitry Kozlyuk
2020-11-21 22:54 ` [dpdk-dev] [PATCH v2] " Nick Connolly
2020-11-22  7:27   ` Tal Shnaiderman [this message]
2020-11-22  8:45 ` [dpdk-dev] [PATCH v3] " Nick Connolly
2020-11-22  9:00   ` Tal Shnaiderman
2020-11-22 17:57     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1201MB2548306C42F88C4763FE8DA4A4FD0@CY4PR1201MB2548.namprd12.prod.outlook.com \
    --to=talshn@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=nick.connolly@mayadata.io \
    --cc=pallavi.kadam@intel.com \
    --cc=talshn@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git