From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BF14A09E0; Sat, 14 Nov 2020 22:41:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3487EC8A6; Sat, 14 Nov 2020 22:41:51 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id CB698C87A for ; Sat, 14 Nov 2020 22:41:48 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 15 Nov 2020 05:41:46 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 14 Nov 2020 21:41:44 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sat, 14 Nov 2020 21:41:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8mHfwPcRVxEqfMzNqzrbXsejJrz2x7HAImwYoupqbm7x7B8zEf5tyKv3liPOjLRku+yQayZpUhdLPPez1vjlW6B4gYP/QBqOwRwtR5utYs3IElt3sntQ4Ng3jdZKjgmbQ0Lrm6M9TAK0KQD8HYkcaS6nDgcOyfJhuQVIqjzi1lOfKTnixZGgvkUQFyr9cOro/takrdNTN03mB0PGfZttAe06QpEFG3gK2rUV5+o7+A5RmadrUJOZYduWI+kwFISFKXj6jrwGhC3tud1vMgQ9VVsDQ4ln9/DxdLqn7b5Y7AvcDBHvhryfU2201s2NkpfaQtAbouZzE2mPIRUbJOcRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dqmkHtnjyAld6OM8tPrUeIOXprNT0LgEzb3VNBIl6s=; b=JerO05aT5QXmE3uOvbMn9NV+ctm72pW6TxUbxoI7jYo0Nk2zE2CzXFEK8TrqdNJk2jBEj1Vfw3vn+ePDfh8Wwt2xdbR0TPKPiYBSywF81d8x7z5HFbxphiyxS7RkFj7P1dDUsdk62R4BbS2tiroS3b4K8pSjxHNx6JWP/YOnyEXjBkImHNEUVTAy6pwVTmFoExN1i3SucjsXgG8x3K/Dyrc4ywAOdnveacsMmiI6lSdugxHx6vsvh7zgnioxPZwqi4AIW4N7rpkNFEWBvaRhg4tCcxywtnC6flIbnk3pRQtWJS84Cg+nLE+8rjcUBE47F5XgRP1ZI0nz5QS6dBNPeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR1201MB0183.namprd12.prod.outlook.com (2603:10b6:910:20::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Sat, 14 Nov 2020 21:41:42 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::bc62:8762:4cb9:52dd]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::bc62:8762:4cb9:52dd%12]) with mapi id 15.20.3541.026; Sat, 14 Nov 2020 21:41:42 +0000 From: Tal Shnaiderman To: Narcisa Ana Maria Vasile , Ophir Munk CC: "dev@dpdk.org" , Raslan Darawsheh , Matan Azrad , NBU-Contact-Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v1 42/72] common/mlx5/windows: add DevX UAR getters Thread-Index: AQHWrLhgs1ZT6u06z02Wmtikns+SJqnCI9uAgAYf5UA= Date: Sat, 14 Nov 2020 21:41:42 +0000 Message-ID: References: <20201027232335.31427-1-ophirmu@nvidia.com> <20201027232335.31427-43-ophirmu@nvidia.com> <20201111000731.GE9449@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20201111000731.GE9449@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.114.72] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c274d1e-30af-468e-654a-08d888e613ac x-ms-traffictypediagnostic: CY4PR1201MB0183: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:483; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rzrqj1JeODM3jss5eKNx9VDb+iDdT8KwnfElYIHwqlgCrw8HRU6fbE8sTLIhtckJEs64dMaBJn97v+U/d8flkDfjTzEubh0xhvRgTdhKpFb2RZUXVqtc5kNKl0IS+508Ugjo7q4FpVSkEp1n5E/q2LOBJ8HHcv9oYgBPwz6QJnnwp8MSqa2akYYMskfQqPkJxSdm138JWpKYdX8KtIBYWRjy6bxB/N80zA3idWfZCrVlOP1mKgndyl2CSaUJR43bRe87e+90HeDrq8GahX3Dc6LAqfIAbiyJoEhgA2XLSwmklem6PvKrDux1Cc1tAPtnqAo5gVagE/Mrc9cEyvlGTQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39850400004)(346002)(136003)(396003)(366004)(54906003)(71200400001)(6636002)(6506007)(316002)(110136005)(83380400001)(55016002)(8676002)(8936002)(5660300002)(64756008)(7696005)(33656002)(66946007)(4326008)(66476007)(66556008)(76116006)(52536014)(2906002)(66446008)(478600001)(9686003)(26005)(86362001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: BcV4qWmomnI3keAJowr+Tst+m6rvjzkfgKyKNK4DwAC8wsrA2hxZIrAF11CG6u7Z6QIVxvdTlLtxbSQulc0eDlypiwARYFUcaHhnh1QBmdfEuYnT/xhJ09sfpP64lW9WgHbxZFGln9k4uReuWAg9+vZbwuRO+GvrGVP69LdPLlMS4Ly/Cxl/dpHr/3zAkOyrr9GMlZtNGT1SpwQuNyLPylL1wqJm7l/4x8ByVLBNleUkjgZeVGtbWEl8lVi/jHMy5YwBMd+9mJbOCr9uUR/Vm48AVUmMMTHC8eOdbMXf4Iyo+lUi1GS6jkt1YLT+PHEQDkZ1cE6V2z0WqwAnPVjlrpPpFiVsBOzLbycyeD+dOyNi3YOMtEY5Ck6hkqgcelXmXRXvkLkjgCruwA4wWtKZwPqhVoYIbpHPD4Xxh+wbeJLK7qsA7jBNWaty7OZX6EBfLB6dooXMKrHPXR3n0jsWk07kf+QqNzU7eLXh6KHzSb2gWScbU4R5DvC2bLxwE0jVafH75o+9TI3y1qkZjwdy+S3SNlIUh8gDS27AYhFD3d9SxZjP1JRaaDeUrlmOBOG8Mgswpw1lehf3k6czQ6NzL6C71UzaAME4cHbTMeS4xNwgEq2BxKc1qG80H1um9JQlk3GGt7tDgPovFX1E6opnDNjdHu3s0/pK0h5IdxVMlUyRNJ44LGpavPru7o6DbS4Ew2js6cEhI0c7tBp5GatSRnH1MGNbk7p+xhiPEACuT/Fob1SAvZZNFPLSYo6nDeZACQ69yH+yC0GI4yKC/T27G3Vr/2aW/ZG8jZUMmaDujMisUcjO242a3Z276YexHGRoemYbdqWFncPdwHlTR2Z4CJ9p79LXDBZWZpsW58zpn7ctMYurXeyE37opQ+WF8Ydq9oAjNs6thhR7vo0hN5XBlw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c274d1e-30af-468e-654a-08d888e613ac X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2020 21:41:42.4776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IcmNTM3I3YyDPyo8VNLVQf9wjcWgCm46AOb5lUAu1sYwX2WtWYOhUuygkP4OrK6OPSoBfMOqfgvMwg7vyvX/vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0183 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605390106; bh=1dqmkHtnjyAld6OM8tPrUeIOXprNT0LgEzb3VNBIl6s=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ZQ8FwwUpU8vlk9ViL80iLT0KlCvDDAZKGaZt8SxvCBHDjqc02xNpi4dlIFGq3krz8 tp+w0d5AsaXwHfCvLSNrMGYrjBphanVV0/pF+8UF/FnxAgefRJc5NkyVwQdIRd/r6w 5uE4LD3Sb103fr4/G6FZ5qnSOTwA0V5oEkUnQcT9t+WmP5vXo/t0yti1J7T7Bg2JOf isF9eaAvyMP4zJwxoLooly0odtHYkiu18poRWaWKB7m1zQVoVf7po14DgDm8ZiMf0T j6tAQyzSUey+L66R1h2YILGjnEXjAguf3Lg7u/8qhSjg6aT2XKMocJPKf2rAL7YWbV vnf/pBI5iaskg== Subject: Re: [dpdk-dev] [PATCH v1 42/72] common/mlx5/windows: add DevX UAR getters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-dev] [PATCH v1 42/72] common/mlx5/windows: add > DevX UAR getters >=20 > On Tue, Oct 27, 2020 at 11:23:05PM +0000, Ophir Munk wrote: > > The following getters are added: mlx5_os_get_devx_uar_mmap_offset, > > mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr, > > mlx5_os_get_devx_uar_page_id. This commit is the Windows equivalent > > of the Linux implementation in (1). > > > > (1) > > commit 8638e19a10aa ("net/mlx5: remove more DV dependencies") > > > > Signed-off-by: Ophir Munk > > --- > > drivers/common/mlx5/windows/mlx5_common_os.h | 74 > > ++++++++++++++++++++++++++++ > > 1 file changed, 74 insertions(+) > > > > diff --git a/drivers/common/mlx5/windows/mlx5_common_os.h > > b/drivers/common/mlx5/windows/mlx5_common_os.h > > + * Get mmap offset. Given a pointer to an DevX UAR object of type > > + * 'struct mlx5dv_devx_uar *' - return its mmap offset. > > + * > > + * @param[in] uar > > + * Pointer to UAR object. > > + * > > + * @return > > + * The mmap offset if uar is valid, 0 otherwise. > > + */ > > +static inline off_t > > +mlx5_os_get_devx_uar_mmap_offset(void *uar) { > > + if (!uar) > > + return 0; > > + return 0; >=20 > Should we return uar->mmap_off here? In Windows, this function will always return 0 as mmap offset is unneeded, = I'll update the function docu and change it to reflect it, thanks. >=20 > > +} > > + > > +/** > > + * Get base addr pointer. Given a pointer to an UAR object of type > > + * 'struct mlx5dv_devx_uar *' - return its base address. > > + *